bulltrackers-module 1.0.277 → 1.0.278

package/functions/computation-system/persistence/ResultCommitter.js

@@ -2,6 +2,7 @@
  * @fileoverview Handles saving computation results with observability and Smart Cleanup.
  * UPDATED: Implements GZIP Compression for efficient storage.
  * UPDATED: Implements Content-Based Hashing (ResultHash) for dependency short-circuiting.
+ * UPDATED: Auto-enforces Weekend Mode validation for 'Price-Only' computations.
  */
 const { commitBatchInChunks, generateDataHash } = require('../utils/utils');
 const { updateComputationStatus }          = require('./StatusRepository');
@@ -28,30 +29,49 @@ async function commitResults(stateObj, dStr, passName, config, deps, skipStatusW
     const pid            = generateProcessId(PROCESS_TYPES.STORAGE, passName, dStr);
     
     // Options defaults
-    const flushMode    = options.flushMode || 'STANDARD';
-    const shardIndexes = options.shardIndexes || {};
+    const flushMode        = options.flushMode || 'STANDARD';
+    const shardIndexes     = options.shardIndexes || {};
     const nextShardIndexes = {};
 
     const fanOutLimit = pLimit(10); 
 
     for (const name in stateObj) {
-        const calc = stateObj[name];
+        const calc      = stateObj[name];
         const execStats = calc._executionStats || { processedUsers: 0, skippedUsers: 0 };
         const currentShardIndex = shardIndexes[name] || 0;
 
         const runMetrics = {
-            storage: { sizeBytes: 0, isSharded: false, shardCount: 1, keys: 0 },
+            storage:    { sizeBytes: 0, isSharded: false, shardCount: 1, keys: 0 },
             validation: { isValid: true, anomalies: [] },
             execution: execStats
         };
 
         try {
             const result = await calc.getResult();
-            const overrides   = validationOverrides[calc.manifest.name] || {};
+            const configOverrides = validationOverrides[calc.manifest.name] || {};
             
+            // --- [NEW] AUTO-ENFORCE WEEKEND MODE FOR PRICE-ONLY CALCS ---
+            // If a calculation depends SOLELY on 'price', we assume market closures
+            // will cause 0s/Flatlines on weekends, so we enforce lenient validation.
+            const dataDeps = calc.manifest.rootDataDependencies || [];
+            const isPriceOnly = (dataDeps.length === 1 && dataDeps[0] === 'price');
+            
+            let effectiveOverrides = { ...configOverrides };
+            
+            if (isPriceOnly && !effectiveOverrides.weekend) {
+                effectiveOverrides.weekend = {
+                    maxZeroPct: 100,
+                    maxFlatlinePct: 100,
+                    maxNullPct: 100 // Allow full nulls (e.g. holidays)
+                };
+            }
+            // -----------------------------------------------------------
+
             // Validation
             if (result && Object.keys(result).length > 0) {
-                const healthCheck = HeuristicValidator.analyze(calc.manifest.name, result, overrides);
+                // [FIX] Added 'dStr' as 3rd argument to match HeuristicValidator signature
+                const healthCheck = HeuristicValidator.analyze(calc.manifest.name, result, dStr, effectiveOverrides);
+                
                 if (!healthCheck.valid) {
                     runMetrics.validation.isValid = false;
                     runMetrics.validation.anomalies.push(healthCheck.reason);
@@ -91,7 +111,7 @@ async function commitResults(stateObj, dStr, passName, config, deps, skipStatusW
             const isMultiDate = resultKeys.length > 0 && resultKeys.every(k => /^\d{4}-\d{2}-\d{2}$/.test(k));
 
             if (isMultiDate) {
-                const datePromises = resultKeys.map((historicalDate) => fanOutLimit(async () => {
+                const datePromises  = resultKeys.map((historicalDate) => fanOutLimit(async () => {
                     const dailyData = result[historicalDate];
                     if (!dailyData || Object.keys(dailyData).length === 0) return;
 

package/functions/computation-system/persistence/ResultsValidator.js

@@ -24,11 +24,11 @@ class HeuristicValidator {
         const sampleSize = Math.min(totalItems, 100);
         const step = Math.floor(totalItems / sampleSize);
         
-        let zeroCount = 0;
-        let nullCount = 0;
-        let nanCount = 0; 
+        let zeroCount        = 0;
+        let nullCount        = 0;
+        let nanCount         = 0; 
         let emptyVectorCount = 0; 
-        let analyzedCount = 0;
+        let analyzedCount    = 0;
         
         const numericValues = []; 
 
@@ -82,9 +82,9 @@ class HeuristicValidator {
 
         // Default Thresholds
         let thresholds = {
-            maxZeroPct: overrides.maxZeroPct ?? 99, 
-            maxNullPct: overrides.maxNullPct ?? 90,
-            maxNanPct:  overrides.maxNanPct  ?? 0,   
+            maxZeroPct:     overrides.maxZeroPct     ?? 99, 
+            maxNullPct:     overrides.maxNullPct     ?? 90,
+            maxNanPct:      overrides.maxNanPct      ?? 0,   
             maxFlatlinePct: overrides.maxFlatlinePct ?? 95 
         };
 

package/functions/computation-system/tools/BuildReporter.js

@@ -4,6 +4,7 @@
  * REFACTORED: Strict 5-category reporting with date-based exclusion logic.
  * UPDATED: Added transactional locking to prevent duplicate reports on concurrent cold starts.
  * UPDATED: Adds 'pass' number to detail records for better waterfall visibility.
+ * FIXED: Ensures 'latest' pointer updates even if detail writes fail.
  */
 
 const { analyzeDateExecution }                                             = require('../WorkflowOrchestrator');
@@ -242,15 +243,34 @@ async function generateBuildReport(config, dependencies, manifest, daysBack = 90
         scanRange: `${datesToCheck[0]} to ${datesToCheck[datesToCheck.length-1]}` 
     };
 
+    // 1. Write the main report header (Specific Version)
     const reportRef = db.collection('computation_build_records').doc(buildId);
     await reportRef.set(reportHeader);
 
+    // 2. Write Details (Protected)
+    // [FIX] We wrap this in try-catch so that if the massive detail write fails,
+    // we still update the 'latest' pointer to the new version.
+    let detailsSuccess = true;
     if (detailWrites.length > 0) {
         logger.log('INFO', `[BuildReporter] Writing ${detailWrites.length} detail records...`);
-        await commitBatchInChunks(config, dependencies, detailWrites, 'BuildReportDetails');
+        try {
+            await commitBatchInChunks(config, dependencies, detailWrites, 'BuildReportDetails');
+        } catch (detailErr) {
+            detailsSuccess = false;
+            logger.log('ERROR', `[BuildReporter] ⚠️ Failed to write all details, but Report Header is saved.`, detailErr);
+        }
     }
 
-    await db.collection('computation_build_records').doc('latest').set({ ...reportHeader, note: "Latest build report pointer (See subcollection for details)." });
+    // 3. Update 'latest' pointer
+    // This now runs even if details failed, preventing the version mismatch bug.
+    const latestMetadata = { 
+        ...reportHeader, 
+        note: detailsSuccess 
+            ? "Latest build report pointer (See subcollection for details)." 
+            : "Latest build report pointer (WARNING: Partial detail records due to write error)."
+    };
+    
+    await db.collection('computation_build_records').doc('latest').set(latestMetadata);
 
     logger.log('SUCCESS', `[BuildReporter] Report ${buildId} saved. Re-runs: ${totalReRun}, New: ${totalRun}.`);
     

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "bulltrackers-module",
-  "version": "1.0.277",
+  "version": "1.0.278",
   "description": "Helper Functions for Bulltrackers.",
   "main": "index.js",
   "files": [