bulltrackers-module 1.0.272 → 1.0.274

package/functions/computation-system/helpers/computation_worker.js

@@ -1,9 +1,8 @@
 /**
  * FILENAME: computation-system/helpers/computation_worker.js
  * PURPOSE: Consumes computation tasks from Pub/Sub and executes them.
+ * UPDATED: Added Deterministic Error Short-Circuit to prevent infinite retry storms on data limits.
  * UPDATED: Integrated Run Ledger for per-run/per-date success/failure tracking.
- * UPDATED: Added Dead Letter Queue logic for Poison Pills.
- * UPDATED: Now logs the trigger reason.
  */
 
 const { executeDispatchTask } = require('../WorkflowOrchestrator.js');
@@ -89,6 +88,35 @@ async function handleComputationTask(message, config, dependencies) {
             await recordRunAttempt(db, { date, computation, pass }, 'SUCCESS', { message: 'Empty Result' }, { durationMs: duration }, triggerReason);
         }
     } catch (err) { 
+        // ----------------------------------- ERROR HANDLING & RETRY LOGIC -----------------------------------
+        
+        // 1. DETERMINISTIC ERROR CHECK (Short-Circuit)
+        // If the error is permanent (like "Too Big" or "Validation Failed"), DO NOT RETRY.
+        // This stops the "Retry Storm" where we pay for 3-4 retries of a task that will never succeed.
+        const isDeterministicError = err.stage === 'SHARDING_LIMIT_EXCEEDED' || 
+                                     err.stage === 'QUALITY_CIRCUIT_BREAKER' ||
+                                     (err.message && (err.message.includes('INVALID_ARGUMENT') || err.message.includes('Transaction too big')));
+
+        if (isDeterministicError) {
+             logger.log('ERROR', `[Worker] 🛑 Permanent Failure (Data/Limit Issue). Sending to DLQ immediately: ${computation} ${date}`);
+             try {
+                 await db.collection('computation_dead_letter_queue').add({
+                     originalData: data,
+                     error: { message: err.message, stack: err.stack, stage: err.stage || 'UNKNOWN' },
+                     finalAttemptAt: new Date(),
+                     failureReason: 'PERMANENT_DETERMINISTIC_ERROR'
+                 });
+                 
+                 // CRITICAL: We record the failure but return successfully to Pub/Sub to ACK the message and stop retries.
+                 // This ensures the task is marked as Failed in run history, but does NOT block the queue.
+                 await recordRunAttempt(db, { date, computation, pass }, 'FAILURE', { message: err.message, stage: err.stage || 'PERMANENT_FAIL' }, { durationMs: 0 }, triggerReason);
+                 return; 
+             } catch (dlqErr) { 
+                 logger.log('FATAL', `[Worker] Failed to write to DLQ for deterministic error`, dlqErr); 
+             }
+        }
+
+        // 2. STANDARD RETRY LOGIC (Timeout / Crash)
         const retryCount = message.deliveryAttempt || 0;
         if (retryCount >= MAX_RETRIES) {
              logger.log('ERROR', `[Worker] ☠️ Task POISONED. Moved to DLQ: ${computation} ${date} (Attempt ${retryCount})`);
@@ -102,6 +130,8 @@ async function handleComputationTask(message, config, dependencies) {
                  return;
              } catch (dlqErr) { logger.log('FATAL', `[Worker] Failed to write to DLQ`, dlqErr); }
         }
+
+        // If it's not deterministic and not max retries, we throw to let Pub/Sub retry it.
         logger.log('ERROR', `[Worker] ❌ Crash: ${computation} for ${date}: ${err.message}`); 
         await recordRunAttempt(db, { date, computation, pass }, 'CRASH', {  message: err.message, stack: err.stack, stage: 'SYSTEM_CRASH' }, { durationMs: 0 }, triggerReason);
         throw err; 

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "bulltrackers-module",
-  "version": "1.0.272",
+  "version": "1.0.274",
   "description": "Helper Functions for Bulltrackers.",
   "main": "index.js",
   "files": [