bulltrackers-module 1.0.268 → 1.0.270

package/functions/computation-system/WorkflowOrchestrator.js

@@ -1,7 +1,7 @@
 /**
  * @fileoverview Main Orchestrator. Coordinates the topological execution.
- * UPDATED: Implements Smart Audit logic to detect WHY a hash mismatch occurred.
- * FIX: Added 'Audit Upgrade' check to force re-run if composition metadata is missing.
+ * UPDATED: Removed 'Permanently Impossible' optimization to ensure full visibility/recovery.
+ * UPDATED: Includes 'Audit Upgrade' check.
  */
 const { normalizeName, DEFINITIVE_EARLIEST_DATES }         = require('./utils/utils');
 const { checkRootDataAvailability, checkRootDependencies } = require('./data/AvailabilityChecker');
@@ -17,7 +17,6 @@ function groupByPass(manifest) {  return manifest.reduce((acc, calc) => { (acc[c
 
 /**
  * Analyzes whether calculations should run, be skipped, or are blocked.
- * Now performs Deep Hash Analysis to explain Re-Runs.
  */
 function analyzeDateExecution(dateStr, calcsInPass, rootDataStatus, dailyStatus, manifestMap, prevDailyStatus = null) {
     const report           = { runnable: [], blocked: [], impossible: [], failedDependency: [], reRuns: [], skipped: [] };
@@ -58,16 +57,16 @@ function analyzeDateExecution(dateStr, calcsInPass, rootDataStatus, dailyStatus,
         let migrationOldCategory = null;
         if (storedCategory && storedCategory !== calc.category) { migrationOldCategory = storedCategory; }
         
-        if (typeof storedHash === 'string' && storedHash.startsWith(STATUS_IMPOSSIBLE_PREFIX)) { 
-            report.skipped.push({ name: cName, reason: `Permanently Impossible (${storedHash})` }); 
-            continue; 
-        }
+        // [REMOVED] The "Permanently Impossible" optimization block was here.
+        // Removal ensures we re-check Root Data every time, allowing for visibility and recovery.
 
+        // 1. Check Root Data (The Primary Gate)
         const rootCheck = checkRootDependencies(calc, rootDataStatus);
         
         if (!rootCheck.canRun) {
             const missingStr = rootCheck.missing.join(', ');
             if (!isTargetToday) {
+                // If previously impossible, this confirms it. If previously run, this is a regression.
                 markImpossible(`Missing Root Data: ${missingStr} (Historical)`, 'NO_DATA');
             } else {
                 report.blocked.push({ name: cName, reason: `Missing Root Data: ${missingStr} (Waiting)` });
@@ -75,6 +74,7 @@ function analyzeDateExecution(dateStr, calcsInPass, rootDataStatus, dailyStatus,
             continue;
         }
 
+        // 2. Check Dependencies
         let dependencyIsImpossible = false;
         const missingDeps = [];
         if (calc.dependencies) {
@@ -95,6 +95,7 @@ function analyzeDateExecution(dateStr, calcsInPass, rootDataStatus, dailyStatus,
         }
         if (missingDeps.length > 0) { report.failedDependency.push({ name: cName, missing: missingDeps }); continue; }
 
+        // 3. Check Historical Continuity
         if (calc.isHistorical && prevDailyStatus) {
             const yesterday = new Date(dateStr + 'T00:00:00Z');
             yesterday.setUTCDate(yesterday.getUTCDate() - 1);
@@ -107,12 +108,12 @@ function analyzeDateExecution(dateStr, calcsInPass, rootDataStatus, dailyStatus,
             }
         }
         
-        // --- HASH CHECK LOGIC ---
+        // 4. Check Hash / Composition (The Audit Gate)
         if (!storedHash) { 
             markRunnable(false, { reason: "New Calculation" }); 
         } 
         else if (storedHash !== currentHash) {
-            // Smart Logic: Why did it change?
+            // Smart Audit Logic
             let changeReason = "Hash Mismatch (Unknown)";
             const oldComp = stored.composition;
             const newComp = calc.composition;
@@ -153,7 +154,7 @@ function analyzeDateExecution(dateStr, calcsInPass, rootDataStatus, dailyStatus,
         else if (migrationOldCategory) {       
             markRunnable(true, { name: cName, reason: 'Category Migration', previousCategory: migrationOldCategory, newCategory: calc.category }); 
         } 
-        // [CRITICAL FIX] Audit Upgrade Check: Force re-run if hash matches but composition is missing (Legacy Record)
+        // Audit Upgrade Check
         else if (!stored.composition) {
             markRunnable(true, { 
                 name: cName, 
@@ -163,7 +164,7 @@ function analyzeDateExecution(dateStr, calcsInPass, rootDataStatus, dailyStatus,
             });
         }
         else { 
-            report.skipped.push({ name: cName }); 
+            report.skipped.push({ name: cName, reason: "Up To Date" }); 
             simulationStatus[cName] = { hash: currentHash, category: calc.category, composition: calc.composition }; 
         }
     }

package/functions/computation-system/system_epoch.js

@@ -1,2 +1,2 @@
 // Change this string to force a global re-computation
-module.exports = "v1.0-epoch-2";
+module.exports = "v2.0-epoch-2";

package/functions/computation-system/tools/BuildReporter.js

@@ -1,22 +1,50 @@
 /**
  * @fileoverview Build Reporter & Auto-Runner.
  * Generates a "Pre-Flight" report of what the computation system WILL do.
- * UPDATED: Shards report details to subcollections to bypass 1MB limit on 'Invalidate All' scenarios.
+ * REFACTORED: Strict 5-category reporting with date-based exclusion logic.
+ * UPDATED: Added meta stats to compare Included vs Expected computation counts per date.
  */
 
 const { analyzeDateExecution }                                             = require('../WorkflowOrchestrator');
 const { fetchComputationStatus }                                           = require('../persistence/StatusRepository');
 const { normalizeName, getExpectedDateStrings, DEFINITIVE_EARLIEST_DATES } = require('../utils/utils');
 const { checkRootDataAvailability }                                        = require('../data/AvailabilityChecker');
-const { commitBatchInChunks }                                              = require('../persistence/FirestoreUtils'); // Reuse chunker
+const { commitBatchInChunks }                                              = require('../persistence/FirestoreUtils');
 const pLimit                                                               = require('p-limit');
 const path                                                                 = require('path');
 const packageJson                                                          = require(path.join(__dirname, '..', '..', '..', 'package.json'));
 const packageVersion                                                       = packageJson.version;
 
+/**
+ * Helper: Determines if a calculation should be excluded from the report
+ * because the date is prior to the earliest possible data existence.
+ */
+function isDateBeforeAvailability(dateStr, calcManifest) {
+    const targetDate = new Date(dateStr + 'T00:00:00Z');
+    const deps = calcManifest.rootDataDependencies || [];
+    
+    // If no data dependencies, it's always valid (e.g., pure math)
+    if (deps.length === 0) return false;
+
+    for (const dep of deps) {
+        // Map dependency name to start date
+        let startDate = null;
+        if (dep === 'portfolio') startDate = DEFINITIVE_EARLIEST_DATES.portfolio;
+        else if (dep === 'history')   startDate = DEFINITIVE_EARLIEST_DATES.history;
+        else if (dep === 'social')    startDate = DEFINITIVE_EARLIEST_DATES.social;
+        else if (dep === 'insights')  startDate = DEFINITIVE_EARLIEST_DATES.insights;
+        else if (dep === 'price')     startDate = DEFINITIVE_EARLIEST_DATES.price;
+
+        // If we have a start date and the target is BEFORE it, exclude this calc.
+        if (startDate && targetDate < startDate) {
+            return true;
+        }
+    }
+    return false;
+}
+
 /**
  * AUTO-RUN ENTRY POINT
- * Checks if a report for the current version exists. If not, runs it.
  */
 async function ensureBuildReport(config, dependencies, manifest) {
     const { db, logger } = dependencies;
@@ -34,8 +62,6 @@ async function ensureBuildReport(config, dependencies, manifest) {
         }
 
         logger.log('INFO', `[BuildReporter] 🚀 New Version Detected (${packageVersion}). Auto-running Pre-flight Report...`);
-        
-        // Scope: 90 days is fine now that we shard the output
         await generateBuildReport(config, dependencies, manifest, 90, buildId);
 
     } catch (e) {
@@ -59,18 +85,18 @@ async function generateBuildReport(config, dependencies, manifest, daysBack = 90
     const datesToCheck = getExpectedDateStrings(startDate, today);
     const manifestMap  = new Map(manifest.map(c => [normalizeName(c.name), c]));
     
-    // Main Report Header (Summary Only)
+    // Main Report Header
     const reportHeader = {
         buildId,
         packageVersion: packageVersion, 
         generatedAt: new Date().toISOString(),
-        summary: {},
-        _sharded: true // Flag to tell UI/Tools to look in subcollection
+        summary: {}, 
+        _sharded: true 
     };
 
-    let totalReRuns = 0;
-    let totalNew    = 0;
-    const detailWrites = []; // Accumulate writes for batching
+    let totalRun = 0;
+    let totalReRun = 0;
+    const detailWrites = []; 
 
     const limit = pLimit(20);
 
@@ -99,28 +125,78 @@ async function generateBuildReport(config, dependencies, manifest, daysBack = 90
 
             const analysis = analyzeDateExecution(dateStr, manifest, rootDataStatus, dailyStatus, manifestMap, prevDailyStatus);
 
-            const dateSummary = { willRun: [], willReRun: [], blocked: [], impossible: [] };
-
-            analysis.runnable.forEach   (item => dateSummary.willRun.push    ({ name: item.name, reason: "New / No Previous Record" }));
-            analysis.reRuns.forEach     (item => dateSummary.willReRun.push  ({ name: item.name, reason: item.reason || "Hash Mismatch" }));
-            analysis.impossible.forEach (item => dateSummary.impossible.push ({ name: item.name, reason: item.reason }));
-            [...analysis.blocked, ...analysis.failedDependency].forEach(item => dateSummary.blocked.push({ name: item.name, reason: item.reason || 'Dependency' }));
-
-            const hasUpdates = dateSummary.willRun.length || dateSummary.willReRun.length || dateSummary.blocked.length || dateSummary.impossible.length;
-            
-            if (hasUpdates) {
-                // Prepare Write for Subcollection
-                const detailRef = db.collection('computation_build_records').doc(buildId).collection('details').doc(dateStr);
-                detailWrites.push({
-                    ref: detailRef,
-                    data: dateSummary
-                });
-
-                return {
-                    stats: { new: dateSummary.willRun.length, rerun: dateSummary.willReRun.length }
-                };
+            // ---------------------------------------------------------
+            // STRICT 5-CATEGORY MAPPING
+            // ---------------------------------------------------------
+            const dateSummary = {
+                run: [],        // New / No Hash / "Runnable"
+                rerun: [],      // Hash Mismatch / Category Migration
+                blocked: [],    // Missing Data (Today) / Dependency Missing
+                impossible: [], // Missing Data (Historical) / Impossible Dependency
+                uptodate: [],   // Hash Match (Previously "Skipped")
+                
+                // [NEW] Metadata for Verification
+                meta: {
+                    totalIncluded: 0,
+                    totalExpected: 0,
+                    match: false
+                }
+            };
+
+            // Calculate Expected Count (Computations in manifest that exist for this date)
+            const expectedCount = manifest.filter(c => !isDateBeforeAvailability(dateStr, c)).length;
+            dateSummary.meta.totalExpected = expectedCount;
+
+            // Helper to push only if date is valid for this specific calc
+            const pushIfValid = (targetArray, item, extraReason = null) => {
+                const calcManifest = manifestMap.get(item.name);
+                if (calcManifest && isDateBeforeAvailability(dateStr, calcManifest)) {
+                    return; // EXCLUDED: Date is before data exists
+                }
+                targetArray.push({ name: item.name, reason: item.reason || extraReason });
+            };
+
+            // 1. RUN (New)
+            analysis.runnable.forEach(item => pushIfValid(dateSummary.run, item, "New Calculation"));
+
+            // 2. RE-RUN (Hash Mismatch)
+            analysis.reRuns.forEach(item => pushIfValid(dateSummary.rerun, item, "Hash Mismatch"));
+
+            // 3. BLOCKED (Temporary Issues)
+            // Merging 'blocked' and 'failedDependency' as both are temporary blocks
+            analysis.blocked.forEach(item => pushIfValid(dateSummary.blocked, item));
+            analysis.failedDependency.forEach(item => pushIfValid(dateSummary.blocked, item, "Dependency Missing"));
+
+            // 4. IMPOSSIBLE (Permanent Issues)
+            analysis.impossible.forEach(item => pushIfValid(dateSummary.impossible, item));
+
+            // 5. UP-TO-DATE (Previously "Skipped")
+            analysis.skipped.forEach(item => pushIfValid(dateSummary.uptodate, item, "Up To Date"));
+
+            // Calculate Included Count
+            const includedCount = dateSummary.run.length + 
+                                  dateSummary.rerun.length + 
+                                  dateSummary.blocked.length + 
+                                  dateSummary.impossible.length + 
+                                  dateSummary.uptodate.length;
+
+            dateSummary.meta.totalIncluded = includedCount;
+            dateSummary.meta.match = (includedCount === expectedCount);
+
+            if (!dateSummary.meta.match) {
+                logger.log('WARN', `[BuildReporter] ⚠️ Mismatch on ${dateStr}: Expected ${expectedCount} but got ${includedCount}.`);
             }
-            return null;
+
+            // ALWAYS WRITE THE REPORT (No filtering based on activity)
+            const detailRef = db.collection('computation_build_records').doc(buildId).collection('details').doc(dateStr);
+            detailWrites.push({
+                ref: detailRef,
+                data: dateSummary
+            });
+
+            return {
+                stats: { run: dateSummary.run.length, rerun: dateSummary.rerun.length }
+            };
 
         } catch (err) {
             logger.log('ERROR', `[BuildReporter] Error analyzing date ${dateStr}: ${err.message}`);
@@ -132,27 +208,28 @@ async function generateBuildReport(config, dependencies, manifest, daysBack = 90
 
     results.forEach(res => {
         if (res) {
-            totalNew += res.stats.new;
-            totalReRuns += res.stats.rerun;
+            totalRun   += res.stats.run;
+            totalReRun += res.stats.rerun;
         }
     });
 
-    reportHeader.summary = { totalReRuns, totalNew, scanRange: `${datesToCheck[0]} to ${datesToCheck[datesToCheck.length-1]}` };
+    reportHeader.summary = { 
+        totalReRuns: totalReRun, 
+        totalNew: totalRun, 
+        scanRange: `${datesToCheck[0]} to ${datesToCheck[datesToCheck.length-1]}` 
+    };
 
-    // 1. Write Header
     const reportRef = db.collection('computation_build_records').doc(buildId);
     await reportRef.set(reportHeader);
 
-    // 2. Batch Write Details (Using FirestoreUtils to handle batching constraints)
     if (detailWrites.length > 0) {
         logger.log('INFO', `[BuildReporter] Writing ${detailWrites.length} detail records...`);
         await commitBatchInChunks(config, dependencies, detailWrites, 'BuildReportDetails');
     }
 
-    // 3. Update 'latest' pointer (Summary only)
     await db.collection('computation_build_records').doc('latest').set({ ...reportHeader, note: "Latest build report pointer (See subcollection for details)." });
 
-    logger.log('SUCCESS', `[BuildReporter] Report ${buildId} saved. Re-runs: ${totalReRuns}, New: ${totalNew}.`);
+    logger.log('SUCCESS', `[BuildReporter] Report ${buildId} saved. Re-runs: ${totalReRun}, New: ${totalRun}.`);
     
     return {
         success: true,

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "bulltrackers-module",
-  "version": "1.0.268",
+  "version": "1.0.270",
   "description": "Helper Functions for Bulltrackers.",
   "main": "index.js",
   "files": [