bulltrackers-module 1.0.262 → 1.0.263

package/functions/computation-system/persistence/ResultCommitter.js

@@ -227,9 +227,8 @@ async function deleteOldCalculationData(dateStr, oldCategory, calcName, config,
 
         const shardsCol  = oldDocRef.collection('_shards');
         const shardsSnap = await withRetry(() => shardsCol.listDocuments(), 'ListOldShards');
-        
-        const batch = db.batch();
-        let ops = 0;
+        const batch      = db.batch();
+        let ops          = 0;
 
         for (const shardDoc of shardsSnap) { batch.delete(shardDoc); ops++; }
         batch.delete(oldDocRef);

package/functions/computation-system/persistence/ResultsValidator.js

@@ -97,32 +97,20 @@ class HeuristicValidator {
         // If we found numeric values, check if they are all the same
         let isFlatline = false;
         if (numericValues.length > 5) {
-            const first = numericValues[0];
+            const first          = numericValues[0];
             const identicalCount = numericValues.filter(v => Math.abs(v - first) < 0.000001).length;
-            const flatlinePct = (identicalCount / numericValues.length) * 100;
+            const flatlinePct    = (identicalCount / numericValues.length) * 100;
             
             // Only flag flatline if the value isn't 0 (0 is handled by maxZeroPct)
-            if (flatlinePct > thresholds.maxFlatlinePct && Math.abs(first) > 0.0001) {
-                isFlatline = true;
-            }
+            if (flatlinePct > thresholds.maxFlatlinePct && Math.abs(first) > 0.0001) { isFlatline = true; }
         }
 
         // 6. Evaluations
-        if (nanPct > thresholds.maxNanPct) {
-            return { valid: false, reason: `Mathematical Error: ${nanPct.toFixed(1)}% of sampled results contain NaN or Infinity.` };
-        }
-
-        if (zeroPct > thresholds.maxZeroPct) {
-            return { valid: false, reason: `Data Integrity: ${zeroPct.toFixed(1)}% of sampled results are 0. (Suspected Logic Failure)` };
-        }
+        if (nanPct  > thresholds.maxNanPct)  { return { valid: false, reason: `Mathematical Error: ${nanPct.toFixed(1)}% of sampled results contain NaN or Infinity.` }; }
+        if (zeroPct > thresholds.maxZeroPct) { return { valid: false, reason: `Data Integrity:     ${zeroPct.toFixed(1)}% of sampled results are 0. (Suspected Logic Failure)` }; }
+        if (nullPct > thresholds.maxNullPct) { return { valid: false, reason: `Data Integrity:     ${nullPct.toFixed(1)}% of sampled results are Empty/Null.` }; }
 
-        if (nullPct > thresholds.maxNullPct) {
-            return { valid: false, reason: `Data Integrity: ${nullPct.toFixed(1)}% of sampled results are Empty/Null.` };
-        }
-
-        if (isFlatline) {
-            return { valid: false, reason: `Anomaly: Detected Result Flatline. >${thresholds.maxFlatlinePct}% of outputs are identical (non-zero).` };
-        }
+        if (isFlatline) { return { valid: false, reason: `Anomaly: Detected Result Flatline. >${thresholds.maxFlatlinePct}% of outputs are identical (non-zero).` }; }
         
         // Special check for Distribution/Profile calculations
         if (calcName.includes('profile') || calcName.includes('distribution')) {

package/functions/computation-system/persistence/RunRecorder.js

@@ -48,7 +48,7 @@ async function recordRunAttempt(db, context, status, error = null, detailedMetri
     
     // History Doc: Stores this specific run
     // ID Format: targetDate_triggerTimestamp (Sortable by data date, then execution time)
-    const runId = `${targetDate}_${triggerTimestamp}`;
+    const runId     = `${targetDate}_${triggerTimestamp}`;
     const runDocRef = computationDocRef.collection('history').doc(runId);
 
     // 2. Prepare Metrics & Environment Info
@@ -56,16 +56,11 @@ async function recordRunAttempt(db, context, status, error = null, detailedMetri
     
     // Calculate size in MB
     let sizeMB = 0;
-    if (detailedMetrics.storage && detailedMetrics.storage.sizeBytes) {
-        sizeMB = Number((detailedMetrics.storage.sizeBytes / (1024 * 1024)).toFixed(4));
-    }
+    if (detailedMetrics.storage && detailedMetrics.storage.sizeBytes) { sizeMB = Number((detailedMetrics.storage.sizeBytes / (1024 * 1024)).toFixed(4)); }
 
     // Extract Validation Anomalies (Unusual Keys/Values)
     const anomalies = detailedMetrics.validation?.anomalies || [];
-    if (error && error.message && error.message.includes('Data Integrity')) {
-        // If the error itself was a validation failure, add it to anomalies
-        anomalies.push(error.message);
-    }
+    if (error && error.message && error.message.includes('Data Integrity')) { anomalies.push(error.message); }
 
     // 3. Construct the Run Log Entry
     const runEntry = {

package/functions/computation-system/persistence/StatusRepository.js

@@ -5,23 +5,17 @@
 
 async function fetchComputationStatus(dateStr, config, { db }) {
     if (!dateStr) throw new Error('fetchStatus requires a key'); 
-    
     const collection = config.computationStatusCollection || 'computation_status';
-    const docRef = db.collection(collection).doc(dateStr);
-    
-    const snap = await docRef.get();
+    const docRef     = db.collection(collection).doc(dateStr);
+    const snap       = await docRef.get();
     if (!snap.exists) return {};
-
-    const rawData = snap.data();
+    const rawData    = snap.data();
     const normalized = {};
 
     // Normalize V1 (String) to V2 (Object)
     for (const [name, value] of Object.entries(rawData)) {
-        if (typeof value === 'string') {
-            normalized[name] = { hash: value, category: null }; // Legacy entry
-        } else {
-            normalized[name] = value; // V2 entry { hash, category }
-        }
+        if (typeof value === 'string') { normalized[name] = { hash: value, category: null }; // Legacy entry
+        } else { normalized[name] = value; }
     }
 
     return normalized;
@@ -34,18 +28,10 @@ async function updateComputationStatus(dateStr, updates, config, { db }) {
     const collection = config.computationStatusCollection || 'computation_status';
     const docRef = db.collection(collection).doc(dateStr);
     
-    // We expect updates to be an object: { "CalcName": { hash: "...", category: "..." } }
-    // But result committer might still pass strings if we don't update it. 
-    // We will enforce the structure here just in case.
-    
     const safeUpdates = {};
     for (const [key, val] of Object.entries(updates)) {
-        if (typeof val === 'string') {
-             // Fallback if caller wasn't updated (shouldn't happen with full patch)
-            safeUpdates[key] = { hash: val, category: 'unknown', lastUpdated: new Date() };
-        } else {
-            safeUpdates[key] = { ...val, lastUpdated: new Date() };
-        }
+        if (typeof val === 'string') { safeUpdates[key] = { hash: val, category: 'unknown', lastUpdated: new Date() };
+        } else { safeUpdates[key] = { ...val, lastUpdated: new Date() }; }
     }
 
     await docRef.set(safeUpdates, { merge: true });

package/functions/computation-system/tools/BuildReporter.js

@@ -1,17 +1,17 @@
 /**
  * @fileoverview Build Reporter & Auto-Runner.
  * Generates a "Pre-Flight" report of what the computation system WILL do.
- * UPDATED: Optimized with Parallel Status Fetches inside the date loop.
+ * UPDATED: Fixed 'latest' document overwrite bug.
  */
 
-const { analyzeDateExecution } = require('../WorkflowOrchestrator');
-const { fetchComputationStatus } = require('../persistence/StatusRepository');
+const { analyzeDateExecution }                                             = require('../WorkflowOrchestrator');
+const { fetchComputationStatus }                                           = require('../persistence/StatusRepository');
 const { normalizeName, getExpectedDateStrings, DEFINITIVE_EARLIEST_DATES } = require('../utils/utils');
-const { checkRootDataAvailability } = require('../data/AvailabilityChecker');
-const pLimit = require('p-limit');
-const path = require('path');
-const packageJson = require(path.join(__dirname, '..', '..', '..', 'package.json'));
-const packageVersion = packageJson.version;
+const { checkRootDataAvailability }                                        = require('../data/AvailabilityChecker');
+const pLimit                                                               = require('p-limit');
+const path                                                                 = require('path');
+const packageJson                                                          = require(path.join(__dirname, '..', '..', '..', 'package.json'));
+const packageVersion                                                       = packageJson.version;
 
 /**
  * AUTO-RUN ENTRY POINT
@@ -20,11 +20,13 @@ const packageVersion = packageJson.version;
 async function ensureBuildReport(config, dependencies, manifest) {
     const { db, logger } = dependencies;
     const now = new Date();
+    // Create a standardized build ID
     const buildId = `v${packageVersion}_${now.getFullYear()}-${String(now.getMonth()+1).padStart(2,'0')}-${String(now.getDate()).padStart(2,'0')}_${String(now.getHours()).padStart(2,'0')}-${String(now.getMinutes()).padStart(2,'0')}-${String(now.getSeconds()).padStart(2,'0')}`;
     const latestRef = db.collection('computation_build_records').doc('latest');
 
     try {
         const latestDoc = await latestRef.get();
+        // Check using 'packageVersion' key to match what we store
         const priorVersion = latestDoc.exists ? latestDoc.data().packageVersion : null;
 
         if (priorVersion === packageVersion) {
@@ -33,13 +35,12 @@ async function ensureBuildReport(config, dependencies, manifest) {
         }
 
         logger.log('INFO', `[BuildReporter] 🚀 New Version Detected (${packageVersion}). Auto-running Pre-flight Report...`);
+        
+        // Run generation. This function handles writing the 'latest' document with FULL data.
         await generateBuildReport(config, dependencies, manifest, 90, buildId);
         
-        await latestRef.set({
-            packageVersion,
-            buildId,
-            generatedAt: now.toISOString()
-        });
+        // [FIX] REMOVED: The redundant write that was overwriting the full report with just metadata.
+        // The generateBuildReport function now serves as the single source of truth for writing 'latest'.
 
     } catch (e) {
         logger.log('ERROR', `[BuildReporter] Auto-run check failed: ${e.message}`);
@@ -65,7 +66,7 @@ async function generateBuildReport(config, dependencies, manifest, daysBack = 90
     
     const reportData = {
         buildId,
-        version: packageVersion,
+        packageVersion: packageVersion, // [FIX] Renamed 'version' to 'packageVersion' for consistency with ensureBuildReport check
         generatedAt: new Date().toISOString(),
         summary: {},
         dates: {}
@@ -117,9 +118,9 @@ async function generateBuildReport(config, dependencies, manifest, daysBack = 90
                 willRun: [], willReRun: [], blocked: [], impossible: [] 
             };
 
-            analysis.runnable.forEach(item => dateSummary.willRun.push({ name: item.name, reason: "New / No Previous Record" }));
-            analysis.reRuns.forEach(item => dateSummary.willReRun.push({ name: item.name, reason: item.previousCategory ? "Migration" : "Hash Mismatch" }));
-            analysis.impossible.forEach(item => dateSummary.impossible.push({ name: item.name, reason: item.reason }));
+            analysis.runnable.forEach   (item => dateSummary.willRun.push    ({ name: item.name, reason: "New / No Previous Record" }));
+            analysis.reRuns.forEach     (item => dateSummary.willReRun.push  ({ name: item.name, reason: item.previousCategory ? "Migration" : "Hash Mismatch" }));
+            analysis.impossible.forEach (item => dateSummary.impossible.push ({ name: item.name, reason: item.reason }));
             [...analysis.blocked, ...analysis.failedDependency].forEach(item => dateSummary.blocked.push({ name: item.name, reason: item.reason || 'Dependency' }));
 
             const hasUpdates = dateSummary.willRun.length || dateSummary.willReRun.length || dateSummary.blocked.length || dateSummary.impossible.length;
@@ -155,6 +156,7 @@ async function generateBuildReport(config, dependencies, manifest, daysBack = 90
     await reportRef.set(reportData);
 
     // 5. Update 'latest' pointer
+    // This now writes the FULL reportData, making 'latest' a cache of the actual report.
     await db.collection('computation_build_records').doc('latest').set({
         ...reportData,
         note: "Latest build report pointer."

package/functions/computation-system/utils/data_loader.js

@@ -187,15 +187,10 @@ async function ensurePriceShardIndex(config, deps) {
     const snap = await indexDocRef.get();
     if (snap.exists) {
         const data = snap.data();
-        
-        // [FIX] Check TTL (24 hours)
         const lastUpdated = data.lastUpdated ? new Date(data.lastUpdated).getTime() : 0;
         const now = Date.now();
         const oneDayMs = 24 * 60 * 60 * 1000;
-
-        if ((now - lastUpdated) < oneDayMs) {
-            return data.index || {};
-        }
+        if ((now - lastUpdated) < oneDayMs) { return data.index || {}; }
         logger.log('INFO', '[ShardIndex] Index is stale (>24h). Rebuilding...');
     } else {
         logger.log('INFO', '[ShardIndex] Index not found. Building new Price Shard Index...');

package/functions/computation-system/utils/schema_capture.js

@@ -17,14 +17,9 @@ function validateSchema(schema) {
         
         // 2. Ensure it's not too large (Firestore limit: 1MB, reserve 100KB for metadata)
         const size = Buffer.byteLength(jsonStr);
-        if (size > 900 * 1024) {
-            return { valid: false, reason: `Schema exceeds 900KB limit (${(size/1024).toFixed(2)} KB)` };
-        }
-        
+        if (size > 900 * 1024) { return { valid: false, reason: `Schema exceeds 900KB limit (${(size/1024).toFixed(2)} KB)` }; }
         return { valid: true };
-    } catch (e) {
-        return { valid: false, reason: `Serialization failed: ${e.message}` };
-    }
+    } catch (e) { return { valid: false, reason: `Serialization failed: ${e.message}` }; }
 }
 
 /**
@@ -65,10 +60,10 @@ async function batchStoreSchemas(dependencies, config, schemas) {
             // Critical: Always overwrite 'lastUpdated' to now
             batch.set(docRef, {
                 computationName: item.name,
-                category: item.category,
-                schema: item.schema,
-                metadata: item.metadata || {},
-                lastUpdated: new Date() 
+                category:        item.category,
+                schema:          item.schema,
+                metadata:        item.metadata || {},
+                lastUpdated:     new Date() 
             }, { merge: true });
             
             validCount++;

package/functions/computation-system/utils/utils.js

@@ -159,13 +159,13 @@ async function getFirstDateFromCollection(config, deps, collectionName) {
 async function getEarliestDataDates(config, deps) {
     const { logger } = deps;
     const [ investorDate, speculatorDate, investorHistoryDate, speculatorHistoryDate, insightsDate, socialDate, priceDate ] = await Promise.all([
-        getFirstDateFromCollection(config, deps, config.normalUserPortfolioCollection),
-        getFirstDateFromCollection(config, deps, config.speculatorPortfolioCollection),
-        getFirstDateFromCollection(config, deps, config.normalUserHistoryCollection),
-        getFirstDateFromCollection(config, deps, config.speculatorHistoryCollection),
-        getFirstDateFromSimpleCollection(config, deps, config.insightsCollectionName),
-        getFirstDateFromSimpleCollection(config, deps, config.socialInsightsCollectionName),
-        getFirstDateFromPriceCollection(config, deps)
+        getFirstDateFromCollection       (config, deps, config.normalUserPortfolioCollection),
+        getFirstDateFromCollection       (config, deps, config.speculatorPortfolioCollection),
+        getFirstDateFromCollection       (config, deps, config.normalUserHistoryCollection),
+        getFirstDateFromCollection       (config, deps, config.speculatorHistoryCollection),
+        getFirstDateFromSimpleCollection (config, deps, config.insightsCollectionName),
+        getFirstDateFromSimpleCollection (config, deps, config.socialInsightsCollectionName),
+        getFirstDateFromPriceCollection  (config, deps)
     ]);
 
     const getMinDate = (...dates) => {
@@ -221,5 +221,5 @@ module.exports = {
     getEarliestDataDates, 
     generateCodeHash,
     withRetry,
-    DEFINITIVE_EARLIEST_DATES // [NEW EXPORT]
+    DEFINITIVE_EARLIEST_DATES
 };

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "bulltrackers-module",
-  "version": "1.0.262",
+  "version": "1.0.263",
   "description": "Helper Functions for Bulltrackers.",
   "main": "index.js",
   "files": [