bulltrackers-module 1.0.250 → 1.0.251

package/functions/computation-system/tools/BuildReporter.js

@@ -1,7 +1,7 @@
 /**
  * @fileoverview Build Reporter & Auto-Runner.
  * Generates a "Pre-Flight" report of what the computation system WILL do.
- * UPDATED: Removed "Smart Mocking" in favor of REAL data availability checks to detect gaps/impossible dates.
+ * UPDATED: Now fetches 'prevDailyStatus' to enforce strict historical continuity checks.
  */
 
 const { analyzeDateExecution } = require('../WorkflowOrchestrator');
@@ -88,7 +88,6 @@ async function generateBuildReport(config, dependencies, manifest, daysBack = 90
 
     // 2. PARALLEL PROCESSING (Fix for DEADLINE_EXCEEDED)
     // Run 20 reads in parallel. 
-    // This is now slightly heavier because we verify root data existence, but necessary for accuracy.
     const limit = pLimit(20);
 
     const processingPromises = datesToCheck.map(dateStr => limit(async () => {
@@ -96,9 +95,26 @@ async function generateBuildReport(config, dependencies, manifest, daysBack = 90
             // A. Fetch REAL status from DB (What ran previously?)
             const dailyStatus = await fetchComputationStatus(dateStr, config, dependencies);
 
-            // B. REAL Root Data Check [FIXED]
-            // Previously we mocked this based on dates. Now we check if the data ACTUALLY exists.
-            // This ensures missing social data (even if after the start date) is flagged as IMPOSSIBLE.
+            // [NEW] B. Fetch YESTERDAY'S Status (For strict continuity checks)
+            let prevDailyStatus = null;
+            
+            // Only fetch if ANY calculation in the manifest is historical
+            // (Optimization: In BuildReporter we pass the full manifest, so we check if any exist generally)
+            if (manifest.some(c => c.isHistorical)) {
+                const prevDate = new Date(dateStr + 'T00:00:00Z');
+                prevDate.setUTCDate(prevDate.getUTCDate() - 1);
+                const prevDateStr = prevDate.toISOString().slice(0, 10);
+                
+                // Ensure we don't look before the dawn of time
+                if (prevDate >= DEFINITIVE_EARLIEST_DATES.absoluteEarliest) {
+                    prevDailyStatus = await fetchComputationStatus(prevDateStr, config, dependencies);
+                } else {
+                    prevDailyStatus = {}; // Pre-epoch is valid empty context
+                }
+            }
+
+            // C. REAL Root Data Check
+            // Uses the new Indexer logic (returns null refs, but valid status flags)
             const availability = await checkRootDataAvailability(dateStr, config, dependencies, DEFINITIVE_EARLIEST_DATES);
             
             const rootDataStatus = availability ? availability.status : {
@@ -109,10 +125,11 @@ async function generateBuildReport(config, dependencies, manifest, daysBack = 90
                 hasPrices:    false
             };
 
-            // C. Run Logic Analysis
-            const analysis = analyzeDateExecution(dateStr, manifest, rootDataStatus, dailyStatus, manifestMap);
+            // D. Run Logic Analysis
+            // Now passes prevDailyStatus to enable the "Blocked if yesterday missing" logic
+            const analysis = analyzeDateExecution(dateStr, manifest, rootDataStatus, dailyStatus, manifestMap, prevDailyStatus);
 
-            // D. Format Findings
+            // E. Format Findings
             const dateSummary = {
                 willRun: [],
                 willReRun: [],

package/functions/root-data-indexer/index.js

@@ -10,7 +10,7 @@ const pLimit = require('p-limit');
 // Hardcoded verification blocks as per logic requirements
 const CANARY_BLOCK_ID = '19M';
 const CANARY_PART_ID = 'part_0';
-const PRICE_SHARD_ID = 'shard_0';
+const PRICE_SHARD_ID = 'shard_1'; // Shard_1 contains ETH price data, which has 24/7 prices since it's crypto, so if it exists for a given date, system worked for price data, if it doesn't exist, then the system failed for that date, best case assumption.
 
 /**
  * Main pipe: pipe.maintenance.runRootDataIndexer
@@ -28,11 +28,39 @@ exports.runRootDataIndexer = async (config, dependencies) => {
     // 1. Pre-fetch Price Data Availability (Optimization)
     // Instead of reading the shard N times, we read it once and map available dates.
     const priceAvailabilitySet = new Set();
+    
+    // --- DEBUGGING START ---
+    logger.log('INFO', `[RootDataIndexer] DEBUG: Attempting to fetch price shard. Collection: "${collections.prices}", Doc ID: "${PRICE_SHARD_ID}"`);
+    // --- DEBUGGING END ---
+
     try {
         const priceShardRef = db.collection(collections.prices).doc(PRICE_SHARD_ID);
         const priceSnap = await priceShardRef.get();
+        
         if (priceSnap.exists) {
             const data = priceSnap.data();
+            const instruments = Object.values(data);
+            
+            // --- DEBUGGING START ---
+            logger.log('INFO', `[RootDataIndexer] DEBUG: Shard document found. Contains ${instruments.length} instrument entries.`);
+            
+            if (instruments.length > 0) {
+                // Log the structure of the first instrument found to verify schema match
+                const sampleKey = Object.keys(data)[0];
+                const sampleVal = data[sampleKey];
+                logger.log('INFO', `[RootDataIndexer] DEBUG: Sample Instrument Data (ID: ${sampleKey}):`, sampleVal);
+                
+                if (!sampleVal.prices) {
+                    logger.log('WARN', `[RootDataIndexer] DEBUG: ⚠️ Sample instrument is MISSING the 'prices' field! Available fields: ${Object.keys(sampleVal).join(', ')}`);
+                } else {
+                    const priceKeys = Object.keys(sampleVal.prices);
+                    logger.log('INFO', `[RootDataIndexer] DEBUG: Sample 'prices' keys found (${priceKeys.length}): [${priceKeys.slice(0, 5).join(', ')}...]`);
+                }
+            } else {
+                logger.log('WARN', '[RootDataIndexer] DEBUG: Shard document exists but appears empty (0 instruments found).');
+            }
+            // --- DEBUGGING END ---
+
             // Iterate over all instruments in this shard to find any available dates
             Object.values(data).forEach(instrument => {
                 if (instrument.prices) {
@@ -40,10 +68,17 @@ exports.runRootDataIndexer = async (config, dependencies) => {
                         // Validate format YYYY-MM-DD
                         if (/^\d{4}-\d{2}-\d{2}$/.test(dateKey)) {
                             priceAvailabilitySet.add(dateKey);
+                        } else {
+                            // Log regex failures occasionally
+                            if (Math.random() < 0.001) logger.log('WARN', `[RootDataIndexer] DEBUG: Date key "${dateKey}" failed regex validation.`);
                         }
                     });
                 }
             });
+        } else {
+            // --- DEBUGGING START ---
+            logger.log('ERROR', `[RootDataIndexer] DEBUG: 🛑 FATAL: Document "${PRICE_SHARD_ID}" does NOT exist in collection "${collections.prices}". Price availability will be false for all dates.`);
+            // --- DEBUGGING END ---
         }
         logger.log('INFO', `[RootDataIndexer] Loaded price availability map. Found prices for ${priceAvailabilitySet.size} unique dates.`);
     } catch (e) {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "bulltrackers-module",
-  "version": "1.0.250",
+  "version": "1.0.251",
   "description": "Helper Functions for Bulltrackers.",
   "main": "index.js",
   "files": [