bulltrackers-module 1.0.183 → 1.0.184

package/functions/computation-system/controllers/computation_controller.js

@@ -1,6 +1,6 @@
 /**
  * FIXED: computation_controller.js
- * V3.3: Adds Price Loading for Meta Context & Fixes Context Injection
+ * V3.4: Adds Price Loading & Context Injection.
  */
 
 const { DataExtractor, 
@@ -55,34 +55,25 @@ class DataLoader {
         
         try {
             const snapshot = await db.collection(collection).get();
-            if (snapshot.empty) return { history: [] };
+            if (snapshot.empty) return { history: {} };
 
-            // Flatten shards into a single array for the context
-            // Structure expected by calculation: Array of { instrumentId, prices: {...} }
-            const allPrices = [];
+            const historyMap = {};
             
             snapshot.forEach(doc => {
                 const shardData = doc.data();
-                // Iterate keys in shard (instrumentIds)
-                for (const [instId, data] of Object.entries(shardData)) {
-                    if (data && data.prices) {
-                        allPrices.push({
-                            instrumentId: instId,
-                            ...data 
-                        });
-                    }
-                }
+                // Merge shard keys (instrumentIds) into main map
+                if (shardData) Object.assign(historyMap, shardData);
             });
 
-            logger.log('INFO', `[DataLoader] Loaded prices for ${allPrices.length} instruments.`);
+            logger.log('INFO', `[DataLoader] Loaded prices for ${Object.keys(historyMap).length} instruments.`);
             
-            // Cache as an object with 'history' array to match context expectations
-            this.cache.prices = { history: allPrices };
+            // Cache as an object with 'history' map to match priceExtractor expectations
+            this.cache.prices = { history: historyMap };
             return this.cache.prices;
 
         } catch (e) {
             logger.log('ERROR', `[DataLoader] Failed to load prices: ${e.message}`);
-            return { history: [] };
+            return { history: {} };
         }
     }
 }

package/functions/computation-system/helpers/orchestration_helpers.js

@@ -1,6 +1,6 @@
 /**
  * FILENAME: bulltrackers-module/functions/computation-system/helpers/orchestration_helpers.js
- * FIXED: Only marks computations as TRUE if they actually store results.
+ * FIXED: Explicit Logging + Honest Status Updates
  */
 
 const { ComputationController }              = require('../controllers/computation_controller');
@@ -28,8 +28,6 @@ function checkRootDependencies(calcManifest, rootDataStatus) {
         else if (dep === 'insights'  && !rootDataStatus.hasInsights)  missing.push('insights');
         else if (dep === 'social'    && !rootDataStatus.hasSocial)    missing.push('social');
         else if (dep === 'history'   && !rootDataStatus.hasHistory)   missing.push('history');
-        // Note: 'price' is typically not a blocking root check in this specific function logic unless added,
-        // but usually prices are treated as auxiliary. If you want to block on prices, add it here.
     }
     return { canRun: missing.length === 0, missing };
 }
@@ -52,7 +50,6 @@ async function checkRootDataAvailability(dateStr, config, dependencies, earliest
         
         await Promise.all(tasks);
         
-        // We allow running if ANY data is present. Specific calcs filter themselves using checkRootDependencies.
         if (!(hasPortfolio || hasInsights || hasSocial || hasHistory)) return null;
         
         return { 
@@ -205,6 +202,9 @@ async function runStandardComputationPass(date, calcs, passName, config, deps, r
             const inst = new c.class(); 
             inst.manifest = c; 
             state[normalizeName(c.name)] = inst; 
+            
+            // LOG: Explicitly say what calculation is being processed (Initialized)
+            logger.log('INFO', `${c.name} calculation running for ${dStr}`);
         } 
         catch(e)  { 
             logger.log('WARN', `Failed to init ${c.name}`); 
@@ -223,6 +223,9 @@ async function runMetaComputationPass(date, calcs, passName, config, deps, fetch
 
     for (const mCalc of calcs) {
         try {
+            // LOG: Explicitly say what calculation is being processed
+            deps.logger.log('INFO', `${mCalc.name} calculation running for ${dStr}`);
+
             const inst = new mCalc.class();
             inst.manifest = mCalc;
             await controller.executor.executeOncePerDay(inst, mCalc, dStr, fetchedDeps, previousFetchedDeps);
@@ -234,8 +237,8 @@ async function runMetaComputationPass(date, calcs, passName, config, deps, fetch
 }
 
 /**
- * --- FIXED: commitResults ---
- * Only marks 'successUpdates' if data is actually written.
+ * --- UPDATED: commitResults ---
+ * Includes Explicit Result Logging and Honest Status Reporting.
  */
 async function commitResults(stateObj, dStr, passName, config, deps, skipStatusWrite = false) {
     const writes = [], schemas = [], sharded = {};
@@ -245,10 +248,15 @@ async function commitResults(stateObj, dStr, passName, config, deps, skipStatusW
         const calc = stateObj[name];
         try {
             const result = await calc.getResult(); 
-            if (!result) continue;
+            
+            // If null/undefined, log as Failed/Unknown immediately
+            if (!result) {
+                deps.logger.log('INFO', `${name} calculation for ${dStr} ran, result : Failed (Empty Result)`);
+                continue;
+            }
             
             const standardRes = {};
-            let hasData = false; // Track if this calc produced data
+            let hasData = false;
 
             for (const key in result) {
                 if (key.startsWith('sharded_')) {
@@ -284,15 +292,19 @@ async function commitResults(stateObj, dStr, passName, config, deps, skipStatusW
                 });
             }
             
-            // FIX: Only mark as successful if we actually had data to write.
+            // --- EXPLICIT LOGGING & STATUS UPDATE ---
             if (hasData) {
                 successUpdates[name] = true;
+                deps.logger.log('INFO', `${name} calculation for ${dStr} ran, result : Succeeded`);
             } else {
-                // Optional: Log that it produced no data
-                // deps.logger.log('INFO', `Calc ${name} produced no data. Skipping status update.`);
+                // It ran without error, but produced no content (e.g. no data met criteria)
+                deps.logger.log('INFO', `${name} calculation for ${dStr} ran, result : Unknown (No Data Written)`);
             }
 
-        } catch (e) { deps.logger.log('ERROR', `Commit failed ${name}: ${e.message}`); }
+        } catch (e) { 
+            deps.logger.log('ERROR', `Commit failed ${name}: ${e.message}`);
+            deps.logger.log('INFO', `${name} calculation for ${dStr} ran, result : Failed (Exception)`);
+        }
     }
 
     if (schemas.length) batchStoreSchemas(deps, config, schemas).catch(()=>{});

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "bulltrackers-module",
-  "version": "1.0.183",
+  "version": "1.0.184",
   "description": "Helper Functions for Bulltrackers.",
   "main": "index.js",
   "files": [