bulltrackers-module 1.0.152 → 1.0.154

package/functions/etoro-price-fetcher/helpers/handler_helpers.js

@@ -17,109 +17,41 @@ const SHARD_SIZE = 40;
  */
 exports.fetchAndStorePrices = async (config, dependencies) => {
     const { db, logger, headerManager, proxyManager } = dependencies;
-
     logger.log('INFO', '[PriceFetcherHelpers] Starting Daily Closing Price Update...');
     let selectedHeader = null;
     let wasSuccessful = false;
-
-    // --- NEW: Use the new config key, or fallback to the old one --- TODO Implement the config
     const priceCollectionName =  'asset_prices';
-
-    try {
-        if (!config.etoroApiUrl) {
-            throw new Error("Missing required configuration: etoroApiUrl.");
-        }
-
+    try { if (!config.etoroApiUrl) { throw new Error("Missing required configuration: etoroApiUrl."); }
         selectedHeader = await headerManager.selectHeader();
-        if (!selectedHeader || !selectedHeader.header) {
-            throw new Error("Could not select a valid header for the request.");
-        }
-
-        const fetchOptions = {
-             headers: selectedHeader.header,
-             timeout: 60000
-        };
-
+        if (!selectedHeader || !selectedHeader.header) { throw new Error("Could not select a valid header for the request."); }
+        const fetchOptions = { headers: selectedHeader.header, timeout: 60000 };
         logger.log('INFO', `[PriceFetcherHelpers] Using header ID: ${selectedHeader.id}`);
-
         const response = await proxyManager.fetch(config.etoroApiUrl, fetchOptions);
-
-        if (!response || typeof response.text !== 'function') {
-            throw new Error(`Invalid response structure received from proxy.`);
-        }
-
-        if (!response.ok) {
-            const errorBody = await response.text();
-            throw new Error(`API returned status ${response.status}: ${errorBody}`);
-        }
+        if (!response || typeof response.text !== 'function') { throw new Error(`Invalid response structure received from proxy.`); }
+        if (!response.ok) { const errorBody = await response.text(); throw new Error(`API returned status ${response.status}: ${errorBody}`); }
         wasSuccessful = true;
-
         const results = await response.json();
-        if (!Array.isArray(results)) {
-            throw new Error('Invalid response format from API. Expected an array.');
-        }
-
-        // --- START MODIFICATION ---
-        
+        if (!Array.isArray(results)) { throw new Error('Invalid response format from API. Expected an array.'); }        
         logger.log('INFO', `[PriceFetcherHelpers] Received ${results.length} instrument prices. Sharding...`);
-        const shardUpdates = {}; // { "shard_0": { ... }, "shard_1": { ... } }
-
+        const shardUpdates = {}; 
         for (const instrumentData of results) {
             const dailyData = instrumentData?.ClosingPrices?.Daily;
             const instrumentId = instrumentData.InstrumentId;
-
             if (instrumentId && dailyData?.Price && dailyData?.Date) {
                 const instrumentIdStr = String(instrumentId);
                 const dateKey = dailyData.Date.substring(0, 10);
-                
-                // Determine shard ID
                 const shardId = `shard_${parseInt(instrumentIdStr, 10) % SHARD_SIZE}`;
-                
-                if (!shardUpdates[shardId]) {
-                    shardUpdates[shardId] = {};
-                }
-                
-                // Use dot notation to define the update path
+                if (!shardUpdates[shardId]) { shardUpdates[shardId] = {}; }
                 const pricePath = `${instrumentIdStr}.prices.${dateKey}`;
                 const updatePath = `${instrumentIdStr}.lastUpdated`;
-
                 shardUpdates[shardId][pricePath] = dailyData.Price;
-                shardUpdates[shardId][updatePath] = FieldValue.serverTimestamp();
-            }
-        }
-
-        // Commit all shard updates in parallel
+                shardUpdates[shardId][updatePath] = FieldValue.serverTimestamp(); } }
         const batchPromises = [];
-        for (const shardId in shardUpdates) {
-            const docRef = db.collection(priceCollectionName).doc(shardId);
-            const payload = shardUpdates[shardId];
-            
-            // --- THIS IS THE FIX ---
-            // Use .update() to correctly merge data into nested maps.
-            // Using .set(payload, { merge: true }) creates the flat, broken keys.
-            batchPromises.push(docRef.update(payload));
-            // --- END FIX ---
-        }
-
+        for (const shardId in shardUpdates) { const docRef = db.collection(priceCollectionName).doc(shardId); const payload = shardUpdates[shardId]; batchPromises.push(docRef.update(payload)); }
         await Promise.all(batchPromises);
-        
-        // --- END MODIFICATION ---
-
         const successMessage = `Successfully processed and saved daily prices for ${results.length} instruments to ${batchPromises.length} shards.`;
         logger.log('SUCCESS', `[PriceFetcherHelpers] ${successMessage}`);
         return { success: true, message: successMessage, instrumentsProcessed: results.length };
-
-    } catch (error) {
-        logger.log('ERROR', '[PriceFetcherHelpers] Fatal error during closing price update', {
-            errorMessage: error.message,
-            errorStack: error.stack,
-            headerId: selectedHeader ? selectedHeader.id : 'not-selected'
-        });
-        throw error;
-    } finally {
-        if (selectedHeader) {
-            await headerManager.updatePerformance(selectedHeader.id, wasSuccessful);
-            await headerManager.flushPerformanceUpdates();
-        }
-    }
+    } catch (error) { logger.log('ERROR', '[PriceFetcherHelpers] Fatal error during closing price update', { errorMessage: error.message, errorStack: error.stack, headerId: selectedHeader ? selectedHeader.id : 'not-selected' }); throw error;
+    } finally { if (selectedHeader) { await headerManager.updatePerformance(selectedHeader.id, wasSuccessful); await headerManager.flushPerformanceUpdates(); } }
 };

package/functions/fetch-insights/helpers/handler_helpers.js

@@ -12,80 +12,28 @@ const { FieldValue } = require('@google-cloud/firestore');
  */
 exports.fetchAndStoreInsights = async (config, dependencies) => {
     const { db, logger, headerManager, proxyManager } = dependencies;
-    
     logger.log('INFO', '[FetchInsightsHelpers] Starting eToro insights data fetch...');
-    let selectedHeader = null;
-    let wasSuccessful = false;
-
+    let selectedHeader = null; let wasSuccessful = false;
     try {
-        if (!config.etoroInsightsUrl || !config.insightsCollectionName) {
-            throw new Error("Missing required configuration: etoroInsightsUrl or insightsCollectionName.");
-        }
-
+        if (!config.etoroInsightsUrl || !config.insightsCollectionName) { throw new Error("Missing required configuration: etoroInsightsUrl or insightsCollectionName."); }
         selectedHeader = await headerManager.selectHeader();
-         if (!selectedHeader || !selectedHeader.header) {
-            throw new Error("Could not select a valid header for the request.");
-        }
-
-        logger.log('INFO', `[FetchInsightsHelpers] Using header ID: ${selectedHeader.id}`, {
-            userAgent: selectedHeader.header['User-Agent']
-        });
-
-        const fetchOptions = {
-             headers: selectedHeader.header,
-             timeout: 30000
-        };
-
+        if (!selectedHeader || !selectedHeader.header) { throw new Error("Could not select a valid header for the request."); }
+        logger.log('INFO', `[FetchInsightsHelpers] Using header ID: ${selectedHeader.id}`, { userAgent: selectedHeader.header['User-Agent'] });
+        const fetchOptions = { headers: selectedHeader.header, timeout: 30000 };
         const response = await proxyManager.fetch(config.etoroInsightsUrl, fetchOptions);
-        
-        if (!response || typeof response.text !== 'function') {
-            const responseString = JSON.stringify(response, null, 2);
-            logger.log('ERROR', `[FetchInsightsHelpers] Invalid or incomplete response received. Response object: ${responseString}`);
-            throw new Error(`Invalid response structure received from proxy.`);
-        }
-
-        if (!response.ok) {
-            const errorText = await response.text();
-            throw new Error(`API request failed via proxy with status ${response.status}: ${errorText}`);
-        }
-
+        if (!response || typeof response.text !== 'function') { const responseString = JSON.stringify(response, null, 2); 
+        logger.log('ERROR', `[FetchInsightsHelpers] Invalid or incomplete response received. Response object: ${responseString}`); throw new Error(`Invalid response structure received from proxy.`); }
+        if (!response.ok) { const errorText = await response.text(); 
+        throw new Error(`API request failed via proxy with status ${response.status}: ${errorText}`); }
         wasSuccessful = true;
         const insightsData = await response.json();
-
-         if (!Array.isArray(insightsData) || insightsData.length === 0) {
-             throw new Error('API returned empty or invalid data.');
-         }
-
-         const today = new Date().toISOString().slice(0, 10);
-         const docRef = db.collection(config.insightsCollectionName).doc(today); // Use db
-
-         const firestorePayload = {
-             fetchedAt: FieldValue.serverTimestamp(),
-             instrumentCount: insightsData.length,
-             insights: insightsData
-         };
-
-         await docRef.set(firestorePayload);
-
-         const successMsg = `Successfully fetched and stored ${insightsData.length} instrument insights for ${today}.`;
-         logger.log('SUCCESS', `[FetchInsightsHelpers] ${successMsg}`, {
-             documentId: today,
-             instrumentCount: insightsData.length
-         });
-         return { success: true, message: successMsg, instrumentCount: insightsData.length };
-
-    } catch (error) {
-        logger.log('ERROR', '[FetchInsightsHelpers] Error fetching eToro insights', {
-            errorMessage: error.message,
-            errorStack: error.stack,
-            headerId: selectedHeader ? selectedHeader.id : 'not-selected'
-        });
-        throw error;
-    } finally {
-         if (selectedHeader) {
-            await headerManager.updatePerformance(selectedHeader.id, wasSuccessful);
-            // Also flush performance, as this is a standalone function
-            await headerManager.flushPerformanceUpdates();
-         }
-    }
+        if (!Array.isArray(insightsData) || insightsData.length === 0) { throw new Error('API returned empty or invalid data.'); }
+        const today = new Date().toISOString().slice(0, 10);
+        const docRef = db.collection(config.insightsCollectionName).doc(today);
+        const firestorePayload = { fetchedAt: FieldValue.serverTimestamp(), instrumentCount: insightsData.length, insights: insightsData };
+        await docRef.set(firestorePayload);
+        const successMsg = `Successfully fetched and stored ${insightsData.length} instrument insights for ${today}.`; 
+        logger.log('SUCCESS', `[FetchInsightsHelpers] ${successMsg}`, { documentId: today, instrumentCount: insightsData.length }); return { success: true, message: successMsg, instrumentCount: insightsData.length };
+    } catch (error) { logger.log('ERROR', '[FetchInsightsHelpers] Error fetching eToro insights', { errorMessage: error.message, errorStack: error.stack, headerId: selectedHeader ? selectedHeader.id : 'not-selected' }); throw error;
+    } finally { if (selectedHeader) { await headerManager.updatePerformance(selectedHeader.id, wasSuccessful); await headerManager.flushPerformanceUpdates(); } }
 };

package/functions/generic-api/helpers/api_helpers.js

@@ -7,7 +7,6 @@
 
 const { FieldPath } = require('@google-cloud/firestore');
 
-// --- All Mocks are REMOVED ---
 
 /**
  * Sub-pipe: pipe.api.helpers.validateRequest
@@ -16,16 +15,13 @@ const validateRequest = (query, config) => {
     if (!query.computations) return "Missing 'computations' parameter.";
     if (!query.startDate || !/^\d{4}-\d{2}-\d{2}$/.test(query.startDate)) return "Missing or invalid 'startDate'.";
     if (!query.endDate || !/^\d{4}-\d{2}-\d{2}$/.test(query.endDate)) return "Missing or invalid 'endDate'.";
-
     const start = new Date(query.startDate);
     const end = new Date(query.endDate);
     if (end < start) return "'endDate' must be after 'startDate'.";
-
     const maxDateRange = config.maxDateRange || 100;
     const diffTime = Math.abs(end - start);
     const diffDays = Math.ceil(diffTime / (1000 * 60 * 60 * 24)) + 1;
     if (diffDays > maxDateRange) return `Date range cannot exceed ${maxDateRange} days.`;
-
     return null;
 };
 
@@ -38,29 +34,8 @@ const validateRequest = (query, config) => {
 const buildCalculationMap = (unifiedCalculations) => {
     const calcMap = {};
     for (const category in unifiedCalculations) {
-        for (const subKey in unifiedCalculations[category]) {
-            const item = unifiedCalculations[category][subKey];
-
-            // Handle historical subdirectory
-            if (subKey === 'historical' && typeof item === 'object') {
-                for (const calcName in item) {
-                    calcMap[calcName] = { 
-                        category: category,
-                        class: item[calcName] // <-- Store the class
-                    };
-                }
-            } 
-            // Handle regular daily/meta/social calc
-            else if (typeof item === 'function') {
-                const calcName = subKey;
-                calcMap[calcName] = { 
-                    category: category,
-                    class: item // <-- Store the class
-                };
-            }
-        }
-    }
-    return calcMap;
+        for (const subKey in unifiedCalculations[category]) { const item = unifiedCalculations[category][subKey]; if (subKey === 'historical' && typeof item === 'object') { for (const calcName in item) { calcMap[calcName] = {  category: category, class: item[calcName]  }; } }  
+        else if (typeof item === 'function') { const calcName = subKey; calcMap[calcName] = {  category: category, class: item  }; }}} return calcMap;
 };
 
 /**
@@ -70,11 +45,7 @@ const getDateStringsInRange = (startDate, endDate) => {
     const dates = [];
     const current = new Date(startDate + 'T00:00:00Z');
     const end = new Date(endDate + 'T00:00:00Z');
-
-    while (current <= end) {
-        dates.push(current.toISOString().slice(0, 10));
-        current.setUTCDate(current.getUTCDate() + 1);
-    }
+    while (current <= end) { dates.push(current.toISOString().slice(0, 10)); current.setUTCDate(current.getUTCDate() + 1); }
     return dates;
 };
 
@@ -87,40 +58,19 @@ const fetchUnifiedData = async (config, dependencies, calcKeys, dateStrings, cal
     const insightsCollection = config.unifiedInsightsCollection || 'unified_insights';
     const resultsSub = config.resultsSubcollection || 'results';
     const compsSub = config.computationsSubcollection || 'computations';
-
     try {
         for (const date of dateStrings) {
             response[date] = {};
             const docRefs = [];
             const keyPaths = [];
-
             for (const key of calcKeys) {
                 const pathInfo = calcMap[key];
-                if (pathInfo) {
-                    const docRef = db.collection(insightsCollection).doc(date)
-                        .collection(resultsSub).doc(pathInfo.category)
-                        .collection(compsSub).doc(key);
-                    docRefs.push(docRef);
-                    keyPaths.push(key);
-                } else {
-                    logger.log('WARN', `[${date}] No path info found for computation key: ${key}`);
-                }
-            }
+                if (pathInfo) { const docRef = db.collection(insightsCollection).doc(date) .collection(resultsSub).doc(pathInfo.category) .collection(compsSub).doc(key); docRefs.push(docRef); keyPaths.push(key);
+                } else { logger.log('WARN', `[${date}] No path info found for computation key: ${key}`); } }
             if (docRefs.length === 0) continue;
             const snapshots = await db.getAll(...docRefs);
-            snapshots.forEach((doc, i) => {
-                const key = keyPaths[i];
-                if (doc.exists) {
-                    response[date][key] = doc.data();
-                } else {
-                    response[date][key] = null;
-                }
-            });
-        }
-    } catch (error) {
-        logger.log('ERROR', 'API: Error fetching data from Firestore.', { errorMessage: error.message });
-        throw new Error('Failed to retrieve computation data.');
-    }
+            snapshots.forEach((doc, i) => { const key = keyPaths[i]; if (doc.exists) { response[date][key] = doc.data(); } else { response[date][key] = null; } }); }
+    } catch (error) { logger.log('ERROR', 'API: Error fetching data from Firestore.', { errorMessage: error.message }); throw new Error('Failed to retrieve computation data.'); }
     return response;
 };
 
@@ -129,31 +79,14 @@ const fetchUnifiedData = async (config, dependencies, calcKeys, dateStrings, cal
  */
 const createApiHandler = (config, dependencies, calcMap) => {
     const { logger } = dependencies; 
-    
-    return async (req, res) => {
-        const validationError = validateRequest(req.query, config);
-        if (validationError) {
-            logger.log('WARN', 'API Bad Request', { error: validationError, query: req.query });
-            return res.status(400).send({ status: 'error', message: validationError });
-        }
+    return async (req, res) => { const validationError = validateRequest(req.query, config);
+        if (validationError) { logger.log('WARN', 'API Bad Request', { error: validationError, query: req.query });  return res.status(400).send({ status: 'error', message: validationError }); }
         try {
             const computationKeys = req.query.computations.split(',');
             const dateStrings = getDateStringsInRange(req.query.startDate, req.query.endDate);
             const data = await fetchUnifiedData(config, dependencies, computationKeys, dateStrings, calcMap);
-            res.status(200).send({
-                status: 'success',
-                metadata: {
-                    computations: computationKeys,
-                    startDate: req.query.startDate,
-                    endDate: req.query.endDate,
-                },
-                data,
-            });
-        } catch (error) {
-            logger.log('ERROR', 'API processing failed.', { errorMessage: error.message, stack: error.stack });
-            res.status(500).send({ status: 'error', message: 'An internal error occurred.' });
-        }
-    };
+            res.status(200).send({ status: 'success', metadata: { computations: computationKeys, startDate: req.query.startDate, endDate: req.query.endDate, }, data, });
+        } catch (error) { logger.log('ERROR', 'API processing failed.', { errorMessage: error.message, stack: error.stack }); res.status(500).send({ status: 'error', message: 'An internal error occurred.' }); } };
 };
 
 /**
@@ -166,13 +99,9 @@ function createStructureSnippet(data, maxKeys = 20) {
         if (typeof data === 'boolean') return true;
         return data;
     }
-    if (Array.isArray(data)) {
-        if (data.length === 0) return "<empty array>";
-        return [ createStructureSnippet(data[0], maxKeys) ];
-    }
+    if (Array.isArray(data)) { if (data.length === 0) return "<empty array>"; return [ createStructureSnippet(data[0], maxKeys) ]; }
     const newObj = {};
-    const keys = Object.keys(data);
-    
+    const keys = Object.keys(data)
     if (keys.length > 0 && keys.every(k => k.match(/^[A-Z.]+$/) || k.includes('_') || k.match(/^[0-9]+$/))) {
         const exampleKey = keys[0];
         newObj[exampleKey] = createStructureSnippet(data[exampleKey], maxKeys);
@@ -184,10 +113,7 @@ function createStructureSnippet(data, maxKeys = 20) {
         newObj[firstKey] = createStructureSnippet(data[firstKey], maxKeys);
         newObj[`... (${keys.length - 1} more keys)`] = "<object>";
     } else {
-        for (const key of keys) {
-            newObj[key] = createStructureSnippet(data[key], maxKeys);
-        }
-    }
+        for (const key of keys) { newObj[key] = createStructureSnippet(data[key], maxKeys); } }
     return newObj;
 }
 
@@ -198,40 +124,22 @@ async function getComputationStructure(computationName, calcMap, config, depende
     const { db, logger } = dependencies;
     try {
         const pathInfo = calcMap[computationName];
-        if (!pathInfo) {
-            return { status: 'error', computation: computationName, message: `Computation not found in calculation map.` };
-        }
+        if (!pathInfo) { return { status: 'error', computation: computationName, message: `Computation not found in calculation map.` }; }
         const { category } = pathInfo;
         const insightsCollection = config.unifiedInsightsCollection || 'unified_insights';
         const resultsSub = config.resultsSubcollection || 'results';
         const compsSub = config.computationsSubcollection || 'computations';
         const computationQueryPath = `${category}.${computationName}`;
-        
-        const dateQuery = db.collection(insightsCollection)
-            .where(computationQueryPath, '==', true)
-            .orderBy(FieldPath.documentId(), 'desc')
-            .limit(1);
+        const dateQuery = db.collection(insightsCollection) .where(computationQueryPath, '==', true) .orderBy(FieldPath.documentId(), 'desc') .limit(1);
         const dateSnapshot = await dateQuery.get();
-        if (dateSnapshot.empty) {
-            return { status: 'error', computation: computationName, message: `No computed data found. (Query path: ${computationQueryPath})` };
-        }
+        if (dateSnapshot.empty) { return { status: 'error', computation: computationName, message: `No computed data found. (Query path: ${computationQueryPath})` }; }
         const latestStoredDate = dateSnapshot.docs[0].id;
-        const docRef = db.collection(insightsCollection).doc(latestStoredDate)
-            .collection(resultsSub).doc(category)
-            .collection(compsSub).doc(computationName);
+        const docRef = db.collection(insightsCollection).doc(latestStoredDate) .collection(resultsSub).doc(category) .collection(compsSub).doc(computationName);
         const doc = await docRef.get();
-        if (!doc.exists) {
-            return { status: 'error', computation: computationName, message: `Summary flag was present for ${latestStoredDate} but doc is missing.` };
-        }
+        if (!doc.exists) { return { status: 'error', computation: computationName, message: `Summary flag was present for ${latestStoredDate} but doc is missing.` }; }
         const fullData = doc.data();
         const structureSnippet = createStructureSnippet(fullData);
-        return {
-            status: 'success',
-            computation: computationName,
-            category: category,
-            latestStoredDate: latestStoredDate,
-            structureSnippet: structureSnippet,
-        };
+        return { status: 'success', computation: computationName, category: category, latestStoredDate: latestStoredDate, structureSnippet: structureSnippet, };
     } catch (error) {
         logger.log('ERROR', `API /structure/${computationName} helper failed.`, { errorMessage: error.message });
         return { status: 'error', computation: computationName, message: error.message };
@@ -244,17 +152,10 @@ async function getComputationStructure(computationName, calcMap, config, depende
  */
 async function getDynamicSchema(CalcClass, calcName) {
     if (CalcClass && typeof CalcClass.getSchema === 'function') {
-        try {
-            return CalcClass.getSchema();
-        } catch (e) {
-            console.error(`Error running static getSchema() for ${calcName}: ${e.message}`);
-            return { "ERROR": `Failed to get static schema: ${e.message}` };
-        }
-    } else {
-        return { "ERROR": `Computation '${calcName}' does not have a static getSchema() method defined.` };
-    }
+        try { return CalcClass.getSchema();
+        } catch (e) { console.error(`Error running static getSchema() for ${calcName}: ${e.message}`); return { "ERROR": `Failed to get static schema: ${e.message}` };}
+    } else { return { "ERROR": `Computation '${calcName}' does not have a static getSchema() method defined.` }; }
 }
-// --- END UPDATED HARNESS ---
 
 
 /**
@@ -263,58 +164,18 @@ async function getDynamicSchema(CalcClass, calcName) {
 const createManifestHandler = (config, dependencies, calcMap) => {
     const { db, logger } = dependencies;
     const schemaCollection = config.schemaCollection || 'computation_schemas';
-    
     return async (req, res) => {
         try {
             logger.log('INFO', '[API /manifest] Fetching all computation schemas...');
             const snapshot = await db.collection(schemaCollection).get();
-            if (snapshot.empty) {
-                logger.log('WARN', '[API /manifest] No schemas found in collection.');
-                return res.status(404).send({ status: 'error', message: 'No computation schemas have been generated yet.' });
-            }
-            
+            if (snapshot.empty) { logger.log('WARN', '[API /manifest] No schemas found in collection.'); return res.status(404).send({ status: 'error', message: 'No computation schemas have been generated yet.' }); }
             const manifest = {};
-            snapshot.forEach(doc => {
-                const data = doc.data();
-                manifest[doc.id] = {
-                    // --- CHANGED: Return the structure consistent with your file ---
-                    category: data.category,
-                    structure: data.schema, // Use 'structure' key
-                    metadata: data.metadata,
-                    lastUpdated: data.lastUpdated
-                };
-            });
-            
-            res.status(200).send({
-                status: 'success',
-                // --- CHANGED: Use the structure from your file ---
-                summary: {
-                    source: 'firestore_computation_schemas',
-                    totalComputations: snapshot.size,
-                    schemasAvailable: snapshot.size,
-                    schemasFailed: 0,
-                    lastUpdated: Math.max(...Object.values(manifest).map(m => 
-                        m.lastUpdated ? m.lastUpdated.toMillis() : 0
-                    ))
-                },
-                manifest: manifest
-            });
-
+            snapshot.forEach(doc => { const data = doc.data(); manifest[doc.id] = { category: data.category, structure: data.schema,  metadata: data.metadata, lastUpdated: data.lastUpdated }; });
+            res.status(200).send({ status: 'success', summary: { source: 'firestore_computation_schemas', totalComputations: snapshot.size, schemasAvailable: snapshot.size, schemasFailed: 0, lastUpdated: Math.max(...Object.values(manifest).map(m =>  m.lastUpdated ? m.lastUpdated.toMillis() : 0 )) }, manifest: manifest });
         } catch (error) {
             logger.log('ERROR', 'API /manifest handler failed.', { errorMessage: error.message, stack: error.stack });
-            res.status(500).send({ status: 'error', message: 'An internal error occurred.' });
-        }
-    };
+            res.status(500).send({ status: 'error', message: 'An internal error occurred.' }); } };
 };
-// --- END NEW HANDLER ---
 
 
-module.exports = {
-    validateRequest,
-    buildCalculationMap,
-    fetchUnifiedData,
-    createApiHandler,
-    getComputationStructure,
-    getDynamicSchema,
-    createManifestHandler // <-- EXPORT NEW HANDLER
-};
+module.exports = { validateRequest, buildCalculationMap, fetchUnifiedData, createApiHandler, getComputationStructure, getDynamicSchema, createManifestHandler  };