bulltrackers-module 1.0.128 → 1.0.130

package/functions/computation-system/helpers/orchestration_helpers.js

@@ -12,15 +12,25 @@ function checkRootDependencies(calcManifest, rootDataStatus) { if (!calcManifest
 }
 
 /** Stage 3: Check root data availability for a date */
-async function checkRootDataAvailability(dateStr, config, { logger, ...deps }) {
+// --- START FIX ---
+// The signature is changed from '{ logger, ...deps }' to 'dependencies'
+// to ensure the full object is passed down.
+async function checkRootDataAvailability(dateStr, config, dependencies) {
+    const { logger } = dependencies; // Destructure logger for local use
     logger.log('INFO', `[PassRunner] Checking root data for ${dateStr}...`);
     try {
-        const [portfolioRefs, insightsData, socialData, historyRefs] = await Promise.all([ getPortfolioPartRefs(config, deps, dateStr), loadDailyInsights(config, deps, dateStr), loadDailySocialPostInsights(config, deps, dateStr), getHistoryPartRefs(config, deps, dateStr) ]);
+        const [portfolioRefs, insightsData, socialData, historyRefs] = await Promise.all([
+            getPortfolioPartRefs(config, dependencies, dateStr),        // Pass full 'dependencies'
+            loadDailyInsights(config, dependencies, dateStr),         // Pass full 'dependencies'
+            loadDailySocialPostInsights(config, dependencies, dateStr), // Pass full 'dependencies'
+            getHistoryPartRefs(config, dependencies, dateStr)           // Pass full 'dependencies'
+        ]);
         const hasPortfolio = !!(portfolioRefs?.length), hasInsights = !!insightsData, hasSocial = !!socialData, hasHistory = !!(historyRefs?.length);
         if (!(hasPortfolio||hasInsights||hasSocial||hasHistory)) { logger.log('WARN', `[PassRunner] No root data for ${dateStr}.`); return null; }
         return { portfolioRefs: portfolioRefs||[], insightsData: insightsData||null, socialData: socialData||null, historyRefs: historyRefs||[], status: { hasPortfolio, hasInsights, hasSocial, hasHistory } };
     } catch (err) { logger.log('ERROR', `[PassRunner] Error checking data for ${dateStr}`, { errorMessage: err.message }); return null; }
 }
+// --- END FIX ---
 
 /** Stage 4: Fetch computed dependencies from Firestore */
 async function fetchDependenciesForPass(dateStr, calcsInPass, fullManifest, config, { db, logger }) {
@@ -85,4 +95,4 @@ async function runMetaComputationPass(date, calcs, passName, config, deps, fetch
     logger.log(success===calcs.length?'SUCCESS':'WARN', `[${passName}] Completed ${dStr}. Success: ${success}/${calcs.length}`);
 }
 
-module.exports = { groupByPass, checkRootDataAvailability, fetchDependenciesForPass, filterCalculations, runStandardComputationPass, runMetaComputationPass };
+module.exports = { groupByPass, checkRootDataAvailability, fetchDependenciesForPass, filterCalculations, runStandardComputationPass, runMetaComputationPass };

package/functions/computation-system/utils/data_loader.js

@@ -28,11 +28,22 @@ async function getPortfolioPartRefs(config, deps, dateString) {
         const blockDocRefs = await withRetry(() => blockDocsQuery.listDocuments(), `listDocuments(${collectionName})`);
         if (!blockDocRefs.length) { logger.log('WARN', `No block documents in ${collectionName}`); continue; }
 
-        for (const blockDocRef of blockDocRefs) {
+        // --- START MODIFICATION ---
+        // Run all "listDocuments" calls in parallel instead of a sequential loop
+        const partsPromises = blockDocRefs.map(blockDocRef => {
             const partsCollectionRef = blockDocRef.collection(config.snapshotsSubcollection).doc(dateString).collection(config.partsSubcollection);
-            const partDocs = await withRetry(() => partsCollectionRef.listDocuments(), `listDocuments(${partsCollectionRef.path})`);
+            // Each call is individually retried
+            return withRetry(() => partsCollectionRef.listDocuments(), `listDocuments(${partsCollectionRef.path})`);
+        });
+
+        // Wait for all parallel queries to finish
+        const partDocArrays = await Promise.all(partsPromises);
+        
+        // Flatten the arrays of arrays into the final list
+        partDocArrays.forEach(partDocs => {
             allPartRefs.push(...partDocs);
-        }
+        });
+        // --- END MODIFICATION ---
     }
 
     logger.log('INFO', `Found ${allPartRefs.length} portfolio part refs for ${dateString}`);
@@ -132,11 +143,22 @@ async function getHistoryPartRefs(config, deps, dateString) {
         const blockDocRefs = await withRetry(() => blockDocsQuery.listDocuments(), `listDocuments(${collectionName})`);
         if (!blockDocRefs.length) { logger.log('WARN', `No block documents in ${collectionName}`); continue; }
 
-        for (const blockDocRef of blockDocRefs) {
+        // --- START MODIFICATION ---
+        // Run all "listDocuments" calls in parallel instead of a sequential loop
+        const partsPromises = blockDocRefs.map(blockDocRef => {
             const partsCollectionRef = blockDocRef.collection(config.snapshotsSubcollection).doc(dateString).collection(config.partsSubcollection);
-            const partDocs = await withRetry(() => partsCollectionRef.listDocuments(), `listDocuments(${partsCollectionRef.path})`);
+            // Each call is individually retried
+            return withRetry(() => partsCollectionRef.listDocuments(), `listDocuments(${partsCollectionRef.path})`);
+        });
+
+        // Wait for all parallel queries to finish
+        const partDocArrays = await Promise.all(partsPromises);
+        
+        // Flatten the arrays of arrays into the final list
+        partDocArrays.forEach(partDocs => {
             allPartRefs.push(...partDocs);
-        }
+        });
+        // --- END MODIFICATION ---
     }
 
     logger.log('INFO', `Found ${allPartRefs.length} history part refs for ${dateString}`);
@@ -150,4 +172,4 @@ module.exports = {
     loadDailyInsights,
     loadDailySocialPostInsights,
     getHistoryPartRefs,
-};
+};

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "bulltrackers-module",
-  "version": "1.0.128",
+  "version": "1.0.130",
   "description": "Helper Functions for Bulltrackers.",
   "main": "index.js",
   "files": [