bulltrackers-module 1.0.104 → 1.0.106

package/functions/task-engine/helpers/verify_helpers.js

@@ -1,163 +1,163 @@
-/**
- * @fileoverview Sub-pipe: pipe.taskEngine.handleVerify
- * REFACTORED: Now stateless and receives dependencies.
- * OPTIMIZED: Fetches all user portfolios in parallel to reduce function runtime.
- */
-const { FieldValue } = require('@google-cloud/firestore');
-
-/**
- * Internal helper to fetch and process a single user's portfolio.
- * This allows the main function to run these in parallel.
- * @param {object} user - The user object { cid, isBronze }
- * @param {object} dependencies - Contains proxyManager, headerManager
- * @param {object} config - The configuration object
- * @param {Set<number>} speculatorInstrumentSet - Pre-built Set of instrument IDs
- * @returns {Promise<object|null>} A result object for batching, or null on failure.
- */
-async function fetchAndVerifyUser(user, dependencies, config, speculatorInstrumentSet) {
-    const { logger, headerManager, proxyManager } = dependencies;
-    const userId = user.cid;
-    
-    const portfolioUrl = `${config.ETORO_API_PORTFOLIO_URL}?cid=${userId}`;
-    const selectedHeader = await headerManager.selectHeader();
-    if (!selectedHeader) return null; // Cannot fetch
-
-    let wasSuccess = false;
-    try {
-        const response = await proxyManager.fetch(portfolioUrl, { headers: selectedHeader.header });
-        if (!response.ok) {
-            wasSuccess = false;
-            return null; // API error or private user
-        }
-        wasSuccess = true;
-        
-        const portfolioData = await response.json();
-
-        // Process verification logic *within* the parallel task
-        if (config.userType === 'speculator') {
-            const matchingInstruments = portfolioData.AggregatedPositions
-                .map(p => p.InstrumentID)
-                .filter(id => speculatorInstrumentSet.has(id));
-
-            if (matchingInstruments.length > 0) {
-                logger.log('INFO', `[VERIFY] Speculator user ${userId} holds assets: ${matchingInstruments.join(', ')}`);
-                // Return data needed for the speculator batch update
-                return {
-                    type: 'speculator',
-                    userId: userId,
-                    isBronze: user.isBronze,
-                    updateData: {
-                        instruments: matchingInstruments,
-                        lastVerified: new Date(),
-                        lastHeldSpeculatorAsset: new Date()
-                    }
-                };
-            } else {
-                 logger.log('INFO', `[VERIFY] Speculator user ${userId} does not hold any speculator assets.`);
-                 return null; // Valid fetch, but failed verification
-            }
-        } else { // Normal user verification
-            // Return data needed for the normal user batch update
-            return {
-                type: 'normal',
-                userId: userId,
-                isBronze: user.isBronze,
-                updateData: {
-                    lastVerified: new Date()
-                }
-            };
-        }
-    } catch (error) {
-        logger.log('WARN', `[VERIFY] Error processing user ${userId}`, { errorMessage: error.message });
-        return null;
-    } finally {
-        if (selectedHeader) headerManager.updatePerformance(selectedHeader.id, wasSuccess);
-    }
-}
-
-
-/**
- * Sub-pipe: pipe.taskEngine.handleVerify
- * @param {object} task The Pub/Sub task payload.
- * @param {string} taskId A unique ID for logging.
- * @param {object} dependencies - Contains db, pubsub, logger, headerManager, proxyManager, batchManager.
- * @param {object} config The configuration object.
- */
-async function handleVerify(task, taskId, dependencies, config) {
-    const { logger, db } = dependencies;
-    const { users, blockId, instrument, userType } = task;
-    
-    // Use db from dependencies
-    const batch = db.batch();
-    let validUserCount = 0;
-    const speculatorUpdates = {};
-    const normalUserUpdates = {};
-    const bronzeStateUpdates = {}; // This can be one object
-
-    const speculatorInstrumentSet = new Set(config.SPECULATOR_INSTRUMENTS_ARRAY);
-    
-    // --- OPTIMIZATION: Run all user fetches in parallel ---
-    const verificationPromises = users.map(user => 
-        fetchAndVerifyUser(
-            user, 
-            dependencies, 
-            { ...config, userType: userType }, // Pass userType into the helper config
-            speculatorInstrumentSet
-        )
-    );
-
-    const results = await Promise.allSettled(verificationPromises);
-    // --- END OPTIMIZATION ---
-
-    // Process results (this is fast, no I/O)
-    results.forEach(result => {
-        if (result.status === 'rejected' || !result.value) {
-            // Log rejection reason if needed: result.reason
-            return;
-        }
-
-        const data = result.value;
-        
-        if (data.type === 'speculator') {
-            speculatorUpdates[`users.${data.userId}`] = data.updateData;
-            bronzeStateUpdates[data.userId] = data.isBronze;
-            validUserCount++;
-        } else if (data.type === 'normal') {
-            normalUserUpdates[`users.${data.userId}`] = data.updateData;
-            bronzeStateUpdates[data.userId] = data.isBronze;
-            validUserCount++;
-        }
-    });
-
-
-    if (Object.keys(speculatorUpdates).length > 0 || Object.keys(normalUserUpdates).length > 0) {
-        if (userType === 'speculator') {
-            const speculatorBlockRef = db.collection(config.FIRESTORE_COLLECTION_SPECULATOR_BLOCKS).doc(String(blockId));
-            batch.set(speculatorBlockRef, speculatorUpdates, { merge: true });
-            const bronzeStateRef = db.collection(config.FIRESTORE_COLLECTION_BRONZE_SPECULATORS).doc(String(blockId));
-            batch.set(bronzeStateRef, bronzeStateUpdates, {merge: true});
-
-        } else {
-            const normalBlockRef = db.collection(config.FIRESTORE_COLLECTION_NORMAL_PORTFOLIOS).doc(String(blockId));
-            batch.set(normalBlockRef, normalUserUpdates, { merge: true });
-            const bronzeStateRef = db.collection(config.FIRESTORE_COLLECTION_BRONZE_NORMAL).doc(String(blockId));
-            batch.set(bronzeStateRef, bronzeStateUpdates, {merge: true});
-        }
-        
-        if (validUserCount > 0) {
-            const blockCountsRef = db.doc(userType === 'speculator' 
-                ? config.FIRESTORE_DOC_SPECULATOR_BLOCK_COUNTS 
-                : config.FIRESTORE_DOC_BLOCK_COUNTS);
-            
-            const incrementField = userType === 'speculator' ? `counts.${instrument}_${blockId}` : `counts.${blockId}`;
-            batch.set(blockCountsRef, { [incrementField]: FieldValue.increment(validUserCount) }, { merge: true });
-        }
-    }
-    
-    await batch.commit();
-    if(validUserCount > 0) {
-        logger.log('INFO', `[VERIFY] Verified and stored ${validUserCount} new ${userType} users.`);
-    }
-}
-
+/**
+ * @fileoverview Sub-pipe: pipe.taskEngine.handleVerify
+ * REFACTORED: Now stateless and receives dependencies.
+ * OPTIMIZED: Fetches all user portfolios in parallel to reduce function runtime.
+ */
+const { FieldValue } = require('@google-cloud/firestore');
+
+/**
+ * Internal helper to fetch and process a single user's portfolio.
+ * This allows the main function to run these in parallel.
+ * @param {object} user - The user object { cid, isBronze }
+ * @param {object} dependencies - Contains proxyManager, headerManager
+ * @param {object} config - The configuration object
+ * @param {Set<number>} speculatorInstrumentSet - Pre-built Set of instrument IDs
+ * @returns {Promise<object|null>} A result object for batching, or null on failure.
+ */
+async function fetchAndVerifyUser(user, dependencies, config, speculatorInstrumentSet) {
+    const { logger, headerManager, proxyManager } = dependencies;
+    const userId = user.cid;
+    
+    const portfolioUrl = `${config.ETORO_API_PORTFOLIO_URL}?cid=${userId}`;
+    const selectedHeader = await headerManager.selectHeader();
+    if (!selectedHeader) return null; // Cannot fetch
+
+    let wasSuccess = false;
+    try {
+        const response = await proxyManager.fetch(portfolioUrl, { headers: selectedHeader.header });
+        if (!response.ok) {
+            wasSuccess = false;
+            return null; // API error or private user
+        }
+        wasSuccess = true;
+        
+        const portfolioData = await response.json();
+
+        // Process verification logic *within* the parallel task
+        if (config.userType === 'speculator') {
+            const matchingInstruments = portfolioData.AggregatedPositions
+                .map(p => p.InstrumentID)
+                .filter(id => speculatorInstrumentSet.has(id));
+
+            if (matchingInstruments.length > 0) {
+                logger.log('INFO', `[VERIFY] Speculator user ${userId} holds assets: ${matchingInstruments.join(', ')}`);
+                // Return data needed for the speculator batch update
+                return {
+                    type: 'speculator',
+                    userId: userId,
+                    isBronze: user.isBronze,
+                    updateData: {
+                        instruments: matchingInstruments,
+                        lastVerified: new Date(),
+                        lastHeldSpeculatorAsset: new Date()
+                    }
+                };
+            } else {
+                 logger.log('INFO', `[VERIFY] Speculator user ${userId} does not hold any speculator assets.`);
+                 return null; // Valid fetch, but failed verification
+            }
+        } else { // Normal user verification
+            // Return data needed for the normal user batch update
+            return {
+                type: 'normal',
+                userId: userId,
+                isBronze: user.isBronze,
+                updateData: {
+                    lastVerified: new Date()
+                }
+            };
+        }
+    } catch (error) {
+        logger.log('WARN', `[VERIFY] Error processing user ${userId}`, { errorMessage: error.message });
+        return null;
+    } finally {
+        if (selectedHeader) headerManager.updatePerformance(selectedHeader.id, wasSuccess);
+    }
+}
+
+
+/**
+ * Sub-pipe: pipe.taskEngine.handleVerify
+ * @param {object} task The Pub/Sub task payload.
+ * @param {string} taskId A unique ID for logging.
+ * @param {object} dependencies - Contains db, pubsub, logger, headerManager, proxyManager, batchManager.
+ * @param {object} config The configuration object.
+ */
+async function handleVerify(task, taskId, dependencies, config) {
+    const { logger, db } = dependencies;
+    const { users, blockId, instrument, userType } = task;
+    
+    // Use db from dependencies
+    const batch = db.batch();
+    let validUserCount = 0;
+    const speculatorUpdates = {};
+    const normalUserUpdates = {};
+    const bronzeStateUpdates = {}; // This can be one object
+
+    const speculatorInstrumentSet = new Set(config.SPECULATOR_INSTRUMENTS_ARRAY);
+    
+    // --- OPTIMIZATION: Run all user fetches in parallel ---
+    const verificationPromises = users.map(user => 
+        fetchAndVerifyUser(
+            user, 
+            dependencies, 
+            { ...config, userType: userType }, // Pass userType into the helper config
+            speculatorInstrumentSet
+        )
+    );
+
+    const results = await Promise.allSettled(verificationPromises);
+    // --- END OPTIMIZATION ---
+
+    // Process results (this is fast, no I/O)
+    results.forEach(result => {
+        if (result.status === 'rejected' || !result.value) {
+            // Log rejection reason if needed: result.reason
+            return;
+        }
+
+        const data = result.value;
+        
+        if (data.type === 'speculator') {
+            speculatorUpdates[`users.${data.userId}`] = data.updateData;
+            bronzeStateUpdates[data.userId] = data.isBronze;
+            validUserCount++;
+        } else if (data.type === 'normal') {
+            normalUserUpdates[`users.${data.userId}`] = data.updateData;
+            bronzeStateUpdates[data.userId] = data.isBronze;
+            validUserCount++;
+        }
+    });
+
+
+    if (Object.keys(speculatorUpdates).length > 0 || Object.keys(normalUserUpdates).length > 0) {
+        if (userType === 'speculator') {
+            const speculatorBlockRef = db.collection(config.FIRESTORE_COLLECTION_SPECULATOR_BLOCKS).doc(String(blockId));
+            batch.set(speculatorBlockRef, speculatorUpdates, { merge: true });
+            const bronzeStateRef = db.collection(config.FIRESTORE_COLLECTION_BRONZE_SPECULATORS).doc(String(blockId));
+            batch.set(bronzeStateRef, bronzeStateUpdates, {merge: true});
+
+        } else {
+            const normalBlockRef = db.collection(config.FIRESTORE_COLLECTION_NORMAL_PORTFOLIOS).doc(String(blockId));
+            batch.set(normalBlockRef, normalUserUpdates, { merge: true });
+            const bronzeStateRef = db.collection(config.FIRESTORE_COLLECTION_BRONZE_NORMAL).doc(String(blockId));
+            batch.set(bronzeStateRef, bronzeStateUpdates, {merge: true});
+        }
+        
+        if (validUserCount > 0) {
+            const blockCountsRef = db.doc(userType === 'speculator' 
+                ? config.FIRESTORE_DOC_SPECULATOR_BLOCK_COUNTS 
+                : config.FIRESTORE_DOC_BLOCK_COUNTS);
+            
+            const incrementField = userType === 'speculator' ? `counts.${instrument}_${blockId}` : `counts.${blockId}`;
+            batch.set(blockCountsRef, { [incrementField]: FieldValue.increment(validUserCount) }, { merge: true });
+        }
+    }
+    
+    await batch.commit();
+    if(validUserCount > 0) {
+        logger.log('INFO', `[VERIFY] Verified and stored ${validUserCount} new ${userType} users.`);
+    }
+}
+
 module.exports = { handleVerify };