bullmq 5.56.8 → 5.56.9

package/dist/esm/commands/moveStalledJobsToWait-8.lua

@@ -25,6 +25,7 @@ local rcall = redis.call
 --- @include "includes/addJobInTargetList"
 --- @include "includes/batches"
 --- @include "includes/getTargetQueueList"
+--- @include "includes/moveJobToWait"
 --- @include "includes/trimEvents"
 
 local stalledKey = KEYS[1]
@@ -73,20 +74,11 @@ if (#stalling > 0) then
                     -- If this job has been stalled too many times, such as if it crashes the worker, then fail it.
                     local stalledCount = rcall("HINCRBY", jobKey, "stc", 1)
                     if stalledCount > maxStalledJobCount then
-                        local jobAttributes = rcall("HMGET", jobKey, "opts", "parent")
-                        local rawOpts = jobAttributes[1]
-                        local rawParentData = jobAttributes[2]
-                        local opts = cjson.decode(rawOpts)
-
                         local failedReason = "job stalled more than allowable limit"
                         rcall("HSET", jobKey, "defa", failedReason)
                     end
-                    local target, isPausedOrMaxed = getTargetQueueList(metaKey, activeKey, waitKey, pausedKey)
-
-                    -- Move the job back to the wait queue, to immediately be picked up by a waiting worker.
-                    addJobInTargetList(target, markerKey, "RPUSH", isPausedOrMaxed, jobId)
-
-                    rcall("XADD", eventStreamKey, "*", "event", "waiting", "jobId", jobId, 'prev', 'active')
+                    moveJobToWait(metaKey, activeKey, waitKey, pausedKey, markerKey, eventStreamKey, jobId,
+                        "RPUSH")
 
                     -- Emit the stalled event
                     rcall("XADD", eventStreamKey, "*", "event", "stalled", "jobId", jobId)

package/dist/esm/commands/{moveToWaitingChildren-8.lua → moveToWaitingChildren-7.lua}

@@ -8,8 +8,7 @@
     KEYS[4] job dependencies key
     KEYS[5] job unsuccessful key
     KEYS[6] stalled key
-    KEYS[7] failed key
-    KEYS[8] events key
+    KEYS[7] events key
 
     ARGV[1] token
     ARGV[2] child key
@@ -23,6 +22,7 @@
    -1 - Missing job.
    -2 - Missing lock
    -3 - Job not in active set
+   -9 - Job has failed children
 ]]
 local rcall = redis.call
 local activeKey = KEYS[1]
@@ -31,15 +31,12 @@ local jobKey = KEYS[3]
 local jobDependenciesKey = KEYS[4]
 local jobUnsuccessfulKey = KEYS[5]
 local stalledKey = KEYS[6]
-local failedKey = KEYS[7]
+local eventStreamKey = KEYS[7]
 local token = ARGV[1]
 local timestamp = ARGV[3]
 local jobId = ARGV[4]
 
 --- Includes
---- @include "includes/moveChildFromDependenciesIfNeeded"
---- @include "includes/removeDeduplicationKeyIfNeededOnFinalization"
---- @include "includes/removeJobsOnFail"
 --- @include "includes/removeLock"
 
 local function removeJobFromActive(activeKey, stalledKey, jobKey, jobId,
@@ -51,15 +48,15 @@ local function removeJobFromActive(activeKey, stalledKey, jobKey, jobId,
 
   local numRemovedElements = rcall("LREM", activeKey, -1, jobId)
 
-  if(numRemovedElements < 1) then
+  if numRemovedElements < 1 then
     return -3
   end
 
   return 0
 end
 
-local function moveToWaitingChildren(activeKey, waitingChildrenKey, stalledKey, jobKey, jobId,
-    timestamp, token)
+local function moveToWaitingChildren(activeKey, waitingChildrenKey, stalledKey, eventStreamKey,
+    jobKey, jobId, timestamp, token)
   local errorCode = removeJobFromActive(activeKey, stalledKey, jobKey, jobId, token)
   if errorCode < 0 then
     return errorCode
@@ -68,49 +65,26 @@ local function moveToWaitingChildren(activeKey, waitingChildrenKey, stalledKey,
   local score = tonumber(timestamp)
 
   rcall("ZADD", waitingChildrenKey, score, jobId)
+  rcall("XADD", eventStreamKey, "*", "event", "waiting-children", "jobId", jobId, 'prev', 'active')
 
   return 0
 end
 
 if rcall("EXISTS", jobKey) == 1 then
   if rcall("ZCARD", jobUnsuccessfulKey) ~= 0 then
-    local errorCode = removeJobFromActive(activeKey, stalledKey, jobKey, jobId, token)
-    if errorCode < 0 then
-      return errorCode
-    end
-
-    -- TODO: refactor this logic in an include later
-    local jobAttributes = rcall("HMGET", jobKey, "parent", "deid", "opts")
-
-    removeDeduplicationKeyIfNeededOnFinalization(ARGV[5], jobAttributes[2], jobId)
-  
-    local failedReason = "children are failed"
-    rcall("ZADD", failedKey, timestamp, jobId)
-    rcall("HSET", jobKey, "finishedOn", timestamp)
-    rcall("XADD", KEYS[8], "*", "event", "failed", "jobId", jobId, "failedReason",
-      failedReason, "prev", "active")
-
-    local rawParentData = jobAttributes[1]
-    local rawOpts = jobAttributes[3]
-    local opts = cjson.decode(rawOpts)
-
-    moveChildFromDependenciesIfNeeded(rawParentData, jobKey, failedReason, timestamp)
-
-    removeJobsOnFail(ARGV[5], failedKey, jobId, opts, timestamp)
-
-    return 0
+    return -9
   else
     if ARGV[2] ~= "" then
       if rcall("SISMEMBER", jobDependenciesKey, ARGV[2]) ~= 0 then
-        return moveToWaitingChildren(activeKey, waitingChildrenKey, stalledKey, jobKey, jobId,
-          timestamp, token)
+        return moveToWaitingChildren(activeKey, waitingChildrenKey, stalledKey, eventStreamKey,
+          jobKey, jobId, timestamp, token)
       end
   
       return 1
     else
       if rcall("SCARD", jobDependenciesKey) ~= 0 then 
-        return moveToWaitingChildren(activeKey, waitingChildrenKey, stalledKey, jobKey, jobId,
-          timestamp, token)
+        return moveToWaitingChildren(activeKey, waitingChildrenKey, stalledKey, eventStreamKey,
+          jobKey, jobId, timestamp, token)
       end
   
       return 1

package/dist/esm/enums/error-code.d.ts

@@ -7,5 +7,5 @@ export declare enum ErrorCode {
     JobLockMismatch = -6,
     ParentJobCannotBeReplaced = -7,
     JobBelongsToJobScheduler = -8,
-    JobFailedChildren = -9
+    JobHasFailedChildren = -9
 }

package/dist/esm/enums/error-code.js

@@ -8,6 +8,6 @@ export var ErrorCode;
     ErrorCode[ErrorCode["JobLockMismatch"] = -6] = "JobLockMismatch";
     ErrorCode[ErrorCode["ParentJobCannotBeReplaced"] = -7] = "ParentJobCannotBeReplaced";
     ErrorCode[ErrorCode["JobBelongsToJobScheduler"] = -8] = "JobBelongsToJobScheduler";
-    ErrorCode[ErrorCode["JobFailedChildren"] = -9] = "JobFailedChildren";
+    ErrorCode[ErrorCode["JobHasFailedChildren"] = -9] = "JobHasFailedChildren";
 })(ErrorCode || (ErrorCode = {}));
 //# sourceMappingURL=error-code.js.map

package/dist/esm/enums/error-code.js.map

@@ -1 +1 @@
-{"version":3,"file":"error-code.js","sourceRoot":"","sources":["../../../src/enums/error-code.ts"],"names":[],"mappings":"AAAA,MAAM,CAAN,IAAY,SAUX;AAVD,WAAY,SAAS;IACnB,wDAAgB,CAAA;IAChB,gEAAoB,CAAA;IACpB,4DAAkB,CAAA;IAClB,sEAAuB,CAAA;IACvB,oEAAsB,CAAA;IACtB,gEAAoB,CAAA;IACpB,oFAA8B,CAAA;IAC9B,kFAA6B,CAAA;IAC7B,oEAAsB,CAAA;AACxB,CAAC,EAVW,SAAS,KAAT,SAAS,QAUpB"}
+{"version":3,"file":"error-code.js","sourceRoot":"","sources":["../../../src/enums/error-code.ts"],"names":[],"mappings":"AAAA,MAAM,CAAN,IAAY,SAUX;AAVD,WAAY,SAAS;IACnB,wDAAgB,CAAA;IAChB,gEAAoB,CAAA;IACpB,4DAAkB,CAAA;IAClB,sEAAuB,CAAA;IACvB,oEAAsB,CAAA;IACtB,gEAAoB,CAAA;IACpB,oFAA8B,CAAA;IAC9B,kFAA6B,CAAA;IAC7B,0EAAyB,CAAA;AAC3B,CAAC,EAVW,SAAS,KAAT,SAAS,QAUpB"}

package/dist/esm/scripts/index.d.ts

@@ -28,7 +28,7 @@ export * from './moveStalledJobsToWait-8';
 export * from './moveToActive-11';
 export * from './moveToDelayed-8';
 export * from './moveToFinished-14';
-export * from './moveToWaitingChildren-8';
+export * from './moveToWaitingChildren-7';
 export * from './obliterate-2';
 export * from './paginate-1';
 export * from './pause-7';

package/dist/esm/scripts/index.js

@@ -28,7 +28,7 @@ export * from './moveStalledJobsToWait-8';
 export * from './moveToActive-11';
 export * from './moveToDelayed-8';
 export * from './moveToFinished-14';
-export * from './moveToWaitingChildren-8';
+export * from './moveToWaitingChildren-7';
 export * from './obliterate-2';
 export * from './paginate-1';
 export * from './pause-7';

package/dist/esm/scripts/moveStalledJobsToWait-8.js

@@ -70,6 +70,16 @@ local function getTargetQueueList(queueMetaKey, activeKey, waitKey, pausedKey)
   end
   return waitKey, false
 end
+--[[
+  Function to move job to wait to be picked up by a waiting worker.
+]]
+-- Includes
+local function moveJobToWait(metaKey, activeKey, waitKey, pausedKey, markerKey, eventStreamKey,
+  jobId, pushCmd)
+  local target, isPausedOrMaxed = getTargetQueueList(metaKey, activeKey, waitKey, pausedKey)
+  addJobInTargetList(target, markerKey, pushCmd, isPausedOrMaxed, jobId)
+  rcall("XADD", eventStreamKey, "*", "event", "waiting", "jobId", jobId, 'prev', 'active')
+end
 --[[
   Function to trim events, default 10000.
 ]]
@@ -132,17 +142,11 @@ if (#stalling > 0) then
                     -- If this job has been stalled too many times, such as if it crashes the worker, then fail it.
                     local stalledCount = rcall("HINCRBY", jobKey, "stc", 1)
                     if stalledCount > maxStalledJobCount then
-                        local jobAttributes = rcall("HMGET", jobKey, "opts", "parent")
-                        local rawOpts = jobAttributes[1]
-                        local rawParentData = jobAttributes[2]
-                        local opts = cjson.decode(rawOpts)
                         local failedReason = "job stalled more than allowable limit"
                         rcall("HSET", jobKey, "defa", failedReason)
                     end
-                    local target, isPausedOrMaxed = getTargetQueueList(metaKey, activeKey, waitKey, pausedKey)
-                    -- Move the job back to the wait queue, to immediately be picked up by a waiting worker.
-                    addJobInTargetList(target, markerKey, "RPUSH", isPausedOrMaxed, jobId)
-                    rcall("XADD", eventStreamKey, "*", "event", "waiting", "jobId", jobId, 'prev', 'active')
+                    moveJobToWait(metaKey, activeKey, waitKey, pausedKey, markerKey, eventStreamKey, jobId,
+                        "RPUSH")
                     -- Emit the stalled event
                     rcall("XADD", eventStreamKey, "*", "event", "stalled", "jobId", jobId)
                     table.insert(stalled, jobId)

package/dist/esm/scripts/moveStalledJobsToWait-8.js.map

@@ -1 +1 @@
-{"version":3,"file":"moveStalledJobsToWait-8.js","sourceRoot":"","sources":["../../../src/scripts/moveStalledJobsToWait-8.ts"],"names":[],"mappings":"AAAA,MAAM,OAAO,GAAG;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;CAiKf,CAAC;AACF,MAAM,CAAC,MAAM,qBAAqB,GAAG;IACnC,IAAI,EAAE,uBAAuB;IAC7B,OAAO;IACP,IAAI,EAAE,CAAC;CACR,CAAC"}
+{"version":3,"file":"moveStalledJobsToWait-8.js","sourceRoot":"","sources":["../../../src/scripts/moveStalledJobsToWait-8.ts"],"names":[],"mappings":"AAAA,MAAM,OAAO,GAAG;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;CAqKf,CAAC;AACF,MAAM,CAAC,MAAM,qBAAqB,GAAG;IACnC,IAAI,EAAE,uBAAuB;IAC7B,OAAO;IACP,IAAI,EAAE,CAAC;CACR,CAAC"}

package/dist/esm/scripts/moveToWaitingChildren-7.js

@@ -0,0 +1,104 @@
+const content = `--[[
+  Moves job from active to waiting children set.
+  Input:
+    KEYS[1] active key
+    KEYS[2] wait-children key
+    KEYS[3] job key
+    KEYS[4] job dependencies key
+    KEYS[5] job unsuccessful key
+    KEYS[6] stalled key
+    KEYS[7] events key
+    ARGV[1] token
+    ARGV[2] child key
+    ARGV[3] timestamp
+    ARGV[4] jobId
+    ARGV[5] prefix
+  Output:
+    0 - OK
+    1 - There are not pending dependencies.
+   -1 - Missing job.
+   -2 - Missing lock
+   -3 - Job not in active set
+   -9 - Job has failed children
+]]
+local rcall = redis.call
+local activeKey = KEYS[1]
+local waitingChildrenKey = KEYS[2]
+local jobKey = KEYS[3]
+local jobDependenciesKey = KEYS[4]
+local jobUnsuccessfulKey = KEYS[5]
+local stalledKey = KEYS[6]
+local eventStreamKey = KEYS[7]
+local token = ARGV[1]
+local timestamp = ARGV[3]
+local jobId = ARGV[4]
+--- Includes
+local function removeLock(jobKey, stalledKey, token, jobId)
+  if token ~= "0" then
+    local lockKey = jobKey .. ':lock'
+    local lockToken = rcall("GET", lockKey)
+    if lockToken == token then
+      rcall("DEL", lockKey)
+      rcall("SREM", stalledKey, jobId)
+    else
+      if lockToken then
+        -- Lock exists but token does not match
+        return -6
+      else
+        -- Lock is missing completely
+        return -2
+      end
+    end
+  end
+  return 0
+end
+local function removeJobFromActive(activeKey, stalledKey, jobKey, jobId,
+    token)
+  local errorCode = removeLock(jobKey, stalledKey, token, jobId)
+  if errorCode < 0 then
+    return errorCode
+  end
+  local numRemovedElements = rcall("LREM", activeKey, -1, jobId)
+  if numRemovedElements < 1 then
+    return -3
+  end
+  return 0
+end
+local function moveToWaitingChildren(activeKey, waitingChildrenKey, stalledKey, eventStreamKey,
+    jobKey, jobId, timestamp, token)
+  local errorCode = removeJobFromActive(activeKey, stalledKey, jobKey, jobId, token)
+  if errorCode < 0 then
+    return errorCode
+  end
+  local score = tonumber(timestamp)
+  rcall("ZADD", waitingChildrenKey, score, jobId)
+  rcall("XADD", eventStreamKey, "*", "event", "waiting-children", "jobId", jobId, 'prev', 'active')
+  return 0
+end
+if rcall("EXISTS", jobKey) == 1 then
+  if rcall("ZCARD", jobUnsuccessfulKey) ~= 0 then
+    return -9
+  else
+    if ARGV[2] ~= "" then
+      if rcall("SISMEMBER", jobDependenciesKey, ARGV[2]) ~= 0 then
+        return moveToWaitingChildren(activeKey, waitingChildrenKey, stalledKey, eventStreamKey,
+          jobKey, jobId, timestamp, token)
+      end
+      return 1
+    else
+      if rcall("SCARD", jobDependenciesKey) ~= 0 then 
+        return moveToWaitingChildren(activeKey, waitingChildrenKey, stalledKey, eventStreamKey,
+          jobKey, jobId, timestamp, token)
+      end
+      return 1
+    end    
+  end
+end
+return -1
+`;
+export const moveToWaitingChildren = {
+    name: 'moveToWaitingChildren',
+    content,
+    keys: 7,
+};
+//# sourceMappingURL=moveToWaitingChildren-7.js.map

package/dist/esm/scripts/moveToWaitingChildren-7.js.map

@@ -0,0 +1 @@
+{"version":3,"file":"moveToWaitingChildren-7.js","sourceRoot":"","sources":["../../../src/scripts/moveToWaitingChildren-7.ts"],"names":[],"mappings":"AAAA,MAAM,OAAO,GAAG;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;CAiGf,CAAC;AACF,MAAM,CAAC,MAAM,qBAAqB,GAAG;IACnC,IAAI,EAAE,uBAAuB;IAC7B,OAAO;IACP,IAAI,EAAE,CAAC;CACR,CAAC"}