buildanything 2.0.0 → 2.1.2

package/src/graph/types.ts

@@ -0,0 +1,432 @@
+// Slice 1 graph types. Source of truth: docs/graph/04-slice1-schema.md.
+// Confidence semantics inherit Graphify's vocabulary even though Slice 1 is
+// pure-deterministic (every edge is EXTRACTED). The field is preserved so
+// later slices that introduce LLM extraction can extend without migration.
+
+export type Confidence = "EXTRACTED" | "INFERRED" | "AMBIGUOUS";
+
+export type EntityType =
+  | "persona"
+  | "feature"
+  | "screen"
+  | "state"
+  | "transition"
+  | "business_rule"
+  | "failure_mode"
+  | "acceptance_criterion"
+  | "persona_constraint"
+  // Slice 2 additions. Source of truth: docs/graph/05-slice2-schema.md.
+  | "dna_axis"
+  | "brand_dna_guideline"
+  | "brand_reference"
+  | "component_manifest_entry"
+  | "component_slot"
+  | "design_doc_root"
+  // Slice 3 additions. Source of truth: docs/graph/07-slice3-schema.md.
+  | "token"
+  | "page_spec"
+  | "wireframe_section"
+  | "screen_state_slot"
+  | "screen_component_use"
+  | "key_copy"
+  // Slice 4 additions. Source of truth: docs/graph/09-slice4-schema.md.
+  | "architecture_module"
+  | "api_contract"
+  | "data_model"
+  | "task"
+  | "decision"
+  // Slice 5 additions. Source of truth: docs/graph/11-slice5-schema.md.
+  | "screenshot"
+  | "image_component_detection"
+  | "dogfood_finding"
+  | "brand_drift_observation";
+
+export type Relation =
+  | "has_screen"
+  | "has_state"
+  | "has_initial_state"
+  | "transitions_to"
+  | "triggered_by_transition"
+  | "has_rule"
+  | "has_failure_mode"
+  | "has_acceptance"
+  | "constrains"
+  | "applies_to_persona"
+  | "depends_on"
+  // Slice 2 additions. Source of truth: docs/graph/05-slice2-schema.md.
+  | "has_axis"
+  | "dna_governs"
+  | "forbids"
+  | "applies_to"
+  | "slot_filled_by"
+  | "manifest_uses_library"
+  | "references_axis"
+  // Slice 3 additions. Source of truth: docs/graph/07-slice3-schema.md.
+  | "has_page_spec"
+  | "has_section"
+  | "has_screen_state"
+  | "slot_used_on_screen"
+  | "screen_uses_token"
+  | "token_derived_from"
+  | "key_copy_on_screen"
+  // Slice 4 additions. Source of truth: docs/graph/09-slice4-schema.md.
+  | "module_has_contract"
+  | "module_has_data_model"
+  | "task_implements_feature"
+  | "task_touches_screen"
+  | "task_depends_on"
+  | "feature_provides_endpoint"
+  | "feature_consumes_endpoint"
+  | "decision_supersedes"
+  | "decision_relates_to"
+  | "decision_drove"
+  // Slice 5 additions. Source of truth: docs/graph/11-slice5-schema.md.
+  | "references_axis_image"
+  | "screenshot_depicts_screen"
+  | "screenshot_evidences_finding"
+  | "image_has_component_detection"
+  | "prod_drifts_from_reference_prod"
+  | "prod_drifts_from_reference_ref"
+  | "similar_to_image";
+
+export interface NodeBase {
+  id: string;
+  label: string;
+  entity_type: EntityType;
+  source_file: string;
+  source_location?: string; // "L42"
+  confidence: Confidence;
+}
+
+export interface PersonaNode extends NodeBase {
+  entity_type: "persona";
+  description: string;
+  role: string;
+  is_primary: boolean;
+  primary_jtbd: string;
+}
+
+export interface FeatureNode extends NodeBase {
+  entity_type: "feature";
+  name: string;
+  kebab_anchor: string;
+}
+
+export interface ScreenNode extends NodeBase {
+  entity_type: "screen";
+  description: string;
+  feature_ids: string[];
+  count?: number; // populated when screen inventory says "Checkout (3 screens)" without naming all 3
+}
+
+export interface StateNode extends NodeBase {
+  entity_type: "state";
+  feature_id: string;
+  is_initial: boolean;
+  meta_state: boolean;
+}
+
+export interface TransitionNode extends NodeBase {
+  entity_type: "transition";
+  from_state_id: string;
+  to_state_id: string;
+  trigger: string;
+  preconditions: string;
+  side_effects: string;
+}
+
+export interface BusinessRuleNode extends NodeBase {
+  entity_type: "business_rule";
+  feature_id: string;
+  text: string;
+  value: string | null;
+  decision_needed: boolean;
+}
+
+export interface FailureModeNode extends NodeBase {
+  entity_type: "failure_mode";
+  feature_id: string;
+  trigger: string;
+  user_sees: string;
+  user_can: string;
+  system_does: string;
+}
+
+export interface AcceptanceCriterionNode extends NodeBase {
+  entity_type: "acceptance_criterion";
+  feature_id: string;
+  text: string;
+  verified: boolean;
+}
+
+export interface PersonaConstraintNode extends NodeBase {
+  entity_type: "persona_constraint";
+  feature_id: string;
+  persona_id: string;
+  constraint_text: string;
+  cited_source: string;
+}
+
+// Slice 2 additions. Source of truth: docs/graph/05-slice2-schema.md.
+
+export interface DesignDocRootNode extends NodeBase {
+  entity_type: "design_doc_root";
+  name: string;
+  description: string;
+  locked_at: string; // ISO-8601 from `### Locked At`
+  lint_status?: "pass" | "warn" | "fail" | null;
+  pass_complete: { pass1: boolean; pass2: boolean };
+}
+
+export interface DnaAxisNode extends NodeBase {
+  entity_type: "dna_axis";
+  axis_name: "scope" | "density" | "character" | "material" | "motion" | "type" | "copy";
+  value: string;
+  rationale: string;
+}
+
+export interface BrandDnaGuidelineNode extends NodeBase {
+  entity_type: "brand_dna_guideline";
+  polarity: "do" | "dont";
+  text: string;
+  axis_scope: string | null;
+}
+
+export interface BrandReferenceNode extends NodeBase {
+  entity_type: "brand_reference";
+  url_or_path: string;
+  exemplifies_axes: string[];
+}
+
+export interface ComponentManifestEntryNode extends NodeBase {
+  entity_type: "component_manifest_entry";
+  slot: string;
+  library: string;
+  variant: string;
+  source_ref: string | null;
+  hard_gate: boolean;
+  fallback_plan?: string;
+}
+
+export interface ComponentSlotNode extends NodeBase {
+  entity_type: "component_slot";
+  slot_name: string;
+}
+
+// Slice 3 additions. Source of truth: docs/graph/07-slice3-schema.md.
+
+export interface TokenNode extends NodeBase {
+  entity_type: "token";
+  name: string;
+  value: string;
+  layer: "color" | "typography" | "spacing" | "shape" | "elevation" | "motion" | "type" | "component";
+  axis_provenance: "scope" | "density" | "character" | "material" | "motion" | "type" | "copy" | null;
+  category: string | null;
+}
+
+export interface PageSpecNode extends NodeBase {
+  entity_type: "page_spec";
+  screen_id: string;
+  wireframe_text: string;
+  content_hierarchy: string[];
+  route: string | null;
+}
+
+export interface WireframeSectionNode extends NodeBase {
+  entity_type: "wireframe_section";
+  section_name: string;
+  parent_page_spec_id: string;
+  order: number;
+  prose: string;
+}
+
+export interface ScreenStateSlotNode extends NodeBase {
+  entity_type: "screen_state_slot";
+  screen_id: string;
+  state_id: string;
+  appearance_text: string;
+}
+
+export interface ScreenComponentUseNode extends NodeBase {
+  entity_type: "screen_component_use";
+  screen_id: string;
+  slot: string;
+  position_in_wireframe: string;
+  prop_overrides: string;
+}
+
+export interface KeyCopyNode extends NodeBase {
+  entity_type: "key_copy";
+  screen_id: string;
+  text: string;
+  placement: string;
+}
+
+// Slice 4 additions. Source of truth: docs/graph/09-slice4-schema.md.
+
+export interface ArchitectureModuleNode extends NodeBase {
+  entity_type: "architecture_module";
+  name: string;
+  description: string;
+  responsibilities: string[];
+  tech_stack: string[];
+}
+
+export interface ApiContractNode extends NodeBase {
+  entity_type: "api_contract";
+  endpoint: string; // e.g. "POST /api/orders"
+  module_id: string; // FK
+  request_schema: string; // JSON-string blob
+  response_schema: string; // JSON-string blob
+  auth_required: boolean;
+  error_codes: string[];
+}
+
+export interface DataModelNode extends NodeBase {
+  entity_type: "data_model";
+  entity_name: string;
+  module_id: string;
+  fields: string[]; // "name:type" pairs
+  indexes: string[];
+}
+
+export interface TaskNode extends NodeBase {
+  entity_type: "task";
+  task_id: string; // e.g. "T-1"
+  title: string;
+  size: "S" | "M" | "L";
+  behavioral_test: string;
+  assigned_phase: string;
+  feature_id: string | null;
+  screen_ids: string[];
+  owns_files: string[];
+}
+
+export interface DecisionNode extends NodeBase {
+  entity_type: "decision";
+  decision_id: string;
+  summary: string;
+  decided_by: string; // verbatim from JSONL — could be "code-architect", "human", etc.
+  related_decision_id: string | null;
+  revisit_criterion: string | null;
+  status: "open" | "triggered" | "resolved";
+  phase: string;
+  step_id: string | null;
+  ref: string | null; // e.g. "architecture.md#backend/persistence" — anchor into source doc
+}
+
+// Slice 5 additions. Source of truth: docs/graph/11-slice5-schema.md.
+
+export interface ScreenshotNode extends NodeBase {
+  entity_type: "screenshot";
+  image_path: string;
+  image_class: "reference" | "brand_drift" | "dogfood";
+  caption: string;
+  perceptual_hash: string; // 64-bit dHash as 16-char hex
+  dominant_palette: string[]; // up to 5 hex colors
+  image_dimensions: string; // e.g. "1280x720"
+  dna_axis_tags: string[]; // axes this image exemplifies
+  linked_screen_id: string | null;
+  linked_finding_id: string | null;
+}
+
+export interface ImageComponentDetectionNode extends NodeBase {
+  entity_type: "image_component_detection";
+  screenshot_id: string;
+  component_label: string;
+  bounding_box: string | null;
+  // Vision-model detection probability (0-1). Renamed from `confidence` to avoid collision
+  // with NodeBase.confidence (EXTRACTED/INFERRED/AMBIGUOUS extraction-confidence vocabulary).
+  detection_confidence: number | null;
+}
+
+export interface DogfoodFindingNode extends NodeBase {
+  entity_type: "dogfood_finding";
+  finding_id: string;
+  severity: "critical" | "major" | "minor";
+  description: string;
+  screenshot_id: string;
+  affected_screen_id: string | null;
+}
+
+export interface BrandDriftObservationNode extends NodeBase {
+  entity_type: "brand_drift_observation";
+  observation_id: string;
+  prod_screenshot_id: string;
+  reference_screenshot_id: string;
+  axis: "scope" | "density" | "character" | "material" | "motion" | "type" | "copy";
+  score: number;
+  verdict: "drift" | "ok" | "needs-review";
+}
+
+export type GraphNode =
+  | PersonaNode
+  | FeatureNode
+  | ScreenNode
+  | StateNode
+  | TransitionNode
+  | BusinessRuleNode
+  | FailureModeNode
+  | AcceptanceCriterionNode
+  | PersonaConstraintNode
+  | DesignDocRootNode
+  | DnaAxisNode
+  | BrandDnaGuidelineNode
+  | BrandReferenceNode
+  | ComponentManifestEntryNode
+  | ComponentSlotNode
+  | TokenNode
+  | PageSpecNode
+  | WireframeSectionNode
+  | ScreenStateSlotNode
+  | ScreenComponentUseNode
+  | KeyCopyNode
+  | ArchitectureModuleNode
+  | ApiContractNode
+  | DataModelNode
+  | TaskNode
+  | DecisionNode
+  | ScreenshotNode
+  | ImageComponentDetectionNode
+  | DogfoodFindingNode
+  | BrandDriftObservationNode;
+
+export interface GraphEdge {
+  source: string;
+  target: string;
+  relation: Relation;
+  confidence: Confidence;
+  source_file: string;
+  source_location?: string;
+  produced_by_agent?: string; // forward-compat — Slice 1 sets "product-spec-writer"
+  produced_at_step?: string; // forward-compat — Slice 1 sets "1.6"
+  label?: string; // cross-feature rule text, e.g. "user must be authenticated"
+}
+
+export type Schema =
+  | "buildanything-slice-1"
+  | "buildanything-slice-2"
+  | "buildanything-slice-3"
+  | "buildanything-slice-4"
+  | "buildanything-slice-5";
+
+export interface GraphFragment {
+  version: 1;
+  schema: Schema;
+  source_file: string;
+  source_sha: string; // sha256 of product-spec.md content
+  produced_at: string; // ISO timestamp
+  nodes: GraphNode[];
+  edges: GraphEdge[];
+}
+
+export interface ExtractError {
+  line: number;
+  message: string;
+}
+
+export interface ExtractResult {
+  ok: boolean;
+  fragment?: GraphFragment;
+  errors: ExtractError[];
+}

package/src/graph/util/dhash.ts

@@ -0,0 +1,84 @@
+/**
+ * Difference hash (dHash) — STUB for hypothetical environment.
+ *
+ * Real production dHash requires image decoding (e.g. Sharp / @napi-rs/image / jimp):
+ *   1. Decode image to raw pixels
+ *   2. Convert to grayscale
+ *   3. Downsample to 9×8 (72 pixels)
+ *   4. For each row, compare adjacent pixels → 64 horizontal comparisons → 64 bits
+ *   5. Pack into 16 hex chars (MSB-first)
+ *
+ * This stub is deterministic for testing but is NOT a perceptual hash on visual
+ * content — it only hashes raw byte distribution by sampling 65 evenly-spaced
+ * byte positions and comparing adjacent samples.
+ *
+ * TODO(Slice 5 production): Replace with real image-decoding dHash.
+ *
+ * @module
+ */
+
+/**
+ * Compute a 64-bit difference hash of raw bytes (stub algorithm).
+ *
+ * @returns 16-character lowercase hex string representing 64 bits.
+ */
+export function dhash(bytes: Uint8Array): string {
+  if (bytes.length === 0) {
+    throw new Error("dhash: input bytes empty");
+  }
+
+  const len = bytes.length;
+
+  // Sample 65 evenly-spaced byte positions
+  const samples = new Uint8Array(65);
+  for (let i = 0; i < 65; i++) {
+    const pos = Math.min(Math.floor((i * len) / 65), len - 1);
+    samples[i] = bytes[pos];
+  }
+
+  // 64 boolean comparisons → 64 bits → 16 hex chars
+  let hex = "";
+  for (let nibbleIdx = 0; nibbleIdx < 16; nibbleIdx++) {
+    let nibble = 0;
+    for (let bit = 0; bit < 4; bit++) {
+      const i = nibbleIdx * 4 + bit;
+      if (samples[i] > samples[i + 1]) {
+        nibble |= 1 << (3 - bit); // MSB-first within nibble
+      }
+    }
+    hex += nibble.toString(16);
+  }
+
+  return hex;
+}
+
+// Popcount lookup for 4-bit nibbles (0x0–0xF)
+const NIBBLE_POPCOUNT = [0, 1, 1, 2, 1, 2, 2, 3, 1, 2, 2, 3, 2, 3, 3, 4] as const;
+
+const HEX16_RE = /^[0-9a-fA-F]{16}$/;
+
+/**
+ * Hamming distance between two 64-bit dHash hex strings.
+ *
+ * Distance interpretation:
+ *   - ≤5  = highly similar
+ *   - >20 = unrelated
+ *
+ * @returns integer 0–64
+ */
+export function hammingDistance(hashA: string, hashB: string): number {
+  if (!HEX16_RE.test(hashA)) {
+    throw new Error(`hammingDistance: hashA is not a 16-char hex string: "${hashA}"`);
+  }
+  if (!HEX16_RE.test(hashB)) {
+    throw new Error(`hammingDistance: hashB is not a 16-char hex string: "${hashB}"`);
+  }
+
+  let dist = 0;
+  for (let i = 0; i < 16; i++) {
+    const a = parseInt(hashA[i], 16);
+    const b = parseInt(hashB[i], 16);
+    dist += NIBBLE_POPCOUNT[a ^ b];
+  }
+  return dist;
+}

package/src/lrr/aggregator.ts

@@ -8,12 +8,25 @@ export interface ChapterResult {
   follow_up_confirmed?: boolean;
 }
 
+export interface RoutingTarget {
+  decision_id: string;
+  resolved_decision_id: string;
+  phase: string;
+  step_id: string | null;
+  decided_by: string;
+  superseded: boolean;
+}
+
 export interface AggregateResult {
   combined_verdict: 'PRODUCTION READY' | 'NEEDS WORK' | 'BLOCKED';
   triggered_rule: number;
   chapters: ChapterResult[];
   star_rule_triggered?: boolean;
   star_rule_decision_ids?: string[];
+  cross_chapter_contradiction?: string;
+  routing_targets?: RoutingTarget[];
+  routing_source?: 'graph' | 'fallback';
+  routing_warnings?: string[];
 }
 
 export function aggregate(chapters: ChapterResult[]): AggregateResult {
@@ -21,23 +34,24 @@ export function aggregate(chapters: ChapterResult[]): AggregateResult {
   if (chapters.some(c => c.override_blocks_launch))
     return { combined_verdict: 'BLOCKED', triggered_rule: 1, chapters };
 
-  // Rule 6: contradictions between chapters on typed fields → BLOCKED
-  // Two chapters contradict if they reference the same finding description
-  // but assign conflicting verdicts (one PASS, one BLOCK on the same topic).
-  const findingsByDesc = new Map<string, Set<Verdict>>();
+  // Rule 6: contradictions between chapters on related_decision_id → BLOCKED
+  // Two chapters contradict if they reference the same decision_id
+  // but assign conflicting verdicts (one PASS, one BLOCK).
+  const verdictByDecisionId = new Map<string, Set<Verdict>>();
   for (const ch of chapters) {
     for (const f of ch.findings) {
-      const key = f.description.toLowerCase().trim();
-      if (!findingsByDesc.has(key)) findingsByDesc.set(key, new Set());
-      findingsByDesc.get(key)!.add(ch.verdict);
+      if (!f.related_decision_id) continue;
+      const key = f.related_decision_id;
+      if (!verdictByDecisionId.has(key)) verdictByDecisionId.set(key, new Set());
+      verdictByDecisionId.get(key)!.add(ch.verdict);
     }
   }
-  for (const [desc, verdicts] of findingsByDesc) {
+  for (const [decId, verdicts] of verdictByDecisionId) {
     if (verdicts.has('PASS') && verdicts.has('BLOCK')) {
       return {
         combined_verdict: 'BLOCKED', triggered_rule: 6, chapters,
-        cross_chapter_contradiction: desc,
-      } as AggregateResult;
+        cross_chapter_contradiction: decId,
+      };
     }
   }
 
@@ -78,3 +92,84 @@ export function applyStarRule(result: AggregateResult): AggregateResult {
   }
   return { ...result, star_rule_triggered: false };
 }
+
+/**
+ * Slice 4 graph fast-path for backward routing.
+ *
+ * Given an aggregate result with `star_rule_decision_ids`, resolve each ID to a
+ * routing target (phase + step_id + decided_by) by querying the graph layer.
+ * Walks `decision_supersedes` via DecisionView.superseded_by so a finding
+ * tagged with a resolved-and-replaced decision routes to the replacement's
+ * authoring phase.
+ *
+ * Falls back to the existing string-only path on any graph failure: returns
+ * the input result with `routing_source: "fallback"` so the caller knows to
+ * use `star_rule_decision_ids` directly with whatever legacy logic it has.
+ */
+export async function resolveRoutingTargets(
+  result: AggregateResult,
+  projectDir: string,
+): Promise<AggregateResult> {
+  if (!result.star_rule_triggered || !result.star_rule_decision_ids?.length) {
+    return result;
+  }
+
+  let loadAllGraphs: typeof import('../graph/storage/index.js').loadAllGraphs;
+  let queryDecisions: typeof import('../graph/storage/index.js').queryDecisions;
+  try {
+    const mod = await import('../graph/storage/index.js');
+    loadAllGraphs = mod.loadAllGraphs;
+    queryDecisions = mod.queryDecisions;
+  } catch (err) {
+    return {
+      ...result,
+      routing_source: 'fallback',
+      routing_warnings: [`graph storage import failed: ${err instanceof Error ? err.message : String(err)}`],
+    };
+  }
+
+  const graph = loadAllGraphs(projectDir);
+  if (!graph) {
+    return {
+      ...result,
+      routing_source: 'fallback',
+      routing_warnings: [`no graph fragment in ${projectDir} — string-only routing path`],
+    };
+  }
+
+  const targetIds = new Set(result.star_rule_decision_ids);
+  const allViews = queryDecisions(graph, {});
+  const byDecisionId = new Map(allViews.map(v => [v.decision_id, v]));
+
+  const targets: RoutingTarget[] = [];
+  const warnings: string[] = [];
+
+  for (const decId of result.star_rule_decision_ids) {
+    const view = byDecisionId.get(decId);
+    if (!view) {
+      warnings.push(`decision_id "${decId}" not found in graph`);
+      continue;
+    }
+
+    const replacement = view.superseded_by
+      ? allViews.find(v => v.id === view.superseded_by!.id)
+      : undefined;
+    const resolved = replacement ?? view;
+
+    targets.push({
+      decision_id: decId,
+      resolved_decision_id: resolved.decision_id,
+      phase: resolved.phase,
+      step_id: resolved.step_id,
+      decided_by: resolved.decided_by,
+      superseded: replacement !== undefined,
+    });
+  }
+
+  return {
+    ...result,
+    routing_source: 'graph',
+    routing_targets: targets,
+    ...(warnings.length > 0 ? { routing_warnings: warnings } : {}),
+  };
+}