build-start-rebuild-perf 0.3.0 → 0.4.0

package/.github/workflows/plan-release.yml

@@ -15,77 +15,44 @@ concurrency:
   cancel-in-progress: true
 
 jobs:
-  is-this-a-release:
-    name: "Is this a release?"
+  should-run-release-plan-prepare:
+    name: Should we run release-plan prepare?
     runs-on: ubuntu-latest
     outputs:
-      command: ${{ steps.check-release.outputs.command }}
-
+      should-prepare: ${{ steps.should-prepare.outputs.should-prepare }}
     steps:
-      - uses: actions/checkout@v4
+      - uses: release-plan/actions/should-prepare-release@v1
         with:
-          fetch-depth: 2
           ref: 'main'
-      # This will only cause the `is-this-a-release` job to have a "command" of `release`
-      # when the .release-plan.json file was changed on the last commit.
-      - id: check-release
-        run: if git diff --name-only HEAD HEAD~1 | grep -w -q ".release-plan.json"; then echo "command=release"; fi >> $GITHUB_OUTPUT
+        id: should-prepare
 
   create-prepare-release-pr:
     name: Create Prepare Release PR
     runs-on: ubuntu-latest
     timeout-minutes: 5
-    needs: is-this-a-release
+    needs: should-run-release-plan-prepare
     permissions:
       contents: write
       issues: read
       pull-requests: write
-    # only run on push event or workflow dispatch if plan wasn't updated (don't create a release plan when we're releasing)
-    # only run on labeled event if the PR has already been merged
-    if: ((github.event_name == 'push' || github.event_name == 'workflow_dispatch') && needs.is-this-a-release.outputs.command != 'release') || (github.event_name == 'pull_request_target' && github.event.pull_request.merged == true)
-
+    if: needs.should-run-release-plan-prepare.outputs.should-prepare == 'true'
     steps:
-      - uses: actions/checkout@v4
-        # We need to download lots of history so that
-        # github-changelog can discover what's changed since the last release
+      - uses: release-plan/actions/prepare@v1
+        name: Run release-plan prepare
         with:
-          fetch-depth: 0
           ref: 'main'
-      - uses: pnpm/action-setup@v4
-      - uses: actions/setup-node@v4
-        with:
-          node-version: 18
-          cache: pnpm
-      - run: pnpm install --frozen-lockfile
-      - name: "Generate Explanation and Prep Changelogs"
-        id: explanation
-        run: |
-          set +e
-          pnpm release-plan prepare 2> >(tee -a release-plan-stderr.txt >&2)
-
-          if [ $? -ne 0 ]; then
-            release_plan_output=$(cat release-plan-stderr.txt)
-          else
-            release_plan_output=$(jq .description .release-plan.json -r)
-            rm release-plan-stderr.txt
-
-            if [ $(jq '.solution | length' .release-plan.json) -eq 1 ]; then
-              new_version=$(jq -r '.solution[].newVersion' .release-plan.json)
-              echo "new_version=v$new_version" >> $GITHUB_OUTPUT
-            fi
-          fi
-            echo 'text<<EOF' >> $GITHUB_OUTPUT
-          echo "$release_plan_output" >> $GITHUB_OUTPUT
-            echo 'EOF' >> $GITHUB_OUTPUT
         env:
           GITHUB_AUTH: ${{ secrets.GITHUB_TOKEN }}
+        id: explanation
 
-      - uses: peter-evans/create-pull-request@v7
+      - uses: peter-evans/create-pull-request@v8
+        name: Create Prepare Release PR
         with:
-          commit-message: "Prepare Release ${{ steps.explanation.outputs.new_version}} using 'release-plan'"
+          commit-message: "Prepare Release ${{ steps.explanation.outputs.new-version}} using 'release-plan'"
           labels: "internal"
+          sign-commits: true
           branch: release-preview
-          title: Prepare Release ${{ steps.explanation.outputs.new_version }}
+          title: Prepare Release ${{ steps.explanation.outputs.new-version }}
           body: |
             This PR is a preview of the release that [release-plan](https://github.com/embroider-build/release-plan) has prepared. To release you should just merge this PR 👍
 

package/.github/workflows/publish.yml

@@ -22,17 +22,15 @@ jobs:
     runs-on: ubuntu-latest
     permissions:
       contents: write
-      pull-requests: write
       id-token: write
       attestations: write
 
     steps:
-      - uses: actions/checkout@v4
-      - uses: pnpm/action-setup@v4
-      - uses: actions/setup-node@v4
+      - uses: actions/checkout@v6
+      - uses: pnpm/action-setup@v5
+      - uses: actions/setup-node@v6
         with:
-          node-version: 18
-          # This creates an .npmrc that reads the NODE_AUTH_TOKEN environment variable
+          node-version: 24
           registry-url: 'https://registry.npmjs.org'
           cache: pnpm
       - run: pnpm install --frozen-lockfile
@@ -40,4 +38,3 @@ jobs:
         run: NPM_CONFIG_PROVENANCE=true pnpm release-plan publish
         env:
           GITHUB_AUTH: ${{ secrets.GITHUB_TOKEN }}
-          NODE_AUTH_TOKEN: ${{ secrets.NPM_TOKEN }}

package/.github/workflows/test.yml

@@ -30,4 +30,5 @@ jobs:
         with:
           cache: pnpm
       - run: pnpm i --frozen-lockfile
+      - run: pnpm puppeteer browsers install chrome
       - run: pnpm run test

package/.release-plan.json

@@ -2,17 +2,25 @@
   "solution": {
     "build-start-rebuild-perf": {
       "impact": "minor",
-      "oldVersion": "0.2.3",
-      "newVersion": "0.3.0",
+      "oldVersion": "0.3.0",
+      "newVersion": "0.4.0",
       "tagName": "latest",
       "constraints": [
         {
           "impact": "minor",
           "reason": "Appears in changelog section :rocket: Enhancement"
+        },
+        {
+          "impact": "patch",
+          "reason": "Appears in changelog section :bug: Bug Fix"
+        },
+        {
+          "impact": "patch",
+          "reason": "Appears in changelog section :house: Internal"
         }
       ],
       "pkgJSONPath": "./package.json"
     }
   },
-  "description": "## Release (2025-08-25)\n\n* build-start-rebuild-perf 0.3.0 (minor)\n\n#### :rocket: Enhancement\n* `build-start-rebuild-perf`\n  * [#41](https://github.com/mainmatter/build-start-rebuild-perf/pull/41) add option to have a custom page-load-timeout ([@mansona](https://github.com/mansona))\n\n#### Committers: 1\n- Chris Manson ([@mansona](https://github.com/mansona))\n"
+  "description": "## Release (2026-07-13)\n\n* build-start-rebuild-perf 0.4.0 (minor)\n\n#### :rocket: Enhancement\n* `build-start-rebuild-perf`\n  * [#53](https://github.com/mainmatter/build-start-rebuild-perf/pull/53) Fix waitForPageToLoad behavior ([@NullVoxPopuli](https://github.com/NullVoxPopuli))\n  * [#49](https://github.com/mainmatter/build-start-rebuild-perf/pull/49) Disable thousands separator for clearness ([@BlueCutOfficial](https://github.com/BlueCutOfficial))\n  * [#43](https://github.com/mainmatter/build-start-rebuild-perf/pull/43) use standard puppeteer ([@mansona](https://github.com/mansona))\n\n#### :bug: Bug Fix\n* `build-start-rebuild-perf`\n  * [#54](https://github.com/mainmatter/build-start-rebuild-perf/pull/54) Upgrade puppeteer so that tests pass ([@NullVoxPopuli](https://github.com/NullVoxPopuli))\n\n#### :house: Internal\n* `build-start-rebuild-perf`\n  * [#66](https://github.com/mainmatter/build-start-rebuild-perf/pull/66) chore: update release-plan ([@BobrImperator](https://github.com/BobrImperator))\n  * [#57](https://github.com/mainmatter/build-start-rebuild-perf/pull/57) stop running renovate on unpublished test app ([@mansona](https://github.com/mansona))\n  * [#55](https://github.com/mainmatter/build-start-rebuild-perf/pull/55) make package.json licence match project licence ([@mansona](https://github.com/mansona))\n  * [#56](https://github.com/mainmatter/build-start-rebuild-perf/pull/56) prevent version mismatch for puppeteer chrome install on CI ([@mansona](https://github.com/mansona))\n  * [#44](https://github.com/mainmatter/build-start-rebuild-perf/pull/44) update biome schema to avoid warning ([@mansona](https://github.com/mansona))\n\n#### Committers: 4\n- Bartlomiej Dudzik ([@BobrImperator](https://github.com/BobrImperator))\n- Chris Manson ([@mansona](https://github.com/mansona))\n- Marine Dunstetter ([@BlueCutOfficial](https://github.com/BlueCutOfficial))\n- [@NullVoxPopuli](https://github.com/NullVoxPopuli)\n"
 }

package/CHANGELOG.md

@@ -1,5 +1,33 @@
 # Changelog
 
+## Release (2026-07-13)
+
+* build-start-rebuild-perf 0.4.0 (minor)
+
+#### :rocket: Enhancement
+* `build-start-rebuild-perf`
+  * [#53](https://github.com/mainmatter/build-start-rebuild-perf/pull/53) Fix waitForPageToLoad behavior ([@NullVoxPopuli](https://github.com/NullVoxPopuli))
+  * [#49](https://github.com/mainmatter/build-start-rebuild-perf/pull/49) Disable thousands separator for clearness ([@BlueCutOfficial](https://github.com/BlueCutOfficial))
+  * [#43](https://github.com/mainmatter/build-start-rebuild-perf/pull/43) use standard puppeteer ([@mansona](https://github.com/mansona))
+
+#### :bug: Bug Fix
+* `build-start-rebuild-perf`
+  * [#54](https://github.com/mainmatter/build-start-rebuild-perf/pull/54) Upgrade puppeteer so that tests pass ([@NullVoxPopuli](https://github.com/NullVoxPopuli))
+
+#### :house: Internal
+* `build-start-rebuild-perf`
+  * [#66](https://github.com/mainmatter/build-start-rebuild-perf/pull/66) chore: update release-plan ([@BobrImperator](https://github.com/BobrImperator))
+  * [#57](https://github.com/mainmatter/build-start-rebuild-perf/pull/57) stop running renovate on unpublished test app ([@mansona](https://github.com/mansona))
+  * [#55](https://github.com/mainmatter/build-start-rebuild-perf/pull/55) make package.json licence match project licence ([@mansona](https://github.com/mansona))
+  * [#56](https://github.com/mainmatter/build-start-rebuild-perf/pull/56) prevent version mismatch for puppeteer chrome install on CI ([@mansona](https://github.com/mansona))
+  * [#44](https://github.com/mainmatter/build-start-rebuild-perf/pull/44) update biome schema to avoid warning ([@mansona](https://github.com/mansona))
+
+#### Committers: 4
+- Bartlomiej Dudzik ([@BobrImperator](https://github.com/BobrImperator))
+- Chris Manson ([@mansona](https://github.com/mansona))
+- Marine Dunstetter ([@BlueCutOfficial](https://github.com/BlueCutOfficial))
+- [@NullVoxPopuli](https://github.com/NullVoxPopuli)
+
 ## Release (2025-08-25)
 
 * build-start-rebuild-perf 0.3.0 (minor)

package/README.md

@@ -41,7 +41,7 @@ pnpm dlx build-start-rebuild-perf --file "app/router.js" --wait-for ".logo"
 
 | Dev Server Ready | First Paint | App Loaded | Reload after change |
 | ---------------- | ----------- | ---------- | ------------------- |
-| 5,523 ms         | 5,618 ms    | 6,142 ms   | 918 ms              |
+| 5523 ms          | 5618 ms     | 6142 ms    | 918 ms              |
 ```
 
 ## Share with us

package/biome.json

@@ -1,5 +1,5 @@
 {
-  "$schema": "https://biomejs.dev/schemas/2.1.3/schema.json",
+  "$schema": "https://biomejs.dev/schemas/2.1.4/schema.json",
   "files": {
     "includes": ["bin/**", "lib/**", "src/**", "test/**", "*.js", "*.mjs", "*.json"],
     "ignoreUnknown": true

package/lib/browser.js

@@ -1,7 +1,6 @@
 import { promises as fs } from "node:fs";
 import { resolve } from "node:path";
-import { Launcher } from "chrome-launcher";
-import puppeteer from "puppeteer-core";
+import puppeteer from "puppeteer";
 import { error, log, warn } from "./log.js";
 
 export const VIEWPORT = {
@@ -14,7 +13,6 @@ let page = null;
 
 export async function initBrowser() {
   browser = await puppeteer.launch({
-    executablePath: Launcher.getInstallations()[0],
     headless: process.env.SHOW_BROWSER !== "true",
     args: ["--no-sandbox"],
   });
@@ -49,6 +47,32 @@ export async function initBrowser() {
   }
 }
 
+const HARD_CODED_NETWORK_IDLE_TIMEOUT = 30_000;
+async function waitForNetworkIdle(page, pageLoadTimeout) {
+  let attempts = Math.max(pageLoadTimeout / HARD_CODED_NETWORK_IDLE_TIMEOUT, 1);
+
+  /**
+   * waitForNetworkIdle has no configurable timeout
+   * and always times out at 30s, if your app takes
+   * more than 30s to finish dependency discovery and optimization.
+   * (easily possible on 3 million line code bases)
+   */
+  for (let attempt = 0; attempt < attempts; attempt++) {
+    log(`waitForNetworkIdle: attempt ${attempt} of ${attempts}`);
+
+    try {
+      await page.waitForNetworkIdle();
+      return;
+    } catch (error) {
+      if (error.message.includes("Timed out after waiting 30000ms")) {
+        continue;
+      }
+
+      throw error;
+    }
+  }
+}
+
 export async function measurePageLoad(url, waitForSelector = "body", pageLoadTimeout = 60_000) {
   log(`Loading page: ${url}`);
 
@@ -64,7 +88,7 @@ export async function measurePageLoad(url, waitForSelector = "body", pageLoadTim
   const atFirstPaint = performance.now();
 
   log("Waiting for page to fully load...");
-  await page.waitForNetworkIdle();
+  await waitForNetworkIdle(page, pageLoadTimeout);
 
   log(`Waiting for element: ${waitForSelector}`);
   await page.waitForSelector(waitForSelector, {
@@ -82,7 +106,7 @@ export async function measurePageLoad(url, waitForSelector = "body", pageLoadTim
   };
 }
 
-export async function measureFileReload(filePath) {
+export async function measureFileReload(filePath, pageLoadTimeout = 60_000) {
   if (!filePath) {
     log("No file specified for reload test, skipping...");
     return 0;
@@ -108,7 +132,7 @@ export async function measureFileReload(filePath) {
   const atFileChanged = performance.now();
 
   log("Waiting for hot reload to complete...");
-  await page.waitForNetworkIdle();
+  await waitForNetworkIdle(page, pageLoadTimeout);
 
   const atReloadComplete = performance.now();
 

package/lib/measure.js

@@ -33,7 +33,7 @@ export async function measure(options) {
       options.waitFor,
       options.pageLoadTimeout,
     );
-    const reloadMetrics = await measureFileReload(options.file);
+    const reloadMetrics = await measureFileReload(options.file, options.pageLoadTimeout);
     await terminateServer();
 
     return {

package/lib/utils.js

@@ -38,6 +38,7 @@ export class PrefixedTransform extends Transform {
 const formatter = Intl.NumberFormat("en-US", {
   style: "unit",
   unit: "millisecond",
+  useGrouping: false,
 });
 
 export function formatMs(timeMs) {

package/package.json

@@ -1,29 +1,28 @@
 {
   "name": "build-start-rebuild-perf",
-  "version": "0.3.0",
+  "version": "0.4.0",
   "description": "",
   "keywords": [],
   "repository": {
     "type": "git",
     "url": "git@github.com:mainmatter/build-start-rebuild-perf.git"
   },
-  "license": "ISC",
+  "license": "MIT",
   "author": "",
   "type": "module",
   "bin": {
     "build-start-rebuild-perf": "bin/cli.js"
   },
   "dependencies": {
-    "chrome-launcher": "^1.2.0",
     "commander": "^14.0.0",
     "execa": "^9.6.0",
     "markdown-table": "^3.0.4",
-    "puppeteer-core": "^24.16.0",
+    "puppeteer": "^24.36.1",
     "strip-ansi": "^7.1.0"
   },
   "devDependencies": {
     "@biomejs/biome": "^2.1.3",
-    "release-plan": "^0.17.0",
+    "release-plan": "^0.18.0",
     "vitest": "^3.2.4"
   },
   "scripts": {

package/pnpm-workspace.yaml

@@ -1,3 +1,6 @@
 packages:
-  - '.'
-  - 'test-ember-app'
+  - .
+  - test-ember-app
+
+onlyBuiltDependencies:
+  - puppeteer

package/renovate.json

@@ -1,4 +1,10 @@
 {
   "$schema": "https://docs.renovatebot.com/renovate-schema.json",
-  "extends": ["config:recommended"]
+  "extends": ["config:recommended"],
+  "packageRules": [
+    {
+      "matchFiles": ["test-ember-app/package.json"],
+      "enabled": false
+    }
+  ]
 }