buddy-workbench 0.1.80 → 0.1.82

package/bin/devbuddy.js

@@ -64,10 +64,15 @@ function npmExecOptions(options = {}) {
   };
 }
 
+function npmInstallArgs(packageSpec, global = false) {
+  const before = new Date(Date.now() - 48 * 60 * 60 * 1000).toISOString();
+  return ['install', ...(global ? ['--global'] : []), '--before', before, packageSpec];
+}
+
 function scheduleWindowsSelfUpdate(packageSpec) {
   const updateScript = `import { execFileSync } from 'node:child_process';
 await new Promise((resolve) => setTimeout(resolve, 1500));
-execFileSync('npm.cmd', ['install', '--global', ${JSON.stringify(packageSpec)}], { shell: true, windowsHide: true, stdio: 'inherit' });`;
+execFileSync('npm.cmd', ${JSON.stringify(npmInstallArgs(packageSpec, true))}, { shell: true, windowsHide: true, stdio: 'inherit' });`;
   const updater = spawn(process.execPath, ['--input-type=module', '-e', updateScript], {
     cwd: homedir(),
     detached: true,
@@ -117,7 +122,7 @@ function selfUpdate(args) {
     return;
   }
   try {
-    execFileSync(npmCommand(), ['install', '--global', `${details.name}@${version}`], npmExecOptions({
+    execFileSync(npmCommand(), npmInstallArgs(`${details.name}@${version}`, true), npmExecOptions({
       cwd: root,
       stdio: 'inherit'
     }));

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "buddy-workbench",
-  "version": "0.1.80",
+  "version": "0.1.82",
   "private": false,
   "type": "module",
   "bin": {

package/server/routes/overview.js

@@ -68,6 +68,55 @@ function mapJiraIssue(issue) {
 
 function issueUrl(host, key) { return `https://${host}/browse/${encodeURIComponent(key)}`; }
 
+function myWorkUrl(host, path) { return `https://${host}/rest/mywork/latest${path}`; }
+
+function notificationText(value) {
+  if (typeof value !== 'string') return '';
+  return value.replace(/<[^>]+>/g, ' ').replace(/\s+/g, ' ').trim();
+}
+
+function notificationUrl(host, item) {
+  const candidate = item?.url || item?.link || item?._links?.webui || item?.content?.url || item?.content?._links?.webui;
+  if (!candidate) return '';
+  return /^https?:\/\//i.test(candidate) ? candidate : `https://${host}${candidate.startsWith('/') ? '' : '/'}${candidate}`;
+}
+
+function notificationDate(value) {
+  if (!value) return null;
+  const date = new Date(value);
+  return Number.isNaN(date.getTime()) ? null : date.toISOString();
+}
+
+async function loadNotifications(host, token, source) {
+  if (!host || !token) return [];
+  const authHeader = token.startsWith('Bearer ') ? token : `Bearer ${token}`;
+  const url = myWorkUrl(host, '/notification?limit=50');
+  const response = await httpClient.get(url, { headers: { Accept: 'application/json', Authorization: authHeader } });
+  if (!isSuccess(response)) throw new Error(`${source} notifications failed (${response.status}): ${apiMessage(response, 'Request failed')}`);
+
+  const payload = response.data;
+  const values = Array.isArray(payload)
+    ? payload
+    : payload?.notifications || payload?.values || payload?.items || payload?.results || [];
+  return values.map((item, index) => {
+    const title = notificationText(item?.title || item?.subject || item?.message || item?.content?.title || item?.content?.summary) || `${source} notification`;
+    const summary = notificationText(item?.body || item?.description || item?.content?.body || item?.content?.description || item?.message || '');
+    const date = item?.created || item?.createdDate || item?.updated || item?.updatedDate || item?.timestamp || item?.content?.updated;
+    const normalizedDate = notificationDate(date);
+    return {
+      id: `${source.toLowerCase()}-${item?.id || item?.notificationId || index}`,
+      title,
+      summary,
+      source,
+      sourceType: source.toLowerCase(),
+      read: item?.read === true || item?.isRead === true,
+      activityAt: normalizedDate,
+      updated: normalizedDate,
+      url: notificationUrl(host, item)
+    };
+  });
+}
+
 async function loadJiraData(host, token) {
   const authHeader = token.startsWith('Bearer ') ? token : `Bearer ${token}`;
   const headers = { Accept: 'application/json', Authorization: authHeader };
@@ -267,4 +316,30 @@ router.get('/', async (_req, res) => {
   });
 });
 
+router.get('/notifications', async (_req, res) => {
+  const settings = readSettings();
+  const jira = jiraHost(settings.domain);
+  const confluence = confluenceHost(settings.domain);
+  const confluenceToken = settings.confluenceAccessToken || settings.jiraAccessToken;
+
+  if (!jira && !confluence) {
+    return res.json({ configured: false, notifications: { jira: [], confluence: [] }, errors: ['Configure a Jira or Confluence domain in Settings.'] });
+  }
+
+  const [jiraResult, confluenceResult] = await Promise.all([
+    requestSection('Jira notifications', () => loadNotifications(jira, settings.jiraAccessToken, 'Jira')),
+    requestSection('Confluence notifications', () => loadNotifications(confluence, confluenceToken, 'Confluence'))
+  ]);
+
+  return res.json({
+    configured: true,
+    fetchedAt: new Date().toISOString(),
+    notifications: {
+      jira: jiraResult.items || [],
+      confluence: confluenceResult.items || []
+    },
+    errors: [jiraResult.error, confluenceResult.error].filter(Boolean)
+  });
+});
+
 export default router;

package/server/routes/pr-review.js

@@ -13,7 +13,7 @@ const aiReviewJobs = new Map();
 const PR_REVIEW_RULES = [
   { id: 'lodash-get', name: 'Lodash Get Required', description: 'Prefer lodash/get for nested object property access.', pattern: String.raw`\b([a-zA-Z_$][\w$]*)\s*(\?\.|\.)\s*([a-zA-Z_$][\w$]*)\b(?!\s*\()`, severity: 'warning' },
   { id: 'no-any', name: 'No Any Type', description: 'Disallow the TypeScript any type.', pattern: String.raw`:\s*any\b|:\s*any\[\]|as\s+any\b|<[^>]*?\bany\b[^>]*?>|\bany\[\]`, severity: 'critical' },
-  { id: 'no-hardcoded-strings', name: 'No Hardcoded Strings', description: 'Move hardcoded text into constants or i18n.', pattern: String.raw`(const|let|var)\s+[a-zA-Z_$][\w$]*\s*=\s*['"][^'"]+['"]`, severity: 'warning' },
+  { id: 'no-hardcoded-strings', name: 'No Hardcoded Strings', description: 'Move hardcoded text into constants or i18n.', pattern: String.raw`(const|let|var)\s+[a-zA-Z_$][\w$]*\s*=\s*['"\x60][^'"\x60]+['"\x60]|\b(?!className\b|type\b|key\b|name\b|rel\b|target\b|method\b)[a-zA-Z_$][\w$-]*\s*=\s*['"\x60][^'"\x60]+['"\x60]`, severity: 'warning' },
   { id: 'no-inline-styles', name: 'No Inline Styles', description: 'Use CSS classes or styled components instead of inline styles.', pattern: String.raw`\bstyle\s*=\s*\{\s*\{[\s\S]*?\}\s*\}|\bstyle\s*=\s*['"][\s\S]*?['"]`, severity: 'warning' },
   { id: 'clickable-element-tag', name: 'Clickable Element Tag', description: 'Use button or anchor elements for clickable UI.', pattern: String.raw`<(div|span|p|li|tr|td|img|i|svg|section|article|header|footer|h[1-6]|label)\b[^>]*?\b(onClick|@click)\b[^>]*?>`, severity: 'warning' },
   { id: 'no-relative-paths', name: 'No Relative Paths', description: 'Use absolute module imports or path aliases.', pattern: String.raw`import\s*(?:\{[^}]*\}|[^{'"\n]+)\s*from\s*['"]\.\.?\/*['"]|require\s*\(\s*['"]\.\.?\/*['"]\)`, severity: 'warning' },
@@ -77,6 +77,25 @@ async function fetchFullFileContent({ host, projectKey, repositorySlug, filePath
   return String(response.data ?? '');
 }
 
+function formatDiffForAi(hunks) {
+  return (hunks || []).map((hunk) => {
+    const sourceLine = hunk.sourceLine ?? hunk.source ?? 0;
+    const sourceSpan = hunk.sourceSpan ?? 0;
+    const destinationLine = hunk.destinationLine ?? hunk.destination ?? 0;
+    const destinationSpan = hunk.destinationSpan ?? 0;
+    const header = `@@ -${sourceLine},${sourceSpan} +${destinationLine},${destinationSpan} @@`;
+    const lines = (hunk.segments || []).flatMap((segment) => (segment.lines || []).map((line) => {
+      const text = line.line ?? line.text ?? '';
+      const lineNumber = segment.type === 'REMOVED'
+        ? (line.source ?? line.sourceLine ?? '')
+        : (line.destination ?? line.destinationLine ?? '');
+      const prefix = segment.type === 'ADDED' ? '+' : segment.type === 'REMOVED' ? '-' : ' ';
+      return `${prefix}${lineNumber === '' ? '' : `${lineNumber} `}${text}`;
+    }));
+    return [header, ...lines].join('\n');
+  }).filter(Boolean).join('\n');
+}
+
 function aiCompletionUrl(host) {
   const normalizedHost = String(host || '').replace(/\/+$/, '');
   return /\/chat\/completions$/i.test(normalizedHost) ? normalizedHost : `${normalizedHost}/chat/completions`;
@@ -127,7 +146,7 @@ async function runAiReview({ aiApiHost, pr, files }) {
     `Description: ${pr.description || ''}`,
     `Branches: ${pr.sourceBranch || ''} -> ${pr.targetBranch || ''}`,
     '',
-    'Changed files (complete current file contents):',
+    'Changed files (diff only; do not review unchanged code):',
     ...files.map((file) => [
       `--- FILE: ${file.filePath} (${file.type || 'MODIFY'}) ---`,
       file.content,
@@ -545,129 +564,50 @@ const analyzeDiff = (filePath, hunks) => {
         }
       }
 
-      // Rule 1: Object property extraction requires lodash.get
-      const propAccessRegex = /\b([a-zA-Z_$][\w$]*)\s*(\?\.|\.)\s*([a-zA-Z_$][\w$]*)\b(?!\s*\()/g;
-      for (const match of segmentText.matchAll(propAccessRegex)) {
-        const objName = match[1];
-        const propName = match[3];
-        const matchIdx = match.index;
-
-        if (objName === 'row' && propName === 'original') continue;
-        if (objName === 'original' && matchIdx >= 4 && segmentText.slice(matchIdx - 4, matchIdx).includes('row.')) continue;
-
-        const globalNamespaces = [
-          'Math', 'Object', 'Array', 'JSON', 'Promise', 'Reflect', 'Symbol', 'Date',
-          'Number', 'String', 'Boolean', 'React', 'process', 'e', 'evt', 'event',
-          'console', 'window', 'document', 'history', 'location', 'styles', 'style',
-          'req', 'res'
-        ];
-        if (globalNamespaces.includes(objName)) continue;
-
-        const lineText = getLineInfo(matchIdx).text.trim();
-        if (/^\s*(import|export|type|interface)\b/.test(lineText)) continue;
-        if (/\b(lodash\.)?get\s*\(/.test(lineText)) continue;
-
-        addIssue('warning', 'Lodash Get Required', 'Object property better use `lodash/get`: `get(obj, ...)`', matchIdx);
-      }
-
-      // Rule 2: TS cannot use 'any' type
-      const anyRegex = /:\s*any\b|:\s*any\[\]|as\s+any\b|<[^>]*?\bany\b[^>]*?>|\bany\[\]/g;
-      for (const match of segmentText.matchAll(anyRegex)) {
-        addIssue('critical', 'No Any Type', 'TypeScript strictly prohibits using the `any` type.', match.index);
-      }
-
-      // Rule 3: No hardcoded text / strings
-      const hardcodedVarRegex = /(const|let|var)\s+[a-zA-Z_$][\w$]*\s*=\s*['"`][^'"`]+['"`]/g;
-      for (const match of segmentText.matchAll(hardcodedVarRegex)) {
-        const lineText = getLineInfo(match.index).text.trim();
-        if (!/^\s*(import|export)\b/.test(lineText) && !/\brequire\s*\(/.test(lineText)) {
-          addIssue('warning', 'No Hardcoded Strings', 'Do not use hardcoded string literals (e.g., `const a = "aa"` or `attr="111"`). Use constants or i18n.', match.index);
-        }
-      }
-      const hardcodedAttrRegex = /\b(?!className\b|type\b|key\b|name\b|rel\b|target\b|method\b)[a-zA-Z_$][\w$-]*\s*=\s*['"`][^'"`]+['"`]/g;
-      for (const match of segmentText.matchAll(hardcodedAttrRegex)) {
-        const lineText = getLineInfo(match.index).text.trim();
-        if (!/^\s*(import|export)\b/.test(lineText) && !/\brequire\s*\(/.test(lineText)) {
-          addIssue('warning', 'No Hardcoded Strings', 'Do not use hardcoded string literals (e.g., `const a = "aa"` or `attr="111"`). Use constants or i18n.', match.index);
-        }
-      }
-
-      // Rule 4: No inline styles (multiline)
-      const styleRegex = /\bstyle\s*=\s*\{\s*\{[\s\S]*?\}\s*\}|\bstyle\s*=\s*['"][\s\S]*?['"]/g;
-      for (const match of segmentText.matchAll(styleRegex)) {
-        addIssue('warning', 'No Inline Styles', 'Inline styles are strictly prohibited. Use CSS classes or styled components.', match.index);
-      }
-
-      // Rule 6: Clickable elements must be button or a (multiline JSX opening tag)
-      const nonClickableTagRegex = /<(div|span|p|li|tr|td|img|i|svg|section|article|header|footer|h[1-6]|label)\b[^>]*?\b(onClick|@click)\b[^>]*?>/gis;
-      for (const match of segmentText.matchAll(nonClickableTagRegex)) {
-        addIssue('warning', 'Clickable Element Tag', 'Clickable elements must use `<button>` or `<a>` tags (or Button/Link components). Do not bind onClick to non-clickable tags like div/span.', match.index, match[0]);
-      }
-
-      // Rule 7: No relative paths (multiline import)
-      const relativeImportRegex = /(import\s*(?:\{[^}]*\}|[^{'"\n]+)\s*from\s*['"]\.\.?\/*['"]|require\s*\(\s*['"]\.\.?\/*['"]\))/gs;
-      for (const match of segmentText.matchAll(relativeImportRegex)) {
-        addIssue('warning', 'No Relative Paths', 'Relative module imports (`./` or `../`) are prohibited. Use absolute paths or path aliases.', match.index, match[0]);
-      }
-
-      // Rule 8: No debugger
-      const debuggerRegex = /\bdebugger\b/g;
-      for (const match of segmentText.matchAll(debuggerRegex)) {
-        addIssue('critical', 'No Debugger', 'Do not leave `debugger;` statements in code.', match.index);
-      }
-
-      // Rule 9: No console.log
-      const consoleRegex = /\bconsole\.log\b/g;
-      for (const match of segmentText.matchAll(consoleRegex)) {
-        addIssue('critical', 'No Console Log', 'Do not leave `console.log` statements in code.', match.index);
-      }
-
-      // Rule 10: No array index key
-      const keyIndexRegex = /\bkey\s*=\s*\{\s*(index|idx|i)\s*\}/g;
-      for (const match of segmentText.matchAll(keyIndexRegex)) {
-        addIssue('warning', 'No Array Index Key', 'Avoid using array index (e.g., `key={index}`) as a React key in list rendering.', match.index);
-      }
-
-      // Rule 11: No nested components
-      const nestedCompRegex = /^\s*(const|function)\s+[A-Z][a-zA-Z0-9_$]*\s*=\s*\(|\bfunction\s+[A-Z][a-zA-Z0-9_$]*\s*\(/gm;
-      for (const match of segmentText.matchAll(nestedCompRegex)) {
-        const lineText = getLineInfo(match.index).text.trim();
-        if (!/^\s*(export|import)\b/.test(lineText)) {
-          addIssue('warning', 'No Nested Components', 'Do not define React components inside another component body. Move component definitions outside.', match.index);
-        }
-      }
-
-      // Rule 12: No async client component
-      const asyncCompRegex = /\b(const|function)\s+[A-Z][a-zA-Z0-9_$]*\s*=\s*async\b|\basync\s+function\s+[A-Z][a-zA-Z0-9_$]*/g;
-      for (const match of segmentText.matchAll(asyncCompRegex)) {
-        addIssue('critical', 'No Async Component', 'React client components must not be async functions.', match.index);
-      }
-
-      // Rule 13: No non-null assertions (!.)
-      const nonNullRegex = /[a-zA-Z0-9_$]!\s*(\.|\[)/g;
-      for (const match of segmentText.matchAll(nonNullRegex)) {
-        addIssue('warning', 'No Non-null Assertion', 'Avoid using TypeScript non-null assertions (`!.`). Use optional chaining (`?.`) or defensive null checks instead.', match.index);
-      }
-
-      // Rule 14: No direct state mutation
-      const stateMutationRegex = /\b(state|list|items|data)\.(push|pop|shift|unshift|splice|sort|reverse)\s*\(|\bstate\.[a-zA-Z0-9_$]+\s*=\s*/g;
-      for (const match of segmentText.matchAll(stateMutationRegex)) {
-        addIssue('warning', 'No Direct State Mutation', 'Do not mutate React state directly. Use immutable data patterns.', match.index);
-      }
+      const messages = {
+        'Lodash Get Required': 'Object property better use `lodash/get`: `get(obj, ...)`',
+        'No Any Type': 'TypeScript strictly prohibits using the `any` type.',
+        'No Hardcoded Strings': 'Do not use hardcoded string literals. Use constants or i18n.',
+        'No Inline Styles': 'Inline styles are strictly prohibited. Use CSS classes or styled components.',
+        'Clickable Element Tag': 'Clickable elements must use `<button>` or `<a>` tags (or Button/Link components). Do not bind onClick to non-clickable tags like div/span.',
+        'No Relative Paths': 'Relative module imports (`./` or `../`) are prohibited. Use absolute paths or path aliases.',
+        'No Debugger': 'Do not leave `debugger;` statements in code.',
+        'No Console Log': 'Do not leave `console.log` statements in code.',
+        'No Array Index Key': 'Avoid using array index (e.g., `key={index}`) as a React key in list rendering.',
+        'No Nested Components': 'Do not define React components inside another component body. Move component definitions outside.',
+        'No Async Component': 'React client components must not be async functions.',
+        'No Non-null Assertion': 'Avoid using TypeScript non-null assertions (`!.`). Use optional chaining (`?.`) or defensive null checks instead.',
+        'No Direct State Mutation': 'Do not mutate React state directly. Use immutable data patterns.',
+        'Unhandled Async Event': 'Async event handlers must wrap asynchronous calls in a try...catch block to handle errors.',
+        'No Magic Numbers': 'Avoid magic numbers in business logic. Define named constants or enums instead.'
+      };
 
-      // Rule 15: Unhandled async event
-      const unhandledAsyncRegex = /\bon[A-Z][a-zA-Z0-9_$]*\s*=\s*\{\s*async\b[\s\S]*?\}/g;
-      for (const match of segmentText.matchAll(unhandledAsyncRegex)) {
-        if (!match[0].includes('try')) {
-          addIssue('warning', 'Unhandled Async Event', 'Async event handlers must wrap asynchronous calls in a try...catch block to handle errors.', match.index, match[0]);
+      for (const rule of Object.values(ruleSettings)) {
+        if (rule.enabled === false || !rule.pattern) continue;
+        let regex;
+        try {
+          // The built-in rule definition is the source of truth for matching.
+          regex = new RegExp(rule.pattern, 'gims');
+        } catch {
+          continue;
         }
-      }
+        for (const match of segmentText.matchAll(regex)) {
+          const matchIdx = match.index;
+          const lineText = getLineInfo(matchIdx).text.trim();
+
+          if (rule.id === 'lodash-get') {
+            const objName = match[1];
+            const propName = match[3];
+            const globalNamespaces = ['Math', 'Object', 'Array', 'JSON', 'Promise', 'Reflect', 'Symbol', 'Date', 'Number', 'String', 'Boolean', 'React', 'process', 'e', 'evt', 'event', 'console', 'window', 'document', 'history', 'location', 'styles', 'style', 'req', 'res'];
+            if (objName === 'row' && propName === 'original') continue;
+            if (objName === 'original' && matchIdx >= 4 && segmentText.slice(matchIdx - 4, matchIdx).includes('row.')) continue;
+            if (globalNamespaces.includes(objName) || /^\s*(import|export|type|interface)\b/.test(lineText) || /\b(lodash\.)?get\s*\(/.test(lineText)) continue;
+          }
+          if ((rule.id === 'no-hardcoded-strings' || rule.id === 'no-nested-components') && /^\s*(import|export)\b/.test(lineText)) continue;
+          if (rule.id === 'unhandled-async-event' && !match[0].includes('try')) continue;
+          if (rule.id === 'no-magic-numbers' && /\b(200|201|204|400|401|403|404|500)\b/.test(match[0])) continue;
 
-      // Rule 16: No magic numbers
-      const magicNumberRegex = /(===|==|!==|!=)\s*([2-9]|\d{2,})\b|\bsetTimeout\s*\([^,]+,\s*([2-9]|\d{2,})\)/g;
-      for (const match of segmentText.matchAll(magicNumberRegex)) {
-        if (!/\b(200|201|204|400|401|403|404|500)\b/.test(match[0])) {
-          addIssue('info', 'No Magic Numbers', 'Avoid magic numbers in business logic. Define named constants or enums instead.', match.index);
+          addIssue(rule.severity, rule.name, messages[rule.name] || rule.description, matchIdx, rule.id === 'clickable-element-tag' || rule.id === 'no-relative-paths' || rule.id === 'unhandled-async-event' ? match[0] : undefined);
         }
       }
     }
@@ -767,7 +707,7 @@ router.post('/check', async (req, res) => {
       }
       const fileIssues = analyzeDiff(filePath, hunks);
       const content = buildDemoContent(filePath, hunks);
-      aiFiles.push({ filePath, type: 'MODIFY', content });
+      aiFiles.push({ filePath, type: 'MODIFY', content: formatDiffForAi(hunks) });
       reviewFiles.push({ filePath, type: 'MODIFY', content, diffLines: getDiffLineMetadata(hunks), issues: fileIssues });
       if (fileIssues.length > 0) {
         totalIssues += fileIssues.length;
@@ -913,7 +853,7 @@ The pull request introduces feature updates across **${aiFiles.length} files**.
       const fileIssues = analyzeDiff(filePath, hunks || []);
       const contentCommit = change.type === 'DELETE' ? sinceCommit : untilCommit;
       const content = await fetchFullFileContent({ host, projectKey, repositorySlug, filePath, commit: contentCommit, headers });
-      if (content !== null) aiFiles.push({ filePath, type: change.type, content });
+      aiFiles.push({ filePath, type: change.type, content: formatDiffForAi(hunks || []) });
 
       reviewFiles.push({ filePath, type: change.type, content: content || '', diffLines: getDiffLineMetadata(hunks), issues: fileIssues });
       if (fileIssues.length > 0) {