buddy-workbench 0.1.59 → 0.1.60

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "buddy-workbench",
-  "version": "0.1.59",
+  "version": "0.1.60",
   "private": false,
   "type": "module",
   "bin": {

package/server/routes/updates.js

@@ -83,19 +83,26 @@ function buildReleaseList(metadata) {
 }
 
 async function readNpmPackageMetadata() {
-  const npmCommand = process.platform === 'win32' ? 'npm.cmd' : 'npm';
-  const { stdout } = await execFileAsync(
-    npmCommand,
-    ['view', `${PACKAGE_NAME}@latest`, 'version', 'time', 'devbuddyChangelog', '--json'],
-    {
-      timeout: 8000,
-      maxBuffer: 1024 * 1024,
-      shell: process.platform === 'win32',
-      windowsHide: true
-    }
-  );
-  const metadata = JSON.parse(stdout);
-  if (!metadata || typeof metadata !== 'object' || !metadata.version) {
+  // Do not depend on npm being present in the server process PATH. On Windows,
+  // a UI launched from a shortcut often has a reduced PATH and `npm.cmd view`
+  // fails even though npm works in an interactive terminal.
+  const registry = String(process.env.npm_config_registry || 'https://registry.npmjs.org/')
+    .trim()
+    .replace(/\/+$/, '');
+  const response = await fetch(`${registry}/${encodeURIComponent(PACKAGE_NAME)}`, {
+    headers: { Accept: 'application/json' },
+    signal: AbortSignal.timeout(8000)
+  });
+  if (!response.ok) {
+    throw new Error(`The configured npm registry returned HTTP ${response.status}.`);
+  }
+  const packageMetadata = await response.json();
+  const metadata = {
+    version: packageMetadata?.['dist-tags']?.latest,
+    time: packageMetadata?.time,
+    devbuddyChangelog: packageMetadata?.devbuddyChangelog
+  };
+  if (!metadata.version) {
     throw new Error('The configured npm registry did not return package version metadata.');
   }
   return metadata;
@@ -157,17 +164,19 @@ process.exitCode = failed ? 1 : 0;`;
 
 router.get('/', async (req, res) => {
   const forceRefresh = req.query.refresh === '1';
-  if (!forceRefresh && cachedResult && Date.now() - cachedAt < CACHE_TTL_MS) {
+  if (!forceRefresh && cachedResult && !cachedResult.sourceUnavailable && Date.now() - cachedAt < CACHE_TTL_MS) {
     return res.json(cachedResult);
   }
 
   try {
     cachedResult = await checkForUpdates();
+    cachedAt = Date.now();
+    return res.json(cachedResult);
   } catch {
-    cachedResult = unavailableResult();
+    // A transient startup/network failure must not poison the 15-minute cache.
+    // The next normal request should be allowed to try the registry again.
+    return res.json(unavailableResult());
   }
-  cachedAt = Date.now();
-  return res.json(cachedResult);
 });
 
 router.post('/self-update', async (req, res) => {