bt-sensors-plugin-sk 1.2.0-beta.0.1.0 → 1.2.0-beta.0.1.2

package/BTSensor.js

@@ -465,23 +465,24 @@ class BTSensor extends EventEmitter {
 
     deviceConnect() {
 
-        /* CAUTION: HACK AHEAD 
-
-        Bluez for some cockamamie reason (It's 2025 for chrissake. 
-        BLUETOOTH ISN'T JUST FOR DESKTOPS ANYMORE, BLUEZ DEVS!)
-        SUSPENDS scanning while connected to a device.
-
-        The next line of code gives the scanner a kick in the arse, 
-        starting it up again so, I dunno, another device might be able 
-        to connect and sensor classes could maybe get beacon updates.
-
-        You know, the little things.
-      */
+     
         return connectQueue.enqueue( async ()=>{
             this.debug(`Connecting to ${this.getName()}`)
             await this.device.connect()
             try {
 
+               /* CAUTION: HACK AHEAD 
+
+                    Bluez for some cockamamie reason (It's 2025 for chrissake. 
+                    BLUETOOTH ISN'T JUST FOR DESKTOPS ANYMORE, BLUEZ DEVS!)
+                    SUSPENDS scanning while connected to a device.
+
+                    The next line of code gives the scanner a kick in the arse, 
+                    starting it up again so, I dunno, another device might be able 
+                    to connect and sensor classes could maybe get beacon updates.
+
+                    You know, the little things.
+                */
                 await this._adapter.helper.callMethod('StopDiscovery')
                 await this._adapter.helper.callMethod('SetDiscoveryFilter', {
                     Transport: new Variant('s', this._adapter?._transport??"le")
@@ -492,9 +493,13 @@ class BTSensor extends EventEmitter {
                 //probably ignorable error. probably.
                 console.log(e)
             }
+              /* END HACK*/
+              this.device.on("disconnect", ()=>{
+                this.debug(`${this.macAndName()} disconnected`)
+            })        
         })
-    /* END HACK*/
-  }
+
+}
 
     /**
      * 
@@ -771,7 +776,9 @@ class BTSensor extends EventEmitter {
 
     async stopListening(){
         this.removeAllListeners()
+        this.device.removeAllListeners()
         this.device.helper.removeListeners()
+ 
         if (this.intervalID){
             clearInterval(this.intervalID)
         }

package/README.md

@@ -1,6 +1,13 @@
 # Bluetooth Sensors for [Signal K](http://www.signalk.org)
 
 ## What's New
+## 1.2.0-beta-0.1.2
+
+SSE deregister fix (long story)
+
+## 1.2.0-beta-0.1.1
+
+Gobius fix for inclination path, id parameter.
 
 ## 1.2.0-beta-0.1.0
 

package/index.js

@@ -125,6 +125,7 @@ module.exports =   function (app) {
 	var discoveryIntervalID, progressID, progressTimeoutID, deviceHealthID
 	var adapter 
 	const channel = createChannel()
+
 	const classMap = loadClassMap(app)
 	const sensorMap=new Map()
 
@@ -248,17 +249,20 @@ module.exports =   function (app) {
 			  });
 			
 			router.get('/getPluginState', async (req, res) => {
-		
 				res.status(200).json({
+					"connectionId": Date.now(),
 					"state":(plugin.started?"started":"stopped")
 				})
 			});
 			router.get("/sse", async (req, res) => {
-				const session = await createSession(req, res);
+				const session = await createSession(req,res)
 				channel.register(session)
-		   });
-	
-
+				req.on("close", ()=>{
+					app.debug("deregistering session")
+					channel.deregister(session)	
+				})
+			});
+		
 		};
 
 		function sensorsToJSON(){
@@ -339,18 +343,22 @@ module.exports =   function (app) {
 				if (startNumber != starts ) {
 					return
 				}
-				//app.debug(`Found ${config.mac_address}`)
 				s = await instantiateSensor(device,config) 
-	
+				//app.debug(`Instantiated ${config.mac_address}`)
+				
 				if (s instanceof BLACKLISTED)
 					reject ( `Device is blacklisted (${s.reasonForBlacklisting()}).`)
 				else{
+					//app.debug(`Adding sensor to list ${config.mac_address}`)
+				
 					addSensorToList(s)
 					s._lastRSSI=-1*Infinity
 					s.on("RSSI",(()=>{
-						if (Date.now()-s._lastRSSI > 20000) { //only update RSSI on client every five seconds
-							//app.debug(`${s.getMacAddress()} ${Date.now()-s._lastRSSI}`) 
+						if (Date.now()-s._lastRSSI > 30000) { //only update RSSI on client every 30 seconds
+							//app.debug(`Updating ${s.getMacAddress()} RSSI after ${Date.now()-s._lastRSSI} ms`) 
+
 							s._lastRSSI=Date.now()
+				
 							updateSensor(s)
 						}	
 
@@ -524,8 +532,9 @@ module.exports =   function (app) {
 		}
 	
 		sensorMap.clear()
-		if (channel)
+		if (channel){
 			channel.broadcast({state:"started"},"pluginstate")
+		}
 		deviceConfigs=options?.peripherals??[]
 
 		if (plugin.stopped) {
@@ -591,7 +600,7 @@ module.exports =   function (app) {
 				const dt = config?.discoveryTimeout??options.discoveryTimeout
 				const lc=sensor.elapsedTimeSinceLastContact()
 				if (lc > dt) { 
-					app.debug(`${sensor.getMacAddress()} not heard from in ${lc} seconds`)
+					//app.debug(`${sensor.getMacAddress()} not heard from in ${lc} seconds`)
 					channel.broadcast(getSensorInfo(sensor), "sensorchanged")
 				}
 			})

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "bt-sensors-plugin-sk",
-  "version": "1.2.0-beta.0.1.0",
+  "version": "1.2.0-beta.0.1.2",
   "description": "Bluetooth Sensors for Signalk -- support for Victron devices, RuuviTag, Xiaomi, ATC and Inkbird, Ultrasonic wind meters, Mopeka tank readers, Renogy Battery and Solar Controllers, Aranet4 environment sensors, SwitchBot temp and humidity sensors, KilovaultHLXPlus smart batteries, and Govee GVH51xx temp sensors",
   "main": "index.js",
   "dependencies": {
@@ -10,9 +10,8 @@
     "better-sse": "^0.14.1",
     "dbus-next": "^0.10.2",
     "int24": "^0.0.1",
-    "kaitai-struct": "^0.10.0",
+    "kaitai-struct": "^0.10.0", 
     "node-ble": "^1.13.0",
-    "rimraf": "^6.0.1",
     "semver": "^7.7.1"
   },
   "devDependencies": {

package/public/159.js

@@ -1 +1 @@
-"use strict";(self.webpackChunkbt_sensors_plugin_sk=self.webpackChunkbt_sensors_plugin_sk||[]).push([[159],{2995:(e,t,n)=>{n.r(t),n.d(t,{default:()=>A});var a=n(3490),s=n(4810),o=n(4147),r=n.n(o),l=n(7606),c=n(6452),i=n(3768),u=n(1431),g=n(9676),d=n(7041),m=n(3657),f=n(5027),p=n(3540),h=n(4712),E=n(5056),w=n(6890),S=n(3399);const v=e=>console.log.bind(console,e);var y,b={};const A=e=>{const[t,n]=(0,o.useState)({}),[A,D]=(0,o.useState)({}),[$,_]=(0,o.useState)({}),[k,x]=(0,o.useState)({"ui:submitButtonOptions":{props:{disabled:!1,className:"btn btn-info"},norender:!0,submitText:"Submit"}}),[C,T]=(0,o.useState)([]),[j,M]=(0,o.useState)(),[O,N]=(0,o.useState)(new Map),[B,U]=(0,o.useState)({progress:0,maxTimeout:100,deviceCount:0,totalDevices:0}),[J,L]=(0,o.useState)("unknown"),[P,K]=(0,o.useState)();function z(e,t){console.log(`sending ${e}`),console.log(t);const n=new Headers;return n.append("Content-Type","application/json"),fetch(`/plugins/bt-sensors-plugin-sk/${e}`,{credentials:"include",method:"POST",body:JSON.stringify(t),headers:n})}async function H(e){return console.log(`fetching ${e}`),fetch(`/plugins/bt-sensors-plugin-sk/${e}`,{credentials:"include"})}async function I(){console.log("getProgress");const e=await H("getProgress");if(200!=e.status)throw new Error(`Unable get progres: ${e.statusText} (${e.status}) `);const t=await e.json();return console.log(t),t}function R(){console.log("refreshing sensor map"),async function(){console.log("getSensors");const e=await H("getSensors");if(200!=e.status)throw new Error(`Unable get sensor data: ${e.statusText} (${e.status}) `);const t=await e.json();return console.log(t),t}().then((e=>{N(new Map(e.map((e=>[e.info.mac,e]))))})).catch((e=>{K(e)}))}function W(e){return Object.keys(e.config).length>0}function Y(e){const t=W(e);return r().createElement(w.A,{action:!0,onClick:()=>{e.config.mac_address=e.info.mac,_(e.schema),M(e.config)}},r().createElement("div",{class:"d-flex justify-content-between align-items-center",style:t?{fontWeight:"normal"}:{fontStyle:"italic"}},`${e._changesMade?"*":""}${e.info.name} MAC: ${e.info.mac} RSSI: ${n=e.info.RSSI,null==n?NaN:n}`,r().createElement("div",{class:"d-flex justify-content-between "},function(e){return null==e.info.lastContactDelta||e.info.lastContactDelta>e.config.discoveryTimeout?r().createElement(i.A,null):e.info.signalStrength>80?r().createElement(u.A,null):e.info.signalStrength>60?r().createElement(g.A,null):e.info.signalStrength>40?r().createElement(d.A,null):e.info.signalStrength>20?r().createElement(m.A,null):r().createElement(f.A,null)}(e))));var n}return(0,o.useEffect)((()=>{console.log("useEffect([])"),H("getPluginState").then((async e=>{if(404==e.status)throw L("unknown"),new Error("unable to get plugin state");const t=await e.json();L(t.state),await async function(){console.log("getDomains");const e=await H("getDomains");if(200!=e.status)throw new Error(`Unable get domain data: ${e.statusText} (${e.status}) `);const t=await e.json();return console.log(t),t}(),console.log("Setting up eventsource");const n=new EventSource("/plugins/bt-sensors-plugin-sk/sse");return n.addEventListener("newsensor",(e=>{console.log("newsensor");let t=JSON.parse(e.data);y.has(t.info.mac)||(console.log(`New sensor: ${t.info.mac}`),N(new Map(y.set(t.info.mac,t))))})),n.addEventListener("sensorchanged",(e=>{let t=JSON.parse(e.data);if(console.log("sensorchanged"),console.log(t),y.has(t.mac)){let e=y.get(t.mac);Object.assign(e.info,t),N(new Map(y))}})),n.addEventListener("progress",(e=>{console.log("progress");const t=JSON.parse(e.data);U(t),console.log(t)})),n.addEventListener("pluginstate",(e=>{console.log("pluginstate");const t=JSON.parse(e.data);L(t.state)})),()=>n.close()})).catch((e=>{K(e)}))}),[]),(0,o.useEffect)((()=>{console.log("useEffect([pluginState])"),"started"==J?(R(),async function(){console.log("getBaseData");const e=await H("getBaseData");if(200!=e.status)throw new Error(`Unable get base data: ${e.statusText} (${e.status}) `);const t=await e.json();return console.log(t),t}().then((e=>{n(e.schema),D(e.data)})).catch((e=>{K(e)})),I().then((e=>{U(e)})).catch((e=>{K(e)}))):(N(new Map),n({}),D({}))}),[J]),(0,o.useEffect)((()=>{console.log("useEffect([sensorMap])"),y=O;const e=new Set(O.entries().map((e=>e[1].info.domain))),t={_configured:Array.from(O.entries()).filter((e=>W(e[1]))).map((e=>Y(O.get(e[0]))))};e.forEach((e=>{var n;t[e]=(n=e,Array.from(O.entries()).filter((e=>e[1].info.domain===n))).map((e=>Y(O.get(e[0]))))})),b=t}),[O]),"stopped"==J||"unknown"==J?r().createElement("h1",null,"Enable plugin to see configuration (if plugin is Enabled and you're seeing this message, restart SignalK)"):r().createElement("div",null,P?r().createElement("h2",{style:"color: red;"},P):"",r().createElement(a.Ay,{schema:t,validator:s.Ay,onChange:e=>D(e.formData),onSubmit:({formData:e},t)=>{var n;n=e,console.log("updateBaseData"),z("updateBaseData",n).then((e=>{200!=e.status?K(new Error(`Unable to update base data: ${e.statusText} (${e.status})`)):(I().then((e=>{U(e)})).catch((e=>{K(e)})),R())})),_({})},onError:v("errors"),formData:A}),r().createElement("p",null),r().createElement("p",null),B.deviceCount<B.totalDevices?r().createElement(S.A,{max:B.maxTimeout,now:B.progress}):"",r().createElement("h2",null,O.size>0?"Bluetooth Devices - Select to configure":""),r().createElement("h2",null,O.size>0?"(* = sensor has unsaved changes)":""),r().createElement("p",null),r().createElement(h.A,{defaultActiveKey:"_configured",id:"domain-tabs",className:"mb-3"},Object.keys(b).map((e=>{return n=(t=e).slice("_"===t.charAt(0)?1:0),r().createElement(E.A,{eventKey:t,title:n.charAt(0).toUpperCase()+n.slice(1)},r().createElement("div",{style:{paddingBottom:20},class:"d-flex flex-wrap justify-content-start align-items-start"},r().createElement(p.A,{style:{maxHeight:"300px",overflowY:"auto"}},function(e){return b[e]}(t)),r().createElement("div",{style:{paddingLeft:10,paddingTop:10,display:0==Object.keys($).length?"none":""}},r().createElement(a.Ay,{schema:$,validator:s.Ay,uiSchema:k,onChange:e=>{O.get(e.formData.mac_address)._changesMade=!0,M(e.formData)},onSubmit:({formData:e},t)=>{var n;console.log(e),n=e,console.log("updateSensorData"),z("updateSensorData",n).then((e=>{if(200!=e.status)throw new Error(e.statusText);O.get(n.mac_address)._changesMade=!1,O.get(n.mac_address).config=n})),_({}),alert("Changes saved")},onError:v("errors"),formData:j},r().createElement("div",null,r().createElement(l.A,{direction:"row",style:{spacing:5}},r().createElement(c.A,{type:"submit",color:"primary",variant:"contained"},"Save"),r().createElement(c.A,{variant:"contained",onClick:()=>{var e;e=j.mac_address,console.log("undoChanges"),O.get(e)._changesMade=!1,M(O.get(e).config)}},"Undo"),r().createElement(c.A,{variant:"contained",color:"secondary",onClick:e=>{return t=j.mac_address,void(window.confirm(`Delete configuration for ${t}?`)&&function(e){console.log("removeSensorData");try{z("removeSensorData",{mac_address:e}).then((e=>{if(200!=e.status)throw new Error(e.statusText)})),y.delete(e),N(new Map(y)),_({})}catch{}}(t));var t}},"Delete")))))));var t,n}))))}}}]);
+"use strict";(self.webpackChunkbt_sensors_plugin_sk=self.webpackChunkbt_sensors_plugin_sk||[]).push([[159],{2995:(e,t,n)=>{n.r(t),n.d(t,{default:()=>A});var a=n(3490),s=n(4810),o=n(4147),r=n.n(o),l=n(7606),c=n(6452),i=n(3768),u=n(1431),g=n(9676),d=n(7041),m=n(3657),f=n(5027),p=n(3540),h=n(4712),E=n(5056),w=n(6890),S=n(3399);const v=e=>console.log.bind(console,e);var y,b={};const A=e=>{const[t,n]=(0,o.useState)({}),[A,D]=(0,o.useState)({}),[$,_]=(0,o.useState)({}),[k,C]=(0,o.useState)({"ui:submitButtonOptions":{props:{disabled:!1,className:"btn btn-info"},norender:!0,submitText:"Submit"}}),[x,T]=(0,o.useState)([]),[j,M]=(0,o.useState)(),[O,N]=(0,o.useState)(new Map),[B,U]=(0,o.useState)({progress:0,maxTimeout:100,deviceCount:0,totalDevices:0}),[J,L]=(0,o.useState)("unknown"),[P,K]=(0,o.useState)();function z(e,t){console.log(`sending ${e}`),console.log(t);const n=new Headers;return n.append("Content-Type","application/json"),fetch(`/plugins/bt-sensors-plugin-sk/${e}`,{credentials:"include",method:"POST",body:JSON.stringify(t),headers:n})}async function H(e){return console.log(`fetching ${e}`),fetch(`/plugins/bt-sensors-plugin-sk/${e}`,{credentials:"include"})}async function I(){console.log("getProgress");const e=await H("getProgress");if(200!=e.status)throw new Error(`Unable get progres: ${e.statusText} (${e.status}) `);const t=await e.json();return console.log(t),t}function R(){console.log("refreshing sensor map"),async function(){console.log("getSensors");const e=await H("getSensors");if(200!=e.status)throw new Error(`Unable get sensor data: ${e.statusText} (${e.status}) `);const t=await e.json();return console.log(t),t}().then((e=>{N(new Map(e.map((e=>[e.info.mac,e]))))})).catch((e=>{K(e)}))}function W(e){return Object.keys(e.config).length>0}function Y(e){const t=W(e);return r().createElement(w.A,{action:!0,onClick:()=>{e.config.mac_address=e.info.mac,_(e.schema),M(e.config)}},r().createElement("div",{class:"d-flex justify-content-between align-items-center",style:t?{fontWeight:"normal"}:{fontStyle:"italic"}},`${e._changesMade?"*":""}${e.info.name} MAC: ${e.info.mac} RSSI: ${n=e.info.RSSI,null==n?NaN:n}`,r().createElement("div",{class:"d-flex justify-content-between "},function(e){return null==e.info.lastContactDelta||e.info.lastContactDelta>e.config.discoveryTimeout?r().createElement(i.A,null):e.info.signalStrength>80?r().createElement(u.A,null):e.info.signalStrength>60?r().createElement(g.A,null):e.info.signalStrength>40?r().createElement(d.A,null):e.info.signalStrength>20?r().createElement(m.A,null):r().createElement(f.A,null)}(e))));var n}return(0,o.useEffect)((()=>{console.log("useEffect([])");let e=null;return H("getPluginState").then((async t=>{if(404==t.status)throw L("unknown"),new Error("unable to get plugin state");const n=await t.json();console.log("Setting up eventsource"),e=new EventSource("/plugins/bt-sensors-plugin-sk/sse",{withCredentials:!0}),L(n.state),await async function(){console.log("getDomains");const e=await H("getDomains");if(200!=e.status)throw new Error(`Unable get domain data: ${e.statusText} (${e.status}) `);const t=await e.json();return console.log(t),t}(),e.addEventListener("newsensor",(e=>{console.log("newsensor");let t=JSON.parse(e.data);y.has(t.info.mac)||(console.log(`New sensor: ${t.info.mac}`),N(new Map(y.set(t.info.mac,t))))})),e.addEventListener("sensorchanged",(e=>{let t=JSON.parse(e.data);if(console.log("sensorchanged"),console.log(t),y.has(t.mac)){let e=y.get(t.mac);Object.assign(e.info,t),N(new Map(y))}})),e.addEventListener("progress",(e=>{console.log("progress");const t=JSON.parse(e.data);U(t),console.log(t)})),e.addEventListener("pluginstate",(e=>{console.log("pluginstate");const t=JSON.parse(e.data);L(t.state)}))})).catch((e=>{K(e)})),()=>{console.log("Closing connection to SSE"),e.close()}}),[]),(0,o.useEffect)((()=>{console.log("useEffect([pluginState])"),"started"==J?(R(),async function(){console.log("getBaseData");const e=await H("getBaseData");if(200!=e.status)throw new Error(`Unable get base data: ${e.statusText} (${e.status}) `);const t=await e.json();return console.log(t),t}().then((e=>{n(e.schema),D(e.data)})).catch((e=>{K(e)})),I().then((e=>{U(e)})).catch((e=>{K(e)}))):(N(new Map),n({}),D({}))}),[J]),(0,o.useEffect)((()=>{console.log("useEffect([sensorMap])"),y=O;const e=new Set(O.entries().map((e=>e[1].info.domain))),t={_configured:Array.from(O.entries()).filter((e=>W(e[1]))).map((e=>Y(O.get(e[0]))))};e.forEach((e=>{var n;t[e]=(n=e,Array.from(O.entries()).filter((e=>e[1].info.domain===n))).map((e=>Y(O.get(e[0]))))})),b=t}),[O]),"stopped"==J||"unknown"==J?r().createElement("h1",null,"Enable plugin to see configuration (if plugin is Enabled and you're seeing this message, restart SignalK)"):r().createElement("div",null,P?r().createElement("h2",{style:"color: red;"},P):"",r().createElement(a.Ay,{schema:t,validator:s.Ay,onChange:e=>D(e.formData),onSubmit:({formData:e},t)=>{var n;n=e,console.log("updateBaseData"),z("updateBaseData",n).then((e=>{200!=e.status?K(new Error(`Unable to update base data: ${e.statusText} (${e.status})`)):(I().then((e=>{U(e)})).catch((e=>{K(e)})),R())})),_({})},onError:v("errors"),formData:A}),r().createElement("p",null),r().createElement("p",null),B.deviceCount<B.totalDevices?r().createElement(S.A,{max:B.maxTimeout,now:B.progress}):"",r().createElement("h2",null,O.size>0?"Bluetooth Devices - Select to configure":""),r().createElement("h2",null,O.size>0?"(* = sensor has unsaved changes)":""),r().createElement("p",null),r().createElement(h.A,{defaultActiveKey:"_configured",id:"domain-tabs",className:"mb-3"},Object.keys(b).map((e=>{return n=(t=e).slice("_"===t.charAt(0)?1:0),r().createElement(E.A,{eventKey:t,title:n.charAt(0).toUpperCase()+n.slice(1)},r().createElement("div",{style:{paddingBottom:20},class:"d-flex flex-wrap justify-content-start align-items-start"},r().createElement(p.A,{style:{maxHeight:"300px",overflowY:"auto"}},function(e){return b[e]}(t)),r().createElement("div",{style:{paddingLeft:10,paddingTop:10,display:0==Object.keys($).length?"none":""}},r().createElement(a.Ay,{schema:$,validator:s.Ay,uiSchema:k,onChange:e=>{O.get(e.formData.mac_address)._changesMade=!0,M(e.formData)},onSubmit:({formData:e},t)=>{var n;console.log(e),n=e,console.log("updateSensorData"),z("updateSensorData",n).then((e=>{if(200!=e.status)throw new Error(e.statusText);O.get(n.mac_address)._changesMade=!1,O.get(n.mac_address).config=n})),_({}),alert("Changes saved")},onError:v("errors"),formData:j},r().createElement("div",null,r().createElement(l.A,{direction:"row",style:{spacing:5}},r().createElement(c.A,{type:"submit",color:"primary",variant:"contained"},"Save"),r().createElement(c.A,{variant:"contained",onClick:()=>{var e;e=j.mac_address,console.log("undoChanges"),O.get(e)._changesMade=!1,M(O.get(e).config)}},"Undo"),r().createElement(c.A,{variant:"contained",color:"secondary",onClick:e=>{return t=j.mac_address,void(window.confirm(`Delete configuration for ${t}?`)&&function(e){console.log("removeSensorData");try{z("removeSensorData",{mac_address:e}).then((e=>{if(200!=e.status)throw new Error(e.statusText)})),y.delete(e),N(new Map(y)),_({})}catch{}}(t));var t}},"Delete")))))));var t,n}))))}}}]);

package/sensor_classes/ATC.js

@@ -25,7 +25,7 @@ class ATC extends BTSensor{
                 title:'data parsing strategy',
                 type: 'string',
                 enum:["ATC-LE","ATC-BE"],
-                default: ["ATC-LE"]
+                default: "ATC-LE"
             }
         )
         if (!this.parser){
@@ -66,9 +66,12 @@ class ATC extends BTSensor{
         super.propertiesChanged(props)    
         if (!props.hasOwnProperty("ServiceData")) return
 
-        const buff = this.getServiceData("0000181a-0000-1000-8000-00805f9b34fb")
+        var buff = this.getServiceData("0000181a-0000-1000-8000-00805f9b34fb")
         if (!buff)
-            throw new Error("Unable to get service data for "+this.getDisplayName())
+            buff = this.getServiceData("0000fcd2-0000-1000-8000-00805f9b34fb")
+            if (!buff)
+                throw new Error("Unable to get service data for "+this.getDisplayName())
+            
         this.emitData("temp", buff)
         this.emitData("humidity", buff)
         this.emitData("voltage", buff)

package/sensor_classes/GobiusCTankMeter.js

@@ -295,7 +295,8 @@ class GobiusCTankMeter extends BTSensor{
               ]
         })
 
-        this.addDefaultPath("id")
+        this.addDefaultParam("id")
+                .default="1"
 
         this.addMetadatum("mst","","Device state",
             (buffer)=>{return GobiusState.get(buffer.readInt8(0))}
@@ -319,7 +320,7 @@ class GobiusCTankMeter extends BTSensor{
         .default='tanks.{type}.{id}.currentLevel'
 
         this.addMetadatum("minc","rad","Sensor inclination",
-            (buffer)=>{return buffer.readInt8(5) * Math.pi/180}
+            (buffer)=>{return buffer.readInt8(5) * Math.PI/180}
         )
         .default='tanks.{type}.{id}.inclination'
 

package/sensor_classes/MopekaTankSensor.js

@@ -209,7 +209,7 @@ class MopekaDevice{
     }
 }
     
-MopekaDevices = new Map()
+const MopekaDevices = new Map()
 MopekaDevices.set()
     .set (0x0, new MopekaDevice("XXXX","Unknown Mopeka device"))
     .set (0x3, new MopekaDevice("M1017", "Pro Check"))

package/src/components/PluginConfigurationPanel.js

@@ -50,6 +50,7 @@ export default (props) => {
   const [pluginState, setPluginState ] = useState("unknown")
   const [error, setError ] = useState()
 
+
   function sendJSONData(cmd, data){
 
     console.log(`sending ${cmd}`)
@@ -188,20 +189,21 @@ export default (props) => {
 
   useEffect(()=>{
     console.log("useEffect([])")
+    let eventSource=null
+
     fetchJSONData("getPluginState").then( async (response)=> {
       if (response.status==404) {
         setPluginState("unknown")
         throw new Error("unable to get plugin state")
       }
       const json = await response.json()
-      setPluginState(json.state)
+      console.log("Setting up eventsource")
+      eventSource = new EventSource("/plugins/bt-sensors-plugin-sk/sse", { withCredentials: true })
 
+      setPluginState(json.state)
       
       _sensorDomains = await getDomains()
 
-      console.log("Setting up eventsource")
-      const eventSource = new EventSource("/plugins/bt-sensors-plugin-sk/sse")
-      
       eventSource.addEventListener("newsensor", (event) => {
         console.log("newsensor")
         let json = JSON.parse(event.data)
@@ -235,14 +237,18 @@ export default (props) => {
         const json = JSON.parse(event.data)  
         setPluginState(json.state)
       });
-      return () => eventSource.close();
+     
     })
 
     .catch( (e) => { 
         setError(e)
       }
-    )      
-},[])
+    )
+    return () => { 
+      console.log("Closing connection to SSE")
+      eventSource.close()
+    };
+ },[])
 
 useEffect(()=>{
   console.log("useEffect([pluginState])")