bt-sensors-plugin-sk 1.1.0-beta.1 → 1.1.0-beta.2.1

package/BTSensor.js

@@ -10,10 +10,15 @@ const BTCompanies = require('./bt_co.json')
  */
 
 const BTCompanyMap=new Map()
+
 BTCompanies.company_identifiers.forEach( (v) =>{
     BTCompanyMap.set(v.value, v.name)
 })
 
+/**
+ * https://www.intuitibits.com/2016/03/23/dbm-to-percent-conversion/
+ */
+
 function signalQualityPercentQuad(rssi, perfect_rssi=-20, worst_rssi=-85) {
     const nominal_rssi=(perfect_rssi - worst_rssi);
     var signal_quality =
@@ -31,6 +36,7 @@ function signalQualityPercentQuad(rssi, perfect_rssi=-20, worst_rssi=-85) {
     }
     return Math.ceil(signal_quality);
 }
+
 class BTSensor extends EventEmitter {
     static metadata=new Map()
     constructor(device, config={}, gattConfig={}) {
@@ -84,35 +90,58 @@ class BTSensor extends EventEmitter {
             }
         }  
 
-    static getMetadata(){
-        return this.metadata
-    }
-
-    static {
-        var md = this.addMetadatum("name", "string","Name of sensor" )
-        md.isParam=true
-
-
+  
+        static async getPropsProxy(device){
+        
+            if (!device._propsProxy) {
+                const objectProxy  = await device.helper.dbus.getProxyObject(device.helper.service, device.helper.object)
+                device._propsProxy = await objectProxy.getInterface('org.freedesktop.DBus.Properties')
+            }
+            return device._propsProxy 
+        }
+        static async getDeviceProps(device, propNames=[]){
+            const _propsProxy = await this.getPropsProxy(device)
+            const rawProps = await _propsProxy.GetAll(device.helper.iface)
+            const props = {}
+            for (const propKey in rawProps) {
+                if (propNames.length==0 || propNames.indexOf(propKey)>=0)
+                    props[propKey] = rawProps[propKey].value
+            }
+            return props
+        }
+        static async getDeviceProp(device, prop){
+            const _propsProxy = await this.getPropsProxy(device)
+            try{
+                const rawProps = await _propsProxy.Get(device.helper.iface,prop)
+                return rawProps?.value
+            }
+            catch(e){
+                return null //Property $prop (probably) doesn't exist in $device
+            }
+        }  
         
-    }
-    static addMetadatum(tag, ...args){
-        var metadatum = new this.Metadatum(tag, ...args)
-        this.getMetadata().set(tag,metadatum)
-        return metadatum
-    }
     
-    emitData(tag, buffer, ...args){
-        this.emit(tag, this.getMetadatum(tag).read(buffer, ...args))
+    static async getManufacturerID(device){
+        const md = await this.getDeviceProp(device,'ManufacturerData')
+        if (!md) return null 
+        const keys = Object.keys(md)
+        if (keys && keys.length>0){
+            return parseInt(keys[0])
+        }
+        return null
     }
+    static NaNif(v1,v2) {  return (v1==v2)?NaN:v1 }
     
     async init(){
+        var md = this.addMetadatum("name", "string","Name of sensor" )
+        md.isParam=true
         this.currentProperties = await this.constructor.getDeviceProps(this.device)
         this.addMetadatum("RSSI","db","Signal strength in db")
         this.getMetadatum("RSSI").default=`sensors.${this.getMacAddress().replaceAll(':', '')}.rssi`
         this.getMetadatum("RSSI").read=()=>{return this.getRSSI()}
         this.getMetadatum("RSSI").read.bind(this)
-        if (this.canUseGATT()) {
-            var md = this.addMetadatum("useGATT", "boolean", "Use GATT connection")
+        if (this.hasGATT()) {
+            md = this.addMetadatum("useGATT", "boolean", "Use GATT connection")
             md.type="boolean"
             md.isParam=true
             md.isGATT=true
@@ -123,21 +152,9 @@ class BTSensor extends EventEmitter {
             md.isGATT=true
         }
     }
-
-    static async getManufacturerID(device){
-        const md = await this.getDeviceProp(device,'ManufacturerData')
-        if (!md) return null 
-        const keys = Object.keys(md)
-        if (keys && keys.length>0){
-            return parseInt(keys[0])
-        }
-        return null
-    }
-    static NaNif(v1,v2) {  return (v1==v2)?NaN:v1 }
     
     NaNif(v1,v2) {  return this.constructor.NaNif(v1,v2) }
 
-
     addMetadatum(tag, ...args){
         var metadatum = new this.Metadatum(tag, ...args)
         this.getMetadata().set(tag, metadatum)
@@ -193,6 +210,8 @@ class BTSensor extends EventEmitter {
         return bars 
 
     }
+
+
     getDescription(){
         return `${this.getName()} from ${this.getManufacturer()}`
     }
@@ -213,7 +232,7 @@ class BTSensor extends EventEmitter {
     getRSSI(){
         return this.currentProperties?.RSSI??NaN
     }
-    canUseGATT(){
+    hasGATT(){
         return false
     }
     usingGATT(){
@@ -226,35 +245,10 @@ class BTSensor extends EventEmitter {
             return obj
         
     }
-
-    static async getPropsProxy(device){
-        
-        const objectProxy  = await device.helper.dbus.getProxyObject(device.helper.service, device.helper.object)
-        if (!device._propsProxy)
-            device._propsProxy = await objectProxy.getInterface('org.freedesktop.DBus.Properties')
-        return device._propsProxy 
-    }
-    static async getDeviceProps(device, propNames=[]){
-        const _propsProxy = await this.getPropsProxy(device)
-        const rawProps = await _propsProxy.GetAll(device.helper.iface)
-        const props = {}
-        for (const propKey in rawProps) {
-            if (propNames.length==0 || propNames.indexOf(propKey)>=0)
-                props[propKey] = rawProps[propKey].value
-        }
-        return props
+    emitData(tag, buffer, ...args){
+        this.emit(tag, this.getMetadatum(tag).read(buffer, ...args))
     }
-    static async getDeviceProp(device, prop){
-        const _propsProxy = await this.getPropsProxy(device)
-        try{
-            const rawProps = await _propsProxy.Get(device.helper.iface,prop)
-            return rawProps?.value
-        }
-        catch(e){
-            return null //Property $prop (probably) doesn't exist in $device
-        }
-    }  
-    
+
 /**
  * callback function on device properties changing
  */
@@ -294,9 +288,13 @@ class BTSensor extends EventEmitter {
         const id = this.getManufacturerID()
         return (id==null)?"Unknown manufacturer":BTCompanyMap.get(parseInt(id))
     }
-    getManufacturerData(key){
+
+    getManufacturerData(key=null){
         if (this.currentProperties.ManufacturerData)
-            return this.valueIfVariant (this.currentProperties.ManufacturerData[key])
+            if (key)
+                return this.valueIfVariant (this.currentProperties.ManufacturerData[key])
+            else
+                return(this.valueIfVariant (this.currentProperties.ManufacturerData))                
         else
             return null
     }

package/README.md

@@ -5,49 +5,45 @@
 
 BT Sensors Plugin for Signalk is a lightweight BLE (Bluetooth Low Energy) framework for connecting to Bluetooth sensors on your boat and sending deltas to Signalk paths with the values the sensors reports. <br>
 
-A typical use case is a Bluetooth thermometer like the Xiaomi LYWSD03MMC, an inexpensive Bluetooth thermometer that runs on a 3V watch battery that can report the current temperature and humidity in your refrigerator or cabin or wherever you want to stick it (no judgement.) <br>
+The Plugin currently supports every documented Victron device (AC Charger, Battery Monitor, DC-DC Converter, DC Energy Meter, GX Device, Inverter, Inverter RS, Lynx Smart BMS, Orion XS, Smart Battery Protect, Smart Lithium and VE Bus),  Xiaomi devices, [ATC devices](https://github.com/atc1441/ATC_MiThermometer), RuuviTags and Inkbird thermometers.
 
-The reported temperature can then be displayed on a Signalk app like Kip or, with appropiate mapping to NMEA-2000, a NMEA 2000 Multi-function display. 
+A typical use case is a Bluetooth thermometer like the Xiaomi LYWSD03MMC, an inexpensive Bluetooth thermometer that runs on a 3V watch battery that can report the current temperature and humidity in your refrigerator or cabin or wherever you want to stick it (no judgement.) <br>
 
-The Plugin currently supports the Xiaomi LYWSD03MMC, [ATC](https://github.com/atc1441/ATC_MiThermometer) flashed LYWSD03MMCs, Victron SmartShunt and the Inkbird IBS-TH2 thermometer.
+The reported temperature can then be displayed on a Signalk app like Kip, WilhelmSK or, with appropiate mapping to NMEA-2000, a NMEA 2000 Multi-function display. 
 
-Sounds like meager offerings but it's pretty easy to write and deploy your own sensor class for any currently unsupported sensor. More on that in [the development section](#development).
+It's pretty easy to write and deploy your own sensor class for any currently unsupported sensor. More on that in [the development README](./sensor_classes/DEVELOPMENT.md).
 
 ## WHO IS IT FOR
 
-Signalk users with a Linux boat-puter (Windows and MacOS are NOT supported) and Bluetooth sensors they'd like to integrate into their Signalk datastream.
-
-## ALTERNATIVES
-
-An [MQTT](https://mqtt.org/) server with an appropriate SK client plugin. There are several MQTT plugin clients in the Signalk appstore. 
-
-Advantages of this plugin over an MQTT server and client plugin are:
-* simplicity of setup
-* reduced overhead on server
-* one less piece of software to maintain on your boat-puter
-* ease of rolling your own sensor classes
-
-The key advantages of an MQTT setup is comprehensive support for BT devices and non-Linux platforms. 
+Signalk users with a Linux boat-puter (Windows and MacOS are NOT currently supported) and Bluetooth sensors they'd like to integrate into their Signalk datastream.
 
 ## REQUIREMENTS
 
-* A  Linux Signalk boat-puter with System-D (NOTE: Most Linux installations support System-D)
+* A Linux Signalk boat-puter with System-D (NOTE: Most Linux installations support System-D)
 * A Bluetooth adapter
 * [Bluez](https://www.bluez.org) installed
 (Go here for [Snap installation instructions](https://snapcraft.io/bluez))
 * [Node-ble](https://www.npmjs.com/package/node-ble) (installs with the plugin)
-* [utilities-sk](https://github.com/naugehyde/utilities-sk)
 
 ## INSTALLATION
+
+NOTE: If you're running the 1.0.3 release, you will have to reconfigure your devices.<br>
+
 ### Signalk Appstore
-This will be the recommended installation when the code is ready for wider sharing. In the meantime, use the platform-specific developer install instructions below.
+The plugin is currently available in the Signalk Appstore. <br>
+
+### NPM
+
+See https://www.npmjs.com/package/bt-sensors-plugin-sk/v/1.1.0-beta.2 for more information. 
 
 ### Linux
-From a command prompt:<br>
+
+If you want to install directly from source (this is mostly of interest to custom sensor class developers) execute the following from a command prompt:<br>
 
 <pre>  cd ~/[some_dir]
   git clone https://github.com/naugehyde/bt-sensors-plugin-sk
   cd bt-sensors-plugin-sk
+  git switch '1.1.0'
   npm i
   [sudo] npm link
   cd [signalk_home] 
@@ -62,37 +58,38 @@ Finally, restart SK. Plugin should appear in your server plugins list.<br>
 
 After installing and restarting Signalk you should see a "BT Sensors Plugin" option in the Signalk->Server->Plugin Config page.<br><br>
 
-<img width="1135" alt="Screenshot 2024-09-01 at 8 35 34 PM" src="https://github.com/user-attachments/assets/7e5b7d87-92e3-4fcd-8971-95ef6799c62f"><br><br>
-
-On initial configuration, wait 45 seconds (by default) for the Bluetooth device to complete its scan of nearby devices. Until the scan is complete, the Sensors section will be disabled. When the scan is complete your screen should look something like this:<br><br>
+<img width="1130" alt="Screenshot 2024-10-13 at 6 50 09 PM" src="https://github.com/user-attachments/assets/4180504e-1ca8-48af-babf-899486fb0a24"><br><br>
 
-<img width="378" alt="Screenshot 2024-08-30 at 11 21 39 AM" src="https://github.com/user-attachments/assets/6e24b880-7ee7-4deb-9608-fb42d9db74f7"><br><br>
+On initial configuration, wait for your Bluetooth adapter to scan devices. The plugin will scan for new devices at whatever you set the "scan for new devices interval" value to. <br><br>
 
-> TIP: If after 45 seconds (or whatever your Initial Scan Timeout is set to) you don't see "Scan completed. Found x Bluetooth devices." atop the config screen and the Sensors section is still disabled, close and re-open the config screen to refresh the screen. The config screen isn't as <i>reactive</i> as it oughtta be.<br><br>
+> TIP: Close and re-open the config screen to refresh the screen. The config screen isn't as <i>reactive</i> as it oughtta be.<br><br>
 
-Then press the + button to add a sensor. Your screen should look like this:<br><br>
+Then press the + button to add a sensor. Your screen should look something like this:<br><br>
+<img width="1122" alt="Screenshot 2024-10-13 at 6 52 52 PM" src="https://github.com/user-attachments/assets/0487b8d0-4bc0-4358-85c6-a507bc3c97d2">
 
-<img width="1116" alt="Screenshot 2024-09-01 at 8 47 53 PM" src="https://github.com/user-attachments/assets/6fdab5cc-ab01-4441-a88f-2753a49aadbd">
 <br><br>
 
-Then select the sensor you want to connect to from the drop down.<br>
+Select the sensor you want to connect to from the drop down.<br>
 
->TIP: If you need to rescan, disable and re-enable the plugin or restart Signalk.<br><br>
+If you don't see your device and you know that it's on and nearby to the server, it may not be currently supported. But fear not, you can add custom sensor classes yourself. (Check out [the development section](#development).). <br><br>
 
-<img width="1109" alt="Screenshot 2024-09-01 at 8 48 04 PM" src="https://github.com/user-attachments/assets/264a8737-8c0e-4b34-a737-e0d834b54b99">
-<br><br>
+Now it's a simple matter of associating the data emitted by the sensor with the Signalk path you want it to update. (Also, you can name your sensor so when it appears in logs its easy to recognize.) <br><br>
+
+<img width="1125" alt="Screenshot 2024-10-13 at 9 30 53 PM" src="https://github.com/user-attachments/assets/5284539e-d5ee-488f-bbab-901258eb1c0b">
+
+The plugin doesn't need for Signalk to restart after submitting your config but restart if that makes you more comfortable. <br><br>
 
-Then select the class of bluetooth device. The class should have a similar name to the device. If you don't see the class for your device, you can develop your own (check out [the development section](#development).). <br><br>
+### ADVERTISED DATA
 
-<img width="1104" alt="Screenshot 2024-09-01 at 8 48 19 PM" src="https://github.com/user-attachments/assets/b55ac065-6c57-48eb-8321-e40138d1ca99"><br><br>
+Most supported Bluetooth sensors broadcast (or advertise) their device's data without an explicit connection. Some devices broadcast their data encrypted. Supported devices with encrypted advertised data will allow you to input the encryption key as a config parameter. NOTE: the encryption key is currently stored on the server in plain text. 
 
-Then it's a simple matter of associating the data emitted by the sensor with the Signalk path you want it to update. In the example pictured here there are three data points (temperature, humidity and sensor voltage). Other classes will expose different data.
+### GATT CONNECTIONS
 
-<img width="1107" alt="Screenshot 2024-09-01 at 8 48 38 PM" src="https://github.com/user-attachments/assets/cb5aeb01-2e9a-44b3-ac3a-401cd7d6c3e7"><br><br>
+If you see something like this on your device config:
 
-Remember to hit the submit button. 
+<img width="727" alt="Screenshot 2024-10-13 at 9 42 26 PM" src="https://github.com/user-attachments/assets/65fe1aa7-99a5-41ac-85dc-cfde00e95932">
 
-The plugin doesn't need for Signalk to restart but restart if that makes you more comfortable.
+You have the option of making a GATT Connection to your device. A GATT Connection is energy-inefficient but serves data from your device in more or less real-time. To learn more about GATT check out: https://learn.adafruit.com/introduction-to-bluetooth-low-energy/gatt
 
 ## NOW WHAT?
 
@@ -100,161 +97,8 @@ You should see data appear in your data browser. Here's a screenshot of Signalk
 
 <img width="1142" alt="Screenshot 2024-09-01 at 9 14 27 PM" src="https://github.com/user-attachments/assets/80abbc1c-e01e-4908-aa1a-eec83679cd7c"><br><br>
 
-You can now take the data and display it using Kip, or route it to NMEA-2K and display it on a N2K MFD, or use it to create and respond to alerts in Node-Red. Life is good. So good.
+You can now take the data and display it using Kip, WilhelmSK or route it to NMEA-2K and display it on a N2K MFD, or use it to create and respond to alerts in Node-Red. Isn't life grand?
 
-# <a name="development"></a>BLUETOOTH SENSOR CLASS DEVELOPMENT
-
-The goal of this project is to support as many mariner-useful sensors as possible. If there's anything we can do to make sensor class development easier, please let us know.<br><br>
-
-## REQUIREMENTS
-
-* programming knowledge, preferably class programming in Nodejs
-* familiarity with [Node-ble](https://www.npmjs.com/package/node-ble) 
-* ideally, the device manufacturer's specification for their bluetooth API
-* failing the above, a willingness to hack or at the very least google aggressively
-
-## PROGRAMMING PROCESS
-
-### Discovery
-
-You'll first need to know what data your sensor produces and the means by which it provides data (GATT Server or advertisement) and the details thereof.<br><br>
-
-The first approach is to see if the device manufacturer has documented this. Not all do. Don't worry if you can't find OEM docs, it's likely someone on the internet has figured out your device's whys and wherefores for you already. Google that thang. <br><br>
-
-If you're still coming up empty, there are any number of tools you can use to examine the Bluetooth data stream of your device. <br><br>
-
-* bluetoothctl (installed with Bluez on Linux)
-* [NRF Connect](https://play.google.com/store/apps/details?id=no.nordicsemi.android.mcp&hl=en_US)
-
-With these tools you can see what data your device advertises, and what data it provides via a connection to its GATT Server. <br><br>
-
-### Coding
-
-#### Get the code
-
-To get the code you'll first need to clone this repository then create a branch. That's git talk. Google it if you don't know what that means.<br>
-
-Once you've done that you're ready for...
-
-#### Actual coding
-
-Below is a simple Device class for the Xiaomi thermometer with stock firmware. The code demonstrates the core responsibilities of a Bluetooth sensor device class in the BT-Sensor-plugin's framework:
-
-* resides in the sensor_classes subdirectory
-* extends the BTSensor class
-* provides metadata for the device's various data points (the static metadata class member)
-* overrides the BTSensor::connect() and disconnect() methods
-* emits values for each data point
-* exports the class
-    
-<pre>const BTSensor = require("../BTSensor");
-
-class LYWSD03MMC extends BTSensor{
-
-    static needsScannerOn(){
-        return false
-    }
-    static metadata = new Map()
-                    .set('temp',{unit:'K', description: 'temperature'})
-                    .set('humidity',{unit:'ratio', description: 'humidity'})
-                    .set('voltage',{unit:'V', description: 'sensor battery voltage'})
-
-    constructor(device){
-        super(device)
-    }
-
-    emitValues(buffer){
-        this.emit("temp",((buffer.readInt16LE(0))/100) + 273.1);
-        this.emit("humidity",buffer.readUInt8(2)/100);
-        this.emit("voltage",buffer.readUInt16LE(3)/1000);
-    }
-
-    async connect() {
-        await this.device.connect()
-        var gattServer = await this.device.gatt()
-        var gattService = await gattServer.getPrimaryService("ebe0ccb0-7a0a-4b0c-8a1a-6ff2997da3a6")
-        var gattCharacteristic = await gattService.getCharacteristic("ebe0ccc1-7a0a-4b0c-8a1a-6ff2997da3a6")
-        this.emitValues(await gattCharacteristic.readValue())
-        await gattCharacteristic.startNotifications();	
-        gattCharacteristic.on('valuechanged', buffer => {
-            this.emitValues(buffer)
-        })
-    }
-    async disconnect(){
-        super.disconnect()
-        await this.device.disconnect()
-    }
-}
-module.exports=LYWSD03MMC</pre>
-
-Most of the work is done in the connect() method. In this case, the connect() method creates a connection to the device:
-<pre>await this.device.connect()</pre> 
-Then it gets the device's gattServer and primary service:
-<pre>
- var gattServer = await this.device.gatt()
- var gattService = await gattServer.getPrimaryService("ebe0ccb0-7a0a-4b0c-8a1a-6ff2997da3a6")
- </pre>
- Then, it requests the device's "characteristic" that will send us data.
- <pre>var gattCharacteristic = await gattService.getCharacteristic("ebe0ccc1-7a0a-4b0c-8a1a-6ff2997da3a6")</pre>
- Then it asks the characteristic for notifications when its value changes.
- <pre>await gattCharacteristic.startNotifications();</pre>
- Then most importantly it emits the values when the data has changed:
- <pre>gattCharacteristic.on('valuechanged', buffer => {
-            this.emitValues(buffer) 
-  })</pre>
-  In this implementation, the emitValues member function does the work of parsing the buffer and emitting the values. 
-  <pre>    
-   emitValues(buffer){
-        this.emit("temp",((buffer.readInt16LE(0))/100) + 273.1);
-        this.emit("humidity",buffer.readUInt8(2)/100);
-        this.emit("voltage",buffer.readUInt16LE(3)/1000);
-   }
-  </pre>
-NOTE: If you guessed that the plugin listens to changes to device objects and then publishes the deltas, you guessed right.
- 
-### All that said
-The problem with Gatt Server devices is they stay connected and eat up a lot of energy, draining your device's batteries. You can deactivate the device from the config screen when it's not in use or in this case you can flash the device with custom firmware that changes the device to a broadcast device that advertises its data obviating the need for a battery-draining connection. In the case of Xiaomi LYWSD03MMC you can flash it with some very useful software called [ATC](https://github.com/atc1441/ATC_MiThermometer?tab=readme-ov-file) </pre>
-
-Below is an example of a BTSensor subclass that uses the advertising protocol to get the data from a flashed Xiaomi thermometer.
-
-<pre>const BTSensor = require("../BTSensor");
-const LYWSD03MMC = require('./LYWSD03MMC.js')
-class ATC extends BTSensor{
-
-    constructor(device){
-        super(device)
-    }
-
-    static metadata = LYWSD03MMC.metadata
-    
-    connect() {
-        const cb = async (propertiesChanged) => {
-            try{
-                this.device.getServiceData().then((data)=>{             
-                    //TBD Check if the service ID is universal across ATC variants
-                    const buff=data['0000181a-0000-1000-8000-00805f9b34fb'];
-                    this.emit("temp",((buff.readInt16LE(6))/100) + 273.1);
-                    this.emit("humidity",buff.readUInt16LE(8)/10000);
-                    this.emit("voltage",buff.readUInt16LE(10)/1000);
-                })
-            }
-            catch (error) {
-                throw new Error(`Unable to read data from ${util.inspect(device)}: ${error}` )
-            }
-        }
-        cb();
-        this.device.helper.on('PropertiesChanged', cb)
-    }
-}
-module.exports=ATC</pre>
-
-The big difference here is in the connect() method. All it does is wait on propertiesChanged and when that event occurs, the device object parses the buffer and emits the data. NOTE: Both classes have the same metadata, so the ATC class "borrows" the metadata from the LYWSD03MMC class.<br>
-
-## LET US KNOW
-
-When you're done working on your class and satisified that it's functioning properly, commit and request a merge (more git talk).<br>
-
-We love to see new sensor classes!
 
   
   

package/bt_co.json

@@ -14517,4 +14517,4 @@
         "name": "Ericsson AB"
       }
     ]
-  }
+  }

package/index.js

@@ -30,7 +30,7 @@ class MissingSensor  {
 		this.mac_address = config.mac_address
 		
 	}
-	canUseGATT(){
+	hasGATT(){
 		return false
 	}
 	getMetadata(){
@@ -171,7 +171,7 @@ module.exports =  function (app) {
 			},
 			discoveryInterval: {title: "Scan for new devices interval (in seconds-- 0 for no new device scanning)", 
 				type: "integer", 
-				default: 60,
+				default: 10,
 				minimum: 0,
 				multipleOf: 10
 			 },
@@ -257,7 +257,7 @@ module.exports =  function (app) {
 			oneOf.properties.params.properties[tag]=metadatum.asJSONSchema()
 		})
 
-		if (sensor.canUseGATT()){
+		if (sensor.hasGATT()){
 
 			oneOf.properties.gattParams={
 				title:`GATT Specific device parameters`,

package/package.json

@@ -1,7 +1,7 @@
 {
   "name": "bt-sensors-plugin-sk",
-  "version": "1.1.0-beta.1",
-  "description": "Bluetooth Sensors for Signalk - Beta 20241012",
+  "version": "1.1.0-beta.2.1",
+  "description": "Bluetooth Sensors for Signalk -- support for Victron devices, RuuviTag, Xiaomi, ATC and Inkbird",
   "main": "index.js",
   "dependencies": {
     "dbus-next": "^0.10.2",

package/sensor_classes/ATC.js

@@ -14,8 +14,8 @@ class ATC extends BTSensor{
         return null
     }
   
-    static {
-        this.metadata = new Map(super.getMetadata())
+    async init() {
+        await super.init() 
         this.addMetadatum('temp','K', 'temperature',
             (buff,offset)=>{return ((buff.readInt16LE(offset))/100) + 273.1})
         this.addMetadatum('humidity','ratio', 'humidity',

package/sensor_classes/DEVELOPMENT.md

@@ -0,0 +1,153 @@
+# BLUETOOTH SENSOR CLASS DEVELOPMENT (OUT OF DATE AS OF 1.1.0 Beta release NEW VERSION COMING SOON)
+
+The goal of this project is to support as many mariner-useful sensors as possible. If there's anything we can do to make sensor class development easier, please let us know.<br><br>
+
+## REQUIREMENTS
+
+* programming knowledge, preferably class programming in Nodejs
+* familiarity with [Node-ble](https://www.npmjs.com/package/node-ble) 
+* ideally, the device manufacturer's specification for their bluetooth API
+* failing the above, a willingness to hack or at the very least google aggressively
+
+## PROGRAMMING PROCESS
+
+### Discovery
+
+You'll first need to know what data your sensor produces and the means by which it provides data (GATT Server or advertisement) and the details thereof.<br><br>
+
+The first approach is to see if the device manufacturer has documented this. Not all do. Don't worry if you can't find OEM docs, it's likely someone on the internet has figured out your device's whys and wherefores for you already. Google that thang. <br><br>
+
+If you're still coming up empty, there are any number of tools you can use to examine the Bluetooth data stream of your device. <br><br>
+
+* bluetoothctl (installed with Bluez on Linux)
+* [NRF Connect](https://play.google.com/store/apps/details?id=no.nordicsemi.android.mcp&hl=en_US)
+
+With these tools you can see what data your device advertises, and what data it provides via a connection to its GATT Server. <br><br>
+
+### Coding
+
+#### Get the code
+
+To get the code you'll first need to clone this repository then create a branch. That's git talk. Google it if you don't know what that means.<br>
+
+Once you've done that you're ready for...
+
+#### Actual coding
+
+Below is a simple Device class for the Xiaomi thermometer with stock firmware. The code demonstrates the core responsibilities of a Bluetooth sensor device class in the BT-Sensor-plugin's framework:
+
+* resides in the sensor_classes subdirectory
+* extends the BTSensor class
+* provides metadata for the device's various data points (the static metadata class member)
+* overrides the BTSensor::connect() and disconnect() methods
+* emits values for each data point
+* exports the class
+    
+<pre>const BTSensor = require("../BTSensor");
+
+class LYWSD03MMC extends BTSensor{
+
+    static needsScannerOn(){
+        return false
+    }
+    static metadata = new Map()
+                    .set('temp',{unit:'K', description: 'temperature'})
+                    .set('humidity',{unit:'ratio', description: 'humidity'})
+                    .set('voltage',{unit:'V', description: 'sensor battery voltage'})
+
+    constructor(device){
+        super(device)
+    }
+
+    emitValues(buffer){
+        this.emit("temp",((buffer.readInt16LE(0))/100) + 273.1);
+        this.emit("humidity",buffer.readUInt8(2)/100);
+        this.emit("voltage",buffer.readUInt16LE(3)/1000);
+    }
+
+    async connect() {
+        await this.device.connect()
+        var gattServer = await this.device.gatt()
+        var gattService = await gattServer.getPrimaryService("ebe0ccb0-7a0a-4b0c-8a1a-6ff2997da3a6")
+        var gattCharacteristic = await gattService.getCharacteristic("ebe0ccc1-7a0a-4b0c-8a1a-6ff2997da3a6")
+        this.emitValues(await gattCharacteristic.readValue())
+        await gattCharacteristic.startNotifications();	
+        gattCharacteristic.on('valuechanged', buffer => {
+            this.emitValues(buffer)
+        })
+    }
+    async disconnect(){
+        super.disconnect()
+        await this.device.disconnect()
+    }
+}
+module.exports=LYWSD03MMC</pre>
+
+Most of the work is done in the connect() method. In this case, the connect() method creates a connection to the device:
+<pre>await this.device.connect()</pre> 
+Then it gets the device's gattServer and primary service:
+<pre>
+ var gattServer = await this.device.gatt()
+ var gattService = await gattServer.getPrimaryService("ebe0ccb0-7a0a-4b0c-8a1a-6ff2997da3a6")
+ </pre>
+ Then, it requests the device's "characteristic" that will send us data.
+ <pre>var gattCharacteristic = await gattService.getCharacteristic("ebe0ccc1-7a0a-4b0c-8a1a-6ff2997da3a6")</pre>
+ Then it asks the characteristic for notifications when its value changes.
+ <pre>await gattCharacteristic.startNotifications();</pre>
+ Then most importantly it emits the values when the data has changed:
+ <pre>gattCharacteristic.on('valuechanged', buffer => {
+            this.emitValues(buffer) 
+  })</pre>
+  In this implementation, the emitValues member function does the work of parsing the buffer and emitting the values. 
+  <pre>    
+   emitValues(buffer){
+        this.emit("temp",((buffer.readInt16LE(0))/100) + 273.1);
+        this.emit("humidity",buffer.readUInt8(2)/100);
+        this.emit("voltage",buffer.readUInt16LE(3)/1000);
+   }
+  </pre>
+NOTE: If you guessed that the plugin listens to changes to device objects and then publishes the deltas, you guessed right.
+ 
+### All that said
+The problem with Gatt Server devices is they stay connected and eat up a lot of energy, draining your device's batteries. You can deactivate the device from the config screen when it's not in use or in this case you can flash the device with custom firmware that changes the device to a broadcast device that advertises its data obviating the need for a battery-draining connection. In the case of Xiaomi LYWSD03MMC you can flash it with some very useful software called [ATC](https://github.com/atc1441/ATC_MiThermometer?tab=readme-ov-file) </pre>
+
+Below is an example of a BTSensor subclass that uses the advertising protocol to get the data from a flashed Xiaomi thermometer.
+
+<pre>const BTSensor = require("../BTSensor");
+const LYWSD03MMC = require('./LYWSD03MMC.js')
+class ATC extends BTSensor{
+
+    constructor(device){
+        super(device)
+    }
+
+    static metadata = LYWSD03MMC.metadata
+    
+    connect() {
+        const cb = async (propertiesChanged) => {
+            try{
+                this.device.getServiceData().then((data)=>{             
+                    //TBD Check if the service ID is universal across ATC variants
+                    const buff=data['0000181a-0000-1000-8000-00805f9b34fb'];
+                    this.emit("temp",((buff.readInt16LE(6))/100) + 273.1);
+                    this.emit("humidity",buff.readUInt16LE(8)/10000);
+                    this.emit("voltage",buff.readUInt16LE(10)/1000);
+                })
+            }
+            catch (error) {
+                throw new Error(`Unable to read data from ${util.inspect(device)}: ${error}` )
+            }
+        }
+        cb();
+        this.device.helper.on('PropertiesChanged', cb)
+    }
+}
+module.exports=ATC</pre>
+
+The big difference here is in the connect() method. All it does is wait on propertiesChanged and when that event occurs, the device object parses the buffer and emits the data. NOTE: Both classes have the same metadata, so the ATC class "borrows" the metadata from the LYWSD03MMC class.<br>
+
+## LET US KNOW
+
+When you're done working on your class and satisified that it's functioning properly, commit and request a merge (more git talk).<br>
+
+We love to see new sensor classes!

package/sensor_classes/Inkbird.js

@@ -16,14 +16,10 @@ class Inkbird extends BTSensor{
         return null
     }
 
-    static {
-        this.metadata = new Map(super.getMetadata())
-        this.addMetadatum('temp','K', 'temperature')
-        this.addMetadatum('battery','ratio', 'battery strength')
-    }
-
     async init(){
         await super.init()
+        this.addMetadatum('temp','K', 'temperature')
+        this.addMetadatum('battery','ratio', 'battery strength')
         if (this.getName() == 'sps'){
             this.addMetadatum('humidity','ratio', 'humidity')
         }

package/sensor_classes/RuuviTag.js

@@ -11,11 +11,7 @@ class RuuviTag extends BTSensor{
         }
         return null
     }    
-
-    static {
-        this.metadata = new Map(super.getMetadata())
-    }
-    
+        
     async init(){
         await super.init()
         const md = this.valueIfVariant(this.getManufacturerData(this.constructor.manufacturerID))

package/sensor_classes/Victron/VictronConstants.js

@@ -209,6 +209,7 @@ module.exports = {
     0xA38B: "SmartShunt 2000A/50mV",
     0xA3A4: "Smart Battery Sense",
     0xA3A5: "Smart Battery Sense",
+    0xA3B0: "Smart Battery Protect",
     0xA3C0: "Orion Smart 12V|12V-18A Isolated DC-DC Charger",
     0xA3C8: "Orion Smart 12V|12V-30A Isolated DC-DC Charger",
     0xA3D0: "Orion Smart 12V|12V-30A Non-isolated DC-DC Charger",

package/sensor_classes/Victron/VictronSensor.js

@@ -11,12 +11,6 @@ const VC = require('./VictronConstants.js')
         this.encryptionKey = config?.encryptionKey
     }
    
-    static {
-        this.metadata = new Map(super.getMetadata())
-        const md = this.addMetadatum('encryptionKey','', "Encryption Key")
-        md.isParam = true
-    }
-
     static async identifyMode(device, mode){
 
         try{
@@ -51,13 +45,18 @@ const VC = require('./VictronConstants.js')
 
     async init(){
         await super.init()
+        var md = this.addMetadatum('encryptionKey','', "Encryption Key")
+        md.isParam = true
+        this.metadata = new Map(super.getMetadata())
+        md = this.addMetadatum('encryptionKey','', "Encryption Key")
+        md.isParam = true
         this.model_id=this.getManufacturerData(0x2e1).readUInt16LE(2)
     }
     alarmReason(alarmValue){
         return this.constructor.AlarmReason[alarmValue]
     }
     getModelName(){
-        return VC.MODEL_ID_MAP[this.model_id]
+        return VC?.MODEL_ID_MAP[this.model_id]??this.constructor.name+" (Model ID:"+this.model_id+")"
     }
 
     decrypt(data){

package/sensor_classes/VictronACCharger.js

@@ -28,9 +28,8 @@ class VictronACCharger extends VictronSensor{
         return await this.identifyMode(device, 0x0A)
     }   
 
-    static {
-        this.metadata = new Map(super.getMetadata())
-
+    async init(){
+        await super.init()
         this.addMetadatum('state','', 'device state', 
             (buff)=>{return VC.OperationMode.get(buff.readUInt8(0))})
         this.addMetadatum('error','', 'error code', 
@@ -48,8 +47,8 @@ class VictronACCharger extends VictronSensor{
         this.addMetadatum('curr2','A', 'battery 2 current',
             (buff)=>{return this.NaNif(buff.readUInt16BE(7)&0x7FF,0x7FF)/10})
 
-            this.addMetadatum('batt3','V', 'battery 3 voltage',
-                (buff)=>{return this.NaNif((buff.readUInt16BE(8)>>3), 0x1FFF)/100})
+        this.addMetadatum('batt3','V', 'battery 3 voltage',
+            (buff)=>{return this.NaNif((buff.readUInt16BE(8)>>3), 0x1FFF)/100})
 
         this.addMetadatum('curr3','A', 'battery 3 current',
             (buff)=>{return this.NaNif(buff.readUInt16BE(9)&0x7FF,0x7FF)/10})

package/sensor_classes/VictronBatteryMonitor.js

@@ -1,11 +1,18 @@
 const VictronSensor = require("./Victron/VictronSensor.js");
 const VC=require("./Victron/VictronConstants.js")
 class VictronBatteryMonitor extends VictronSensor{
-    static {
-        this.metadata = new Map(super.getMetadata())
+
+
+    static async identify(device){
+        return await this.identifyMode(device, 0x02)
+    }
+
+    characteristics=[]
+    async init(){
+        await super.init()
         this.addMetadatum('current', 'A', 'house battery amperage', 
-                (buff,offset=0)=>{return buff.readInt32LE(offset)/1000},
-                '6597ed8c-4bda-4c1e-af4b-551c4cf74769')
+            (buff,offset=0)=>{return buff.readInt32LE(offset)/1000},
+            '6597ed8c-4bda-4c1e-af4b-551c4cf74769')
         this.addMetadatum('power','W', 'house battery wattage',
                 (buff,offset=0)=>{return buff.readInt16LE(offset)},
                 '6597ed8e-4bda-4c1e-af4b-551c4cf74769')
@@ -27,15 +34,6 @@ class VictronBatteryMonitor extends VictronSensor{
         this.addMetadatum( 'ttg','s','time to go', 
                 (buff,offset=0)=>{return this.NaNif(buff.readUInt16LE(offset),0xFFFF)*60},
                 '65970ffe-4bda-4c1e-af4b-551c4cf74769')    
-    }
-
-    static async identify(device){
-        return await this.identifyMode(device, 0x02)
-    }
-
-    characteristics=[]
-    async init(){
-        await super.init()
         const modecurrent = this.getAuxModeAndCurrent()
         this.auxMode= modecurrent.auxMode
         switch(this.auxMode){
@@ -138,7 +136,7 @@ class VictronBatteryMonitor extends VictronSensor{
     propertiesChanged(props){
         super.propertiesChanged(props)
     }
-    canUseGATT(){
+    hasGATT(){
         return true
     }
     

package/sensor_classes/VictronDCDCConverter.js

@@ -7,8 +7,8 @@ class VictronDCDCConverter extends VictronSensor{
         return await this.identifyMode(device,0x04)
     }
    
-    static {
-        this.metadata= new Map(super.getMetadata())
+    async init(){
+        await super.init()
         this.addMetadatum('deviceState','', 'device state', 
                 (buff)=>{return VC.OperationMode.get(buff.readUInt8(0))})
         this.addMetadatum('chargerError','', 'charger error',

package/sensor_classes/VictronDCEnergyMeter.js

@@ -8,6 +8,13 @@ class VictronDCEnergyMeter extends VictronSensor{
     }
     async init(){
         await super.init()
+        this.addMetadatum('meterType','', 'meter type', 
+            (buff)=>{return VC.MeterType.get( buff.readInt16LE(0))})
+        this.addMetadatum('voltage','','voltage',
+            (buff)=>{return buff.readInt16LE(2)/100})
+        this.addMetadatum('alarm','', 'alarm', 
+            (buff)=>{return buff.readUInt16LE(4)})
+        this.addMetadatum('current','A', 'current')    
         const modeCurrent =  this.getAuxModeAndCurrent()
         this.auxMode= modeCurrent.auxMode
         switch(this.auxMode){
@@ -30,16 +37,7 @@ class VictronDCEnergyMeter extends VictronSensor{
                 break
         }
     }
-    static { 
-        this.metadata = new Map(super.getMetadata())
-        this.addMetadatum('meterType','', 'meter type', 
-                (buff)=>{return VC.MeterType.get( buff.readInt16LE(0))})
-        this.addMetadatum('voltage','','voltage',
-                (buff)=>{return buff.readInt16LE(2)/100})
-        this.addMetadatum('alarm','', 'alarm', 
-                (buff)=>{return buff.readUInt16LE(4)})
-        this.addMetadatum('current','A', 'current')    
-    }
+    
     emitValuesFrom(decData){
         this.emitData("meterType",decData,0)
         this.emitData("voltage",decData,2);

package/sensor_classes/VictronGXDevice.js

@@ -26,8 +26,8 @@ TBD
         return await this.identifyMode(device, 0x07)
     }   
 
-    static {
-        this.metadata = new Map(super.getMetadata())
+    async init() {
+        super.init()
         this.addMetadatum('voltage','V', 'channel #1 voltage', 
             (buff)=>{return this.NaNif(buff.readInt16LE(0),0xFFFF)/100})
         this.addMetadatum('pvPower','W','DC input power in watts', 

package/sensor_classes/VictronInverter.js

@@ -7,12 +7,11 @@ class VictronInverter extends VictronSensor{
         return await this.identifyMode(device, 0x03)
     }
 
-    static {
-        var md
-        this.metadata= new Map(super.getMetadata())
+    async init() {
+        await super.init()
         this.addMetadatum('deviceState','', 'inverter device state', 
             (buff)=>{return VC.OperationMode.get(buff.readIntU8(0))})
-        md = this.addMetadatum('alarmReason','', 'reason for alarm',
+        const md = this.addMetadatum('alarmReason','', 'reason for alarm',
             (buff)=>{return buff.readIntU16LE(1)})
         md.notify=true
 

package/sensor_classes/VictronInverterRS.js

@@ -10,12 +10,12 @@ class VictronInverterRS extends VictronSensor{
     }
     
 
-    static {
-        var md
-        this.metadata= new Map(super.getMetadata())
+    async init() {
+        await super.init()
+        
         this.addMetadatum('deviceState','', 'inverter device state', 
                 (buff)=>{return VC.OperationMode.get(buff.readIntU8(0))})
-        md = this.addMetadatum('chargerError','', 'charger error',
+        const md = this.addMetadatum('chargerError','', 'charger error',
                 (buff)=>{return VC.ChargerError(buff.readIntU8(1))})
         md.notify=true
 

package/sensor_classes/VictronLynxSmartBMS.js

@@ -23,9 +23,8 @@ class VictronLynxSmartBMS extends VictronSensor{
         return await this.identifyMode(device, 0x0A)
     }   
 
-    static {
-        this.metadata = new Map(super.getMetadata())
-
+    async init() {
+        await super.init()
         this.addMetadatum('error','', 'error code', 
             (buff)=>{return buff.readUInt8(0)})
  

package/sensor_classes/VictronOrionXS.js

@@ -8,9 +8,8 @@ class VictronOrionXS extends VictronSensor{
     static async identify(device){
         return await this.identifyMode(device, 0x0F)
     }   
-    static {
-        this.metadata = new Map(super.getMetadata())
-
+    async init() {
+        await super.init()
         this.addMetadatum('deviceState','', 'device state', 
             (buff)=>{return VC.OperationMode.get(buff.readUInt8(0))})
         this.addMetadatum('chargerError','', 'charger error',

package/sensor_classes/VictronSmartBatteryProtect.js

@@ -23,9 +23,8 @@ class VictronSmartBatteryProtect extends VictronSensor{
         return await this.identifyMode(device, 0x09)
     }   
 
-    static {
-        this.metadata = new Map(super.getMetadata())
-
+    async init() {
+        await super.init()
         this.addMetadatum('deviceState','', 'device state', 
                         (buff)=>{return VC.OperationMode.get(buff.readUInt8(1))})
         this.addMetadatum('outputStatus','', 'output status', //TODO

package/sensor_classes/VictronSmartLithium.js

@@ -25,16 +25,14 @@ class VictronSmartLithium extends VictronSensor{
         return await this.identifyMode(device, 0x05)
     }   
 
-    static {
-
+    async init() {
+        await super.init()
         function _toCellVoltage(val){    
             return val==0x7F?NaN:2.6+(val/100)
         }
-        this.metadata = new Map(super.getMetadata())
-
         this.addMetadatum('bmsFlags','', 'BMS Flags', 
                         (buff)=>{return buff.readUInt32BE(0)})
-/
+
         this.addMetadatum('smartLithiumErrors','', 'Smart Lithium Errors Flags',
             (buff)=>{return buff.readUInt16BE(3)})
         this.addMetadatum('cell1Voltage','V', 'cell #1 voltage', 
@@ -58,9 +56,7 @@ class VictronSmartLithium extends VictronSensor{
         this.addMetadatum('balancerStatus','', 'balancer status', //TODO
             (buff)=>{return this.NaNif((buff.readUInt16BE(14)&0xf),0xF)})
         this.addMetadatum('batteryTemp','K', 'battery temperature', 
-            (buff)=>{return this.NaNif((buff.readInt8(15)>>1),0x7F)+233.15})
-    
-                
+            (buff)=>{return this.NaNif((buff.readInt8(15)>>1),0x7F)+233.15})          
     }
 }
 module.exports=VictronSmartLithium

package/sensor_classes/VictronSolarCharger.js

@@ -6,8 +6,8 @@ class VictronSolarCharger extends VictronSensor{
         return await this.identifyMode(device, 0x01)
     }   
 
-    static {
-        this.metadata = new Map(super.getMetadata())
+    async init() {
+        await super.init()
 
         this.addMetadatum('chargeState','', 'charge state', 
             (buff)=>{return VC.OperationMode.get(buff.readUInt8(0))})

package/sensor_classes/VictronVEBus.js

@@ -9,8 +9,8 @@ class VictronVEBus extends VictronSensor{
         return await this.identifyMode(device, 0x0C)
     }   
 
-    static {
-        this.metadata = new Map(super.getMetadata())
+    async init() {
+        await super.init()
 
         this.addMetadatum('chargeState','', 'charge state', 
             (buff)=>{return VC.OperationMode.get(buff.readUInt8(0))})

package/sensor_classes/XiaomiMiBeacon.js

@@ -91,21 +91,7 @@ class XiaomiMiBeacon extends BTSensor{
         }
         return null
     }
-    static {
-        this.metadata = new Map(super.getMetadata())
-           //3985f4ebc032f276cc316f1f6ecea085
-        //8a1dadfa832fef54e9c1d190
 
-        const md = this.addMetadatum("encryptionKey", "", "encryptionKey (AKA bindKey) for decryption")
-        md.isParam=true
-        this.addMetadatum('temp','K', 'temperature',
-            (buff,offset)=>{return ((buff.readInt16LE(offset))/100) + 273.1})
-        this.addMetadatum('humidity','ratio', 'humidity',
-            (buff,offset)=>{return ((buff.readUInt8(offset))/100)})
-        this.addMetadatum('voltage', 'V',  'sensor battery voltage',
-            (buff,offset)=>{return ((buff.readUInt16LE(offset))/1000)})
-       
-    }
     GATTwarning = "WARNING: Xiaomi GATT connections are known to be unreliable on Debian distributions with Bluez 5.55 and up (earlier BlueZ versions are untested). Using GATT on the Xiaomi may put the system Bluetooth stack into an inconsistent state disrupting and disabling other plugin Bluetooth connections. If by some chance you're successful using GATT with the Xiaomi, let the plugin developer know your configuration. Refer to the plugin documentation for getting the Xiamoi bindKey for non-GATT connections and more information on Xiaomi GATT issues."
     
     emitValues(buffer){
@@ -120,7 +106,10 @@ class XiaomiMiBeacon extends BTSensor{
         return this.GATTwarning
     }
     initGATT(){
-        this.debug(this.GATTwarning.toUpperCase())
+        if (!this?.gattWarningDelivered) {
+            this.debug(this.GATTwarning.toUpperCase())
+            this.gattWarningDelivered=true
+        }
         return new Promise((resolve,reject )=>{
             this.device.connect().then(async ()=>{
                 if (!this.gattServer) {
@@ -168,7 +157,7 @@ class XiaomiMiBeacon extends BTSensor{
         return cipher.update(encryptedPayload)
     }
 
-    canUseGATT(){
+    hasGATT(){
         return true
     }
 
@@ -202,6 +191,15 @@ class XiaomiMiBeacon extends BTSensor{
     
     async init(){
         await super.init()
+        const md = this.addMetadatum("encryptionKey", "", "encryptionKey (AKA bindKey) for decryption")
+        md.isParam=true
+        this.addMetadatum('temp','K', 'temperature',
+            (buff,offset)=>{return ((buff.readInt16LE(offset))/100) + 273.1})
+        this.addMetadatum('humidity','ratio', 'humidity',
+            (buff,offset)=>{return ((buff.readUInt8(offset))/100)})
+        this.addMetadatum('voltage', 'V',  'sensor battery voltage',
+            (buff,offset)=>{return ((buff.readUInt16LE(offset))/1000)})
+
         const data = this.getServiceData(this.constructor.SERVICE_MIBEACON)
         const frameControl = data[0] + (data[1] << 8)
         this.deviceID = data[2] + (data[3] << 8)

package/test.js

@@ -1,32 +0,0 @@
-const {createBluetooth} = require('node-ble')
-const {bluetooth, destroy} = createBluetooth()
-const { argv } = require('node:process');
-
-
-async function main(){
-
-  const adapter = await bluetooth.defaultAdapter()
-  
-  try{await adapter.startDiscovery()} catch{}
-  const device = await adapter.waitDevice(argv[2])
-  var trials=0
-  await device.connect()
-  const gatt = await device.gatt()
-  await device.disconnect()
-
-  async function search(){
-      await device.connect()
-
-      console.log(`GATT trial #${++trials}...`)
-      const s = await gatt.getPrimaryService("65970000-4bda-4c1e-af4b-551c4cf74769")
-      const c = await s.getCharacteristic('6597ffff-4bda-4c1e-af4b-551c4cf74769')
-      await c.readValue()
-      await device.disconnect()
- }
-
-setInterval(() => {
-  search()
-},argv[3]);
-search()
-}
-main()