bsv-mcp 0.2.15 → 0.3.1

package/tools/wallet/transferOrdToken.ts

@@ -1,31 +1,21 @@
-import type { OneSatContext } from '@1sat/actions'
-import { sendBsv21, transferOrdinals } from '@1sat/actions'
-import type { McpServer } from '@modelcontextprotocol/sdk/server/mcp.js'
-import { z } from 'zod'
-
-const walletOutputSchema = z.object({
-	outpoint: z.string(),
-	satoshis: z.number().optional(),
-	tags: z.array(z.string()).optional(),
-	customInstructions: z.string().optional(),
-	lockingScript: z.string().optional(),
-})
+import type { OneSatContext } from "@1sat/actions";
+import { sendBsv21, sendOrdinals } from "@1sat/actions";
+import type { McpServer } from "@modelcontextprotocol/sdk/server/mcp.js";
+import { z } from "zod";
+import { assertBroadcastAllowed } from "../../utils/broadcastGuard";
 
 export const transferOrdTokenArgsSchema = z.object({
-	type: z.enum(['ordinal', 'bsv21']).describe(
-		"'ordinal' to transfer an inscription/NFT, 'bsv21' to send fungible BSV21 tokens",
-	),
-	// ordinal fields
-	ordinal: walletOutputSchema
-		.optional()
+	type: z
+		.enum(["ordinal", "bsv21"])
 		.describe(
-			"WalletOutput of the ordinal to transfer (from wallet_getOrdinals). Required when type='ordinal'",
+			"'ordinal' to transfer an inscription/NFT, 'bsv21' to send fungible BSV21 tokens",
 		),
-	inputBEEF: z
-		.array(z.number())
+	// ordinal fields
+	id: z
+		.string()
 		.optional()
 		.describe(
-			"BEEF bytes from listOutputs (include: 'entire transactions'). Required when type='ordinal'",
+			"Tracking id of the ordinal in the ordinals basket (the 'id:' tag from wallet_getOrdinals). Required when type='ordinal'",
 		),
 	// bsv21 fields
 	tokenId: z
@@ -35,130 +25,128 @@ export const transferOrdTokenArgsSchema = z.object({
 	amount: z
 		.string()
 		.optional()
-		.describe("Amount of tokens to send as a string integer. Required when type='bsv21'"),
+		.describe(
+			"Amount of tokens to send as a string integer. Required when type='bsv21'",
+		),
 	// shared destination fields
-	address: z.string().optional().describe('Recipient P2PKH address'),
+	address: z.string().optional().describe("Recipient P2PKH address"),
 	counterparty: z
 		.string()
 		.optional()
-		.describe('Recipient identity public key (hex)'),
-})
+		.describe("Recipient identity public key (hex)"),
+});
 
-export type TransferOrdTokenArgs = z.infer<typeof transferOrdTokenArgsSchema>
+export type TransferOrdTokenArgs = z.infer<typeof transferOrdTokenArgsSchema>;
 
 export function registerTransferOrdTokenTool(
 	server: McpServer,
 	ctx: OneSatContext | undefined,
 ) {
 	server.tool(
-		'wallet_transferOrdToken',
-		"Transfer an ordinal inscription or send BSV21 fungible tokens. Use type='ordinal' to transfer an NFT/inscription (requires the WalletOutput from wallet_getOrdinals and the BEEF). Use type='bsv21' to send fungible tokens by token ID and amount.",
+		"wallet_transferOrdToken",
+		"Transfer an ordinal inscription or send BSV21 fungible tokens. Use type='ordinal' to transfer an NFT/inscription by its ordinals-basket tracking id (from wallet_getOrdinals). Use type='bsv21' to send fungible tokens by token ID and amount.",
 		{ ...transferOrdTokenArgsSchema.shape },
-		async ({ type, ordinal, inputBEEF, tokenId, amount, address, counterparty }) => {
+		async ({ type, id, tokenId, amount, address, counterparty }) => {
 			if (!ctx) {
 				return {
 					content: [
 						{
-							type: 'text',
-							text: 'Wallet not initialized. Please configure a wallet before transferring.',
+							type: "text",
+							text: "Wallet not initialized. Please configure a wallet before transferring.",
 						},
 					],
 					isError: true,
-				}
+				};
 			}
 
 			try {
-				if (type === 'ordinal') {
-					if (!ordinal) {
-						return {
-							content: [{ type: 'text', text: "ordinal is required when type='ordinal'" }],
-							isError: true,
-						}
-					}
-					if (!inputBEEF) {
-						return {
-							content: [{ type: 'text', text: "inputBEEF is required when type='ordinal'" }],
-							isError: true,
-						}
-					}
-					if (!address && !counterparty) {
+				assertBroadcastAllowed("wallet_transferOrdToken");
+				if (!address && !counterparty) {
+					return {
+						content: [
+							{ type: "text", text: "address or counterparty is required" },
+						],
+						isError: true,
+					};
+				}
+
+				if (type === "ordinal") {
+					if (!id) {
 						return {
-							content: [{ type: 'text', text: 'address or counterparty is required' }],
+							content: [
+								{
+									type: "text",
+									text: "id is required when type='ordinal'",
+								},
+							],
 							isError: true,
-						}
+						};
 					}
 
-					const result = await transferOrdinals.execute(ctx, {
-						transfers: [
-							{
-								ordinal: ordinal as Parameters<typeof transferOrdinals.execute>[1]['transfers'][0]['ordinal'],
-								address,
-								counterparty,
-							},
-						],
-						inputBEEF,
-					})
+					const result = await sendOrdinals.execute(ctx, {
+						transfers: [{ id, address, counterparty }],
+					});
 
 					if (result.error) {
 						return {
-							content: [{ type: 'text', text: result.error }],
+							content: [{ type: "text", text: result.error }],
 							isError: true,
-						}
+						};
 					}
 
 					return {
-						content: [{ type: 'text', text: JSON.stringify({ txid: result.txid }) }],
-					}
+						content: [
+							{ type: "text", text: JSON.stringify({ txid: result.txid }) },
+						],
+					};
 				}
 
 				// bsv21
 				if (!tokenId) {
 					return {
-						content: [{ type: 'text', text: "tokenId is required when type='bsv21'" }],
+						content: [
+							{ type: "text", text: "tokenId is required when type='bsv21'" },
+						],
 						isError: true,
-					}
+					};
 				}
 				if (!amount) {
 					return {
-						content: [{ type: 'text', text: "amount is required when type='bsv21'" }],
-						isError: true,
-					}
-				}
-				if (!address && !counterparty) {
-					return {
-						content: [{ type: 'text', text: 'address or counterparty is required' }],
+						content: [
+							{ type: "text", text: "amount is required when type='bsv21'" },
+						],
 						isError: true,
-					}
+					};
 				}
 
 				const result = await sendBsv21.execute(ctx, {
 					tokenId,
-					amount,
-					address,
-					counterparty,
-				})
+					recipients: [{ amount, destination: { address, counterparty } }],
+				});
 
 				if (result.error) {
 					return {
-						content: [{ type: 'text', text: result.error }],
+						content: [{ type: "text", text: result.error }],
 						isError: true,
-					}
+					};
 				}
 
 				return {
-					content: [{ type: 'text', text: JSON.stringify({ txid: result.txid }) }],
-				}
+					content: [
+						{ type: "text", text: JSON.stringify({ txid: result.txid }) },
+					],
+				};
 			} catch (err: unknown) {
 				return {
 					content: [
 						{
-							type: 'text',
+							type: "text",
 							text: err instanceof Error ? err.message : String(err),
 						},
 					],
 					isError: true,
-				}
+				};
 			}
 		},
-	)
+	);
 }

package/tools/wallet/unlockBsv.ts

@@ -1,57 +1,63 @@
-import type { OneSatContext } from '@1sat/actions'
-import { unlockBsv } from '@1sat/actions'
-import type { McpServer } from '@modelcontextprotocol/sdk/server/mcp.js'
+import type { OneSatContext } from "@1sat/actions";
+import { unlockBsv } from "@1sat/actions";
+import type { McpServer } from "@modelcontextprotocol/sdk/server/mcp.js";
+import { assertBroadcastAllowed } from "../../utils/broadcastGuard";
 
 export function registerUnlockBsvTool(
 	server: McpServer,
 	ctx: OneSatContext | undefined,
 ) {
 	server.tool(
-		'wallet_unlockBsv',
-		'Unlock all matured time-locked BSV',
+		"wallet_unlockBsv",
+		"Unlock all matured time-locked BSV",
 		{},
 		async () => {
 			if (!ctx) {
 				return {
 					content: [
 						{
-							type: 'text',
-							text: 'Wallet not initialized. Please configure a wallet before unlocking.',
+							type: "text",
+							text: "Wallet not initialized. Please configure a wallet before unlocking.",
 						},
 					],
 					isError: true,
-				}
+				};
 			}
 
 			try {
-				const result = await unlockBsv.execute(ctx, {})
+				assertBroadcastAllowed("wallet_unlockBsv");
+				const result = await unlockBsv.execute(ctx, {});
 
 				if (result.error) {
 					return {
-						content: [{ type: 'text', text: result.error }],
+						content: [{ type: "text", text: result.error }],
 						isError: true,
-					}
+					};
 				}
 
 				return {
 					content: [
 						{
-							type: 'text',
-							text: JSON.stringify(result, (_, v) => typeof v === 'bigint' ? v.toString() : v, 2),
+							type: "text",
+							text: JSON.stringify(
+								result,
+								(_, v) => (typeof v === "bigint" ? v.toString() : v),
+								2,
+							),
 						},
 					],
-				}
+				};
 			} catch (err: unknown) {
 				return {
 					content: [
 						{
-							type: 'text',
+							type: "text",
 							text: err instanceof Error ? err.message : String(err),
 						},
 					],
 					isError: true,
-				}
+				};
 			}
 		},
-	)
+	);
 }

package/tools/wallet/utxo.ts

@@ -1,4 +1,5 @@
 import { Transaction } from "@bsv/sdk";
+import { arrayBufferToUint8Array } from "../../utils/buffer";
 
 export async function getTransactionById(
 	txid: string,

package/tools/wallet/wallet.ts

@@ -8,7 +8,6 @@
 
 import type { GetPublicKeyArgs, GetPublicKeyResult, PubKeyHex } from "@bsv/sdk";
 import {
-	Beef,
 	type BroadcastFailure,
 	type BroadcastResponse,
 	fromUtxo,
@@ -16,7 +15,6 @@ import {
 	isBroadcastResponse,
 	P2PKH,
 	PrivateKey,
-	type PublicKey,
 	SatoshisPerKilobyte,
 	Script,
 	Transaction,
@@ -26,16 +24,6 @@ import { fetchNftUtxos, type NftUtxo, type Utxo } from "js-1sat-ord";
 import { V5Broadcaster } from "../../utils/broadcaster";
 import { fetchPaymentUtxosFromV5 } from "./fetchPaymentUtxos";
 
-// Local interface for what encrypt/decrypt expect, will be mapped from Zod schema
-interface InternalEncryptionArgs {
-	data: number[];
-	recipientPublicKey?: PublicKey; // For encryption
-}
-
-interface InternalDecryptionArgs {
-	data: number[];
-}
-
 export class Wallet {
 	private paymentUtxos: Utxo[] = [];
 	private nftUtxos: NftUtxo[] = [];
@@ -146,7 +134,7 @@ export class Wallet {
 		return this.getPaymentKey()?.toAddress();
 	}
 
-	async getPublicKey(args?: GetPublicKeyArgs): Promise<GetPublicKeyResult> {
+	async getPublicKey(_args?: GetPublicKeyArgs): Promise<GetPublicKeyResult> {
 		const currentPaymentKey = this.getPaymentKey();
 		if (!currentPaymentKey) {
 			throw new Error("No payment key available to derive public key.");

package/test-mcp-server.ts

@@ -1,157 +0,0 @@
-#!/usr/bin/env bun
-import { Client } from "@modelcontextprotocol/sdk/client/index.js";
-import { StdioClientTransport } from "@modelcontextprotocol/sdk/client/stdio.js";
-
-async function testMCPServer() {
-	console.log("🧪 Testing BSV MCP Server...\n");
-
-	// Create transport
-	const transport = new StdioClientTransport({
-		command: "bun",
-		args: ["run", "./index.ts"],
-		env: {
-			...process.env,
-			TRANSPORT: "stdio",
-			DISABLE_BROADCASTING: "true", // Don't broadcast test transactions
-			USE_DROPLET_API: "false", // Use local mode to test BSocial
-		},
-	});
-
-	// Create client
-	const client = new Client(
-		{ name: "test-client", version: "1.0.0" },
-		{
-			capabilities: {},
-		},
-	);
-
-	try {
-		// Connect
-		console.log("📡 Connecting to server...");
-		await client.connect(transport);
-		console.log("✅ Connected successfully\n");
-
-		// List available tools
-		console.log("🔧 Available tools:");
-		const tools = await client.listTools();
-		console.log(`Found ${tools.tools.length} tools:`);
-
-		// Group tools by category
-		const categories = new Map<string, string[]>();
-		for (const tool of tools.tools) {
-			const prefix = tool.name.split("_")[0];
-			if (!categories.has(prefix)) {
-				categories.set(prefix, []);
-			}
-			const categoryTools = categories.get(prefix);
-			if (categoryTools) {
-				categoryTools.push(tool.name);
-			}
-		}
-
-		// Display by category
-		for (const [category, toolNames] of categories) {
-			console.log(`\n${category}:`);
-			for (const name of toolNames) {
-				console.log(`  - ${name}`);
-			}
-		}
-
-		// Test a few tools
-		console.log("\n🧪 Testing tools:\n");
-
-		// 1. Test BSV price tool
-		console.log("1. Testing bsv_getPrice:");
-		try {
-			const priceResult = await client.callTool({
-				name: "bsv_getPrice",
-				arguments: {},
-			});
-			const content = priceResult.content[0] as { text: string };
-			console.log("✅", content.text);
-		} catch (error) {
-			console.log("❌ Error:", error);
-		}
-
-		// 2. Test utils conversion
-		console.log("\n2. Testing utils_convertData:");
-		try {
-			const convertResult = await client.callTool({
-				name: "utils_convertData",
-				arguments: {
-					args: {
-						data: "Hello BSV!",
-						from: "utf8",
-						to: "hex",
-					},
-				},
-			});
-			const content = convertResult.content[0] as { text: string };
-			console.log("✅ Converted:", content.text);
-		} catch (error) {
-			console.log("❌ Error:", error);
-		}
-
-		// 3. Test bsocial_readPosts
-		console.log("\n3. Testing bsocial_readPosts:");
-		try {
-			const postsResult = await client.callTool({
-				name: "bsocial_readPosts",
-				arguments: {
-					args: {
-						limit: 5,
-					},
-				},
-			});
-			const content = postsResult.content[0] as { text: string };
-			console.log("✅ Read posts (showing first 200 chars):");
-			console.log(`${content.text.substring(0, 200)}...`);
-		} catch (error) {
-			console.log("❌ Error:", error);
-		}
-
-		// 4. Test ordinals search
-		console.log("\n4. Testing ordinals_searchInscriptions:");
-		try {
-			const ordinalsResult = await client.callTool({
-				name: "ordinals_searchInscriptions",
-				arguments: {
-					args: {
-						query: "test",
-						limit: 3,
-					},
-				},
-			});
-			const content = ordinalsResult.content[0] as { text: string };
-			const response = JSON.parse(content.text);
-			console.log(`✅ Found ${response.total || 0} inscriptions`);
-		} catch (error) {
-			console.log("❌ Error:", error);
-		}
-
-		// List resources
-		console.log("\n📚 Available resources:");
-		const resources = await client.listResources();
-		console.log(`Found ${resources.resources.length} resources`);
-		for (const resource of resources.resources) {
-			console.log(`  - ${resource.name}`);
-		}
-
-		// List prompts
-		console.log("\n💭 Available prompts:");
-		const prompts = await client.listPrompts();
-		console.log(`Found ${prompts.prompts.length} prompts`);
-		for (const prompt of prompts.prompts) {
-			console.log(`  - ${prompt.name}`);
-		}
-	} catch (error) {
-		console.error("❌ Test failed:", error);
-	} finally {
-		console.log("\n🔌 Disconnecting...");
-		await client.close();
-		process.exit(0);
-	}
-}
-
-// Run the test
-testMCPServer().catch(console.error);

package/tools/wallet/sendToAddress.ts

@@ -1,74 +0,0 @@
-import type { OneSatContext } from '@1sat/actions'
-import { sendBsv } from '@1sat/actions'
-import type { McpServer } from '@modelcontextprotocol/sdk/server/mcp.js'
-import { toSatoshi } from 'satoshi-token'
-import { getBsvPriceWithCache } from '../bsv/getPrice'
-import { sendToAddressArgsSchema } from './schemas'
-
-export function registerSendToAddressTool(
-	server: McpServer,
-	ctx: OneSatContext | undefined,
-) {
-	server.tool(
-		'wallet_sendToAddress',
-		'Sends Bitcoin SV (BSV) to a specified address. This tool supports payments in both BSV and USD amounts (with automatic conversion using current exchange rates). Transaction fees are automatically calculated and a confirmation with transaction ID is returned upon success.',
-		{ ...sendToAddressArgsSchema.shape },
-		async ({ address, amount, currency = 'BSV', description = 'Send to address' }) => {
-			if (!ctx) {
-				return {
-					content: [
-						{
-							type: 'text',
-							text: 'Wallet not initialized. Please configure a wallet before sending.',
-						},
-					],
-					isError: true,
-				}
-			}
-
-			try {
-				let satoshis: number
-				if (currency === 'USD') {
-					const bsvPriceUsd = await getBsvPriceWithCache()
-					satoshis = toSatoshi(amount / bsvPriceUsd)
-				} else {
-					satoshis = toSatoshi(amount)
-				}
-
-				const result = await sendBsv.execute(ctx, {
-					requests: [{ address, satoshis }],
-				})
-
-				if (result.error) {
-					return {
-						content: [{ type: 'text', text: result.error }],
-						isError: true,
-					}
-				}
-
-				return {
-					content: [
-						{
-							type: 'text',
-							text: JSON.stringify({
-								status: 'success',
-								txid: result.txid,
-								satoshis,
-							}),
-						},
-					],
-				}
-			} catch (error) {
-				return {
-					content: [
-						{
-							type: 'text',
-							text: error instanceof Error ? error.message : String(error),
-						},
-					],
-					isError: true,
-				}
-			}
-		},
-	)
-}