browsertime 24.8.0 → 24.8.2

package/CHANGELOG.md

@@ -1,5 +1,13 @@
 # Browsertime changelog (we do [semantic versioning](https://semver.org))
 
+## 24.8.2 - 2025-06-22
+### Fixed
+*  Fix for serverTiming - thank you [Gregory Mierzwinski](https://github.com/gmierz) for PR [#2301](https://github.com/sitespeedio/browsertime/pull/2301)
+
+## 24.8.1 - 2025-06-01
+### Fixed
+* [Visual Elements] Fix split for selector to include full value with ':'` - thank you [Pavel Bairov](https://github.com/Amerousful) for PR [#2298](https://github.com/sitespeedio/browsertime/pull/2298).
+
 ## 24.8.0 - 2025-05-30
 ### Added
 * Updated to Chrome/Chromedriver 137 and Firefox 139 in the Docker container [#2284](https://github.com/sitespeedio/browsertime/pull/2284).

package/browserscripts/pageinfo/visualElements.js

@@ -91,7 +91,7 @@
     for (const nameAndSelector of customArray) {
       const parts = nameAndSelector.split(':');
       const type = parts[0];
-      const selector = parts[1];
+      const selector = nameAndSelector.slice(nameAndSelector.indexOf(':') + 1);
       const element = document.body.querySelector(selector);
       try {
         if (isElementPartlyInViewportAndVisible(element)) {

package/browserscripts/timings/navigationTiming.js

@@ -1,7 +1,6 @@
 (function() {
   let t = window.performance.getEntriesByType('navigation')[0];
   const d = 0;
-  if (t) {
     return {
       connectStart: Number(t.connectStart.toFixed(d)),
       domComplete: Number(t.domComplete.toFixed(d)),
@@ -27,40 +26,4 @@
       unloadEventStart: Number(t.unloadEventStart.toFixed(d)),
       workerStart: Number(t.workerStart.toFixed(d))
     };
-  } else {
-    // For Safari
-    t = window.performance.timing;
-    return {
-      navigationStart: 0,
-      unloadEventStart:
-        t.unloadEventStart > 0
-          ? t.unloadEventStart - t.navigationStart
-          : undefined,
-      unloadEventEnd:
-        t.unloadEventEnd > 0 ? t.unloadEventEnd - t.navigationStart : undefined,
-      redirectStart:
-        t.redirectStart > 0 ? t.redirectStart - t.navigationStart : undefined,
-      redirectEnd:
-        t.redirectEnd > 0 ? t.redirectEnd - t.navigationStart : undefined,
-      fetchStart: t.fetchStart - t.navigationStart,
-      domainLookupStart: t.domainLookupStart - t.navigationStart,
-      domainLookupEnd: t.domainLookupEnd - t.navigationStart,
-      connectStart: t.connectStart - t.navigationStart,
-      connectEnd: t.connectEnd - t.navigationStart,
-      secureConnectionStart: t.secureConnectionStart
-        ? t.secureConnectionStart - t.navigationStart
-        : undefined,
-      requestStart: t.requestStart - t.navigationStart,
-      responseStart: t.responseStart - t.navigationStart,
-      responseEnd: t.responseEnd - t.navigationStart,
-      domLoading: t.domLoading - t.navigationStart,
-      domInteractive: t.domInteractive - t.navigationStart,
-      domContentLoadedEventStart:
-        t.domContentLoadedEventStart - t.navigationStart,
-      domContentLoadedEventEnd: t.domContentLoadedEventEnd - t.navigationStart,
-      domComplete: t.domComplete - t.navigationStart,
-      loadEventStart: t.loadEventStart - t.navigationStart,
-      loadEventEnd: t.loadEventEnd - t.navigationStart
-    };
-  }
 })();

package/browserscripts/timings/pageTimings.js

@@ -1,7 +1,6 @@
 (function() {
   let t = window.performance.getEntriesByType('navigation')[0];
   const d = 0;
-  if (t) {
     return {
       domainLookupTime: Number(
         (t.domainLookupEnd - t.domainLookupStart).toFixed(d)
@@ -15,21 +14,5 @@
       pageLoadTime: Number(t.loadEventStart.toFixed(d)),
       frontEndTime: Number((t.loadEventStart - t.responseEnd).toFixed(d)),
       backEndTime: Number(t.responseStart.toFixed(d))
-    };
-  } else {
-    // Safari
-    t = window.performance.timing;
-    return {
-      domainLookupTime: t.domainLookupEnd - t.domainLookupStart,
-      redirectionTime: t.fetchStart - t.navigationStart,
-      serverConnectionTime: t.connectEnd - t.connectStart,
-      serverResponseTime: t.responseEnd - t.requestStart,
-      pageDownloadTime: t.responseEnd - t.responseStart,
-      domInteractiveTime: t.domInteractive - t.navigationStart,
-      domContentLoadedTime: t.domContentLoadedEventStart - t.navigationStart,
-      pageLoadTime: t.loadEventStart - t.navigationStart,
-      frontEndTime: t.loadEventStart - t.responseEnd,
-      backEndTime: t.responseStart - t.navigationStart
-    };
-  }
+    }
 })();

package/browserscripts/timings/serverTimings.js

@@ -1,12 +1,14 @@
 (function () {
     let t = window.performance.getEntriesByType('navigation')[0];
     const serverTimings = [];
-    for (let timing of t.serverTiming) {
-        serverTimings.push({
-            name: timing.name,
-            duration: timing.duration,
-            description: timing.description
-        });
+    if (t.serverTiming) {
+        for (let timing of t.serverTiming) {
+            serverTimings.push({
+                name: timing.name,
+                duration: timing.duration,
+                description: timing.description
+            });
+        }
     }
     return serverTimings;
 })();

package/package.json

@@ -1,7 +1,7 @@
 {
   "name": "browsertime",
   "description": "Get performance metrics from your web page using Browsertime.",
-  "version": "24.8.0",
+  "version": "24.8.2",
   "bin": "./bin/browsertime.js",
   "type": "module",
   "types": "./types/scripting.d.ts",

package/visualmetrics/visualmetrics-portable.py

@@ -193,12 +193,12 @@ def blank_frame(file, color="white"):
 def edges_im(img):
     """Find the edges of the given image.
 
-    First, we apply a gaussian filter using a kernal of radius=13,
+    First, we apply a gaussian filter using a kernel of radius=13,
     and sigma=1 to a grayscale version of the image. Then we apply
     CED to find the edges.
 
     We calculate the hysterisis thresholds for the CED using the min and max
-    vaues of the blurred image. We use 10% as the lower threshold,
+    values of the blurred image. We use 10% as the lower threshold,
     and 30% as the upper threshold.
     """
     try:
@@ -1310,7 +1310,7 @@ def calculate_visual_metrics(
                     json.dump(hero_data, hero_f_out)
                     hero_f_out.close()
             else:
-                logging.warn(
+                logging.warning(
                     "Hero elements file is not valid: " + str(hero_elements_file)
                 )
         else:
@@ -1460,7 +1460,7 @@ def calculate_frame_progress(histogram, start, final):
     This method finds the visually-complete progress by taking a sum of
     all the differences in the histogram between the current frame, and the
     final frame. The initial/first frame is used to remove values that are
-    consitent between the first, and final frame (i.e. it's a baseline).
+    consistent between the first, and final frame (i.e. it's a baseline).
 
     Note that this method should not be using a slop/fuzz because we aren't
     looking at individual pixel intensities which is where the fuzz can be
@@ -1885,7 +1885,7 @@ def main():
         "--viewportretries",
         type=int,
         default=5,
-        help="Number of times to attempt to obtain a viewport. Analagous to the "
+        help="Number of times to attempt to obtain a viewport. Analogous to the "
         "number of frames to try to find a viewport with. By default, up to the "
         "first 5 frames are used.",
     )

package/visualmetrics/visualmetrics.py

@@ -1715,7 +1715,7 @@ def calculate_visual_metrics(
                     json.dump(hero_data, hero_f_out)
                     hero_f_out.close()
             else:
-                logging.warn(
+                logging.warning(
                     "Hero elements file is not valid: " + str(hero_elements_file)
                 )
         else:
@@ -2320,7 +2320,7 @@ def main():
         default=False,
         help="Multiple videos are combined, separated by orange frames."
         "In this mode only the extraction is done and analysis "
-        "needs to be run separetely on each directory. Numbered "
+        "needs to be run separately on each directory. Numbered "
         "directories will be created for each video under the output "
         "directory.",
     )
@@ -2348,7 +2348,7 @@ def main():
         "--viewportretries",
         type=int,
         default=5,
-        help="Number of times to attempt to obtain a viewport. Analagous to the "
+        help="Number of times to attempt to obtain a viewport. Analogous to the "
         "number of frames to try to find a viewport with. By default, up to the "
         "first 5 frames are used.",
     )