browsertime 24.7.0 → 24.8.1

package/CHANGELOG.md

@@ -1,5 +1,19 @@
 # Browsertime changelog (we do [semantic versioning](https://semver.org))
 
+## 24.8.1 - 2025-06-01
+### Fixed
+* [Visual Elements] Fix split for selector to include full value with ':'` - thank you [Pavel Bairov](https://github.com/Amerousful) for PR [#2298](https://github.com/sitespeedio/browsertime/pull/2298).
+
+## 24.8.0 - 2025-05-30
+### Added
+* Updated to Chrome/Chromedriver 137 and Firefox 139 in the Docker container [#2284](https://github.com/sitespeedio/browsertime/pull/2284).
+* Updated to Edge/Edgedriver 137 in the Docker container [#2289](https://github.com/sitespeedio/browsertime/pull/2289).
+* New command: `wait.byXpathAndVisible(...)` - thank you [Pavel Bairov](https://github.com/Amerousful) for PR [#2286](https://github.com/sitespeedio/browsertime/pull/2286).
+*  New command: `wait.bySelectorAndVisible(...)` PR [#2288](https://github.com/sitespeedio/browsertime/pull/2288).
+
+### Fixed
+* Updated dependencies: selenium, usb-power-profiling, execa and dev dependencies [#2290](https://github.com/sitespeedio/browsertime/pull/2290), [#2291](https://github.com/sitespeedio/browsertime/pull/2291), [#2294](https://github.com/sitespeedio/browsertime/pull/2294) and [#2295](https://github.com/sitespeedio/browsertime/pull/2295).
+
 ## 24.7.0 - 2025-05-13
 ### Added
 * Added Edge and Edgedriver 136 [#2282](https://github.com/sitespeedio/browsertime/pull/2282).

package/browserscripts/pageinfo/visualElements.js

@@ -91,7 +91,7 @@
     for (const nameAndSelector of customArray) {
       const parts = nameAndSelector.split(':');
       const type = parts[0];
-      const selector = parts[1];
+      const selector = nameAndSelector.slice(nameAndSelector.indexOf(':') + 1);
       const element = document.body.querySelector(selector);
       try {
         if (isElementPartlyInViewportAndVisible(element)) {

package/lib/core/engine/command/wait.js

@@ -100,6 +100,35 @@ export class Wait {
     }
   }
 
+  /**
+   * Waits for an element located by XPath to appear and visible within a maximum time.
+   *
+   * @async
+   * @param {string} xpath - The XPath of the element to wait for.
+   * @param {number} maxTime - Maximum time to wait in milliseconds.
+   * @returns {Promise<void>} A promise that resolves when the element is found or the time times out.
+   * @throws {Error} Throws an error if the element is not found within the specified time.
+   */
+  async byXpathAndVisible(xpath, maxTime = 6000) {
+    const driver = this.browser.getDriver();
+    await this.byXpath(xpath, maxTime);
+    try {
+      driver.findElement;
+      await driver.wait(
+        webdriver.until.elementIsVisible(
+          driver.findElement(webdriver.By.xpath(xpath))
+        ),
+        maxTime
+      );
+    } catch (error) {
+      log.error('Element by xpath %s was not visible in %s ms', xpath, maxTime);
+      log.verbose(error);
+      throw new Error(
+        `Element by xpath ${xpath} was not located in ${maxTime} ms`
+      );
+    }
+  }
+
   /**
    * Waits for an element located by a CSS selector to appear within a maximum time.
    *
@@ -131,6 +160,38 @@ export class Wait {
     }
   }
 
+  /**
+   * Waits for an element located by a CSS selector to be visible within a maximum time.
+   *
+   * @async
+   * @param {string} selector - The CSS selector of the element to wait for.
+   * @param {number} maxTime - Maximum time to wait in milliseconds.
+   * @returns {Promise<void>} A promise that resolves when the element is found or the time times out.
+   * @throws {Error} Throws an error if the element is not found within the specified time.
+   */
+  async bySelectorAndVisible(selector, maxTime = 6000) {
+    const driver = this.browser.getDriver();
+
+    try {
+      await driver.wait(
+        webdriver.until.elementIsVisible(
+          driver.findElement(webdriver.By.css(selector))
+        ),
+        maxTime
+      );
+    } catch (error) {
+      log.error(
+        'Element by selector %s was not visible in %s ms',
+        selector,
+        maxTime
+      );
+      log.verbose(error);
+      throw new Error(
+        `Element by selector ${selector} was not visible in ${maxTime} ms`
+      );
+    }
+  }
+
   /**
    * Waits for a specified amount of time.
    *

package/package.json

@@ -1,25 +1,25 @@
 {
   "name": "browsertime",
   "description": "Get performance metrics from your web page using Browsertime.",
-  "version": "24.7.0",
+  "version": "24.8.1",
   "bin": "./bin/browsertime.js",
   "type": "module",
   "types": "./types/scripting.d.ts",
   "dependencies": {
     "@devicefarmer/adbkit": "3.3.8",
-    "@sitespeed.io/chromedriver": "136.0.7103-92",
-    "@sitespeed.io/edgedriver": "136.0.3240-64",
+    "@sitespeed.io/chromedriver": "137.0.7151-55",
+    "@sitespeed.io/edgedriver": "137.0.3296-52",
     "@sitespeed.io/geckodriver": "0.36.0",
     "@sitespeed.io/log": "0.2.6",
     "@sitespeed.io/throttle": "5.0.1",
     "@sitespeed.io/tracium": "0.3.3",
     "chrome-har": "1.0.1",
     "chrome-remote-interface": "0.33.3",
-    "execa": "9.5.2",
+    "execa": "9.6.0",
     "fast-stats": "0.0.7",
     "ff-test-bidi-har-export": "0.0.17",
     "lodash.merge": "4.6.2",
-    "selenium-webdriver": "4.32.0",
+    "selenium-webdriver": "4.33.0",
     "yargs": "17.7.2"
   },
   "optionalDependencies": {
@@ -28,18 +28,18 @@
     "@jimp/jpeg": "0.22.12",
     "@jimp/plugin-resize": "0.22.12",
     "@jimp/plugin-scale": "0.22.12",
-    "usb-power-profiling": "1.5.0"
+    "usb-power-profiling": "1.6.0"
   },
   "devDependencies": {
     "@types/selenium-webdriver": "4.1.25",
-    "ava": "6.2.0",
+    "ava": "6.3.0",
     "clean-jsdoc-theme": "4.3.0",
-    "eslint": "9.17.0",
-    "eslint-config-prettier": "9.1.0",
-    "eslint-plugin-prettier": "5.2.1",
+    "eslint": "9.27.0",
+    "eslint-config-prettier": "10.1.5",
+    "eslint-plugin-prettier": "5.4.1",
     "eslint-plugin-unicorn": "56.0.1",
     "jsdoc": "4.0.4",
-    "prettier": "3.4.2",
+    "prettier": "3.5.3",
     "serve": "14.2.4",
     "serve-handler": "6.1.6",
     "typescript": "5.7.2"

package/types/core/engine/command/wait.d.ts

@@ -44,6 +44,16 @@ export class Wait {
      * @throws {Error} Throws an error if the element is not found within the specified time.
      */
     byXpath(xpath: string, maxTime: number): Promise<void>;
+    /**
+     * Waits for an element located by XPath to appear and visible within a maximum time.
+     *
+     * @async
+     * @param {string} xpath - The XPath of the element to wait for.
+     * @param {number} maxTime - Maximum time to wait in milliseconds.
+     * @returns {Promise<void>} A promise that resolves when the element is found or the time times out.
+     * @throws {Error} Throws an error if the element is not found within the specified time.
+     */
+    byXpathAndVisible(xpath: string, maxTime?: number): Promise<void>;
     /**
      * Waits for an element located by a CSS selector to appear within a maximum time.
      *
@@ -54,6 +64,16 @@ export class Wait {
      * @throws {Error} Throws an error if the element is not found within the specified time.
      */
     bySelector(selector: string, maxTime: number): Promise<void>;
+    /**
+     * Waits for an element located by a CSS selector to be visible within a maximum time.
+     *
+     * @async
+     * @param {string} selector - The CSS selector of the element to wait for.
+     * @param {number} maxTime - Maximum time to wait in milliseconds.
+     * @returns {Promise<void>} A promise that resolves when the element is found or the time times out.
+     * @throws {Error} Throws an error if the element is not found within the specified time.
+     */
+    bySelectorAndVisible(selector: string, maxTime?: number): Promise<void>;
     /**
      * Waits for a specified amount of time.
      *

package/types/core/engine/command/wait.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"wait.d.ts","sourceRoot":"","sources":["../../../../lib/core/engine/command/wait.js"],"names":[],"mappings":"AAKA;;;;;GAKG;AACH;IACE,kDASC;IARC;;OAEG;IACH,gBAAsB;IACtB;;OAEG;IACH,0BAA0C;IAG5C;;;;;;;;OAQG;IACH,SALW,MAAM,WACN,MAAM,GACJ,OAAO,CAAC,IAAI,CAAC,CAiBzB;IAED;;;;;;;;OAQG;IACH,mBALW,MAAM,YACN,MAAM,GACJ,OAAO,CAAC,IAAI,CAAC,CAmBzB;IAED;;;;;;;;OAQG;IACH,eALW,MAAM,WACN,MAAM,GACJ,OAAO,CAAC,IAAI,CAAC,CAmBzB;IAED;;;;;;;;OAQG;IACH,qBALW,MAAM,WACN,MAAM,GACJ,OAAO,CAAC,IAAI,CAAC,CAuBzB;IAED;;;;;;;OAOG;IACH,WAHW,MAAM,GACJ,OAAO,CAAC,IAAI,CAAC,CAIzB;IAED;;;;;OAKG;IACH,oBAFa,OAAO,CAAC,IAAI,CAAC,CAIzB;IAED;;;;;;;;OAQG;IACH,0BALW,MAAM,WACN,MAAM,GACJ,OAAO,CAAC,IAAI,CAAC,CAiBzB;CACF"}
+{"version":3,"file":"wait.d.ts","sourceRoot":"","sources":["../../../../lib/core/engine/command/wait.js"],"names":[],"mappings":"AAKA;;;;;GAKG;AACH;IACE,kDASC;IARC;;OAEG;IACH,gBAAsB;IACtB;;OAEG;IACH,0BAA0C;IAG5C;;;;;;;;OAQG;IACH,SALW,MAAM,WACN,MAAM,GACJ,OAAO,CAAC,IAAI,CAAC,CAiBzB;IAED;;;;;;;;OAQG;IACH,mBALW,MAAM,YACN,MAAM,GACJ,OAAO,CAAC,IAAI,CAAC,CAmBzB;IAED;;;;;;;;OAQG;IACH,eALW,MAAM,WACN,MAAM,GACJ,OAAO,CAAC,IAAI,CAAC,CAmBzB;IAED;;;;;;;;OAQG;IACH,yBALW,MAAM,YACN,MAAM,GACJ,OAAO,CAAC,IAAI,CAAC,CAqBzB;IAED;;;;;;;;OAQG;IACH,qBALW,MAAM,WACN,MAAM,GACJ,OAAO,CAAC,IAAI,CAAC,CAuBzB;IAED;;;;;;;;OAQG;IACH,+BALW,MAAM,YACN,MAAM,GACJ,OAAO,CAAC,IAAI,CAAC,CAwBzB;IAED;;;;;;;OAOG;IACH,WAHW,MAAM,GACJ,OAAO,CAAC,IAAI,CAAC,CAIzB;IAED;;;;;OAKG;IACH,oBAFa,OAAO,CAAC,IAAI,CAAC,CAIzB;IAED;;;;;;;;OAQG;IACH,0BALW,MAAM,WACN,MAAM,GACJ,OAAO,CAAC,IAAI,CAAC,CAiBzB;CACF"}