browsertime 24.0.0-alpha.3 → 24.0.0-alpha.5

package/CHANGELOG.md

@@ -2,6 +2,10 @@
 
 ## 24.0.0-alpha.3 - 2025-01-10
 
+The 24.0.0 release remove a lot of dependencies. Since we implemented Browsertime the first time, there are many things that are easy to do in modern NodeJS. Those things have now been implemented in Browsertime.
+
+This release would work exactly as before, the only thing that changed is that usb-power-profiling is a optional dependency. That means that if you install using `--omit=optional` that dependency is not installed.
+
 ### Changed
 * Moved usb-power-profiling to be an optional package [#2249](https://github.com/sitespeedio/browsertime/pull/2249).
 
@@ -21,6 +25,8 @@
   * Replace jimp with jimp custom [#2243](https://github.com/sitespeedio/browsertime/pull/2243).
   * Replace @cypress/xvfb [#2245](https://github.com/sitespeedio/browsertime/pull/2245).
   * Replace intel (log) with sitespeed.io/log [#2246](https://github.com/sitespeedio/browsertime/pull/2246).
+  * Replace lodash.set [#2250](https://github.com/sitespeedio/browsertime/pull/2250).
+  * Replace lodash.get [#2251](https://github.com/sitespeedio/browsertime/pull/2251).
 * Fix Docker file ENV to follow the new standard [#2239](https://github.com/sitespeedio/browsertime/pull/2239).
 
 

package/bin/browsertime.js

@@ -1,7 +1,5 @@
 #!/usr/bin/env node
 import merge from 'lodash.merge';
-import get from 'lodash.get';
-import set from 'lodash.set';
 import { getLogger } from '@sitespeed.io/log';
 import { existsSync, mkdirSync } from 'node:fs';
 import path from 'node:path';
@@ -15,6 +13,7 @@ import { configure } from '../lib/support/logging.js';
 import { parseCommandLine } from '../lib/support/cli.js';
 import { StorageManager } from '../lib/support/storageManager.js';
 import { loadScript } from '../lib/support/engineUtils.js';
+import { setProperty, getProperty } from '../lib/support/util.js';
 import { isAndroidConfigured } from '../lib/android/index.js';
 
 const log = getLogger('browsertime');
@@ -40,28 +39,28 @@ async function preWarmServer(urls, options) {
     docker: options.docker,
     headless: options.headless
   };
-  const chromeDevice = get(options, 'chrome.android.deviceSerial');
-  const firefoxDevice = get(options, 'firefox.android.deviceSerial');
-  const safariIos = get(options, 'safari.ios');
-  const safariDeviceName = get(options, 'safari.deviceName');
-  const safariDeviceUDID = get(options, 'safari.deviceUDID ');
+  const chromeDevice = getProperty(options, 'chrome.android.deviceSerial');
+  const firefoxDevice = getProperty(options, 'firefox.android.deviceSerial');
+  const safariIos = getProperty(options, 'safari.ios');
+  const safariDeviceName = getProperty(options, 'safari.deviceName');
+  const safariDeviceUDID = getProperty(options, 'safari.deviceUDID ');
 
   if (isAndroidConfigured(options) && options.browser === 'chrome') {
-    set(preWarmOptions, 'chrome.android.package', 'com.android.chrome');
+    setProperty(preWarmOptions, 'chrome.android.package', 'com.android.chrome');
   }
   if (chromeDevice) {
-    set(preWarmOptions, 'chrome.android.deviceSerial', chromeDevice);
+    setProperty(preWarmOptions, 'chrome.android.deviceSerial', chromeDevice);
   } else if (firefoxDevice) {
-    set(preWarmOptions, 'firefox.android.deviceSerial', firefoxDevice);
+    setProperty(preWarmOptions, 'firefox.android.deviceSerial', firefoxDevice);
   }
 
   if (safariIos) {
-    set(preWarmOptions, 'safari.ios', true);
+    setProperty(preWarmOptions, 'safari.ios', true);
     if (safariDeviceName) {
-      set(preWarmOptions, 'safari.deviceName', safariDeviceName);
+      setProperty(preWarmOptions, 'safari.deviceName', safariDeviceName);
     }
     if (safariDeviceUDID) {
-      set(preWarmOptions, 'safari.deviceUDID', safariDeviceUDID);
+      setProperty(preWarmOptions, 'safari.deviceUDID', safariDeviceUDID);
     }
   }
 

package/lib/android/index.js

@@ -6,9 +6,9 @@ import { execa } from 'execa';
 import { getLogger } from '@sitespeed.io/log';
 import pkg from '@devicefarmer/adbkit';
 const { Adb } = pkg;
-import get from 'lodash.get';
 import { pathToFolder } from '../support/pathToFolder.js';
 import { loadUsbPowerProfiler } from '../support/usbPower.js';
+import { getProperty } from '../support/util.js';
 const log = getLogger('browsertime.android');
 const mkdir = promisify(_mkdir);
 const delay = ms => new Promise(res => setTimeout(res, ms));
@@ -25,10 +25,10 @@ export class Android {
     Android.instance = this;
     this.client = Adb.createClient();
 
-    this.id = get(
+    this.id = getProperty(
       options,
       'chrome.android.deviceSerial',
-      get(options, 'firefox.android.deviceSerial')
+      getProperty(options, 'firefox.android.deviceSerial')
     );
     this.port = options.devToolsPort;
 
@@ -594,10 +594,10 @@ export function isAndroidConfigured(options) {
   if (options.android && options.android.enabled === true) {
     return true;
   }
-  return get(
+  return getProperty(
     options,
     'chrome.android.package',
-    get(options, 'firefox.android.package', false)
+    getProperty(options, 'firefox.android.package', false)
   )
     ? true
     : false;

package/lib/chrome/longTaskMetrics.js

@@ -1,4 +1,4 @@
-import get from 'lodash.get';
+import { getProperty } from '../support/util.js';
 
 export function longTaskMetrics(result, options) {
   let totalDurationFirstPaint = 0;
@@ -12,21 +12,24 @@ export function longTaskMetrics(result, options) {
   // https://web.dev/tbt/ - total blocking time
   let totalBlockingTime = 0;
 
-  const firstPaint = get(
+  const firstPaint = getProperty(
     result,
     'browserScripts.timings.paintTiming.first-paint'
   );
-  const firstContentfulPaint = get(
+  const firstContentfulPaint = getProperty(
     result,
     'browserScripts.timings.paintTiming.first-contentful-paint'
   );
 
-  const largestContentfulPaint = get(
+  const largestContentfulPaint = getProperty(
     result,
     'browserScripts.timings.largestContentfulPaint.renderTime'
   ); // result.browserScripts.timings.largestContentfulPaint.loadTime;
 
-  const loadEventEnd = get(result, 'browserScripts.timings.loadEventEnd');
+  const loadEventEnd = getProperty(
+    result,
+    'browserScripts.timings.loadEventEnd'
+  );
 
   let longTasksBeforeFirstPaint = 0;
   let longTasksBeforeFirstContentfulPaint = 0;

package/lib/chrome/networkManager.js

@@ -1,12 +1,16 @@
 import { getLogger } from '@sitespeed.io/log';
-import get from 'lodash.get';
+import { getProperty } from '../support/util.js';
 
 const log = getLogger('browsertime.chrome.network');
 
 export class NetworkManager {
   constructor(cdpClient, options) {
-    this.maxTimeout = get(options, 'timeouts.pageCompleteCheck', 30_000);
-    this.idleTime = get(options, 'timeouts.networkIdle', 5000);
+    this.maxTimeout = getProperty(
+      options,
+      'timeouts.pageCompleteCheck',
+      30_000
+    );
+    this.idleTime = getProperty(options, 'timeouts.networkIdle', 5000);
 
     this.cdp = cdpClient.getRawClient();
     this.inflight = 0;

package/lib/chrome/webdriver/builder.js

@@ -1,9 +1,8 @@
-import get from 'lodash.get';
 import { logging } from 'selenium-webdriver';
 import { ServiceBuilder, Options } from 'selenium-webdriver/chrome.js';
 import { pac, manual } from 'selenium-webdriver/proxy.js';
 import { setupChromiumOptions } from './setupChromiumOptions.js';
-import { pick, isEmpty } from '../../support/util.js';
+import { pick, isEmpty, getProperty } from '../../support/util.js';
 
 /**
  * Configure a WebDriver builder based on the specified options.
@@ -13,7 +12,7 @@ import { pick, isEmpty } from '../../support/util.js';
 export async function configureBuilder(builder, baseDir, options) {
   const chromeConfig = options.chrome || {};
 
-  let chromedriverPath = get(chromeConfig, 'chromedriverPath');
+  let chromedriverPath = getProperty(chromeConfig, 'chromedriverPath');
   if (!chromedriverPath) {
     let chromedriver = await import('@sitespeed.io/chromedriver');
     chromedriverPath = chromedriver.default.binPath();
@@ -62,7 +61,7 @@ export async function configureBuilder(builder, baseDir, options) {
 
   builder
     .getCapabilities()
-    .set('pageLoadStrategy', get(options, 'pageLoadStrategy', 'normal'))
+    .set('pageLoadStrategy', getProperty(options, 'pageLoadStrategy', 'normal'))
     .set('goog:loggingPrefs', logPrefs); // Fix for Chrome/Chromedriver 75
 
   setupChromiumOptions(chromeOptions, chromeConfig, options, baseDir);

package/lib/connectivity/humble.js

@@ -1,12 +1,12 @@
 import http from 'node:http';
 import https from 'node:https';
-import get from 'lodash.get';
 import { getLogger } from '@sitespeed.io/log';
+import { getProperty } from '../support/util.js';
 const log = getLogger('browsertime.connectivity.humble');
 
 export class Humble {
   constructor(options) {
-    this.url = get(options.connectivity, 'humble.url');
+    this.url = getProperty(options.connectivity, 'humble.url');
     this.profile = options.connectivity.profile;
   }
 

package/lib/connectivity/index.js

@@ -1,4 +1,3 @@
-import get from 'lodash.get';
 import { getLogger } from '@sitespeed.io/log';
 import {
   start as throttleStart,
@@ -7,6 +6,7 @@ import {
 const log = getLogger('browsertime.connectivity');
 import { Humble } from './humble.js';
 import { parseTrafficShapeConfig } from './trafficShapeParser.js';
+import { getProperty } from '../support/util.js';
 
 let humble;
 
@@ -49,7 +49,11 @@ export async function addConnectivity(options) {
         }
       }
 
-      const setOnLocalHost = get(connectivity, 'throttle.localhost', false);
+      const setOnLocalHost = getProperty(
+        connectivity,
+        'throttle.localhost',
+        false
+      );
       const rtt = profile.variance
         ? getRandomIntInclusive(
             profile.rtt,
@@ -96,7 +100,11 @@ export async function removeConnectivity(options) {
       return;
     }
     case 'throttle': {
-      const setOnLocalHost = get(connectivity, 'throttle.localhost', false);
+      const setOnLocalHost = getProperty(
+        connectivity,
+        'throttle.localhost',
+        false
+      );
       return throttleStop({ localhost: setOnLocalHost });
     }
     case 'humble': {

package/lib/core/engine/collector.js

@@ -1,12 +1,11 @@
 import path from 'node:path';
 import { createRequire } from 'node:module';
-import get from 'lodash.get';
 import { getLogger } from '@sitespeed.io/log';
 import { timestamp as _timestamp } from '../../support/engineUtils.js';
 import { Statistics } from '../../support/statistics.js';
 import { pathToFolder } from '../../support/pathToFolder.js';
 import { getConnectivitySettings } from '../../connectivity/index.js';
-import { formatMetric } from '../../support/util.js';
+import { formatMetric, getProperty } from '../../support/util.js';
 const require = createRequire(import.meta.url);
 const version = require('../../../package.json').version;
 const log = getLogger('browsertime');
@@ -20,11 +19,11 @@ function getNewResult(url, options) {
       url,
       timestamp: _timestamp(),
       connectivity: {
-        engine: get(options, 'connectivity.engine'),
-        profile: get(options, 'connectivity.profile'),
+        engine: getProperty(options, 'connectivity.engine'),
+        profile: getProperty(options, 'connectivity.profile'),
         settings: getConnectivitySettings(options) || undefined
       },
-      extra: JSON.parse(get(options, 'info.extra', '{}')),
+      extra: JSON.parse(getProperty(options, 'info.extra', '{}')),
       browser: { name: options.browser }
     },
     files: {
@@ -163,7 +162,7 @@ export class Collector {
       const results = this.allResults[url] ?? getNewResult(url, this.options);
       results.info.description = allData.description;
       results.info.title = allData.title;
-      results.info.browser.userAgent = get(
+      results.info.browser.userAgent = getProperty(
         allData[0],
         'browserScripts.browser.userAgent',
         ''
@@ -238,30 +237,36 @@ export class Collector {
       }
 
       if (this.options.iterations > 1) {
-        const ttfb = get(
+        const ttfb = getProperty(
           data,
           'browserScripts.timings.pageTimings.backEndTime'
         );
-        const domContentLoaded = get(
+        const domContentLoaded = getProperty(
           data,
           'browserScripts.timings.pageTimings.domContentLoadedTime'
         );
-        const firstPaint = get(data, 'browserScripts.timings.firstPaint');
-        const fcp = get(
+        const firstPaint = getProperty(
+          data,
+          'browserScripts.timings.firstPaint'
+        );
+        const fcp = getProperty(
           data,
           "browserScripts.timings.paintTiming['first-contentful-paint']"
         );
-        const pageLoadTime = get(
+        const pageLoadTime = getProperty(
           data,
           'browserScripts.timings.pageTimings.pageLoadTime'
         );
-        const lcp = get(
+        const lcp = getProperty(
           data,
           'browserScripts.timings.largestContentfulPaint.renderTime'
         );
-        const cls = get(data, 'browserScripts.pageinfo.cumulativeLayoutShift');
-        const tbt = get(data, 'cpu.longTasks.totalBlockingTime');
-        const mem = get(data, 'memory');
+        const cls = getProperty(
+          data,
+          'browserScripts.pageinfo.cumulativeLayoutShift'
+        );
+        const tbt = getProperty(data, 'cpu.longTasks.totalBlockingTime');
+        const mem = getProperty(data, 'memory');
 
         log.info(
           `${url} ${ttfb ? formatMetric('TTFB', ttfb, false, true) + ' ' : ''}${
@@ -451,17 +456,23 @@ export class Collector {
 
       // Add delta to TTFB
       const deltaToTTFB = {};
-      const fcp = get(
+      const fcp = getProperty(
         data,
         "browserScripts.timings.paintTiming['first-contentful-paint']"
       );
-      const ttfb = get(data, 'browserScripts.timings.ttfb');
-      const lcp = get(
+      const ttfb = getProperty(data, 'browserScripts.timings.ttfb');
+      const lcp = getProperty(
         data,
         'browserScripts.timings.largestContentfulPaint.renderTime'
       );
-      const firstVisualChange = get(data, 'visualMetrics.FirstVisualChange');
-      const lastVisualChange = get(data, 'visualMetrics.LastVisualChange');
+      const firstVisualChange = getProperty(
+        data,
+        'visualMetrics.FirstVisualChange'
+      );
+      const lastVisualChange = getProperty(
+        data,
+        'visualMetrics.LastVisualChange'
+      );
 
       if (fcp) {
         deltaToTTFB['firstContentfulPaint'] = fcp - ttfb;

package/lib/core/engine/command/measure.js

@@ -1,6 +1,5 @@
 import path from 'node:path';
 import { getLogger } from '@sitespeed.io/log';
-import get from 'lodash.get';
 import merge from 'lodash.merge';
 import { timestamp as _timestamp } from '../../../support/engineUtils.js';
 import { Video } from '../../../video/video.js';
@@ -12,6 +11,7 @@ import {
 } from '../../../support/userTiming.js';
 import { isAndroidConfigured, Android } from '../../../android/index.js';
 import { TCPDump } from '../../../support/tcpdump.js';
+import { getProperty } from '../../../support/util.js';
 import { lcpHighlightScript as highlightLargestContentfulPaint } from './util/lcpHighlightScript.js';
 import { clsHighlightScript as highlightLS } from './util/lsHighlightScript.js';
 const delay = ms => new Promise(res => setTimeout(res, ms));
@@ -132,15 +132,23 @@ export class Measure {
     /**
      * @private
      */
-    this.ANDROID_DELAY_TIME = get(options, 'orangeAndroidDelayTime', 2000);
+    this.ANDROID_DELAY_TIME = getProperty(
+      options,
+      'orangeAndroidDelayTime',
+      2000
+    );
     /**
      * @private
      */
-    this.IOS_DELAY_TIME = get(options, 'orangeIosDelayTime', 1000);
+    this.IOS_DELAY_TIME = getProperty(options, 'orangeIosDelayTime', 1000);
     /**
      * @private
      */
-    this.DESKTOP_DELAY_TIME = get(options, 'orangeDesktopDelayTime', 800);
+    this.DESKTOP_DELAY_TIME = getProperty(
+      options,
+      'orangeDesktopDelayTime',
+      800
+    );
   }
 
   /**
@@ -657,8 +665,12 @@ export class Measure {
     if (isAndroidConfigured(this.options) && this.options.processStartTime) {
       const packageName =
         this.options.browser === 'firefox'
-          ? get(this.options, 'firefox.android.package', 'org.mozilla.firefox')
-          : get(this.options, 'chrome.android.package');
+          ? getProperty(
+              this.options,
+              'firefox.android.package',
+              'org.mozilla.firefox'
+            )
+          : getProperty(this.options, 'chrome.android.package');
 
       const android = new Android(this.options);
       const pid = await android.pidof(packageName);

package/lib/core/engine/index.js

@@ -2,7 +2,6 @@ import { arch as _arch } from 'node:os';
 import { getLogger } from '@sitespeed.io/log';
 import merge from 'lodash.merge';
 import { execaCommand as command } from 'execa';
-import get from 'lodash.get';
 import { StorageManager } from '../../support/storageManager.js';
 import { Firefox } from '../../firefox/webdriver/firefox.js';
 import { Chromium } from '../../chrome/webdriver/chromium.js';
@@ -11,7 +10,7 @@ import {
   addConnectivity,
   removeConnectivity
 } from '../../connectivity/index.js';
-import { logResultLogLine } from '../../support/util.js';
+import { logResultLogLine, getProperty } from '../../support/util.js';
 import {
   getFullyLoaded,
   getMainDocumentTimings,
@@ -108,7 +107,11 @@ export class Engine {
       }
 
       if (options.androidVerifyNetwork) {
-        const pingAddress = get(options, 'androidPingAddress', '8.8.8.8');
+        const pingAddress = getProperty(
+          options,
+          'androidPingAddress',
+          '8.8.8.8'
+        );
         const connection = await android.ping(pingAddress);
         if (!connection) {
           const message = `No internet connection for ${android.id}. Could not ping ${pingAddress}`;

package/lib/core/seleniumRunner.js

@@ -1,6 +1,5 @@
 import { getLogger } from '@sitespeed.io/log';
 import merge from 'lodash.merge';
-import get from 'lodash.get';
 import { Condition } from 'selenium-webdriver';
 import { isAndroidConfigured } from '../android/index.js';
 import { UrlLoadError, BrowserError, TimeoutError } from '../support/errors.js';
@@ -9,6 +8,7 @@ import { getViewPort } from '../support/getViewPort.js';
 import { defaultPageCompleteCheck } from './pageCompleteChecks/defaultPageCompleteCheck.js';
 import { pageCompleteCheckByInactivity } from './pageCompleteChecks/pageCompleteCheckByInactivity.js';
 import { spaInactivity as spaCheck } from './pageCompleteChecks/spaInactivity.js';
+import { getProperty } from '../support/util.js';
 const log = getLogger('browsertime');
 
 const defaults = {
@@ -292,7 +292,7 @@ export class SeleniumRunner {
       // We give it a couple of times to finish loading, this makes it
       // more stable in real case scenarios on slow servers.
       let totalWaitTime = 0;
-      const tries = get(this.options, 'retries', 5) + 1;
+      const tries = getProperty(this.options, 'retries', 5) + 1;
       for (let index = 0; index < tries; ++index) {
         try {
           await this._waitOnPageCompleteCheck(pageCompleteCheck, normalizedURI);

package/lib/edge/webdriver/builder.js

@@ -1,18 +1,17 @@
 import { Options, ServiceBuilder } from 'selenium-webdriver/edge.js';
 import { getLogger } from '@sitespeed.io/log';
-import get from 'lodash.get';
 import { logging } from 'selenium-webdriver';
 import { setupChromiumOptions } from '../../chrome/webdriver/setupChromiumOptions.js';
 const log = getLogger('browsertime.edge');
 const { pac, manual } = 'selenium-webdriver/proxy.js';
-import { pick, isEmpty } from '../../support/util.js';
+import { pick, isEmpty, getProperty } from '../../support/util.js';
 
 export async function configureBuilder(builder, baseDir, options) {
   const edgeConfig = options.edge || {};
   const chromeConfig = options.chrome || {};
 
-  let edgedriverPath = get(edgeConfig, 'edgedriverPath');
-  const edgePath = get(edgeConfig, 'binaryPath');
+  let edgedriverPath = getProperty(edgeConfig, 'edgedriverPath');
+  const edgePath = getProperty(edgeConfig, 'binaryPath');
 
   if (!edgedriverPath) {
     const edgedriver = await import('@sitespeed.io/edgedriver');
@@ -67,7 +66,7 @@ export async function configureBuilder(builder, baseDir, options) {
 
   builder
     .getCapabilities()
-    .set('pageLoadStrategy', get(options, 'pageLoadStrategy', 'normal'))
+    .set('pageLoadStrategy', getProperty(options, 'pageLoadStrategy', 'normal'))
     .set('ms:loggingPrefs', logPrefs);
 
   setupChromiumOptions(edgeOptions, chromeConfig, options, baseDir);

package/lib/firefox/geckoProfiler.js

@@ -1,10 +1,10 @@
 import path from 'node:path';
-import get from 'lodash.get';
 import { getLogger } from '@sitespeed.io/log';
 import { geckoProfilerDefaults } from './settings/geckoProfilerDefaults.js';
 import { isAndroidConfigured, Android } from '../android/index.js';
 import { pathToFolder } from '../support/pathToFolder.js';
 import { BrowserError } from '../support/errors.js';
+import { getProperty } from '../support/util.js';
 const delay = ms => new Promise(res => setTimeout(res, ms));
 const log = getLogger('browsertime.firefox');
 
@@ -104,7 +104,7 @@ export class GeckoProfiler {
     const runner = this.runner;
     const firefoxConfig = this.firefoxConfig;
     const options = this.options;
-    const chosenFeatures = get(
+    const chosenFeatures = getProperty(
       firefoxConfig,
       'geckoProfilerParams.features',
       geckoProfilerDefaults.features
@@ -112,14 +112,14 @@ export class GeckoProfiler {
 
     const featureString = '["' + chosenFeatures.join('","') + '"]';
 
-    const chosenThreads = get(
+    const chosenThreads = getProperty(
       firefoxConfig,
       'geckoProfilerParams.threads',
       geckoProfilerDefaults.threads
     ).split(',');
     const threadString = '["' + chosenThreads.join('","') + '"]';
 
-    let interval = get(
+    let interval = getProperty(
       firefoxConfig,
       'geckoProfilerParams.interval',
       geckoProfilerDefaults.interval
@@ -135,7 +135,7 @@ export class GeckoProfiler {
         : geckoProfilerDefaults.desktopSamplingInterval;
     }
 
-    const bufferSize = get(
+    const bufferSize = getProperty(
       firefoxConfig,
       'geckoProfilerParams.bufferSize',
       geckoProfilerDefaults.bufferSize
@@ -208,7 +208,7 @@ export class GeckoProfiler {
 
     let deviceProfileFilename = destinationFilename;
     if (isAndroidConfigured(options)) {
-      deviceProfileFilename = `/sdcard/Android/data/${get(
+      deviceProfileFilename = `/sdcard/Android/data/${getProperty(
         this.firefoxConfig,
         'android.package',
         'org.mozilla.firefox'
@@ -250,7 +250,7 @@ export class GeckoProfiler {
       }
 
       if (this.firefoxConfig.powerConsumption === true) {
-        const chosenFeatures = get(
+        const chosenFeatures = getProperty(
           this.firefoxConfig,
           'geckoProfilerParams.features',
           geckoProfilerDefaults.features

package/lib/firefox/networkManager.js

@@ -1,13 +1,17 @@
 import { getLogger } from '@sitespeed.io/log';
-import get from 'lodash.get';
+import { getProperty } from '../support/util.js';
 const log = getLogger('browsertime.chrome.network');
 
 export class NetworkManager {
   constructor(bidi, browsingContextIds, options) {
     this.bidi = bidi;
     this.browsingContextIds = browsingContextIds;
-    this.maxTimeout = get(options, 'timeouts.pageCompleteCheck', 30_000);
-    this.idleTime = get(options, 'timeouts.networkIdle', 5000);
+    this.maxTimeout = getProperty(
+      options,
+      'timeouts.pageCompleteCheck',
+      30_000
+    );
+    this.idleTime = getProperty(options, 'timeouts.networkIdle', 5000);
   }
 
   async waitForNetworkIdle() {