browsertime 22.4.0 → 22.4.1

package/CHANGELOG.md

@@ -1,5 +1,9 @@
 # Browsertime changelog (we do [semantic versioning](https://semver.org))
 
+## 22.3.1 - 2024-06-07
+### Fixed
+* Make sure the engine is stopped before the extra video/profile run [#2140](https://github.com/sitespeedio/browsertime/pull/2140).
+
 ## 22.3.0 - 2024-06-06
 ### Added
 * Use `--enableVideoRun` to get one extra run with a video and visual metrics [#2139](https://github.com/sitespeedio/browsertime/pull/2139)

package/bin/browsertime.js

@@ -123,40 +123,6 @@ async function run(urls, options) {
         );
       }
 
-      if (options.enableProfileRun || options.enableVideoRun) {
-        log.info('Make one extra run to collect trace/video information');
-        options.iterations = 1;
-        if (options.enableProfileRun) {
-          if (options.browser === 'firefox') {
-            options.firefox.geckoProfiler = true;
-          } else if (options.browser === 'chrome') {
-            options.chrome.timeline = true;
-            options.cpu = true;
-            options.chrome.enableTraceScreenshots = true;
-            options.chrome.traceCategory = [
-              'disabled-by-default-v8.cpu_profiler'
-            ];
-          }
-        }
-        if (options.enableVideoRun) {
-          if (options.video === true) {
-            log.error(
-              'You can only configure video run if you do not collect any video'
-            );
-            // This is a hack to not get an error
-            options.video = false;
-            options.visualMetrics = false;
-          } else {
-            options.video = true;
-            options.visualMetrics = true;
-          }
-        }
-        const traceEngine = new Engine(options);
-        await traceEngine.start();
-        await traceEngine.runMultiple(urls, scriptsByCategory);
-        await traceEngine.stop();
-      }
-
       await Promise.all(saveOperations);
 
       const resultDirectory = relative(process.cwd(), storageManager.directory);
@@ -186,6 +152,41 @@ async function run(urls, options) {
         process.exitCode = 1;
       }
     }
+
+    if (options.enableProfileRun || options.enableVideoRun) {
+      log.info('Make one extra run to collect trace/video information');
+      options.iterations = 1;
+      if (options.enableProfileRun) {
+        if (options.browser === 'firefox') {
+          options.firefox.geckoProfiler = true;
+        } else if (options.browser === 'chrome') {
+          options.chrome.timeline = true;
+          options.cpu = true;
+          options.chrome.enableTraceScreenshots = true;
+          options.chrome.traceCategory = [
+            'disabled-by-default-v8.cpu_profiler'
+          ];
+        }
+      }
+      if (options.enableVideoRun) {
+        if (options.video === true) {
+          log.error(
+            'You can only configure video run if you do not collect any video'
+          );
+          // This is a hack to not get an error
+          options.video = false;
+          options.visualMetrics = false;
+        } else {
+          options.video = true;
+          options.visualMetrics = true;
+        }
+      }
+      const traceEngine = new Engine(options);
+      await traceEngine.start();
+      await traceEngine.runMultiple(urls, scriptsByCategory);
+      await traceEngine.stop();
+      log.info('Extra run finished');
+    }
   } catch (error) {
     log.error('Error running browsertime', error);
     process.exitCode = 1;

package/package.json

@@ -1,7 +1,7 @@
 {
   "name": "browsertime",
   "description": "Get performance metrics from your web page using Browsertime.",
-  "version": "22.4.0",
+  "version": "22.4.1",
   "bin": "./bin/browsertime.js",
   "type": "module",
   "types": "./types/scripting.d.ts",