browsertime 22.10.1 → 23.0.0

package/CHANGELOG.md

@@ -1,9 +1,26 @@
 # Browsertime changelog (we do [semantic versioning](https://semver.org))
 
+## 23.0.0 - 2024-09-23
+
+### Breaking
+* Disable camel case configuration that comes automatically with yargs [#2182](https://github.com/sitespeedio/browsertime/pull/2182). This is a breaking change ONLY if you didn't follow our doecumentation/help and used internal YARGS configuration names for our CLI configuration.
+
+### Added
+* Updated Docker container with Chrome 129, Firefox 130. New Chromedriver [#2181](https://github.com/sitespeedio/browsertime/pull/2181).
+
+### Fixed
+* Updated to Selenium 4.25.0 [#2185](https://github.com/sitespeedio/browsertime/pull/2185).
+* Use HAR export 0.0.15 for upcoming changes in Firefox [#2184](https://github.com/sitespeedio/browsertime/pull/2184).
+* Fixes the internal configuration object for android. The old solution created an array with objects instead of just keys on the object.[#2183](https://github.com/sitespeedio/browsertime/pull/2183).
+
+## 22.10.2 - 2024-09-13
+### Fixed
+* Fix for wait.byIdAndVisible command [#2179](https://github.com/sitespeedio/browsertime/pull/2179).
 
 ## 22.10.1 - 2024-09-04
 ### Fixed
 * Upgraded Bidi HAR to 0.0.14 that filters out data:text URLs thar is picked up in Firefox 130 [#2177](https://github.com/sitespeedio/browsertime/pull/2177).
+* Call stopSampling on browser stop during android power testing [#2176](https://github.com/sitespeedio/browsertime/pull/2176).
 
 ## 22.10.0 - 2024-09-03
 ### Added

package/lib/core/engine/command/wait.js

@@ -55,12 +55,15 @@ export class Wait {
    * @returns {Promise<void>} A promise that resolves when the element is found or the time times out.
    * @throws {Error} Throws an error if the element is not found within the specified time.
    */
-  async byIdAndVisible(id, maxTime) {
+  async byIdAndVisible(id, maxTime = 6000) {
     const driver = this.browser.getDriver();
     await this.byId(id, maxTime);
     try {
+      driver.findElement;
       await driver.wait(
-        webdriver.until.elementIsVisible(webdriver.By.id(id)),
+        webdriver.until.elementIsVisible(
+          driver.findElement(webdriver.By.id(id))
+        ),
         maxTime
       );
     } catch (error) {

package/lib/support/cli.js

@@ -63,11 +63,6 @@ function validateInput(argv) {
     }
   }
 
-  // hack to keep backward compability to --android
-  if (argv.android[0] === true) {
-    set(argv, 'android.enabled', true);
-  }
-
   if (argv.chrome && argv.chrome.mobileEmulation) {
     const m = argv.chrome.mobileEmulation;
     if (!(m.deviceName || (m.height && m.width && m.pixelRatio))) {
@@ -144,9 +139,16 @@ function validateInput(argv) {
 }
 
 export function parseCommandLine() {
-  let yargsInstance = yargs(hideBin(process.argv));
+  let argvFix = process.argv.map(arg =>
+    arg === '--android' ? '--android.enabled' : arg
+  );
+
+  let yargsInstance = yargs(hideBin(argvFix));
   let validated = yargsInstance
-    .parserConfiguration({ 'deep-merge-config': true })
+    .parserConfiguration({
+      'camel-case-expansion': false,
+      'deep-merge-config': true
+    })
     .env('BROWSERTIME')
     .usage('$0 [options] <url>/<scriptFile>')
     .require(1, 'One or more url or script files')

package/package.json

@@ -1,14 +1,14 @@
 {
   "name": "browsertime",
   "description": "Get performance metrics from your web page using Browsertime.",
-  "version": "22.10.1",
+  "version": "23.0.0",
   "bin": "./bin/browsertime.js",
   "type": "module",
   "types": "./types/scripting.d.ts",
   "dependencies": {
     "@cypress/xvfb": "1.2.4",
     "@devicefarmer/adbkit": "3.2.6",
-    "@sitespeed.io/chromedriver": "128.0.6613-86",
+    "@sitespeed.io/chromedriver": "129.0.6668-58",
     "@sitespeed.io/edgedriver": "126.0.2592-102",
     "@sitespeed.io/geckodriver": "0.35.0",
     "@sitespeed.io/throttle": "5.0.1",
@@ -19,7 +19,7 @@
     "dayjs": "1.11.13",
     "execa": "9.3.1",
     "fast-stats": "0.0.7",
-    "ff-test-bidi-har-export": "0.0.14",
+    "ff-test-bidi-har-export": "0.0.15",
     "find-up": "7.0.0",
     "get-port": "7.1.0",
     "hasbin": "1.2.3",
@@ -30,7 +30,7 @@
     "lodash.merge": "4.6.2",
     "lodash.pick": "4.4.0",
     "lodash.set": "4.3.2",
-    "selenium-webdriver": "4.24.0",
+    "selenium-webdriver": "4.25.0",
     "usb-power-profiling": "1.4.0",
     "yargs": "17.7.2"
   },

package/types/core/engine/command/wait.d.ts

@@ -33,7 +33,7 @@ export class Wait {
      * @returns {Promise<void>} A promise that resolves when the element is found or the time times out.
      * @throws {Error} Throws an error if the element is not found within the specified time.
      */
-    byIdAndVisible(id: string, maxTime: number): Promise<void>;
+    byIdAndVisible(id: string, maxTime?: number): Promise<void>;
     /**
      * Waits for an element located by XPath to appear within a maximum time.
      *

package/types/core/engine/command/wait.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"wait.d.ts","sourceRoot":"","sources":["../../../../lib/core/engine/command/wait.js"],"names":[],"mappings":"AAKA;;;;;GAKG;AACH;IACE,kDASC;IARC;;OAEG;IACH,gBAAsB;IACtB;;OAEG;IACH,0BAA0C;IAG5C;;;;;;;;OAQG;IACH,SALW,MAAM,WACN,MAAM,GACJ,OAAO,CAAC,IAAI,CAAC,CAiBzB;IAED;;;;;;;;OAQG;IACH,mBALW,MAAM,WACN,MAAM,GACJ,OAAO,CAAC,IAAI,CAAC,CAgBzB;IAED;;;;;;;;OAQG;IACH,eALW,MAAM,WACN,MAAM,GACJ,OAAO,CAAC,IAAI,CAAC,CAmBzB;IAED;;;;;;;;OAQG;IACH,qBALW,MAAM,WACN,MAAM,GACJ,OAAO,CAAC,IAAI,CAAC,CAuBzB;IAED;;;;;;;OAOG;IACH,WAHW,MAAM,GACJ,OAAO,CAAC,IAAI,CAAC,CAIzB;IAED;;;;;OAKG;IACH,oBAFa,OAAO,CAAC,IAAI,CAAC,CAIzB;IAED;;;;;;;;OAQG;IACH,0BALW,MAAM,WACN,MAAM,GACJ,OAAO,CAAC,IAAI,CAAC,CAiBzB;CACF"}
+{"version":3,"file":"wait.d.ts","sourceRoot":"","sources":["../../../../lib/core/engine/command/wait.js"],"names":[],"mappings":"AAKA;;;;;GAKG;AACH;IACE,kDASC;IARC;;OAEG;IACH,gBAAsB;IACtB;;OAEG;IACH,0BAA0C;IAG5C;;;;;;;;OAQG;IACH,SALW,MAAM,WACN,MAAM,GACJ,OAAO,CAAC,IAAI,CAAC,CAiBzB;IAED;;;;;;;;OAQG;IACH,mBALW,MAAM,YACN,MAAM,GACJ,OAAO,CAAC,IAAI,CAAC,CAmBzB;IAED;;;;;;;;OAQG;IACH,eALW,MAAM,WACN,MAAM,GACJ,OAAO,CAAC,IAAI,CAAC,CAmBzB;IAED;;;;;;;;OAQG;IACH,qBALW,MAAM,WACN,MAAM,GACJ,OAAO,CAAC,IAAI,CAAC,CAuBzB;IAED;;;;;;;OAOG;IACH,WAHW,MAAM,GACJ,OAAO,CAAC,IAAI,CAAC,CAIzB;IAED;;;;;OAKG;IACH,oBAFa,OAAO,CAAC,IAAI,CAAC,CAIzB;IAED;;;;;;;;OAQG;IACH,0BALW,MAAM,WACN,MAAM,GACJ,OAAO,CAAC,IAAI,CAAC,CAiBzB;CACF"}