browsertime 22.10.0 → 22.10.2

package/CHANGELOG.md

@@ -1,5 +1,14 @@
 # Browsertime changelog (we do [semantic versioning](https://semver.org))
 
+## 22.10.2 - 2024-09-13
+### Fixed
+* Fix for wait.byIdAndVisible command [#2179](https://github.com/sitespeedio/browsertime/pull/2179).
+
+## 22.10.1 - 2024-09-04
+### Fixed
+* Upgraded Bidi HAR to 0.0.14 that filters out data:text URLs thar is picked up in Firefox 130 [#2177](https://github.com/sitespeedio/browsertime/pull/2177).
+* Call stopSampling on browser stop during android power testing [#2176](https://github.com/sitespeedio/browsertime/pull/2176).
+
 ## 22.10.0 - 2024-09-03
 ### Added
 * Chromedriver 128 [#2175](https://github.com/sitespeedio/browsertime/pull/2175)

package/lib/chrome/webdriver/chromium.js

@@ -489,8 +489,12 @@ export class Chromium {
       await unlink(netlog);
     }
 
-    if (this.android && this.options.androidPower) {
-      await this.android.stopPowerTesting();
+    if (this.android) {
+      if (this.options.androidPower) {
+        await this.android.stopPowerTesting();
+      } else if (this.options.androidUsbPower) {
+        await usbPowerProfiler.stopSampling();
+      }
     }
 
     if (this.cdpClient) {

package/lib/core/engine/command/wait.js

@@ -55,12 +55,15 @@ export class Wait {
    * @returns {Promise<void>} A promise that resolves when the element is found or the time times out.
    * @throws {Error} Throws an error if the element is not found within the specified time.
    */
-  async byIdAndVisible(id, maxTime) {
+  async byIdAndVisible(id, maxTime = 6000) {
     const driver = this.browser.getDriver();
     await this.byId(id, maxTime);
     try {
+      driver.findElement;
       await driver.wait(
-        webdriver.until.elementIsVisible(webdriver.By.id(id)),
+        webdriver.until.elementIsVisible(
+          driver.findElement(webdriver.By.id(id))
+        ),
         maxTime
       );
     } catch (error) {

package/lib/firefox/webdriver/firefox.js

@@ -397,8 +397,12 @@ export class Firefox {
    * Before the browser is stopped/closed.
    */
   async beforeBrowserStop() {
-    if (isAndroidConfigured(this.options) && this.options.androidPower) {
-      await this.android.stopPowerTesting();
+    if (isAndroidConfigured(this.options)) {
+      if (this.options.androidPower) {
+        await this.android.stopPowerTesting();
+      } else if (this.options.androidUsbPower) {
+        await usbPowerProfiler.stopSampling();
+      }
     }
   }
 

package/package.json

@@ -1,7 +1,7 @@
 {
   "name": "browsertime",
   "description": "Get performance metrics from your web page using Browsertime.",
-  "version": "22.10.0",
+  "version": "22.10.2",
   "bin": "./bin/browsertime.js",
   "type": "module",
   "types": "./types/scripting.d.ts",
@@ -19,7 +19,7 @@
     "dayjs": "1.11.13",
     "execa": "9.3.1",
     "fast-stats": "0.0.7",
-    "ff-test-bidi-har-export": "0.0.13",
+    "ff-test-bidi-har-export": "0.0.14",
     "find-up": "7.0.0",
     "get-port": "7.1.0",
     "hasbin": "1.2.3",

package/types/core/engine/command/wait.d.ts

@@ -33,7 +33,7 @@ export class Wait {
      * @returns {Promise<void>} A promise that resolves when the element is found or the time times out.
      * @throws {Error} Throws an error if the element is not found within the specified time.
      */
-    byIdAndVisible(id: string, maxTime: number): Promise<void>;
+    byIdAndVisible(id: string, maxTime?: number): Promise<void>;
     /**
      * Waits for an element located by XPath to appear within a maximum time.
      *

package/types/core/engine/command/wait.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"wait.d.ts","sourceRoot":"","sources":["../../../../lib/core/engine/command/wait.js"],"names":[],"mappings":"AAKA;;;;;GAKG;AACH;IACE,kDASC;IARC;;OAEG;IACH,gBAAsB;IACtB;;OAEG;IACH,0BAA0C;IAG5C;;;;;;;;OAQG;IACH,SALW,MAAM,WACN,MAAM,GACJ,OAAO,CAAC,IAAI,CAAC,CAiBzB;IAED;;;;;;;;OAQG;IACH,mBALW,MAAM,WACN,MAAM,GACJ,OAAO,CAAC,IAAI,CAAC,CAgBzB;IAED;;;;;;;;OAQG;IACH,eALW,MAAM,WACN,MAAM,GACJ,OAAO,CAAC,IAAI,CAAC,CAmBzB;IAED;;;;;;;;OAQG;IACH,qBALW,MAAM,WACN,MAAM,GACJ,OAAO,CAAC,IAAI,CAAC,CAuBzB;IAED;;;;;;;OAOG;IACH,WAHW,MAAM,GACJ,OAAO,CAAC,IAAI,CAAC,CAIzB;IAED;;;;;OAKG;IACH,oBAFa,OAAO,CAAC,IAAI,CAAC,CAIzB;IAED;;;;;;;;OAQG;IACH,0BALW,MAAM,WACN,MAAM,GACJ,OAAO,CAAC,IAAI,CAAC,CAiBzB;CACF"}
+{"version":3,"file":"wait.d.ts","sourceRoot":"","sources":["../../../../lib/core/engine/command/wait.js"],"names":[],"mappings":"AAKA;;;;;GAKG;AACH;IACE,kDASC;IARC;;OAEG;IACH,gBAAsB;IACtB;;OAEG;IACH,0BAA0C;IAG5C;;;;;;;;OAQG;IACH,SALW,MAAM,WACN,MAAM,GACJ,OAAO,CAAC,IAAI,CAAC,CAiBzB;IAED;;;;;;;;OAQG;IACH,mBALW,MAAM,YACN,MAAM,GACJ,OAAO,CAAC,IAAI,CAAC,CAmBzB;IAED;;;;;;;;OAQG;IACH,eALW,MAAM,WACN,MAAM,GACJ,OAAO,CAAC,IAAI,CAAC,CAmBzB;IAED;;;;;;;;OAQG;IACH,qBALW,MAAM,WACN,MAAM,GACJ,OAAO,CAAC,IAAI,CAAC,CAuBzB;IAED;;;;;;;OAOG;IACH,WAHW,MAAM,GACJ,OAAO,CAAC,IAAI,CAAC,CAIzB;IAED;;;;;OAKG;IACH,oBAFa,OAAO,CAAC,IAAI,CAAC,CAIzB;IAED;;;;;;;;OAQG;IACH,0BALW,MAAM,WACN,MAAM,GACJ,OAAO,CAAC,IAAI,CAAC,CAiBzB;CACF"}