browsertime 18.0.0 → 19.0.0

package/CHANGELOG.md

@@ -1,5 +1,14 @@
 # Browsertime changelog (we do [semantic versioning](https://semver.org))
 
+
+## 19.0.0 - 2023-11-15
+### Breaking
+* This only affects you if you run your tests on a rooted Moto G5: With PR[#2021](https://github.com/sitespeedio/browsertime/pull/2021) we add the ability to set the CPU speed for the phone at min/middle/max (the same way as possible on Samsung A51). Before the speed always was set to max. Default now is that the CPU speed will be set to min (the same way as the A51).
+
+### Fixed
+* Largest contentful paint and First contentful paint in Firefox now also fills the "googleWebitals" fields in the results. Thank you [Gregory Mierzwinski](https://github.com/gmierz) for PR [#2018](https://github.com/sitespeedio/browsertime/pull/2018) and my PR [#2020](https://github.com/sitespeedio/browsertime/pull/2020).
+* Make sure `--android.pinCPUSpeed` works [#2019](https://github.com/sitespeedio/browsertime/pull/2019)
+
 ## 18.0.0 - 2023-11-07
 
 ### Breaking

package/lib/android/root.js

@@ -79,13 +79,35 @@ export class RootedDevice {
   async setCPUPerformanceMotoG5() {
     //  # MSM8937(8x 1.4GHz)
     // values obtained from:
-    // /sys/devices/system/cpu/cpufreq/policy0/scaling_available_frequencies
+    // cat /sys/devices/system/cpu/cpu1/cpufreq/scaling_available_frequencies
+    // 960000 1094400 1209600 1248000 1344000 1401000
+
+    let cpuSpeed = 1_401_000;
+    if (
+      this.options.androidPinCPUSpeed === 'min' ||
+      (this.options.android && this.options.android.pinCPUSpeed === 'min')
+    ) {
+      log.info('Set min CPU speed');
+      cpuSpeed = 960_000;
+    } else if (
+      this.options.androidPinCPUSpeed === 'middle' ||
+      (this.options.android && this.options.android.pinCPUSpeed === 'middle')
+    ) {
+      log.info('Set middle CPU speed');
+      cpuSpeed = 1_209_600;
+    } else {
+      log.info('Set max CPU speed');
+    }
+
     for (let index = 0; index < 8; index++) {
       await this.client._runAsRoot(
         `echo performance > /sys/devices/system/cpu/cpu${index}/cpufreq/scaling_governor`
       );
       await this.client._runAsRoot(
-        `echo 1401000 > /sys/devices/system/cpu/cpu${index}/cpufreq/scaling_min_freq`
+        `echo ${cpuSpeed} > /sys/devices/system/cpu/cpu${index}/cpufreq/scaling_min_freq`
+      );
+      await this.client._runAsRoot(
+        `echo ${cpuSpeed} > /sys/devices/system/cpu/cpu${index}/cpufreq/scaling_max_freq`
       );
     }
   }
@@ -120,7 +142,10 @@ export class RootedDevice {
       'cat /sys/devices/system/cpu/cpufreq/policy4/scaling_min_freq'
     );
 
-    if (this.options.androidPinCPUSpeed === 'min') {
+    if (
+      this.options.androidPinCPUSpeed === 'min' ||
+      (this.options.android && this.options.android.pinCPUSpeed === 'min')
+    ) {
       log.info('Set min CPU speed');
 
       // The min settings, see the possible slowest setting by
@@ -144,7 +169,10 @@ export class RootedDevice {
         await this._setCPU(minPolicy4, '4', 'max');
         return this._setCPU(minPolicy4, '4', 'min');
       }
-    } else if (this.options.androidPinCPUSpeed === 'middle') {
+    } else if (
+      this.options.androidPinCPUSpeed === 'middle' ||
+      (this.options.android && this.options.android.pinCPUSpeed === 'middle')
+    ) {
       log.info('Set middle CPU speed');
 
       const middlePolicy0 = 910_000;

package/lib/firefox/webdriver/firefox.js

@@ -224,6 +224,25 @@ export class Firefox {
     if (this.appConstants) {
       result.browserScripts.browser.appConstants = this.appConstants;
     }
+
+    result.googleWebVitals = {};
+    if (
+      result.browserScripts.timings &&
+      result.browserScripts.timings.largestContentfulPaint
+    ) {
+      result.googleWebVitals.largestContentfulPaint =
+        result.browserScripts.timings.largestContentfulPaint.renderTime ||
+        result.browserScripts.timings.largestContentfulPaint.loadTime;
+    }
+
+    if (
+      result.browserScripts.timings &&
+      result.browserScripts.timings.paintTiming &&
+      result.browserScripts.timings.paintTiming['first-contentful-paint']
+    ) {
+      result.googleWebVitals.firstContentfulPaint =
+        result.browserScripts.timings.paintTiming['first-contentful-paint'];
+    }
   }
 
   async postWork(index, results) {

package/lib/support/cli.js

@@ -757,7 +757,7 @@ export function parseCommandLine() {
       choices: ['min', 'middle', 'max'],
       default: 'min',
       describe:
-        'Using a Samsung A51 you can choose how to pin the CPU to better align the speed with your users',
+        'Using a Samsung A51 or Moto G5 you can choose how to pin the CPU to better align the speed with your users. This only works on rooted phones and together with --android.rooted',
       group: 'android'
     })
     .option('android.batteryTemperatureLimit', {

package/package.json

@@ -1,7 +1,7 @@
 {
   "name": "browsertime",
   "description": "Get performance metrics from your web page using Browsertime.",
-  "version": "18.0.0",
+  "version": "19.0.0",
   "bin": "./bin/browsertime.js",
   "type": "module",
   "dependencies": {