browsertime 17.19.0 → 19.0.0

package/CHANGELOG.md

@@ -1,6 +1,25 @@
 # Browsertime changelog (we do [semantic versioning](https://semver.org))
 
-## 17.19.0 - 2022-11-03
+
+## 19.0.0 - 2023-11-15
+### Breaking
+* This only affects you if you run your tests on a rooted Moto G5: With PR[#2021](https://github.com/sitespeedio/browsertime/pull/2021) we add the ability to set the CPU speed for the phone at min/middle/max (the same way as possible on Samsung A51). Before the speed always was set to max. Default now is that the CPU speed will be set to min (the same way as the A51).
+
+### Fixed
+* Largest contentful paint and First contentful paint in Firefox now also fills the "googleWebitals" fields in the results. Thank you [Gregory Mierzwinski](https://github.com/gmierz) for PR [#2018](https://github.com/sitespeedio/browsertime/pull/2018) and my PR [#2020](https://github.com/sitespeedio/browsertime/pull/2020).
+* Make sure `--android.pinCPUSpeed` works [#2019](https://github.com/sitespeedio/browsertime/pull/2019)
+
+## 18.0.0 - 2023-11-07
+
+### Breaking
+* Dropping support for NodeJS 16.
+
+### Fixed
+* Updated all dev-dependencies to latest versions [#2013](https://github.com/sitespeedio/browsertime/pull/2013).
+* Updated  GitHub Actions to use latest versions of actions and Ubuntu 22.04 [#2012](https://github.com/sitespeedio/browsertime/pull/2012), [#2014](https://github.com/sitespeedio/browsertime/pull/2014) and [#2016](https://github.com/sitespeedio/browsertime/pull/2016)
+* Updated all dependencies to latest versions: ADB kit 3.2.5 [#2017](https://github.com/sitespeedio/browsertime/pull/2017), execa, dayjs, get-port and Chromedriver [#2015](https://github.com/sitespeedio/browsertime/pull/2015).
+
+## 17.19.0 - 2023-11-03
 ### Added 
 * Updated to Chrome, Firefox and Edge 119 in the Docker container [#2010](https://github.com/sitespeedio/browsertime/pull/2010).
 * Updated to Edgedriver 119.
@@ -8,12 +27,12 @@
 ### Fixed
 * Updated to Selenium 4.15.0 [#2011](https://github.com/sitespeedio/browsertime/pull/2011).
 
-## 17.18.1 - 2022-10-31
+## 17.18.1 - 2023-10-31
 ### Fixed
 * WebDriver 4.14.0
 * Chromedriver 119.0.6045-59
 
-## 17.18.0 - 2022-10-23
+## 17.18.0 - 2023-10-23
 ### Added
 * Updated to Chromedriver 119 [#2003](https://github.com/sitespeedio/browsertime/pull/2003). 119 works with both Chrome 118 and 119 so it fixes [#1197](https://github.com/sitespeedio/browsertime/issues/1997).
 * Add support for network idle method to know when to end a test that uses network logs. Uses Bidi for Firefox and CDP for Chrome to listen on network events to know when to end a test. By default 5 seconds idle network time ends a tests (you could have network responses that hasn't arrived yet) [#1960](https://github.com/sitespeedio/browsertime/pull/1960). Potentially this can help SPA users or users where the page uses iframes. You can try it out by adding `--pageCompleteCheckNetworkIdle` yo your command line. This is still some work in progress but feel free to try ut out.
@@ -23,7 +42,7 @@
 * Make sure timer always is cleared. There was case of where we do a rase beteween a promise and a timeout where the timeout timer wasn't cleared/removed [#2005](https://github.com/sitespeedio/browsertime/pull/2005).
 * Better way to get the url when you use GeckoProfiler.stop for Firefox, thank you [Nazım Can Altınova](https://github.com/canova) for PR [#1999](https://github.com/sitespeedio/browsertime/pull/1999)
 
-## 17.17.0 - 2022-10-11
+## 17.17.0 - 2023-10-11
 ### Added
 * Firefox 118, Edge 117 and Chrome/Chromedriver 118 in the Docker container [#1996](https://github.com/sitespeedio/browsertime/pull/1996).
 * Expose trace start/stop for Chrome in scripting (the same way as for Firefox). Thank you [KS](https://github.com/92kns) for [#1988](https://github.com/sitespeedio/browsertime/pull/1988). Documentation is coming when the functionality is rolled out in sitespeed.io.
@@ -31,46 +50,46 @@
 ### Updated
 * Updated to Selenium 4.12
 
-## 17.16.0 - 2022-09-04
+## 17.16.0 - 2023-09-04
 ### Added
 * Firefox 117 and Edge 116 in the Docker container.
 
 ### Fixed 
 * Updated the BiDi HAR exporter for Firefox to version 0.0.12. This version will not work with Firefox 116 so if you use the BiDi HAR exporter you need to upgrade to Firefox 117.
 
-## 17.15.0 - 2022-08-16
+## 17.15.0 - 2023-08-16
 ### Added
 * Updated Chrome and Chromedriver to 116.
 
-## 17.14.3 - 2022-08-16
+## 17.14.3 - 2023-08-16
 
 ### Fixed
 * Updated to Selenium 4.11.1 [#1978](https://github.com/sitespeedio/browsertime/pull/1978).
 * Updated Chrome and Chromedriver to minor versions.
 
-## 17.14.2 - 2022-07-31
+## 17.14.2 - 2023-07-31
 ### Fixed
 * The auto build of release Docker container was broken so no tagged containers was pushed.
 
-## 17.14.1 - 2022-07-31
+## 17.14.1 - 2023-07-31
 
 ### Fixed
 * Default jimp resize didn't handle large values (2000) when running in Docker AMD on a ARM machine so changing to another algorithm (HERMITE) [#1977](https://github.com/sitespeedio/browsertime/pull/1977).
 
 * Update: chrome-har, dayjs, execa, chrome-remote-interface and jimp [#1976](https://github.com/sitespeedio/browsertime/pull/1976).
 
-## 17.14.0 - 2022-07-24
+## 17.14.0 - 2023-07-24
 
 ### Added
 * Edge and Edgedriver 115 [#1973](https://github.com/sitespeedio/browsertime/pull/1973).
 
-## 17.13.1 - 2022-07-22
+## 17.13.1 - 2023-07-22
 
 ### Tech
 * Internal fix how the render blocking result is added [#1972](https://github.com/sitespeedio/browsertime/pull/1972).
 
 
-## 17.13.0 - 2022-07-21
+## 17.13.0 - 2023-07-21
 ### Fixed
 * Fix for Chromedriver 115 so that it works on Mac again [#1971](https://github.com/sitespeedio/browsertime/pull/1971).
 
@@ -80,7 +99,7 @@
 ### Tech
 * Run tests on Chrome/Firefox/Edge on Mac OS on our GitHub Actions to catch the next time Chromedriver is broken on Mac [#1970](https://github.com/sitespeedio/browsertime/pull/1970)
 
-## 17.12.1 - 2022-07-19
+## 17.12.1 - 2023-07-19
 ### Fixed
 * Hmm, Chromedriver 115 doesn't seems to work on Mac so reverted to 114.
 
@@ -90,31 +109,31 @@
 
 * If you collect the Chrome devtools trace using `--cpu` we will now also collect the number of elements that needs recalculate styles before FCP/LCP.[#1964](https://github.com/sitespeedio/browsertime/pull/1964).
 
-## 17.11.2 - 2022-06-19
+## 17.11.2 - 2023-06-19
 ### Fixed
 * Fix --debug mode. Thank you [Gregory Mierzwinski](https://github.com/gmierz) for PR [#1959](https://github.com/sitespeedio/browsertime/pull/1959).
 * Update ff-test-bidi-har-export to 0.0.11 that fixes some error logs [#1961](https://github.com/sitespeedio/browsertime/pull/1961).
 
-## 17.11.1 - 2022-06-12
+## 17.11.1 - 2023-06-12
 ### Fixed
 * If Chrome do not collect largest contentful paint, log that instead of just log null [#1957](https://github.com/sitespeedio/browsertime/pull/1957).
 
-## 17.11.0 - 2022-06-01
+## 17.11.0 - 2023-06-01
 ### Fixed
 * Fixed broken Docker auto build that skipped adding Docker manifest file.
 
 ### Added
 * Use Chrome ane Chromedriver 114.
 
-## 17.10.2 - 2022-05-26
+## 17.10.2 - 2023-05-26
 ### Fixed
 * Fix for --host-resolver-rules, thank you [Mikhail](https://github.com/atuchin-m) for PR [#1953](https://github.com/sitespeedio/browsertime/pull/1953).
 
-## 17.10.1 - 2022-05-19
+## 17.10.1 - 2023-05-19
 ### Fixed
 * Updated code to collect Interaction To Next Paint [#1952](https://github.com/sitespeedio/browsertime/pull/1952). This new version follow updated version(s) of Google Web Vitals.
 
-## 17.10.0 - 2022-05-19
+## 17.10.0 - 2023-05-19
 
 ### Added
 * Chrome, Edge and Firefox 113 [#1946](https://github.com/sitespeedio/browsertime/pull/1946), Chromedriver 113 [#1947](https://github.com/sitespeedio/browsertime/pull/1947) and Edgedriver 113 [#1949](https://github.com/sitespeedio/browsertime/pull/1949).
@@ -123,7 +142,7 @@
 * Bugfix for running iPhone Siumlator (and run tests on latest Mac OS) [#1945](https://github.com/sitespeedio/browsertime/pull/1945).
 * Bumped dependencies for Selenium, yargs and jimp [#1950](https://github.com/sitespeedio/browsertime/pull/1950).
 
-## 17.9.0 - 2022-04-19
+## 17.9.0 - 2023-04-19
 ### Added
 * New command to start geckoprofiling when scripting using Firefox. Thank you [KS](https://github.com/92kns) for PR [#1934](https://github.com/sitespeedio/browsertime/pull/1934). This is probably only something you need if you work at Mozilla. There's also a follow PR [#1940](https://github.com/sitespeedio/browsertime/pull/1940) that fixes some of the issues I've been wanted to fix with the Geckoprofiler code.
 
@@ -132,20 +151,20 @@
 ### Fixed
 * Bump Chrome remote interface and execa [#1941](https://github.com/sitespeedio/browsertime/pull/1941).
 
-## 17.8.1 - 2022-04-12
+## 17.8.1 - 2023-04-12
 ### Fixed
 * Upgraded to Firefox HAR 0.0.10 [#1939](https://github.com/sitespeedio/browsertime/pull/1939). 
-## 17.8.0 - 2022-04-11
+## 17.8.0 - 2023-04-11
 ### Fixed
 * Upgraded to Firefox HAR 0.0.8 [#1937](https://github.com/sitespeedio/browsertime/pull/1937). 
 
 ### Added
 * Upgraded to Firefox 112 in the Docker container.
-## 17.7.0 - 2022-04-07
+## 17.7.0 - 2023-04-07
 ### Added
 * Added Edge/Edgedriver 112.
 
-## 17.6.0 - 2022-04-05
+## 17.6.0 - 2023-04-05
 ### Fixed
 * Increased the default wait time from 2 to 5 seconds when a element a clicked and the page complete check runs [#1931](https://github.com/sitespeedio/browsertime/pull/1931)
 
@@ -153,7 +172,7 @@
 * Upgraded to Chrome/Chromedriver 112 in the Docker container [#1932](https://github.com/sitespeedio/browsertime/pull/1932).
 * If you use `--headless` Chrome will use the new headless switch [#1933](https://github.com/sitespeedio/browsertime/pull/1933).
 
-## 17.5.0 - 2022-04-04
+## 17.5.0 - 2023-04-04
 
 ### Added
 * There's a new better way to get the HAR from [Firefox using WebDriver BiDi network events](https://github.com/firefox-devtools/bidi-har-export). Thank you [Julian Descottes](https://github.com/juliandescottes) and others at Mozilla that made this happen! With the new version we hope to see less overhead getting the HAR +  it works on Firefox on Android [#1918](https://github.com/sitespeedio/browsertime/pull/1918). You can turn it on with `--firefox.bidihar`.
@@ -163,12 +182,12 @@
 * Fixed the interaction to next paint error message that started to appear in latest Chrome [#1924](https://github.com/sitespeedio/browsertime/pull/1924).
 * Safer check for getting last meaningful paint  [#1927](https://github.com/sitespeedio/browsertime/pull/1927)
 
-## 17.4.0 - 2022-03-29
+## 17.4.0 - 2023-03-29
 ### Added
 * Log the CPU benchmark metric to the console. This is useful (at least for me) when debugging instances with a lot of instability. [#1920](https://github.com/sitespeedio/browsertime/pull/1920).
 * In Chrome 111 some metrics become more instable when running on host with limited CPU. This change also exists in 112 beta. However we where missing out on a couple of command line magic to disable features in Chrome, this fixes that [#1921](https://github.com/sitespeedio/browsertime/pull/1921).
 
-## 17.3.0 - 2022-03-26
+## 17.3.0 - 2023-03-26
 
 ### Fixed
 * Bumped Selenium-webdriver to 4.8.2 [#1916](https://github.com/sitespeedio/browsertime/pull/1916).
@@ -177,20 +196,20 @@
 * On Linux you can use taskset to assing FFMPEG to specific CPUs using `--videoParams.taskset "0,5,7,9-11" `. It will start FFMPEG with `taskset -c <CPUS>` to pin FFMPG to specific CPU(s). Specify a numerical list of processors. The list may contain multiple items, separated by comma, and ranges. For example, "0,5,7,9-11". Use it together with isolcpus. Added in [#1917](https://github.com/sitespeedio/browsertime/pull/1917).
 
 * If you use a rooted Samsung A51 you can now choose the CPU speed (min/middle/max) using `--android.pinCPUSpeed min|middle|max` [#1915](https://github.com/sitespeedio/browsertime/pull/1915).
-## 17.2.1 - 2022-03-16
+## 17.2.1 - 2023-03-16
 ### Fixed
 * Bumped Geckodriver to 0.32.2 and Edgedriver to 111.
 
-## 17.2.0 - 2022-03-14
+## 17.2.0 - 2023-03-14
 ### Added 
 * Updated Chrome, Chromedriver, Edge and Firefox to 111.
 
-## 17.1.1 - 2022-03-04
+## 17.1.1 - 2023-03-04
 ### Fixed
 * Updated  jimp, yargs, webdriver, execa and chrome-remote-interface dependencies [#1909](https://github.com/sitespeedio/browsertime/pull/1909).
 * Added extra log message when using the package.json hack.
 
-## 17.1.0 - 2022-02-24
+## 17.1.0 - 2023-02-24
 
 ### Added
 * Expose chrome-remote-interface client to scripting. This makes it so much easier to run whatever CDP command. Get the raw version `commands.cdp.getRawClient();`. See PR [#1905](https://github.com/sitespeedio/browsertime/pull/1905) for a concrete example until we update the documentation.
@@ -198,7 +217,7 @@
 * Fix visual-complete progress calculations to not use fuzz/slop, thank you [Gregory Mierzwinski](https://github.com/gmierz) for PR [#1902](https://github.com/sitespeedio/browsertime/pull/1902).
 * Update to new Chrome HAR [#1906](https://github.com/sitespeedio/browsertime/pull/1906).
 * Fix flushing DNS on Ubuntu 22.04 [#1907](https://github.com/sitespeedio/browsertime/pull/1907).
-## 17.0.0 - 2022-02-10
+## 17.0.0 - 2023-02-10
 
 ### Breaking changes
 The project was transitioned to a [pure ESM package](https://gist.github.com/sindresorhus/a39789f98801d908bbc7ff3ecc99d99c) [#1859](https://github.com/sitespeedio/browsertime/pull/1859), allowing us to stay current with dependencies that have made the same transition and ensuring the ability to always utilize the latest versions of our dependencies. This is important for us and will make the project easier to maintain.

package/lib/android/index.js

@@ -4,8 +4,8 @@ import { join } from 'node:path';
 import { EOL as endOfLine } from 'node:os';
 import { execa } from 'execa';
 import intel from 'intel';
-import adbKit from '@devicefarmer/adbkit';
-const { createClient, util } = adbKit;
+import pkg from '@devicefarmer/adbkit';
+const { Adb } = pkg;
 import get from 'lodash.get';
 const log = intel.getLogger('browsertime.android');
 const mkdir = promisify(_mkdir);
@@ -21,7 +21,8 @@ export class Android {
     }
 
     Android.instance = this;
-    this.client = createClient();
+    this.client = Adb.createClient();
+
     this.id = get(
       options,
       'chrome.android.deviceSerial',
@@ -48,36 +49,34 @@ export class Android {
       }
     }
 
+    this.device = this.client.getDevice(this.id);
+
     if (!this.sdcard) {
       this.sdcard = await this._runCommandAndGet('echo $EXTERNAL_STORAGE');
     }
   }
 
   async _runCommand(command) {
-    return this.client.shell(this.id, command);
+    return this.device.shell(command);
   }
 
   async _runCommandAndGet(command) {
-    const data = await this.client.shell(this.id, command);
-    const output = await util.readAll(data);
+    const data = await this.device.shell(command);
+    const output = await Adb.util.readAll(data);
     return output.toString().trim();
   }
 
   async _runAsRootAndGet(command) {
-    const data = await this.client.shell(
-      this.id,
-      'su - root -c "' + command + '"'
-    );
-    const output = await util.readAll(data);
+    const data = await this.device.shell('su - root -c "' + command + '"');
+    const output = await Adb.util.readAll(data);
     return output.toString().trim();
   }
 
   async _runAsRoot(command) {
-    const data = await this.client.shell(
-      this.id,
+    const data = await this.device.shell(
       'su - root -c "' + command + ' && echo SUCCESS || echo FAIL"'
     );
-    const output = await util.readAll(data);
+    const output = await Adb.util.readAll(data);
     const result = output.toString().trim();
     if (result === 'FAIL') {
       log.error('Failing running as root:' + command);
@@ -88,7 +87,7 @@ export class Android {
   async _downloadFile(sourcePath, destinationPath) {
     log.trace(`Pulling to ${destinationPath} from ${sourcePath}`);
 
-    const transfer = await this.client.pull(this.id, sourcePath);
+    const transfer = await this.device.pull(sourcePath);
 
     return new Promise((resolve, reject) => {
       transfer.on('end', function () {
@@ -100,7 +99,7 @@ export class Android {
   }
 
   async _downloadDir(sourcePath, destinationPath) {
-    const files = await this.client.readdir(this.id, sourcePath);
+    const files = await this.device.readdir(sourcePath);
 
     for (const file of files) {
       const fullSourcePath = `${sourcePath}/${file.name}`;
@@ -141,7 +140,7 @@ export class Android {
   }
 
   async reboot() {
-    await this.client.reboot(this.id);
+    await this.device.reboot(this.id);
     return delay(60_000);
   }
 
@@ -155,24 +154,24 @@ export class Android {
   }
 
   async getMeta() {
-    const rawModel = await util.readAll(
+    const rawModel = await Adb.util.readAll(
       await this._runCommand(`getprop ro.product.model`)
     );
     const model = rawModel.toString().trim();
-    const rawName = await util.readAll(
+    const rawName = await Adb.util.readAll(
       await this._runCommand(`getprop ro.product.name`)
     );
     const name = rawName.toString().trim();
-    const rawDevice = await util.readAll(
+    const rawDevice = await Adb.util.readAll(
       await this._runCommand(`getprop ro.product.device`)
     );
     const device = rawDevice.toString().trim();
-    const rawId = await util.readAll(
+    const rawId = await Adb.util.readAll(
       await this._runCommand(`getprop ro.serialno`)
     );
     const id = rawId.toString().trim();
     const wifi = await this.getWifi();
-    const rawRelease = await util.readAll(
+    const rawRelease = await Adb.util.readAll(
       await this._runCommand(`getprop ro.build.version.release `)
     );
     const androidVersion = rawRelease.toString().trim();
@@ -187,8 +186,7 @@ export class Android {
   }
 
   async addDevtoolsFw() {
-    return this.client.forward(
-      this.id,
+    return this.device.forward(
       'tcp:' + this.port,
       'localabstract:chrome_devtools_remote'
     );
@@ -236,13 +234,13 @@ export class Android {
   }
 
   async getWifi() {
-    const rawWifiInfo = await util.readAll(
+    const rawWifiInfo = await Adb.util.readAll(
       await this._runCommand(
         `dumpsys netstats | grep -E 'iface=wlan.*networkId'`
       )
     );
     const wifiInfo = rawWifiInfo.toString().trim();
-    const wifi = wifiInfo.match(/"[^"]*"|^[^"]*$/)[0].replace(/"/g, '');
+    const wifi = wifiInfo.match(/"[^"]*"|^[^"]*$/)[0].replaceAll('"', '');
     return wifi;
   }
 
@@ -299,7 +297,7 @@ export class Android {
     const cmd1 = `pidof ${packageName}`;
     log.debug(`pidof ${cmd1}`);
     const proc1 = await this._runCommand(cmd1);
-    const ps1 = await util.readAll(proc1);
+    const ps1 = await Adb.util.readAll(proc1);
     const ps = ps1.toString();
     log.debug(`pidof ${ps}`);
 
@@ -328,7 +326,7 @@ export class Android {
     const cmd = `ps`;
     log.debug(`pidof ${cmd}`);
     const proc = await this._runCommand(cmd);
-    const psTemporary = await util.readAll(proc);
+    const psTemporary = await Adb.util.readAll(proc);
     const ps = psTemporary.toString();
     log.debug(`pidof ${ps}`);
 
@@ -382,7 +380,9 @@ export class Android {
     // `cut` and `awk`, to make this more robust.
     const cut = `echo $EPOCHREALTIME && cut -d ' ' -f 1 /proc/uptime && cut -d ' ' -f 22 /proc/self/stat /proc/${pid}/stat`;
     // const awk = `date +%s%3N && awk '{print $1}' /proc/uptime && awk '{print $22}' /proc/self/stat /proc/${pid}/stat`;
-    const statAndTimestamp = await util.readAll(await this._runCommand(cut));
+    const statAndTimestamp = await Adb.util.readAll(
+      await this._runCommand(cut)
+    );
     const output = statAndTimestamp.toString();
 
     const [

package/lib/android/root.js

@@ -79,13 +79,35 @@ export class RootedDevice {
   async setCPUPerformanceMotoG5() {
     //  # MSM8937(8x 1.4GHz)
     // values obtained from:
-    // /sys/devices/system/cpu/cpufreq/policy0/scaling_available_frequencies
+    // cat /sys/devices/system/cpu/cpu1/cpufreq/scaling_available_frequencies
+    // 960000 1094400 1209600 1248000 1344000 1401000
+
+    let cpuSpeed = 1_401_000;
+    if (
+      this.options.androidPinCPUSpeed === 'min' ||
+      (this.options.android && this.options.android.pinCPUSpeed === 'min')
+    ) {
+      log.info('Set min CPU speed');
+      cpuSpeed = 960_000;
+    } else if (
+      this.options.androidPinCPUSpeed === 'middle' ||
+      (this.options.android && this.options.android.pinCPUSpeed === 'middle')
+    ) {
+      log.info('Set middle CPU speed');
+      cpuSpeed = 1_209_600;
+    } else {
+      log.info('Set max CPU speed');
+    }
+
     for (let index = 0; index < 8; index++) {
       await this.client._runAsRoot(
         `echo performance > /sys/devices/system/cpu/cpu${index}/cpufreq/scaling_governor`
       );
       await this.client._runAsRoot(
-        `echo 1401000 > /sys/devices/system/cpu/cpu${index}/cpufreq/scaling_min_freq`
+        `echo ${cpuSpeed} > /sys/devices/system/cpu/cpu${index}/cpufreq/scaling_min_freq`
+      );
+      await this.client._runAsRoot(
+        `echo ${cpuSpeed} > /sys/devices/system/cpu/cpu${index}/cpufreq/scaling_max_freq`
       );
     }
   }
@@ -120,7 +142,10 @@ export class RootedDevice {
       'cat /sys/devices/system/cpu/cpufreq/policy4/scaling_min_freq'
     );
 
-    if (this.options.androidPinCPUSpeed === 'min') {
+    if (
+      this.options.androidPinCPUSpeed === 'min' ||
+      (this.options.android && this.options.android.pinCPUSpeed === 'min')
+    ) {
       log.info('Set min CPU speed');
 
       // The min settings, see the possible slowest setting by
@@ -144,7 +169,10 @@ export class RootedDevice {
         await this._setCPU(minPolicy4, '4', 'max');
         return this._setCPU(minPolicy4, '4', 'min');
       }
-    } else if (this.options.androidPinCPUSpeed === 'middle') {
+    } else if (
+      this.options.androidPinCPUSpeed === 'middle' ||
+      (this.options.android && this.options.android.pinCPUSpeed === 'middle')
+    ) {
       log.info('Set middle CPU speed');
 
       const middlePolicy0 = 910_000;

package/lib/core/engine/command/click.js

@@ -129,7 +129,7 @@ export class Click {
   async byXpath(xpath) {
     try {
       // This is how Selenium do internally
-      const replaced = xpath.replace(/"/g, "'");
+      const replaced = xpath.replaceAll('"', "'");
       const script = `document.evaluate("${replaced}", document, null, XPathResult.FIRST_ORDERED_NODE_TYPE, null).singleNodeValue.click();`;
       return this.browser.runScript(script, 'CUSTOM');
     } catch (error) {
@@ -148,7 +148,7 @@ export class Click {
   async byXpathAndWait(xpath) {
     try {
       // This is how Selenium do internally
-      const replaced = xpath.replace(/"/g, "'");
+      const replaced = xpath.replaceAll('"', "'");
       const script = `document.evaluate("${replaced}", document, null, XPathResult.FIRST_ORDERED_NODE_TYPE, null).singleNodeValue.click();`;
       await this.browser.runScript(script, 'CUSTOM');
       return this.browser.extraWait(this.pageCompleteCheck);

package/lib/core/engine/command/measure.js

@@ -114,10 +114,10 @@ export class Measure {
       // If we have tested pages before, but not in the making of
       // measuring a page, associate the error with that latest page.
       if (this.result.length > 0) {
-        if (this.result[this.result.length - 1].error === undefined) {
-          this.result[this.result.length - 1].error = [message];
+        if (this.result.at(-1).error === undefined) {
+          this.result.at(-1).error = [message];
         } else {
-          this.result[this.result.length - 1].error.push(message);
+          this.result.at(-1).error.push(message);
         }
       } else {
         //  error not associated to a start/run so far

package/lib/firefox/webdriver/firefox.js

@@ -224,6 +224,25 @@ export class Firefox {
     if (this.appConstants) {
       result.browserScripts.browser.appConstants = this.appConstants;
     }
+
+    result.googleWebVitals = {};
+    if (
+      result.browserScripts.timings &&
+      result.browserScripts.timings.largestContentfulPaint
+    ) {
+      result.googleWebVitals.largestContentfulPaint =
+        result.browserScripts.timings.largestContentfulPaint.renderTime ||
+        result.browserScripts.timings.largestContentfulPaint.loadTime;
+    }
+
+    if (
+      result.browserScripts.timings &&
+      result.browserScripts.timings.paintTiming &&
+      result.browserScripts.timings.paintTiming['first-contentful-paint']
+    ) {
+      result.googleWebVitals.firstContentfulPaint =
+        result.browserScripts.timings.paintTiming['first-contentful-paint'];
+    }
   }
 
   async postWork(index, results) {

package/lib/support/cli.js

@@ -757,7 +757,7 @@ export function parseCommandLine() {
       choices: ['min', 'middle', 'max'],
       default: 'min',
       describe:
-        'Using a Samsung A51 you can choose how to pin the CPU to better align the speed with your users',
+        'Using a Samsung A51 or Moto G5 you can choose how to pin the CPU to better align the speed with your users. This only works on rooted phones and together with --android.rooted',
       group: 'android'
     })
     .option('android.batteryTemperatureLimit', {

package/lib/support/pathToFolder.js

@@ -6,7 +6,7 @@ const log = intel.getLogger('browsertime');
 
 function toSafeKey(key) {
   // U+2013 : EN DASH – as used on https://en.wikipedia.org/wiki/2019–20_coronavirus_pandemic
-  return key.replace(/[ %&()+,./:?|~–]|%7C/g, '-');
+  return key.replaceAll(/[ %&()+,./:?|~–]|%7C/g, '-');
 }
 
 export function pathToFolder(url, options) {
@@ -59,7 +59,7 @@ export function pathToFolder(url, options) {
 
     for (const [index, segment] of pathSegments.entries()) {
       if (segment) {
-        pathSegments[index] = segment.replace(/[^\w.\u0621-\u064A-]/gi, '-');
+        pathSegments[index] = segment.replaceAll(/[^\w.\u0621-\u064A-]/gi, '-');
       }
     }
 

package/lib/support/storageManager.js

@@ -23,7 +23,7 @@ const mkdir = promisify(_mkdir);
 const log = intel.getLogger('browsertime');
 
 const defaultDir = 'browsertime-results';
-let timestamp = dayjs().format().replace(/:/g, '');
+let timestamp = dayjs().format().replaceAll(':', '');
 
 function pathNameFromUrl(url) {
   const parsedUrl = parse(url),

package/package.json

@@ -1,13 +1,13 @@
 {
   "name": "browsertime",
   "description": "Get performance metrics from your web page using Browsertime.",
-  "version": "17.19.0",
+  "version": "19.0.0",
   "bin": "./bin/browsertime.js",
   "type": "module",
   "dependencies": {
     "@cypress/xvfb": "1.2.4",
-    "@devicefarmer/adbkit": "2.11.3",
-    "@sitespeed.io/chromedriver": "119.0.6045-59",
+    "@devicefarmer/adbkit": "3.2.5",
+    "@sitespeed.io/chromedriver": "119.0.6045-105",
     "@sitespeed.io/edgedriver": "119.0.2151-42",
     "@sitespeed.io/geckodriver": "0.33.0",
     "@sitespeed.io/throttle": "5.0.0",
@@ -16,11 +16,11 @@
     "btoa": "1.2.1",
     "chrome-har": "0.13.2",
     "chrome-remote-interface": "0.33.0",
-    "dayjs": "1.11.9",
-    "execa": "7.2.0",
+    "dayjs": "1.11.10",
+    "execa": "8.0.1",
     "fast-stats": "0.0.6",
     "find-up": "6.3.0",
-    "get-port": "6.1.2",
+    "get-port": "7.0.0",
     "hasbin": "1.2.3",
     "intel": "1.2.0",
     "lodash.get": "4.4.2",
@@ -36,14 +36,14 @@
     "jimp": "0.22.10"
   },
   "devDependencies": {
-    "ava": "5.1.0",
-    "eslint": "8.31.0",
-    "eslint-config-prettier": "8.6.0",
-    "eslint-plugin-prettier": "4.2.1",
-    "eslint-plugin-unicorn": "45.0.2",
-    "prettier": "2.8.2",
+    "ava": "5.3.1",
+    "eslint": "8.53.0",
+    "eslint-config-prettier": "9.0.0",
+    "eslint-plugin-prettier": "5.0.1",
+    "eslint-plugin-unicorn": "49.0.0",
+    "prettier": "3.0.3",
     "serve-handler": "6.1.5",
-    "serve": "14.1.2"
+    "serve": "14.2.1"
   },
   "engines": {
     "node": ">=14.19.1"