browsertime 17.0.0-beta.4 → 17.1.0

package/CHANGELOG.md

@@ -1,12 +1,22 @@
 # Browsertime changelog (we do [semantic versioning](https://semver.org))
 
-## 17.0.0 - UNRELEASED
+## 17.1.0 - 2022-02-24
+
+### Added
+* Fix visual-complete progress calculations to not use fuzz/slop, thank you [Gregory Mierzwinski](https://github.com/gmierz) for PR [#1902](https://github.com/sitespeedio/browsertime/pull/1902).
+* Expose chrome-remote-interface client to scripting. This makes it so much easier to run whatever CDP command. Get the raw version `commands.cdp.getRawClient();`. See PR [#1905](https://github.com/sitespeedio/browsertime/pull/1905) for a concrete example until we update the documentation.
+### Fixed
+* Update to new Chrome HAR [#1906](https://github.com/sitespeedio/browsertime/pull/1906).
+* Fix flushing DNS on Ubuntu 22.04 [#1907](https://github.com/sitespeedio/browsertime/pull/1907).
+## 17.0.0 - 2022-02-10
 
 ### Breaking changes
-* We moved the project to be a [pure ESM package](https://gist.github.com/sindresorhus/a39789f98801d908bbc7ff3ecc99d99c) [#1859](https://github.com/sitespeedio/browsertime/pull/1859). That helps us keep up to date with dependencies that already did the move and make sure we can always use the latest version of our dependencies.
+The project was transitioned to a [pure ESM package](https://gist.github.com/sindresorhus/a39789f98801d908bbc7ff3ecc99d99c) [#1859](https://github.com/sitespeedio/browsertime/pull/1859), allowing us to stay current with dependencies that have made the same transition and ensuring the ability to always utilize the latest versions of our dependencies. This is important for us and will make the project easier to maintain.
+
 
 #### CLI users
 If you are a command line user and use scripting, you will need to do a change to your scripts or add a extra configuration. 
+
 The new browsertime version treat all JavaScript files that ends with *.js* as ESM modules, that means your old script files will not work out of the box. There's a couple of fixes for that:
 
 **The best fix**:
@@ -25,11 +35,13 @@ export default async function (context, commands) {
 }
 ```
 
-If you have more complicated scripts, follow the [ESM package guide](https://gist.github.com/sindresorhus/a39789f98801d908bbc7ff3ecc99d99c).
+If you have more complicated scripts, follow the [ESM package guide](https://gist.github.com/sindresorhus/a39789f98801d908bbc7ff3ecc99d99c). 
+
+This is the best fix and will woirk 100% of the time.
 
-**The quick fix**: Rename your *.js* to *.cjs* that way NodeJS will treat your file as a common JS file and everthing will just work. For example if you have a file names `login.js` you can rename that to `login.cjs` and make sure you load that new file.
+**The quick fix**: Rename your *.js* to *.cjs* that way NodeJS will treat your file as a common JS file and everything will just work. For example if you have a file names `login.js` you can rename that to `login.cjs` and make sure you load that new file.
 
-**Another quick fix alternative**: Add `--cjs` as a parameter to your test. That way the scripting file will be treated as a commonjs file. This is a hack, so to make sure it works, the user that runs Browsertime need to have write privileges to the folder where you have your scripting files.
+**Another quick fix alternative**: As a last alternative add `--cjs` as a parameter to your test. That way the scripting file will be treated as a commonjs file. This is a hack, so to make sure it works, the user that runs Browsertime need to have write privileges to the folder where you have your scripting files. Browsertime will create a package.json file on the same levels as yoru script file. If you already have a package.json there, it will be overwritten.
 
 #### Non cli users 
 If you import Browsertime in NodeJS we changed how you do your import.
@@ -50,7 +62,7 @@ Read [Sindre Sorhus Pure ESM package guide](https://gist.github.com/sindresorhus
 
 * We moved to use a new [Visual Metrics script](https://github.com/sitespeedio/browsertime/blob/main/browsertime/visualmetrics-portable.py) as default contributed by [Gregory Mierzwinski](https://github.com/gmierz) that do _not_ use ImageMagick. Mozilla has used this script for many months and we have internally used it in our test infrastructure since it was first released.
 
-If you run Browsertime direct using NodeJs (and not using Docker) you need to install two new Python dependencies OpenCV-Python Numpy.
+If you run Browsertime direct using NodeJs (and not using Docker) you need to install two new Python dependencies `OpenCV-Python Numpy`.
 
 ```
 python -m pip install --user OpenCV-Python Numpy
@@ -59,16 +71,21 @@ python -m pip install --user OpenCV-Python Numpy
 This is pretty cool because it makes dependencies easier to install on all platforms + the script has also been cleaned up so its easier for us to maintain. 
 
 ### Added
-* Chrome and Chromedriver 106 [#1853](https://github.com/sitespeedio/browsertime/pull/1853).
-* Selenium 4.5 [#1852](https://github.com/sitespeedio/browsertime/pull/1852).
-* Updated dependencies:  edgedriver, execa, days, find-up, get-ports, jimp, yargs [#1860](https://github.com/sitespeedio/browsertime/pull/1860)
-* Updated to Chrome 107 in the Docker container.
-* Updated to NodeJS 18 in the Docker container.
-
+* Selenium 4.8.
+* Updated dependencies: execa, days, find-up, get-ports, jimp, yargs [#1860](https://github.com/sitespeedio/browsertime/pull/1860)
+* Updated to Chrome, Firefox and Edge 109 in the Docker container. Also updated all drivers.
+* Updated to NodeJS 18 and Ubuntu 22.04 in the Docker container.
+* Get CPU metrics using Glean on Firefox, thank you [afinder-mozilla](https://github.com/afinder-mozilla) for PR [#1875](https://github.com/sitespeedio/browsertime/pull/1875)
+* Provide active tab id to gecko profiler StartProfiler API in Firefox, thank you [Nazım Can Altınova](https://github.com/canova) for PR [#1874](https://github.com/sitespeedio/browsertime/pull/1874).
+* There's two new methods to switch to frame: `switch.toFrameByXpath(xpath)` and `switch.toFrameBySelector(selector)` [#1880](https://github.com/sitespeedio/browsertime/pull/1880).
+* Add a timeout to gecko profiler gzipping phase, thank you [Nazım Can Altınova](https://github.com/canova) for PR [#1896](https://github.com/sitespeedio/browsertime/pull/1896)
+* Pin CPU freq to fastest for Samsung A51 (if you have a rooted device) [#1895](https://github.com/sitespeedio/browsertime/pull/1895).
 ### Fixed
 * Pause the gecko profiler before starting to collect the profile data, thank you [Nazım Can Altınova](https://github.com/canova) for PR [#1856](https://github.com/sitespeedio/browsertime/pull/1856).
 
-* All Android configurations has been moved to an Android group. That makes it easier when you run --help and can see all Android configuration grouped together. For example `--androidBatteryTemperature` is now `--android.batteryTemperatureLimit`. Old names will still work. [#1865](https://github.com/sitespeedio/browsertime/pull/1865) 
+* All Android configurations has been moved to an Android group. That makes it easier when you run --help and can see all Android configuration grouped together. For example `--androidBatteryTemperature` is now `--android.batteryTemperatureLimit`. Old names will still work but are deprecated [#1865](https://github.com/sitespeedio/browsertime/pull/1865).
+
+* Updated to Chromedriver 110 to work with Android 13 [#1894](https://github.com/sitespeedio/browsertime/pull/1894).
 
 ## 16.17.0 - 2022-09-27
 ### Added

package/bin/browsertime.js

@@ -5,15 +5,15 @@ import set from 'lodash.set';
 import intel from 'intel';
 import { existsSync, mkdirSync } from 'node:fs';
 import { resolve, relative } from 'node:path';
-import Engine from '../lib/core/engine/index.js';
+import { Engine } from '../lib/core/engine/index.js';
 import {
   findAndParseScripts,
   allScriptCategories,
   getScriptsForCategories
 } from '../lib/support/browserScript.js';
-import logging from '../lib/support/logging.js';
+import { configure } from '../lib/support/logging.js';
 import { parseCommandLine } from '../lib/support/cli.js';
-import StorageManager from '../lib/support/storageManager.js';
+import { StorageManager } from '../lib/support/storageManager.js';
 import { loadScript } from '../lib/support/engineUtils.js';
 import { isAndroidConfigured } from '../lib/android/index.js';
 
@@ -154,7 +154,7 @@ async function run(urls, options) {
 }
 
 let cliResult = parseCommandLine();
-logging(cliResult.options);
+configure(cliResult.options);
 
 /*
   Each url can be:

package/bin/browsertimeWebPageReplay.js

@@ -3,8 +3,8 @@ import merge from 'lodash.merge';
 import yargs from 'yargs';
 import { hideBin } from 'yargs/helpers';
 
-import Engine from '../lib/core/engine/index.js';
-import logging from '../lib/support/logging.js';
+import { Engine } from '../lib/core/engine/index.js';
+import { configure as logging } from '../lib/support/logging.js';
 
 async function runBrowsertime() {
   let yargsInstance = yargs(hideBin(process.argv));

package/browsertime/visualmetrics-portable.py

@@ -372,7 +372,7 @@ def video_to_frames(
     viewport_retries,
     viewport_min_height,
     viewport_min_width,
-    full_resolution
+    full_resolution,
 ):
     """Extract the video frames"""
     global client_viewport
@@ -413,9 +413,7 @@ def video_to_frames(
                         if orange_file is not None:
                             remove_frames_before_orange(dir, orange_file)
                             remove_orange_frames(dir, orange_file)
-                        find_render_start(
-                            dir, orange_file, cropped, is_mobile
-                        )
+                        find_render_start(dir, orange_file, cropped, is_mobile)
                         adjust_frame_times(dir)
                         eliminate_duplicate_frames(dir, cropped, is_mobile)
                         crop_viewport(dir)
@@ -508,6 +506,7 @@ def find_recording_platform(video):
 
     return is_mobile
 
+
 def remove_frames_before_orange(directory, orange_file):
     """Remove stray frames from the start of the video"""
     frames = sorted(glob.glob(os.path.join(directory, "video-*.png")))
@@ -533,6 +532,7 @@ def remove_frames_before_orange(directory, orange_file):
                 logging.debug("Removing pre-orange frame %s", frame)
                 os.remove(frame)
 
+
 def remove_orange_frames(directory, orange_file):
     """Remove orange frames from the beginning of the video"""
     frames = sorted(glob.glob(os.path.join(directory, "video-*.png")))
@@ -708,6 +708,7 @@ def find_video_viewport(
 
     return viewport, cropped
 
+
 def adjust_frame_times(directory):
     offset = None
     frames = sorted(glob.glob(os.path.join(directory, "video-*.png")))
@@ -728,6 +729,7 @@ def adjust_frame_times(directory):
                 dest = os.path.join(directory, "ms_{0:06d}.png".format(new_time))
                 os.rename(frame, dest)
 
+
 def find_render_start(directory, orange_file, cropped, is_mobile):
     logging.debug("Finding Render Start...")
     try:
@@ -902,6 +904,7 @@ def eliminate_duplicate_frames(directory, cropped, is_mobile):
     except BaseException:
         logging.exception("Error processing frames for duplicates")
 
+
 def crop_viewport(directory):
     if client_viewport is not None:
         try:
@@ -928,7 +931,9 @@ def crop_viewport(directory):
 def get_decimate_filter():
     decimate = None
     try:
-        filters = subprocess.check_output(["ffmpeg", "-filters"], stderr=subprocess.STDOUT, encoding="UTF-8")
+        filters = subprocess.check_output(
+            ["ffmpeg", "-filters"], stderr=subprocess.STDOUT, encoding="UTF-8"
+        )
         lines = filters.split("\n")
         match = re.compile(
             r"(?P<filter>[\w]*decimate).*V->V.*Remove near-duplicate frames"
@@ -1005,6 +1010,7 @@ def is_color_frame(file, color_file):
     frame_cache[file][color_file] = bool(match)
     return match
 
+
 def colors_are_similar(a, b, threshold=15):
     similar = True
     sum = 0
@@ -1073,6 +1079,7 @@ def generate_orange_png(orange_file):
     except BaseException:
         logging.exception("Error generating orange png " + orange_file)
 
+
 ##########################################################################
 #   Histogram calculations
 ##########################################################################
@@ -1190,6 +1197,7 @@ def convert_to_jpeg(directory, quality):
 
     logging.debug("Done converting video frames to JPEG")
 
+
 ##########################################################################
 #   Visual Metrics
 ##########################################################################
@@ -1266,9 +1274,7 @@ def calculate_visual_metrics(
                     viewport = hero_data["viewport"]
                     hero_timings = []
                     for hero in hero_data["heroes"]:
-                        hero_time = calculate_hero_time(
-                                    progress, dirs, hero, viewport
-                                )
+                        hero_time = calculate_hero_time(progress, dirs, hero, viewport)
                         if hero_time is not None:
                             hero_timings.append(
                                 {
@@ -1352,30 +1358,34 @@ def calculate_visual_progress(histograms):
 
 
 def calculate_frame_progress(histogram, start, final):
+    """Calculate the progress percentage of a given frame histogram.
+
+    This method finds the visually-complete progress by taking a sum of
+    all the differences in the histogram between the current frame, and the
+    final frame. The initial/first frame is used to remove values that are
+    consitent between the first, and final frame (i.e. it's a baseline).
+
+    Note that this method should not be using a slop/fuzz because we aren't
+    looking at individual pixel intensities which is where the fuzz can be
+    found. Within individual channels, we hit an issue where we cannot tell
+    if a value in the red channel is purely from a red colour in the image, or
+    if it's mixed with other colours such as grey (e.g. red with rbg(240,0,0),
+    and light grey with rgb(245,245,245)).
+    """
     total = 0
     matched = 0
-    slop = 5  # allow for matching slight color variations
-    channels = ["r", "g", "b"]
-    for channel in channels:
-        channel_total = 0
-        channel_matched = 0
-        buckets = 256
-        available = [0 for i in range(buckets)]
-        for i in range(buckets):
-            available[i] = abs(histogram[channel][i] - start[channel][i])
-        for i in range(buckets):
-            target = abs(final[channel][i] - start[channel][i])
-            if target:
-                channel_total += target
-                low = max(0, i - slop)
-                high = min(buckets, i + slop)
-                for j in range(low, high):
-                    this_match = min(target, available[j])
-                    available[j] -= this_match
-                    channel_matched += this_match
-                    target -= this_match
-        total += channel_total
-        matched += channel_matched
+    for channel in ("r", "g", "b"):
+        for pixel_ind in range(256):
+            curr = histogram[channel][pixel_ind]
+            init = start[channel][pixel_ind]
+            target = final[channel][pixel_ind]
+
+            curr_diff = abs(curr - init)
+            target_diff = abs(target - init)
+
+            matched += min(curr_diff, target_diff)
+            total += target_diff
+
     progress = (float(matched) / float(total)) if total else 1
     return math.floor(progress * 100)
 
@@ -1609,16 +1619,14 @@ def calculate_hero_time(progress, directory, hero, viewport):
 def check_config():
     ok = True
 
-    
     if get_decimate_filter() is not None:
-        logging.debug('FFMPEG found')
+        logging.debug("FFMPEG found")
     else:
         print("ffmpeg: FAIL")
         ok = False
 
-    
     if sys.version_info >= (3, 6):
-        logging.debug('Python 3.6+ found')
+        logging.debug("Python 3.6+ found")
     else:
         print("Python 3.6+: FAIL")
         ok = False
@@ -1626,33 +1634,31 @@ def check_config():
     try:
         import numpy as np
 
-        logging.debug('Numpy found')
+        logging.debug("Numpy found")
     except BaseException:
         print("Numpy: FAIL")
         ok = False
 
-    
     try:
         import cv2
-        
-        logging.debug('OpenCV-Python found')
+
+        logging.debug("OpenCV-Python found")
     except BaseException:
         print("OpenCV-Python: FAIL")
         ok = False
 
-    
     try:
         from PIL import Image, ImageCms, ImageDraw, ImageOps  # noqa
 
-        logging.debug('Pillow found')
+        logging.debug("Pillow found")
     except BaseException:
         print("Pillow: FAIL")
         ok = False
 
-    
     try:
         from ssim import compute_ssim  # noqa
-        logging.debug('SSIM found')
+
+        logging.debug("SSIM found")
     except BaseException:
         print("SSIM: FAIL")
         ok = False
@@ -1662,8 +1668,10 @@ def check_config():
 
 def check_process(command, output):
     ok = False
-    try:   
-        out = subprocess.check_output(command, stderr=subprocess.STDOUT, shell=True, encoding="UTF-8")
+    try:
+        out = subprocess.check_output(
+            command, stderr=subprocess.STDOUT, shell=True, encoding="UTF-8"
+        )
         if out.find(output) > -1:
             ok = True
     except BaseException:
@@ -1834,11 +1842,7 @@ def main():
 
     options = parser.parse_args()
 
-    if (
-        not options.check
-        and not options.dir
-        and not options.video
-    ):
+    if not options.check and not options.dir and not options.video:
         parser.error(
             "A video, Directory of images or histograms file needs to be provided.\n\n"
             "Use -h to see available options"
@@ -1910,7 +1914,7 @@ def main():
                     options.viewportminwidth,
                     options.full,
                 )
-            
+
             # Calculate the histograms and visual metrics
             calculate_histograms(directory, histogram_file, options.force)
             metrics = calculate_visual_metrics(

package/index.js

@@ -12,5 +12,5 @@ export const browserScripts = {
   findAndParseScripts
 };
 
-export { default as BrowsertimeEngine } from './lib/core/engine/index.js';
-export { default as configureLogging } from './lib/support/logging.js';
+export { Engine as BrowsertimeEngine } from './lib/core/engine/index.js';
+export { configure as configureLogging } from './lib/support/logging.js';

package/lib/android/gnirehtet.js

@@ -3,7 +3,7 @@ import intel from 'intel';
 const log = intel.getLogger('browsertime.gnirehtet');
 const delay = ms => new Promise(response => setTimeout(response, ms));
 
-class Gnirehtet {
+export class Gnirehtet {
   constructor(options) {
     this.options = options;
   }
@@ -65,4 +65,3 @@ class Gnirehtet {
     return delay(2000);
   }
 }
-export default Gnirehtet;

package/lib/android/root.js

@@ -11,7 +11,7 @@ const animationsToStop = [
   'window_animation_scale'
 ];
 
-class RootedDevice {
+export class RootedDevice {
   constructor(androidClient) {
     this.client = androidClient;
   }
@@ -83,6 +83,29 @@ class RootedDevice {
     }
   }
 
+  async setCPUPerformanceSamsungA51() {
+    // Octa-core (4x2.3 GHz Cortex-A73 & 4x1.7 GHz Cortex-A53)
+    // See values by
+    // cat /sys/devices/system/cpu/cpufreq/policy0/scaling_available_frequencies
+    // cat /sys/devices/system/cpu/cpufreq/policy4/scaling_available_frequencies
+
+    await this.client._runAsRoot(
+      'echo performance > /sys/devices/system/cpu/cpufreq/policy0/scaling_governor'
+    );
+
+    await this.client._runAsRoot(
+      'echo performance > /sys/devices/system/cpu/cpufreq/policy4/scaling_governor'
+    );
+
+    await this.client._runAsRoot(
+      'echo 1742000 > /sys/devices/system/cpu/cpufreq/policy0/scaling_min_freq'
+    );
+
+    return this.client._runAsRoot(
+      'echo 2314000 > /sys/devices/system/cpu/cpufreq/policy4/scaling_min_freq'
+    );
+  }
+
   async setCPUPerformancePixel2() {
     // MSM8998 (4x 2.35GHz, 4x 1.9GHz)
     // values obtained from:
@@ -166,6 +189,11 @@ class RootedDevice {
     );
   }
 
+  async setGPUPerformanceSamsungA51() {
+    // Mali-G72 MP3 (3 @ 850 MHz)
+    // Missing info on how to set the GPU
+  }
+
   async start() {
     await this.stopServices();
     await this.stopAnimations();
@@ -178,19 +206,34 @@ class RootedDevice {
       `getprop ro.product.model`
     );
 
-    if (model === 'Moto G (5)') {
-      log.info('Set CPU and GPU performance settings for Moto G5');
-      await this.setCPUPerformanceMotoG5();
-      await this.setGPUPerformanceMotoG5();
-    } else if (model === 'Pixel 2') {
-      log.info('Set CPU and GPU performance settings for Pixel 2');
-      await this.setCPUPerformancePixel2();
-      await this.setGPUPerformancePixel2();
-    } else {
-      log.info(
-        'No specific CPU/GPU settings for %s - you can help out by creating a PR at https://github.com/sitespeedio/browsertime for your phone',
-        model
-      );
+    switch (model) {
+      case 'Moto G (5)': {
+        log.info('Set CPU and GPU performance settings for Moto G5');
+        await this.setCPUPerformanceMotoG5();
+        await this.setGPUPerformanceMotoG5();
+
+        break;
+      }
+      case 'Pixel 2': {
+        log.info('Set CPU and GPU performance settings for Pixel 2');
+        await this.setCPUPerformancePixel2();
+        await this.setGPUPerformancePixel2();
+
+        break;
+      }
+      case 'SM-A515F': {
+        // Samsung A51
+        await this.setCPUPerformanceSamsungA51();
+        await this.setGPUPerformanceSamsungA51();
+
+        break;
+      }
+      default: {
+        log.info(
+          'No specific CPU/GPU settings for %s - you can help out by creating a PR at https://github.com/sitespeedio/browsertime for your phone',
+          model
+        );
+      }
     }
   }
 
@@ -199,5 +242,3 @@ class RootedDevice {
     return this.startAnimations();
   }
 }
-
-export default RootedDevice;

package/lib/chrome/chromeDevtoolsProtocol.js

@@ -3,7 +3,7 @@ import CDP from 'chrome-remote-interface';
 import btoa from 'btoa';
 const log = intel.getLogger('browsertime.chrome.cdp');
 import { toArray } from '../support/util.js';
-import defaultTraceCategories from './settings/traceCategories.js';
+import { traceCategories as defaultTraceCategories } from './settings/traceCategories.js';
 
 const MIME_TYPE_MATCHERS = [
   [/^text\/html/, 'html'],
@@ -20,7 +20,7 @@ function getContentType(mimeType) {
   return MIME_TYPE_MATCHERS.find(matcher => matcher[0].test(mimeType))[1];
 }
 
-class ChromeDevtoolsProtocol {
+export class ChromeDevtoolsProtocol {
   constructor(options) {
     this.options = options;
     this.chrome = options.chrome || {};
@@ -157,6 +157,10 @@ class ChromeDevtoolsProtocol {
     });
   }
 
+  getRawClient() {
+    return this.cdpClient;
+  }
+
   async setRequestHeaders(requestHeaders) {
     // Our cli don't validate parameters
     // so -run will become -r etc
@@ -234,4 +238,3 @@ class ChromeDevtoolsProtocol {
     }
   }
 }
-export default ChromeDevtoolsProtocol;

package/lib/chrome/har.js

@@ -5,7 +5,7 @@ const log = intel.getLogger('browsertime.chrome');
 import { addBrowser } from '../support/har/index.js';
 const { Type } = logging;
 
-export default async function (
+export async function getHar(
   runner,
   result,
   index,

package/lib/chrome/longTaskMetrics.js

@@ -1,6 +1,6 @@
 import get from 'lodash.get';
 
-export default function (result, options) {
+export function longTaskMetrics(result, options) {
   let totalDurationFirstPaint = 0;
   let totalDurationFirstContentFulPaint = 0;
   let totalDurationLargestContentFulPaint = 0;

package/lib/chrome/parseCpuTrace.js

@@ -11,7 +11,7 @@ function slowestFirst(a, b) {
   return b.value - a.value;
 }
 
-export default async (tracelog, url) => {
+export async function parseCPUTrace(tracelog, url) {
   try {
     log.debug('Start parse Chrome trace log using Tracium.');
     const tasks = computeMainThreadTasks(tracelog, {
@@ -87,4 +87,4 @@ export default async (tracelog, url) => {
     );
     return {};
   }
-};
+}

package/lib/chrome/settings/chromeAndroidOptions.js

@@ -3,7 +3,7 @@
  * see https://github.com/GoogleChrome/chrome-launcher/blob/master/docs/chrome-flags-for-tools.md
  * https://peter.sh/experiments/chromium-command-line-switches/
  */
-export default [
+export const chromeAndroidOptions = [
   '--disable-fre',
   // : Disable reporting to UMA, but allows for collection
   '--metrics-recording-only',

package/lib/chrome/settings/chromeDesktopOptions.js

@@ -1,6 +1,6 @@
 // See https://github.com/GoogleChrome/chrome-launcher/blob/master/docs/chrome-flags-for-tools.md
 // https://peter.sh/experiments/chromium-command-line-switches/
-export default [
+export const chromeDesktopOptions = [
   '--disable-background-networking',
   '--no-default-browser-check',
   '--no-first-run',

package/lib/chrome/settings/traceCategories.js

@@ -1,7 +1,7 @@
 /**
  * Default trace categories for the Chrome trace log.
  */
-export default [
+export const traceCategories = [
   '-*',
   'disabled-by-default-lighthouse',
   'v8',

package/lib/chrome/traceCategoriesParser.js

@@ -119,9 +119,7 @@ function cleanTrace(trace, url) {
   // and using TS of first found TracingStartedIn* event
 
   // With Chrome 58 we got undefined events on Travis (I cant't reproduce it on my local)
-  if (mostActiveFrame !== undefined) {
-    traceEvents.unshift(makeMockEvent(mostActiveFrame, ts));
-  } else {
+  if (mostActiveFrame === undefined) {
     // sometimes it seems we are missing inserting the 'TracingStartedInPage
     // let log and find out more
     log.error(
@@ -130,6 +128,8 @@ function cleanTrace(trace, url) {
       traceEvents.length,
       threads
     );
+  } else {
+    traceEvents.unshift(makeMockEvent(mostActiveFrame, ts));
   }
 
   // Verify that we got a navigationStart event for that frame. In Chrome 76 we started to get

package/lib/chrome/webdriver/builder.js

@@ -4,7 +4,7 @@ import get from 'lodash.get';
 import { logging } from 'selenium-webdriver';
 import { ServiceBuilder, Options } from 'selenium-webdriver/chrome.js';
 import { pac, manual } from 'selenium-webdriver/proxy.js';
-import setupChromiumOptions from './setupChromiumOptions.js';
+import { setupChromiumOptions } from './setupChromiumOptions.js';
 
 /**
  * Configure a WebDriver builder based on the specified options.