browsertime 16.13.0 → 16.13.3

package/CHANGELOG.md

@@ -1,5 +1,19 @@
 # Browsertime changelog (we do [semantic versioning](https://semver.org))
 
+
+## 16.13.3 - 2022-08-17
+
+### Fixed
+* Make sure set cookies work when navigating in script for Chrome/Edge [#1830](https://github.com/sitespeedio/browsertime/pull/1830).
+
+## 16.13.2 - 2022-08-14
+### Fixed
+* Disable adding lastCPULongTask to the HAR data since it breaks waterfall view on slow mobile phones with late CPU long tasks [#1828](https://github.com/sitespeedio/browsertime/pull/1828).
+
+## 16.13.1 - 2022-08-10
+### Fixed
+* Make sure that Android id is always picked up from the phone if tests run on Android [#1826](https://github.com/sitespeedio/browsertime/pull/1826).
+
 ## 16.13.0 - 2022-08-08
 ### Added
 * Upgraded to Edgedriver 104.

package/lib/android/index.js

@@ -161,13 +161,16 @@ class Android {
     const name = (await adb.util.readAll(rawName)).toString().trim();
     const rawDevice = await this._runCommand(`getprop ro.product.device`);
     const device = (await adb.util.readAll(rawDevice)).toString().trim();
+    const rawId = await this._runCommand(`getprop ro.serialno`);
+    const id = (await adb.util.readAll(rawId)).toString().trim();
+
     const rawRelease = await this._runCommand(
       `getprop ro.build.version.release `
     );
     const androidVersion = (await adb.util.readAll(rawRelease))
       .toString()
       .trim();
-    return { model, name, device, androidVersion };
+    return { model, name, device, androidVersion, id };
   }
 
   async pullNetLog(destination) {

package/lib/chrome/webdriver/chromium.js

@@ -444,6 +444,10 @@ class Chromium {
       return { har: harBuilder.mergeHars(this.hars) };
     } else return {};
   }
+
+  async setCookies(url, cookies) {
+    return this.cdpClient.setCookies(url, cookies);
+  }
 }
 
 module.exports = Chromium;

package/lib/core/engine/command/measure.js

@@ -141,6 +141,15 @@ class Measure {
     log.info('Navigating to url %s iteration %s', url, this.index);
     if (this.numberOfVisitedPages === 0) {
       await this.extensionServer.setup(url, this.browser, this.options);
+
+      // There's a bug that we introduced when moving cookie handling to CDP
+      // and this is the hack to fix that.
+      if (
+        (this.options.cookie && this.options.browser === 'chrome') ||
+        this.options.browser === 'edge'
+      ) {
+        await this.engineDelegate.setCookies(url, this.options.cookie);
+      }
     }
     if (this.numberOfVisitedPages === 0) {
       await this.engineDelegate.beforeStartIteration(this.browser, this.index);

package/lib/support/har/index.js

@@ -91,9 +91,11 @@ function addExtrasToHAR(
     harPageTimings._firstPaint = timings.firstPaint;
   }
 
+  /*
   if (cpu && cpu.longTasks && cpu.longTasks.lastLongTask) {
     harPageTimings._lastCPULongTask = cpu.longTasks.lastLongTask;
   }
+  */
 
   if (timings && timings.largestContentfulPaint) {
     harPageTimings._largestContentfulPaint =

package/package.json

@@ -1,6 +1,6 @@
 {
   "description": "Browsertime",
-  "version": "16.13.0",
+  "version": "16.13.3",
   "bin": "./bin/browsertime.js",
   "dependencies": {
     "@cypress/xvfb": "1.2.4",