browserless 13.13.1 → 13.16.3

package/index.d.ts

@@ -31,7 +31,7 @@ export interface Context {
   respawn: () => void
   context: () => Promise<BrowserContext>
   browser: () => Promise<Browser>
-  evaluate: <T>(fn: (page: Page, response?: HTTPResponse | undefined, error?: Error) => T | Promise<T>, gotoOpts?: GotoOptions & { keepPage?: boolean, preserveContext?: boolean }) => Promise<T>
+  evaluate: <T>(fn: (page: Page, response?: HTTPResponse | undefined, error?: Error) => T | Promise<T>, gotoOpts?: GotoOptions & { keepPage?: boolean }) => Promise<T>
   goto: (page: Page, opts: GotoOptions & { url: string }) => Promise<GotoResult>
   html: (url: string, opts?: GotoOptions) => Promise<string>
   page: (name?: string) => Promise<Page>
@@ -41,7 +41,7 @@ export interface Context {
   getDevice: (deviceName: string) => Viewport | undefined
   report: (opts?: { benchmark?: boolean }) => Promise<HardwareInfo>
   destroyContext: (opts?: { force?: boolean }) => Promise<void>
-  withPage: <T>(fn: (page: Page, goto: unknown) => Promise<T>, opts?: { timeout?: number, keepPage?: boolean, preserveContext?: boolean }) => Promise<T>
+  withPage: <T>(fn: (page: Page, goto: unknown) => Promise<T>, opts?: { timeout?: number, keepPage?: boolean }) => Promise<T>
 }
 
 export interface GotoOptions {

package/package.json

@@ -2,7 +2,7 @@
   "name": "browserless",
   "description": "The headless Chrome/Chromium driver on top of Puppeteer. Take screenshots, generate PDFs, extract text and HTML with a production-ready API.",
   "homepage": "https://browserless.js.org",
-  "version": "13.13.1",
+  "version": "13.16.3",
   "types": "index.d.ts",
   "main": "src/index.js",
   "author": {
@@ -36,9 +36,9 @@
   ],
   "dependencies": {
     "@browserless/errors": "13.9.23",
-    "@browserless/goto": "13.13.1",
-    "@browserless/pdf": "13.13.1",
-    "@browserless/screenshot": "13.13.1",
+    "@browserless/goto": "13.16.3",
+    "@browserless/pdf": "13.16.3",
+    "@browserless/screenshot": "13.16.3",
     "debug-logfmt": "~1.4.15",
     "kill-process-group": "~1.0.16",
     "p-reflect": "~2.1.0",
@@ -69,5 +69,5 @@
     "timeout": "2m",
     "workerThreads": false
   },
-  "gitHead": "9b15762cba78cc57788376048161db257e2a9c76"
+  "gitHead": "f84b8a32d240f9c0e3b2af8753baa3a8fbfb9ad5"
 }

package/src/index.js

@@ -110,10 +110,7 @@ module.exports = ({ timeout: globalTimeout = 30000, ...launchOpts } = {}) => {
       }
     }
 
-    const withPage = (
-      fn,
-      { timeout: evaluateTimeout, keepPage = false, preserveContext = false } = {}
-    ) => {
+    const withPage = (fn, { timeout: evaluateTimeout, keepPage = false } = {}) => {
       const name = fn.name || 'anonymous'
 
       return async (...args) => {
@@ -172,13 +169,7 @@ module.exports = ({ timeout: globalTimeout = 30000, ...launchOpts } = {}) => {
               // Every attempt builds its own page, so both codes are retryable
               // inside the existing context: `EBRWSRCONTEXTCONNRESET` covers a
               // closed page, a detached frame and a destroyed execution context,
-              // which a fresh page recovers from. Replacing the context is the
-              // only part a caller that owns it cannot afford, since that closes
-              // the pages it still holds. Skip that, not the retry.
-              if (preserveContext) {
-                debug('retry', { attemptNumber, retriesLeft, message, preserveContext })
-                return
-              }
+              // which a fresh page recovers from.
               const previousContextPromise = _contextPromise
               _contextPromise = createBrowserContext(contextOpts)
               await pReflect(previousContextPromise.then(ctx => ctx.close()))
@@ -198,7 +189,7 @@ module.exports = ({ timeout: globalTimeout = 30000, ...launchOpts } = {}) => {
     const evaluate = (fn, gotoOpts) => {
       // Both belong to withPage, so they are pulled out rather than spread into
       // the navigation options.
-      const { keepPage, preserveContext, ...navigateOpts } = gotoOpts ?? {}
+      const { keepPage, ...navigateOpts } = gotoOpts ?? {}
 
       return withPage(
         Object.defineProperty(
@@ -212,7 +203,7 @@ module.exports = ({ timeout: globalTimeout = 30000, ...launchOpts } = {}) => {
             writable: false
           }
         ),
-        { ...navigateOpts, keepPage, preserveContext }
+        { ...navigateOpts, keepPage }
       )
     }