browser-extension-manager 1.7.2 → 1.7.4

package/bin/browser-extension-manager

@@ -1,5 +1,9 @@
 #!/usr/bin/env node
-const argv = require('yargs')(process.argv.slice(2)).parseSync();
+// Value-less flags must be declared boolean — otherwise yargs treats the next
+// positional as the flag's VALUE (`mgr test --extended some/target` became
+// extended='some/target' with NO target, silently running EVERYTHING in
+// normal mode). Mirrors the same fix in BEM's CLI.
+const argv = require('yargs')(process.argv.slice(2)).boolean(['extended']).parseSync();
 const cli = new (require('../dist/cli.js'))(argv);
 (async function() {
   'use strict';

package/dist/build.js

@@ -101,8 +101,11 @@ Manager.getManifest = function () {
 Manager.prototype.getManifest = Manager.getManifest;
 
 // getConfig: requires and parses browser-extension-manager.json
+// Missing file (framework repo, or a consumer before first setup) → {} — same
+// guard as getManifest above; JSON5.parse(undefined) throws a cryptic
+// "invalid character 'u'" otherwise
 Manager.getConfig = function () {
-  return JSON5.parse(jetpack.read(path.join(process.cwd(), 'config', 'browser-extension-manager.json')));
+  return JSON5.parse(jetpack.read(path.join(process.cwd(), 'config', 'browser-extension-manager.json')) || '{}');
 }
 Manager.prototype.getConfig = Manager.getConfig;
 

package/dist/gulp/tasks/defaults.js

@@ -37,6 +37,11 @@ const FILE_MAP = {
   'src/**/*': {
     overwrite: false,
   },
+  // Consumer-owned after seeding (e.g. test/_init.js fixture hooks) — copy when
+  // missing, never clobber the consumer's version on setup reruns
+  'test/**/*': {
+    overwrite: false,
+  },
   'src/**/*.{html,md}': {
     skip: (file) => {
       // Get the name
@@ -520,6 +525,11 @@ function defaultsWatcher(complete) {
 // Default Task
 module.exports = series(defaults, defaultsWatcher);
 
+// Exported for tests — the FILE_MAP rules are load-bearing (a missing rule means
+// the fall-through overwrite: true silently clobbers consumer-owned files on
+// setup reruns)
+module.exports.getFileOptions = getFileOptions;
+
 function getFileOptions(filePath) {
   const defaults = {
     overwrite: true,

package/dist/test/suites/build/defaults-file-options.test.js

@@ -0,0 +1,64 @@
+// getFileOptions from src/gulp/tasks/defaults.js — the FILE_MAP rules that decide
+// which shipped defaults may overwrite consumer files on `npx bxm setup` reruns.
+// Regression here silently clobbers consumer-owned files: test/_init.js had no
+// matching rule, and the fall-through default is overwrite: true, so every setup
+// rerun reset the consumer's fixture hook to the stub (same gap UJM fixed in 1.9.26).
+
+module.exports = {
+  type: 'group',
+  layer: 'build',
+  description: 'defaults FILE_MAP (gulp/tasks/defaults.js getFileOptions)',
+  tests: [
+    {
+      name: 'consumer-owned seeds are copy-once (test/, hooks/, src/)',
+      run: async (ctx) => {
+        const { getFileOptions } = require('../../../gulp/tasks/defaults.js');
+
+        // The regression case: consumer fixture hook must survive setup reruns
+        ctx.expect(getFileOptions('test/_init.js').overwrite).toBe(false);
+        ctx.expect(getFileOptions('test/README.md').overwrite).toBe(false);
+
+        ctx.expect(getFileOptions('hooks/build/pre.js').overwrite).toBe(false);
+        ctx.expect(getFileOptions('src/manifest.json').overwrite).toBe(false);
+        ctx.expect(getFileOptions('src/assets/css/main.scss').overwrite).toBe(false);
+      },
+    },
+    {
+      name: 'framework-owned files always overwrite',
+      run: async (ctx) => {
+        const { getFileOptions } = require('../../../gulp/tasks/defaults.js');
+
+        // .nvmrc is templated and framework-owned (overwrite stays the default true)
+        const nvmrc = getFileOptions('.nvmrc');
+        ctx.expect(nvmrc.overwrite).toBe(true);
+        ctx.expect(!!nvmrc.template).toBe(true);
+
+        // Unmatched files fall through to overwrite: true — any new consumer-owned
+        // default MUST get an explicit rule or setup will clobber it
+        const workflow = getFileOptions('.github/workflows/publish.yml');
+        ctx.expect(workflow.overwrite).toBe(true);
+        ctx.expect(workflow.rule).toBeNull();
+      },
+    },
+    {
+      name: 'merge and skip rules resolve as declared',
+      run: async (ctx) => {
+        const { getFileOptions } = require('../../../gulp/tasks/defaults.js');
+
+        // Last-match-wins: CLAUDE.md picks up mergeLines AFTER **/*.md set overwrite: false
+        const claude = getFileOptions('CLAUDE.md');
+        ctx.expect(claude.mergeLines).toBe(true);
+        ctx.expect(claude.rule).toBe('CLAUDE.md');
+
+        const config = getFileOptions('config/browser-extension-manager.json');
+        ctx.expect(config.overwrite).toBe(true);
+        ctx.expect(config.merge).toBe(true);
+
+        ctx.expect(getFileOptions('config/messages.json').overwrite).toBe(false);
+
+        ctx.expect(getFileOptions('test/.DS_Store').skip).toBe(true);
+        ctx.expect(getFileOptions('src/__temp/scratch.js').skip).toBe(true);
+      },
+    },
+  ],
+};

package/docs/defaults.md

@@ -12,12 +12,16 @@
 
 ```js
 const FILE_MAP = {
-  'src/**/*':       { overwrite: false },                  // never overwrite user code
+  '**/*.md':        { overwrite: false },                  // docs are consumer-owned after seeding
   'hooks/**/*':     { overwrite: false },                  // never overwrite hooks
-  '_.gitignore':    { name: () => '.gitignore' },          // rename on copy
-  '_.env':          { name: () => '.env', overwrite: false },
-  '.nvmrc':         { template: { node: '22' } },          // run templating against the source
-  'package.json':   { skip: (cwd) => /* dynamic skip */ },
+  'src/**/*':       { overwrite: false },                  // never overwrite user code
+  'test/**/*':      { overwrite: false },                  // consumer-owned after seeding (test/_init.js!)
+  '_.gitignore':    { name: () => '.gitignore', mergeLines: true },  // rename + marker-based merge
+  '_.env':          { name: () => '.env', mergeLines: true },
+  'CLAUDE.md':      { mergeLines: true },                  // framework section live-syncs; Custom section is consumer-owned
+  'config/browser-extension-manager.json': { overwrite: true, merge: true },
+  '.nvmrc':         { template: cleanVersions },           // run templating against the source
+  '**/.DS_Store':   { skip: true },
 };
 ```
 
@@ -31,6 +35,8 @@ const FILE_MAP = {
 | `template: data` | Run the source through templating with `data` as the var bag, then write. |
 | `name: function` | Rename on copy — typically used to add a leading `.` (`_.gitignore` → `.gitignore`). |
 
+⚠️ **Unmatched files fall through to `overwrite: true`** — any NEW consumer-owned default MUST get an explicit copy-once rule, or every `npx bxm setup` rerun clobbers the consumer's version (exactly how `test/_init.js` got reset before the `test/**/*` rule existed). Rules are last-match-wins — `CLAUDE.md` gains `mergeLines` after `**/*.md` already set copy-once. The rule classes are locked by `src/test/suites/build/defaults-file-options.test.js`.
+
 ## Why the underscore prefix?
 
 Files like `_.gitignore`, `_.env` are stored with a `_` prefix in `src/defaults/` so they don't interfere with BXM's own development (the framework repo doesn't want its `.env` overwritten by the template). The `name` rule renames them to the real `.foo` filename on copy.

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "browser-extension-manager",
-  "version": "1.7.2",
+  "version": "1.7.4",
   "description": "Browser Extension Manager dependency manager",
   "main": "dist/index.js",
   "exports": {