browser-extension-manager 1.7.1 → 1.7.2

package/dist/test/runner.js

@@ -402,6 +402,11 @@ function filterBySource(source, files, sourceFilter, pathPart) {
   });
 }
 
+// Glob ignore patterns implementing the "underscore = not a suite" convention:
+// `_`-prefixed FILES (e.g. test/_init.js) and everything under a `_`-prefixed
+// DIRECTORY at any depth (helpers, fixtures — e.g. test/_helpers/harness.js).
+const DISCOVERY_IGNORE = ['**/_*.js', '**/_*/**'];
+
 function discoverTestFiles(target) {
   const { source: sourceFilter, pathPart } = parseTarget(target);
   const framework = [];
@@ -425,7 +430,7 @@ function discoverTestFiles(target) {
   // Consumers write their own boot tests under <cwd>/test/boot/.
   const frameworkSuitesDir = path.join(__dirname, 'suites');
   if (jetpack.exists(frameworkSuitesDir)) {
-    const ignore = ['_**'];
+    const ignore = [...DISCOVERY_IGNORE];
     if (!isFrameworkSelfTest) ignore.push('boot/**');
     glob('**/*.js', { cwd: frameworkSuitesDir, ignore }).sort().forEach((rel) => {
       framework.push(path.join(frameworkSuitesDir, rel));
@@ -434,9 +439,10 @@ function discoverTestFiles(target) {
 
   // Consumer project suites — CWD/test/**/*.js. Skip when running from inside the
   // framework's own dist tree (where consumer-tests-dir === framework-tests-parent).
+  // Excludes `_`-prefixed files and directories (see DISCOVERY_IGNORE).
   const projectTestsDir = path.join(process.cwd(), 'test');
   if (jetpack.exists(projectTestsDir) && projectTestsDir !== path.dirname(frameworkSuitesDir)) {
-    glob('**/*.js', { cwd: projectTestsDir, ignore: ['_**'] }).sort().forEach((rel) => {
+    glob('**/*.js', { cwd: projectTestsDir, ignore: [...DISCOVERY_IGNORE] }).sort().forEach((rel) => {
       project.push(path.join(projectTestsDir, rel));
     });
   }
@@ -512,4 +518,4 @@ async function runInitSetups() {
   }
 }
 
-module.exports = { run, SkipError };
+module.exports = { run, SkipError, DISCOVERY_IGNORE };

package/dist/test/suites/build/test-discovery.test.js

@@ -0,0 +1,63 @@
+// Build-layer tests for test-suite discovery — specifically the
+// "underscore = not a suite" convention: `_`-prefixed files and everything
+// under `_`-prefixed directories (at ANY depth) must be excluded, so consumers
+// can keep helpers and fixture trees (e.g. test/_helpers/harness.js)
+// next to their suites.
+
+const path = require('path');
+
+module.exports = {
+  type: 'suite',
+  layer: 'build',
+  description: 'test discovery — underscore exclusion convention',
+  tests: [
+    {
+      name: 'runner exports DISCOVERY_IGNORE',
+      run: (ctx) => {
+        const runner = require(path.join(__dirname, '..', '..', 'runner.js'));
+        ctx.expect(Array.isArray(runner.DISCOVERY_IGNORE)).toBe(true);
+        ctx.expect(runner.DISCOVERY_IGNORE.length >= 2).toBe(true);
+      },
+    },
+    {
+      name: 'glob with DISCOVERY_IGNORE skips _ files and _ dirs at any depth',
+      run: (ctx) => {
+        const fs = require('fs');
+        const os = require('os');
+        const glob = require('glob').globSync;
+        const { DISCOVERY_IGNORE } = require(path.join(__dirname, '..', '..', 'runner.js'));
+
+        const tmp = fs.mkdtempSync(path.join(os.tmpdir(), 'bxm-discovery-test-'));
+        const write = (rel) => {
+          const file = path.join(tmp, rel);
+          fs.mkdirSync(path.dirname(file), { recursive: true });
+          fs.writeFileSync(file, 'module.exports = {};\n');
+        };
+
+        // Should be DISCOVERED:
+        write('build/config.test.js');
+        write('page/runner.test.js');
+        write('boot/nested/deep.test.js');
+
+        // Should be EXCLUDED:
+        write('_init.js');                                  // top-level _ file
+        write('page/_helper.js');                           // nested _ file
+        write('_helpers/harness.js');                       // file in top-level _ dir
+        write('_fixtures/packages/runner/mod/index.js');    // deep inside a _ dir
+        write('boot/_private/util.js');                     // _ dir below a layer dir
+
+        const found = glob('**/*.js', { cwd: tmp, ignore: [...DISCOVERY_IGNORE] }).sort();
+
+        try {
+          ctx.expect(found).toEqual([
+            'boot/nested/deep.test.js',
+            'build/config.test.js',
+            'page/runner.test.js',
+          ]);
+        } finally {
+          fs.rmSync(tmp, { recursive: true, force: true });
+        }
+      },
+    },
+  ],
+};

package/docs/test-framework.md

@@ -157,7 +157,7 @@ Consumers writing their own tests get this automatically when running through `n
 - **Framework defaults**: `<BXM>/dist/test/suites/**/*.js`
 - **Consumer suites**: `<cwd>/test/**/*.js`
 
-**The underscore convention:** `_`-prefixed files and directories are excluded from suite discovery. Put shared helpers, fixture data, and non-test support files in `_`-prefixed paths — e.g. `test/_fixtures/`, `test/_helpers/`. The runner still specifically loads `test/_init.js` as the lifecycle hook. Matches the same convention in BEM/EM/UJM. Files load alphabetically.
+**The underscore convention** (`DISCOVERY_IGNORE` in `src/test/runner.js`): `_`-prefixed FILES (`test/_init.js`, `test/page/_helper.js`) and everything under a `_`-prefixed DIRECTORY at **any depth** (`test/_fixtures/**`, `test/boot/_private/**`) are excluded from suite discovery. Put shared helpers, fixture data, and non-test support files in `_`-prefixed paths — e.g. `test/_fixtures/`, `test/_helpers/`. The runner still specifically loads `test/_init.js` as the lifecycle hook. Matches the same convention in BEM/EM/UJM. Files load alphabetically.
 
 **Framework's boot suites are scoped to BXM self-test runs only.** When a consumer runs `npx bxm test`, the framework's `dist/test/suites/boot/**` is excluded from discovery (those tests assert on BXM's internal fixture extension). Consumers write their own boot tests under `<cwd>/test/boot/`. See [test-boot-layer.md](test-boot-layer.md).
 

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "browser-extension-manager",
-  "version": "1.7.1",
+  "version": "1.7.2",
   "description": "Browser Extension Manager dependency manager",
   "main": "dist/index.js",
   "exports": {