browser-debugger-cli 0.11.0 → 0.13.0

package/dist/daemon/session/commandRegistry.js

@@ -4,6 +4,8 @@ import { createInteractionRunner } from './interactions.js';
 import { withTriggeredRequestCount } from './triggeredRequests.js';
 import { CommandError } from '../../errors/index.js';
 import { cdpCallError, formDiscoveryFailedError } from '../../errors/messages.js';
+import { searchStyleSheets } from '../../runtime/css/search.js';
+import { auditPage } from '../../runtime/dom/audit.js';
 import { evaluateScript, withBusyPageRecovery } from '../../runtime/dom/evalHelpers.js';
 import { inspectEventListeners } from '../../runtime/dom/eventListeners.js';
 import { FORM_DISCOVERY_SCRIPT, isRawFormData } from '../../runtime/dom/formDiscovery.js';
@@ -15,10 +17,12 @@ import { inspectElement } from '../../runtime/dom/inspect.js';
 import { inspectLayout } from '../../runtime/dom/layout.js';
 import { onScriptTarget } from '../../runtime/dom/targetNode.js';
 import { waitForCondition } from '../../runtime/dom/wait.js';
+import { evaluateInBdgWorld, sendForBdgScript } from '../../runtime/page/bdgWorld.js';
 import { emulatePage, pageAppearance } from '../../runtime/page/emulation.js';
 import { readDocumentReadyState } from '../../runtime/page/loadingState.js';
 import { navigatePage } from '../../runtime/page/navigation.js';
 import { skippedBodyReason } from '../../telemetry/network.js';
+import { consoleMessageDroppedError } from '../../ui/messages/consoleMessages.js';
 import { sessionCommand } from '../../ui/messages/sessionCommand.js';
 import { EXIT_CODES } from '../../utils/exitCodes.js';
 import { filterDefined } from '../../utils/objects.js';
@@ -185,24 +189,28 @@ function findNetworkRequestOrThrow(store, id) {
     return request;
 }
 /**
- * Find console message by index or throw.
+ * Find console message by its session index or throw.
  *
- * @param messages - Array of console messages
+ * @param messages - Console messages kept
  * @param indexStr - Index as string
+ * @param dropped - Messages dropped before the first kept one (its index)
  * @returns Found message
- * @throws Error if invalid index or not found
+ * @throws CommandError if the index is invalid, dropped or not found
  */
-function findConsoleMessageOrThrow(messages, indexStr) {
+function findConsoleMessageOrThrow(messages, indexStr, dropped) {
     if (!/^\d+$/.test(indexStr)) {
         throw new CommandError(`Invalid console message index: ${indexStr}`, { suggestion: `Use a 0-based index from: ${sessionCommand('bdg console --list')}` }, EXIT_CODES.INVALID_ARGUMENTS);
     }
     const index = parseInt(indexStr, 10);
-    if (index >= messages.length) {
+    if (index < dropped) {
+        throw new CommandError(consoleMessageDroppedError(index, dropped), { suggestion: `List messages with: ${sessionCommand('bdg console --list')}` }, EXIT_CODES.RESOURCE_NOT_FOUND);
+    }
+    if (index - dropped >= messages.length) {
         throw new CommandError(messages.length === 0
             ? `Console message not found at index: ${indexStr} (no messages captured yet)`
-            : `Console message not found at index: ${indexStr} (available: 0-${messages.length - 1})`, { suggestion: `List messages with: ${sessionCommand('bdg console --list')}` }, EXIT_CODES.RESOURCE_NOT_FOUND);
+            : `Console message not found at index: ${indexStr} (available: ${dropped}-${dropped + messages.length - 1})`, { suggestion: `List messages with: ${sessionCommand('bdg console --list')}` }, EXIT_CODES.RESOURCE_NOT_FOUND);
     }
-    const message = messages[index];
+    const message = messages[index - dropped];
     if (!message) {
         throw new CommandError(`Console message not found at index: ${indexStr}`, {}, EXIT_CODES.RESOURCE_NOT_FOUND);
     }
@@ -310,6 +318,7 @@ export function createCommandRegistry(store, emulation) {
             const allNetwork = allNetworkRequests(store);
             const totalNetwork = allNetwork.length;
             const totalConsole = store.consoleMessages.length;
+            const dropped = store.consoleDropped;
             const networkBounds = calculateSliceBounds(totalNetwork, lastN, offset);
             const consoleBounds = calculateSliceBounds(totalConsole, lastN, offset);
             const recentNetwork = params.only === 'console'
@@ -321,7 +330,7 @@ export function createCommandRegistry(store, emulation) {
                 ? []
                 : store.consoleMessages
                     .slice(consoleBounds.start, consoleBounds.end)
-                    .map((msg, i) => mapConsoleMessageToPreview(msg, consoleBounds.start + i));
+                    .map((msg, i) => mapConsoleMessageToPreview(msg, dropped + consoleBounds.start + i));
             return Promise.resolve({
                 version: VERSION,
                 startTime: store.sessionStartTime,
@@ -332,10 +341,12 @@ export function createCommandRegistry(store, emulation) {
                 },
                 activeTelemetry: store.activeTelemetry,
                 currentNavigationId: store.getCurrentNavigationId?.() ?? 0,
+                ...(store.pageCrashedAt !== undefined && { pageCrashedAt: store.pageCrashedAt }),
                 network: recentNetwork,
                 console: recentConsole,
                 totalNetwork,
                 totalConsole,
+                ...(dropped > 0 && { droppedConsole: dropped }),
                 hasMoreNetwork: networkBounds.start > 0,
                 hasMoreConsole: consoleBounds.start > 0,
             });
@@ -346,7 +357,7 @@ export function createCommandRegistry(store, emulation) {
                 return Promise.resolve({ item: withBodyNotCaptured(request) });
             }
             if (params.itemType === 'console') {
-                const message = findConsoleMessageOrThrow(store.consoleMessages, params.id);
+                const message = findConsoleMessageOrThrow(store.consoleMessages, params.id, store.consoleDropped);
                 return Promise.resolve({ item: message });
             }
             return Promise.reject(new Error(`Unknown itemType: ${String(params.itemType)}. Expected 'network' or 'console'.`));
@@ -361,7 +372,9 @@ export function createCommandRegistry(store, emulation) {
                 target: {
                     url: store.targetInfo?.url ?? '',
                     title: store.targetInfo?.title ?? '',
-                    ...(await pageAppearance(cdp)),
+                    ...(store.pageCrashedAt === undefined
+                        ? await pageAppearance(cdp)
+                        : { crashedAt: store.pageCrashedAt }),
                 },
                 activeTelemetry: store.activeTelemetry,
                 activity: filterDefined({
@@ -399,10 +412,15 @@ export function createCommandRegistry(store, emulation) {
             });
         },
         cdp_call: async (cdp, params) => {
-            const result = await withBusyPageRecovery(cdp, cdp.send(params.method, params.params ?? {}).catch((error) => {
+            const send = params.isolated
+                ? sendForBdgScript(cdp, params.method, params.params ?? {})
+                : cdp.send(params.method, params.params ?? {});
+            const result = await withBusyPageRecovery(cdp, send.catch((error) => {
                 throw callerError(params.method, error) ?? error;
             }));
-            const detectionResult = patternDetector.trackCommand(params.method);
+            const detectionResult = params.isolated
+                ? { shouldShow: false, pattern: undefined }
+                : patternDetector.trackCommand(params.method);
             let hint;
             if (detectionResult.shouldShow && detectionResult.pattern) {
                 hint = {
@@ -458,7 +476,11 @@ export function createCommandRegistry(store, emulation) {
         })), params.wait !== false))),
         dom_listeners: async (cdp, params) => withBusyPageRecovery(cdp, inspectEventListeners(cdp, params)),
         dom_layout: async (cdp, params) => withBusyPageRecovery(cdp, inspectLayout(cdp, params)),
-        dom_inspect: async (cdp, params) => withBusyPageRecovery(cdp, inspectElement(cdp, params)),
+        dom_audit: async (cdp, params) => withBusyPageRecovery(cdp, auditPage(cdp, params)),
+        css_search: async (cdp, params) => searchStyleSheets(cdp, params),
+        dom_inspect: async (cdp, params) => withBusyPageRecovery(cdp, inspectElement(cdp, params).then((result) => result.theme === 'dark' && emulation.get().colorScheme === 'dark'
+            ? { ...result, themeFrom: 'emulation' }
+            : result)),
         dom_wait: async (cdp, params) => waitForCondition(cdp, params),
         page_navigate: async (cdp, params) => interact(cdp, () => navigatePage(cdp, params.action, {
             ...filterDefined({ url: params.url, wait: params.wait }),
@@ -469,7 +491,7 @@ export function createCommandRegistry(store, emulation) {
             return { emulated, ...(await pageAppearance(cdp)) };
         },
         dom_form_discover: async (cdp) => {
-            const response = await withBusyPageRecovery(cdp, cdp.send('Runtime.evaluate', {
+            const response = await withBusyPageRecovery(cdp, evaluateInBdgWorld(cdp, {
                 expression: FORM_DISCOVERY_SCRIPT,
                 returnByValue: true,
             }));

package/dist/daemon/session/interactions.d.ts

@@ -51,7 +51,8 @@ export type InteractionRunner = <T extends object>(cdp: CDPConnection, action: (
  * queued. After each one, the bound target (`window.__bdgTarget`) is removed
  * from the page (without waiting: during a pending navigation that takes until
  * the new page commits), and the dialogs it opened, what it changed on the
- * page (see {@link watchActionEffects}) and the network requests it
+ * page (see {@link watchActionEffects}; a console message logged meanwhile
+ * counts as an effect) and the network requests it
  * triggered (see {@link watchTriggeredRequests}) are added to its result,
  * and, when asked, what the page was still working on (see
  * {@link pendingChanges}). They are attributed by time: a dialog or request

package/dist/daemon/session/interactions.js

@@ -18,6 +18,15 @@ const log = createLogger('dom');
 function succeeded(result) {
     return !('success' in result) || result.success !== false;
 }
+/**
+ * Console messages the session has logged, dropped ones included.
+ *
+ * @param store - Session store
+ * @returns Count that only grows
+ */
+function consoleMessagesLogged(store) {
+    return store.consoleDropped + store.consoleMessages.length;
+}
 /**
  * Create the runner for a session's interactions.
  *
@@ -26,7 +35,8 @@ function succeeded(result) {
  * queued. After each one, the bound target (`window.__bdgTarget`) is removed
  * from the page (without waiting: during a pending navigation that takes until
  * the new page commits), and the dialogs it opened, what it changed on the
- * page (see {@link watchActionEffects}) and the network requests it
+ * page (see {@link watchActionEffects}; a console message logged meanwhile
+ * counts as an effect) and the network requests it
  * triggered (see {@link watchTriggeredRequests}) are added to its result,
  * and, when asked, what the page was still working on (see
  * {@link pendingChanges}). They are attributed by time: a dialog or request
@@ -41,6 +51,7 @@ export function createInteractionRunner(store) {
     return (cdp, action, options = {}) => {
         const run = queue.then(async () => {
             const firstDialog = store.dialogs.length;
+            const firstConsoleMessage = consoleMessagesLogged(store);
             const collectRequests = options.reportRequests === false ? undefined : watchTriggeredRequests(store);
             const effects = options.reportEffects === false ? undefined : watchActionEffects(cdp);
             try {
@@ -50,6 +61,7 @@ export function createInteractionRunner(store) {
                     return { ...result, ...(dialogs.length > 0 && { dialogs }) };
                 const collected = await effects?.collect({
                     dialogs: dialogs.length,
+                    consoleMessages: () => consoleMessagesLogged(store) - firstConsoleMessage,
                     detectNoEffect: options.detectNoEffect === true,
                     reportShown: options.reportShown === true,
                     detectUnsettled: options.detectUnsettled === true,

package/dist/daemon/session/plugins.js

@@ -1,8 +1,10 @@
+import { hideHeadlessUserAgent } from '../../runtime/page/userAgent.js';
 import { startConsoleCollection } from '../../telemetry/console.js';
 import { startDialogHandling } from '../../telemetry/dialogs.js';
 import { prepareDOMCollection } from '../../telemetry/dom.js';
 import { startNavigationTracking } from '../../telemetry/navigation.js';
 import { startNetworkCollection, startWebSocketCollection } from '../../telemetry/network.js';
+import { pageCrashedCommandError, startCrashTracking } from '../../telemetry/pageCrash.js';
 import { getErrorMessage } from '../../utils/errors.js';
 import { filterDefined } from '../../utils/objects.js';
 /** Delay before reading the title after a same-document navigation */
@@ -83,56 +85,6 @@ async function emulatePageFocus(cdp, logger) {
         .send('Emulation.setFocusEmulationEnabled', { enabled: true })
         .catch((error) => logger.debug(`No focus emulation: ${getErrorMessage(error)}`));
 }
-/** Reads the client hints Chrome reports, renaming the HeadlessChrome brand */
-const USER_AGENT_METADATA_SCRIPT = `(async () => {
-  const data = navigator.userAgentData;
-  if (!data) return null;
-  const values = await data.getHighEntropyValues(
-    ['architecture', 'bitness', 'model', 'platformVersion', 'fullVersionList', 'wow64']
-  );
-  const rename = (list) => (list || []).map((entry) => ({
-    brand: entry.brand.replace('HeadlessChrome', 'Google Chrome'),
-    version: entry.version,
-  }));
-  return {
-    brands: rename(values.brands),
-    fullVersionList: rename(values.fullVersionList),
-    platform: values.platform,
-    platformVersion: values.platformVersion,
-    architecture: values.architecture,
-    model: values.model,
-    mobile: values.mobile,
-    bitness: values.bitness,
-    wow64: values.wow64,
-  };
-})()`;
-/**
- * Send the user agent and client hints of regular Chrome from headless
- * Chrome: sites serve "HeadlessChrome" a different page (or a bot
- * challenge), so the page would not be the one a user sees.
- *
- * @param cdp - CDP connection
- * @param logger - Logger for failures (the session works without it)
- */
-async function hideHeadlessUserAgent(cdp, logger) {
-    try {
-        const { userAgent } = (await cdp.send('Browser.getVersion'));
-        if (!userAgent.includes('HeadlessChrome'))
-            return;
-        const metadata = (await cdp.send('Runtime.evaluate', {
-            expression: USER_AGENT_METADATA_SCRIPT,
-            awaitPromise: true,
-            returnByValue: true,
-        }));
-        await cdp.send('Emulation.setUserAgentOverride', {
-            userAgent: userAgent.replace('HeadlessChrome', 'Chrome'),
-            ...(metadata.result?.value ? { userAgentMetadata: metadata.result.value } : {}),
-        });
-    }
-    catch (error) {
-        logger.debug(`User agent left as is: ${getErrorMessage(error)}`);
-    }
-}
 export function createDefaultTelemetryPlugins() {
     return [
         {
@@ -145,12 +97,24 @@ export function createDefaultTelemetryPlugins() {
         {
             name: 'page-identity',
             runAlways: true,
-            async start({ cdp, logger }) {
+            async start({ cdp, logger, config }) {
                 await emulatePageFocus(cdp, logger);
-                await hideHeadlessUserAgent(cdp, logger);
+                if (!config.viewport?.mobile)
+                    await hideHeadlessUserAgent(cdp, logger);
                 return () => undefined;
             },
         },
+        {
+            name: 'page-crash',
+            runAlways: true,
+            async start({ cdp, store }) {
+                return startCrashTracking(cdp, (crashedAt) => {
+                    store.pageCrashedAt = crashedAt;
+                    if (crashedAt !== undefined)
+                        cdp.rejectPending(pageCrashedCommandError(crashedAt));
+                });
+            },
+        },
         {
             name: 'navigation',
             runAlways: true,
@@ -191,7 +155,9 @@ export function createDefaultTelemetryPlugins() {
             name: 'console',
             telemetry: 'console',
             async start({ cdp, config, store }) {
-                return startConsoleCollection(cdp, store.consoleMessages, config.includeAll ?? false, store.getCurrentNavigationId ?? undefined);
+                return startConsoleCollection(cdp, store.consoleMessages, config.includeAll ?? false, store.getCurrentNavigationId ?? undefined, () => {
+                    store.consoleDropped++;
+                });
             },
         },
         {

package/dist/daemon/session/teardown.js

@@ -123,6 +123,6 @@ async function terminateChrome(chrome, log) {
         log.info(`Chrome (PID ${pid}) survived SIGKILL`);
         return;
     }
-    clearChromePid();
+    clearChromePid(pid);
 }
 //# sourceMappingURL=teardown.js.map