browser-commander 0.21.1 → 0.21.2

package/CHANGELOG.md

@@ -1,5 +1,11 @@
 # Changelog
 
+## 0.21.2
+
+### Patch Changes
+
+- 917d611: Keep the real-browser launcher under the ESLint complexity limit, fail `npm run lint` on any warning, and record that `node-pty`'s install script (pulled in by `command-stream`) stays blocked.
+
 ## 0.21.1
 
 ### Patch Changes

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "browser-commander",
-  "version": "0.21.1",
+  "version": "0.21.2",
   "description": "Universal browser automation library that supports both Playwright and Puppeteer with a unified API",
   "main": "src/index.js",
   "bin": {
@@ -27,7 +27,7 @@
     "test:e2e:api-coverage": "node scripts/run-tests.mjs --env RUN_E2E=true tests/e2e/api-coverage.e2e.test.js",
     "test:e2e:google-probe": "node scripts/run-tests.mjs --env RUN_E2E=true --env RUN_GOOGLE_PROBE=true tests/e2e/google-signin-probe.e2e.test.js",
     "test:all": "npm run test:unit && npm run test:e2e",
-    "lint": "eslint .",
+    "lint": "eslint . --max-warnings 0",
     "lint:fix": "eslint . --fix",
     "format": "prettier --write .",
     "format:check": "prettier --check .",
@@ -103,6 +103,7 @@
   },
   "allowScripts": {
     "better-sqlite3@13.0.3": true,
+    "node-pty": false,
     "puppeteer": false
   }
 }

package/src/browser/real-browser.js

@@ -527,6 +527,22 @@ function mergeSeedCookies(seedCookies, migratedCookies) {
     : seedCookies;
 }
 
+// Runs a launch step and, if it throws, removes the profile this launch
+// created before rethrowing. A caller-supplied profile is never removed.
+async function removingTemporaryProfileOnError(
+  { userDataDir, temporaryProfile },
+  step
+) {
+  try {
+    return await step();
+  } catch (error) {
+    if (temporaryProfile) {
+      await removeUserDataDir(userDataDir);
+    }
+    throw error;
+  }
+}
+
 export async function launchAndConnectRealBrowserWithDependencies(
   options = {},
   dependencies = {}
@@ -602,23 +618,18 @@ export async function launchAndConnectRealBrowserWithDependencies(
 
   // Migration and snapshot attach can copy a preference that enables the
   // default-browser infobar, so apply launch settings after either copy.
-  try {
-    await configureUserDataDir(userDataDir, {
+  const profile = { userDataDir, temporaryProfile };
+  await removingTemporaryProfileOnError(profile, () =>
+    configureUserDataDir(userDataDir, {
       defaultBrowserCheck,
       preferences,
       localState,
       profileDirectory: attach?.profile ?? 'Default',
-    });
-  } catch (error) {
-    if (temporaryProfile) {
-      await removeUserDataDir(userDataDir);
-    }
-    throw error;
-  }
+    })
+  );
 
-  let launched;
-  try {
-    launched = await spawnOnFreePort({
+  const launched = await removingTemporaryProfileOnError(profile, () =>
+    spawnOnFreePort({
       requestedPort: remoteDebuggingPort,
       portAttempts,
       executablePath,
@@ -628,13 +639,8 @@ export async function launchAndConnectRealBrowserWithDependencies(
       userDataDir,
       startupTimeout,
       dependencies,
-    });
-  } catch (error) {
-    if (temporaryProfile) {
-      await removeUserDataDir(userDataDir);
-    }
-    throw error;
-  }
+    })
+  );
   const { browserProcess, cdpEndpoint: resolvedCdpEndpoint } = launched;
   if (temporaryProfile) {
     // The profile goes away with the browser, also when the user closes the