brightspace-mcp-server 5.1.40 → 5.1.42

package/build/tools/get-assignment-rubric.js

@@ -5,7 +5,7 @@
  */
 import { ApiError, DEFAULT_CACHE_TTLS } from "../api/index.js";
 import { GetAssignmentRubricSchema } from "./schemas.js";
-import { toolResponse, sanitizeError } from "./tool-helpers.js";
+import { toolResponse, sanitizeError, throwIfCredentialRejected } from "./tool-helpers.js";
 import { feedbackText } from "../utils/feedback.js";
 import { log } from "../utils/logger.js";
 // D2L's documented SCORING_M enumeration
@@ -216,13 +216,21 @@ export async function fetchAssignmentRubrics(apiClient, courseId, assignmentId)
             rubrics = Array.isArray(raw) ? raw : raw?.Objects ?? [];
         }
         catch (error) {
-            if (error instanceof ApiError && (error.status === 403 || error.status === 404)) {
-                rubrics = [];
-            }
-            else {
-                log("DEBUG", `Failed to fetch rubrics for assignment ${assignmentId} via the rubrics endpoint`, error);
-                rubrics = [];
+            throwIfCredentialRejected(error);
+            if (!(error instanceof ApiError && (error.status === 403 || error.status === 404))) {
+                // Only a 403/404 means "nothing to show here". Anything else (5xx,
+                // timeout, network) leaves it unknown whether a rubric is attached,
+                // so it must never be reported as "no rubric".
+                log("INFO", `get_assignment_rubric: Rubrics for assignment ${assignmentId} in course ${courseId} could not be read`, error);
+                return {
+                    rubrics: [],
+                    rubricsUnreadable: true,
+                    note: "The rubric for this assignment could not be read from Brightspace, so it may still have one. " +
+                        "Do not report the assignment as having no rubric: call get_assignment_rubric again, or check " +
+                        "the assignment in Brightspace.",
+                };
             }
+            rubrics = [];
         }
     }
     if (rubrics.length === 0) {
@@ -257,7 +265,7 @@ export function registerGetAssignmentRubric(server, apiClient) {
     server.registerTool("get_assignment_rubric", {
         title: "Get Assignment Rubric",
         annotations: { readOnlyHint: true },
-        description: "Fetch the full grading rubric for a dropbox assignment: every criteria group, criterion, and achievement level with its points and description, plus the student's own graded outcome per criterion once it has been released. Use this when the user asks what a rubric wants, how an assignment will be graded, or why they got a particular score on a criterion.",
+        description: "Fetch the full grading rubric for a dropbox assignment: every criteria group, criterion, and achievement level with its points and description, plus the student's own graded outcome per criterion once it has been released. If the rubric lookup fails with anything but a 403/404, rubricsUnreadable is true and an empty rubrics list is not proof the assignment has no rubric. Use this when the user asks what a rubric wants, how an assignment will be graded, or why they got a particular score on a criterion.",
         inputSchema: GetAssignmentRubricSchema,
     }, async (args) => {
         try {

package/build/tools/get-dropbox-submissions.js

@@ -5,7 +5,7 @@
  */
 import { ApiError, DEFAULT_CACHE_TTLS } from "../api/index.js";
 import { GetDropboxSubmissionsSchema } from "./schemas.js";
-import { toolResponse, sanitizeError, errorResponse } from "./tool-helpers.js";
+import { toolResponse, sanitizeError, errorResponse, throwIfCredentialRejected } from "./tool-helpers.js";
 import { log } from "../utils/logger.js";
 // Per-submitter feedback lookup is one GET each; cap how many run at once so
 // a large dropbox folder can't fan out hundreds of concurrent requests.
@@ -100,6 +100,7 @@ export function registerGetDropboxSubmissions(server, apiClient) {
                         feedbackMap.set(userId, fb);
                     }
                     catch (error) {
+                        throwIfCredentialRejected(error);
                         if (!(error instanceof ApiError && error.status === 404)) {
                             feedbackUnread.add(userId);
                         }

package/build/tools/get-dropbox-user-submissions.js

@@ -5,7 +5,7 @@
  */
 import { ApiError } from "../api/index.js";
 import { GetDropboxUserSubmissionsSchema } from "./schemas.js";
-import { toolResponse, sanitizeError, errorResponse } from "./tool-helpers.js";
+import { toolResponse, sanitizeError, errorResponse, throwIfCredentialRejected } from "./tool-helpers.js";
 import { log } from "../utils/logger.js";
 /**
  * Register get_dropbox_user_submissions tool.
@@ -65,6 +65,7 @@ export function registerGetDropboxUserSubmissions(server, apiClient) {
                     feedback = await apiClient.get(feedbackPath);
                 }
                 catch (error) {
+                    throwIfCredentialRejected(error);
                     if (!(error instanceof ApiError && error.status === 404)) {
                         feedbackUnread = true;
                         log("INFO", "get_dropbox_user_submissions: Feedback could not be read", { courseId, folderId, userId });

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "brightspace-mcp-server",
-  "version": "5.1.40",
+  "version": "5.1.42",
   "mcpName": "io.github.RohanMuppa/brightspace",
   "description": "MCP server for Brightspace (D2L). Check grades, due dates, assignments, announcements, syllabus, rosters and more via Claude, ChatGPT, Cursor, Windsurf, or any MCP client.",
   "type": "module",