brightspace-mcp-server 5.1.26 → 5.1.27

package/build/utils/zip-extract.js

@@ -16,8 +16,9 @@ import { inflateRawSync } from "node:zlib";
  * parsing a header that does not exist.
  *
  * Nothing here throws. A truncated download, an unsupported compression
- * method, or a ZIP64 archive all return null, because the caller's fallback
- * is simply to report the file without its text.
+ * method, a ZIP64 archive, or an entry that inflates past the size budget all
+ * return null, because the caller's fallback is simply to report the file
+ * without its text.
  */
 const EOCD_SIGNATURE = 0x06054b50;
 const CENTRAL_FILE_SIGNATURE = 0x02014b50;
@@ -26,6 +27,13 @@ const EOCD_MAX_COMMENT = 0xffff;
 const ZIP64_MARKER = 0xffffffff;
 const METHOD_STORED = 0;
 const METHOD_DEFLATE = 8;
+/**
+ * Most bytes one document may inflate to, across every entry read from it.
+ * DEFLATE reaches ~1000:1, so a 50 MB download could otherwise inflate to
+ * tens of gigabytes and take the server down (issue #380). Real Office XML
+ * sits far below this.
+ */
+export const MAX_INFLATED_BYTES = 64 * 1024 * 1024;
 /** Find the End of Central Directory record by scanning backwards. */
 function findEocd(buffer) {
     const earliest = Math.max(0, buffer.length - EOCD_MIN_SIZE - EOCD_MAX_COMMENT);
@@ -70,7 +78,13 @@ function readCentralDirectory(buffer) {
     }
     return entries;
 }
-function readEntryData(buffer, entry) {
+/**
+ * An entry's bytes, or null when it would exceed `limit`. The declared size
+ * is checked first, but a header can lie, so inflation is capped as well.
+ */
+function readEntryData(buffer, entry, limit) {
+    if (entry.uncompressedSize > limit)
+        return null;
     const header = entry.localHeaderOffset;
     if (header + 30 > buffer.length)
         return null;
@@ -84,18 +98,19 @@ function readEntryData(buffer, entry) {
         return null;
     const raw = buffer.subarray(start, end);
     if (entry.method === METHOD_STORED)
-        return Buffer.from(raw);
+        return raw.length > limit ? null : Buffer.from(raw);
     if (entry.method !== METHOD_DEFLATE)
         return null;
     try {
-        return inflateRawSync(raw);
+        // Throws a RangeError past maxOutputLength.
+        return inflateRawSync(raw, { maxOutputLength: Math.max(1, limit) });
     }
     catch {
         return null;
     }
 }
 /** One entry from a ZIP archive by exact name, or null. Never throws. */
-export function extractZipEntry(buffer, entryName) {
+export function extractZipEntry(buffer, entryName, limit = MAX_INFLATED_BYTES) {
     try {
         const entries = readCentralDirectory(buffer);
         if (!entries)
@@ -103,7 +118,7 @@ export function extractZipEntry(buffer, entryName) {
         const entry = entries.find((e) => e.name === entryName);
         if (!entry)
             return null;
-        return readEntryData(buffer, entry);
+        return readEntryData(buffer, entry, limit);
     }
     catch {
         return null;
@@ -145,7 +160,22 @@ export function officeDocumentText(buffer) {
     const names = listZipEntries(buffer);
     if (!names)
         return null;
-    const read = (name) => xmlToText(extractZipEntry(buffer, name)?.toString("utf-8") ?? "");
+    // One budget for the whole document, so a PPTX can't spread a zip bomb
+    // across many slides that each fit on their own. An entry that fails to
+    // read (oversize included) ends the walk: retrying the rest would re-inflate
+    // up to the budget once per entry.
+    let budget = MAX_INFLATED_BYTES;
+    const read = (name) => {
+        if (budget <= 0)
+            return "";
+        const data = extractZipEntry(buffer, name, budget);
+        if (!data) {
+            budget = 0;
+            return "";
+        }
+        budget -= data.length;
+        return xmlToText(data.toString("utf-8"));
+    };
     let text = "";
     if (names.includes("word/document.xml")) {
         text = read("word/document.xml");

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "brightspace-mcp-server",
-  "version": "5.1.26",
+  "version": "5.1.27",
   "mcpName": "io.github.RohanMuppa/brightspace",
   "description": "MCP server for Brightspace (D2L). Check grades, due dates, assignments, announcements, syllabus, rosters and more via Claude, ChatGPT, Cursor, Windsurf, or any MCP client.",
   "type": "module",