brightspace-mcp-server 3.11.9 → 3.11.10

package/build/tools/get-assignment-rubric.js

@@ -6,7 +6,7 @@
 import { ApiError, DEFAULT_CACHE_TTLS } from "../api/index.js";
 import { GetAssignmentRubricSchema } from "./schemas.js";
 import { toolResponse, sanitizeError } from "./tool-helpers.js";
-import { convertHtmlToMarkdown } from "../utils/html-converter.js";
+import { feedbackText } from "../utils/feedback.js";
 import { log } from "../utils/logger.js";
 // D2L's documented SCORING_M enumeration
 // (https://docs.valence.desire2learn.com/res/assessment.html). Only values
@@ -20,10 +20,7 @@ const SCORING_METHOD_NAMES = {
 };
 /** Rich text to plain markdown, or undefined when there is nothing to say. */
 function textOf(rt) {
-    if (!rt)
-        return undefined;
-    const text = rt.Html ? convertHtmlToMarkdown(rt.Html).markdown : rt.Text ?? undefined;
-    return text && text.trim().length > 0 ? text : undefined;
+    return feedbackText(rt) ?? undefined;
 }
 /** The groups a rubric carries, normalizing the grouped and flattened shapes. */
 function groupsOf(rubric) {
@@ -120,7 +117,7 @@ function levelNamesOf(rubric) {
  * The student's own graded outcome on this rubric, resolved against the
  * rubric's own criterion/level names rather than re-sent by the assessment.
  */
-function toOutputAssessment(rubric, assessment) {
+export function toOutputAssessment(rubric, assessment) {
     const criterionNames = criterionNamesOf(rubric);
     const levelNames = levelNamesOf(rubric);
     const out = { criteria: [] };

package/build/tools/get-assignments.js

@@ -13,6 +13,8 @@ import { applyCourseFilter } from "../utils/course-filter.js";
 import { gradebookUrl, quizUrl } from "../utils/deep-links.js";
 import { assignmentLinkResolver } from "./assignment-links.js";
 import { dueIn } from "../utils/due-in.js";
+import { feedbackText, FEEDBACK_UNAVAILABLE_NOTE } from "../utils/feedback.js";
+import { toOutputAssessment } from "./get-assignment-rubric.js";
 /** The display HTML of a quiz rich-text field, nested shape or flat. */
 function richTextHtml(field) {
     if (!field)
@@ -154,13 +156,18 @@ export async function fetchCourseAssignments(apiClient, courseId, baseUrl) {
             }
             // Fetch feedback independently of submissions
             let feedback = null;
+            let feedbackStatus = "unavailable";
             try {
                 feedback = await apiClient.get(apiClient.le(courseId, `/dropbox/folders/${folder.Id}/feedback/myFeedback/`), { ttl: DEFAULT_CACHE_TTLS.assignments });
+                feedbackStatus = feedback ? "retrieved" : "unavailable";
             }
             catch (error) {
                 if (isAuthUnavailable(error))
                     throw error;
-                // 404/403 means no feedback available (or no access) - that's fine
+                // Permission failures, missing API records, and transport failures
+                // do not establish whether published feedback exists in the UI.
+                feedbackStatus = error?.status === 403 ? "restricted"
+                    : error?.status === 404 ? "unavailable" : "error";
                 if (error?.status !== 404 && error?.status !== 403) {
                     log("DEBUG", `Failed to fetch feedback for folder ${folder.Id}`, error);
                 }
@@ -176,6 +183,15 @@ export async function fetchCourseAssignments(apiClient, courseId, baseUrl) {
                 .filter((l) => Boolean(l.Href))
                 .map((l) => ({ name: l.LinkName ?? l.Title ?? l.Href ?? null, url: l.Href }));
             // Build assignment object
+            const overallFeedback = feedbackText(feedback?.Feedback);
+            const rubricAssessments = (feedback?.RubricAssessments ?? []).map((assessment) => {
+                const rubric = folder.Assessment?.Rubrics?.find((r) => r.RubricId === assessment.RubricId);
+                return {
+                    rubricId: assessment.RubricId,
+                    ...toOutputAssessment((rubric ?? { RubricId: assessment.RubricId, Name: "" }), assessment),
+                };
+            });
+            const commentsRetrieved = Boolean(overallFeedback || rubricAssessments.some((rubric) => rubric.feedback || rubric.criteria.some((criterion) => criterion.feedback)));
             const assignment = {
                 type: "assignment",
                 id: folder.Id,
@@ -227,11 +243,14 @@ export async function fetchCourseAssignments(apiClient, courseId, baseUrl) {
                 feedback: feedback
                     ? {
                         score: feedback.Score,
-                        feedback: feedback.Feedback?.Html
-                            ? convertHtmlToMarkdown(feedback.Feedback.Html).markdown
-                            : null,
+                        feedback: overallFeedback,
+                        rubricAssessments,
                     }
                     : null,
+                feedbackStatus,
+                feedbackCommentsStatus: commentsRetrieved ? "retrieved" : "unavailable",
+                feedbackUrl: baseUrl ? gradebookUrl(baseUrl, courseId) : null,
+                ...(commentsRetrieved ? {} : { feedbackStatusNote: FEEDBACK_UNAVAILABLE_NOTE }),
             };
             assignments.push(assignment);
         }

package/build/tools/get-my-grades.js

@@ -10,6 +10,7 @@ import { toolResponse, sanitizeError, errorResponse, isAuthUnavailable, authPend
 import { log } from "../utils/logger.js";
 import { applyCourseFilter } from "../utils/course-filter.js";
 import { gradebookUrl, quizUrl } from "../utils/deep-links.js";
+import { feedbackText, FEEDBACK_UNAVAILABLE_NOTE } from "../utils/feedback.js";
 /**
  * The quiz a grade row is scored from can hold feedback the gradebook does
  * not, and the student API cannot read it: quiz attempts are refused to
@@ -35,15 +36,15 @@ async function fetchQuizzes(apiClient, courseId) {
     }
 }
 /**
- * Clean grade rows. Rows scored from a quiz also carry feedbackUrl, and a
- * feedbackNote when the gradebook comment is empty; other rows are unchanged.
+ * Normalize public comments and report their retrieval status. Quiz-linked
+ * rows keep the quiz source URL and note; other rows link to the gradebook.
  */
 function toGradeItems(gradeValues, quizzes, baseUrl, courseId) {
     const quizByGradeItem = new Map(quizzes
         .filter((q) => q.GradeItemId != null)
         .map((q) => [String(q.GradeItemId), q.QuizId]));
     return gradeValues.map((gv) => {
-        const comments = gv.Comments?.Text || null;
+        const comments = feedbackText(gv.Comments);
         const quizId = quizByGradeItem.get(String(gv.GradeObjectIdentifier));
         return {
             name: gv.GradeObjectName,
@@ -52,12 +53,13 @@ function toGradeItems(gradeValues, quizzes, baseUrl, courseId) {
             pointsDenominator: gv.PointsDenominator,
             weightedNumerator: gv.WeightedNumerator,
             weightedDenominator: gv.WeightedDenominator,
+            gradeObjectId: gv.GradeObjectIdentifier,
             comments,
+            feedbackStatus: comments ? "retrieved" : "unavailable",
+            feedbackUrl: quizId === undefined ? gradebookUrl(baseUrl, courseId) : quizUrl(baseUrl, courseId, quizId),
+            ...(comments ? {} : { feedbackStatusNote: FEEDBACK_UNAVAILABLE_NOTE }),
             lastModified: gv.LastModified,
-            ...(quizId === undefined ? {} : {
-                feedbackUrl: quizUrl(baseUrl, courseId, quizId),
-                ...(comments ? {} : { feedbackNote: QUIZ_FEEDBACK_NOTE }),
-            }),
+            ...(quizId !== undefined && !comments ? { feedbackNote: QUIZ_FEEDBACK_NOTE } : {}),
         };
     });
 }

package/build/utils/feedback.js

@@ -0,0 +1,12 @@
+/** Public instructor feedback only; never substitute private comments. */
+import { convertHtmlToMarkdown } from "./html-converter.js";
+export function feedbackText(value) {
+    if (!value)
+        return null;
+    const markdown = value.Html ? convertHtmlToMarkdown(value.Html).markdown : null;
+    if (markdown?.trim())
+        return markdown;
+    return value.Text?.trim() ? value.Text : null;
+}
+export const FEEDBACK_UNAVAILABLE_NOTE = "Brightspace did not return instructor comments through this API. Published feedback may still " +
+    "be available in Brightspace; do not interpret null as no feedback. Check the source URL.";

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "brightspace-mcp-server",
-  "version": "3.11.9",
+  "version": "3.11.10",
   "mcpName": "io.github.RohanMuppa/brightspace",
   "description": "MCP server for Brightspace (D2L). Check grades, due dates, assignments, announcements, syllabus, rosters and more via Claude, ChatGPT, Cursor, Windsurf, or any MCP client.",
   "type": "module",