brighterscript 1.0.0-alpha.47 → 1.0.0-alpha.49

package/dist/bscPlugin/validation/ScopeValidator.spec.js

@@ -14,6 +14,7 @@ const fsExtra = require("fs-extra");
 const testHelpers_spec_2 = require("../../testHelpers.spec");
 const reflection_1 = require("../../astUtils/reflection");
 const ScopeValidator_1 = require("./ScopeValidator");
+const logger_1 = require("@rokucommunity/logger");
 describe('ScopeValidator', () => {
     let sinon = sinonImport.createSandbox();
     let program;
@@ -1713,6 +1714,86 @@ describe('ScopeValidator', () => {
                 ]);
             });
         });
+        describe('inline interfaces', () => {
+            it('allows function param with compatible interface', () => {
+                program.setFile('source/main.bs', `
+                    sub takesInline(datum as {name as string})
+                    end sub
+
+                    sub callsTakesInline()
+                        takesInline({age: 123, name: "test"})
+                    end sub
+                `);
+                program.validate();
+                (0, testHelpers_spec_1.expectZeroDiagnostics)(program);
+            });
+            it('validates function param with incompatible interface', () => {
+                program.setFile('source/main.bs', `
+                    sub takesInline(datum as {name as string})
+                    end sub
+
+                    sub callsTakesInline()
+                        takesInline({name: 123})
+                    end sub
+                `);
+                program.validate();
+                (0, testHelpers_spec_1.expectDiagnostics)(program, [
+                    DiagnosticMessages_1.DiagnosticMessages.argumentTypeMismatch('roAssociativeArray', '{name as string}', {
+                        fieldMismatches: [{ name: 'name', expectedType: StringType_1.StringType.instance, actualType: IntegerType_1.IntegerType.instance }]
+                    }).message
+                ]);
+            });
+        });
+        describe('type statement types', () => {
+            it('allows compatible type statement types to be passed to functions expecting normal types', () => {
+                program.setFile('source/main.bs', `
+                    type number = integer or float
+
+                    sub takesNumber(x as number)
+                        takesInteger(x)
+                    end sub
+
+                    sub takesInteger(x as integer)
+                        print x
+                      end sub
+                `);
+                program.validate();
+                (0, testHelpers_spec_1.expectZeroDiagnostics)(program);
+            });
+            it('disallows incompatible type statement types to be passed to functions expecting normal types', () => {
+                program.setFile('source/main.bs', `
+                    type whatever = float or string
+
+                    sub takesNumber(x as whatever)
+                        takesInteger(x)
+                    end sub
+
+                    sub takesInteger(x as integer)
+                        print x
+                    end sub
+                `);
+                program.validate();
+                (0, testHelpers_spec_1.expectDiagnostics)(program, [
+                    DiagnosticMessages_1.DiagnosticMessages.argumentTypeMismatch('whatever', 'integer').message
+                ]);
+            });
+        });
+        it('allows using invalid as argument for typed array params', () => {
+            program.setFile('source/main.bs', `
+                sub takesIntArray(arr as integer[])
+                end sub
+
+                sub takesStrArray(arr as string[])
+                end sub
+
+                sub test()
+                    takesIntArray(invalid)
+                    takesStrArray(invalid)
+                end sub
+            `);
+            program.validate();
+            (0, testHelpers_spec_1.expectZeroDiagnostics)(program);
+        });
     });
     describe('cannotFindName', () => {
         it('finds variables from assignments from member functions of primitive types', () => {
@@ -2178,6 +2259,42 @@ describe('ScopeValidator', () => {
             program.validate();
             (0, testHelpers_spec_1.expectZeroDiagnostics)(program);
         });
+        it('validates accessing a bad member on a type statement type', () => {
+            program.setFile('source/main.bs', `
+                type numberOrString = integer or string
+
+                function test(x as numberOrString)
+                    print x.nonExistentMember
+                end function
+            `);
+            program.validate();
+            (0, testHelpers_spec_1.expectDiagnostics)(program, [
+                DiagnosticMessages_1.DiagnosticMessages.cannotFindName('nonExistentMember', 'numberOrString.nonExistentMember', 'numberOrString')
+            ]);
+        });
+        describe('inline interfaces', () => {
+            it('finds members of inline interface', () => {
+                program.setFile('source/main.bs', `
+                    sub takesInline(datum as {name as string})
+                        print datum.name.split(",")
+                    end sub
+
+                `);
+                program.validate();
+                (0, testHelpers_spec_1.expectZeroDiagnostics)(program);
+            });
+            it('validates using invalid member name', () => {
+                program.setFile('source/main.bs', `
+                    sub takesInline(datum as {name as string})
+                        print datum.notThere.split(",")
+                    end sub
+                `);
+                program.validate();
+                (0, testHelpers_spec_1.expectDiagnostics)(program, [
+                    DiagnosticMessages_1.DiagnosticMessages.cannotFindName('notThere', '{name as string}.notThere', '{name as string}')
+                ]);
+            });
+        });
     });
     describe('itemCannotBeUsedAsVariable', () => {
         it('detects assigning to a member of a namespace outside the namespace', () => {
@@ -2693,6 +2810,124 @@ describe('ScopeValidator', () => {
             program.validate();
             (0, testHelpers_spec_1.expectZeroDiagnostics)(program);
         });
+        it('allows returning a function call', () => {
+            const spy = sinon.spy(logger_1.Logger.prototype, 'error');
+            program.setFile('source/main.bs', `
+                function abc(func as function) as dynamic
+                    return func()
+                end function
+            `);
+            program.validate();
+            (0, testHelpers_spec_1.expectZeroDiagnostics)(program);
+            (0, chai_1.expect)(spy.getCalls().map(x => { var _a, _b; return (_b = (_a = x.args) === null || _a === void 0 ? void 0 : _a[0]) === null || _b === void 0 ? void 0 : _b.toString(); }).filter(x => x === null || x === void 0 ? void 0 : x.includes('Error when calling plugin'))).to.eql([]);
+        });
+        it('allows returning a roFunction call', () => {
+            const spy = sinon.spy(logger_1.Logger.prototype, 'error');
+            program.setFile('source/main.bs', `
+                function abc(func as roFunction) as dynamic
+                    return func()
+                end function
+            `);
+            program.validate();
+            (0, testHelpers_spec_1.expectZeroDiagnostics)(program);
+            (0, chai_1.expect)(spy.getCalls().map(x => { var _a, _b; return (_b = (_a = x.args) === null || _a === void 0 ? void 0 : _a[0]) === null || _b === void 0 ? void 0 : _b.toString(); }).filter(x => x === null || x === void 0 ? void 0 : x.includes('Error when calling plugin'))).to.eql([]);
+        });
+        it('allows returning a call on an object type', () => {
+            const spy = sinon.spy(logger_1.Logger.prototype, 'error');
+            program.setFile('source/main.bs', `
+                function abc(func as object) as dynamic
+                    return func()
+                end function
+            `);
+            program.validate();
+            (0, testHelpers_spec_1.expectZeroDiagnostics)(program);
+            (0, chai_1.expect)(spy.getCalls().map(x => { var _a, _b; return (_b = (_a = x.args) === null || _a === void 0 ? void 0 : _a[0]) === null || _b === void 0 ? void 0 : _b.toString(); }).filter(x => x === null || x === void 0 ? void 0 : x.includes('Error when calling plugin'))).to.eql([]);
+        });
+        it('allows calling func returned from other func', () => {
+            const spy = sinon.spy(logger_1.Logger.prototype, 'error');
+            program.setFile('source/calc.bs', `
+                sub otherFuncFirst()
+                  ' forces getOperation to be referenceType called from ReferenceType
+                end sub
+
+                function calc(a as dynamic, b as dynamic, op as string) as dynamic
+                    op = getOperation(op)
+                    return op(1, 2)
+                end function
+
+                function getOperation(name as string) as object
+                    return {
+                        "sum": function(a as dynamic, b as dynamic) as dynamic
+                            return a + b
+                        end function
+                    }[name]
+                end function
+            `);
+            program.validate();
+            (0, testHelpers_spec_1.expectZeroDiagnostics)(program);
+            (0, chai_1.expect)(spy.getCalls().map(x => { var _a, _b; return (_b = (_a = x.args) === null || _a === void 0 ? void 0 : _a[0]) === null || _b === void 0 ? void 0 : _b.toString(); }).filter(x => x === null || x === void 0 ? void 0 : x.includes('Error when calling plugin'))).to.eql([]);
+        });
+        it('allows returning something that matches a type statement type', () => {
+            program.setFile('source/util.bs', `
+                interface Person
+                    name as string
+                    age as integer
+                end interface
+
+                type Wrapped = Person
+
+                function getWrapped() as Wrapped
+                    return {
+                        name: "Alice",
+                        age: 30
+                    }
+                 end function
+            `);
+            program.validate();
+            (0, testHelpers_spec_1.expectZeroDiagnostics)(program);
+        });
+        describe('inline interfaces', () => {
+            it('allows returning an Associative Array that meets the interface', () => {
+                program.setFile('source/main.bs', `
+                    function takesInline() as  {id as string}
+                        return { id: "test" }
+                    end function
+                `);
+                program.validate();
+                (0, testHelpers_spec_1.expectZeroDiagnostics)(program);
+            });
+            it('allows returning a Node that meets the interface', () => {
+                program.setFile('source/main.bs', `
+                    function takesInline() as  {id as string}
+                        return createObject("roSGNode", "Poster")
+                    end function
+                `);
+                program.validate();
+                (0, testHelpers_spec_1.expectZeroDiagnostics)(program);
+            });
+            it('validates returning an AA that does not meet the interface', () => {
+                program.setFile('source/main.bs', `
+                    function takesInline() as {id as integer}
+                        return {id: "hello"}
+                    end function
+                `);
+                program.validate();
+                (0, testHelpers_spec_1.expectDiagnostics)(program, [
+                    DiagnosticMessages_1.DiagnosticMessages.returnTypeMismatch('roAssociativeArray', '{id as integer}', {
+                        fieldMismatches: [{ name: 'id', expectedType: IntegerType_1.IntegerType.instance, actualType: StringType_1.StringType.instance }]
+                    }).message
+                ]);
+            });
+        });
+        it('allows returning invalid instead of typed array', () => {
+            program.setFile('source/main.bs', `
+                function getNumbers() as integer[]
+                    return invalid
+                end function
+            `);
+            program.validate();
+            (0, testHelpers_spec_1.expectZeroDiagnostics)(program);
+        });
     });
     describe('returnTypeCoercionMismatch', () => {
         it('allows functions, subs, and "function as void/dynamic" to not have return statements', () => {
@@ -3124,6 +3359,48 @@ describe('ScopeValidator', () => {
                 ]);
             });
         });
+        describe('inline interfaces', () => {
+            it('allows assigning an Associative Array that meets the interface', () => {
+                program.setFile('source/main.bs', `
+                    interface Iface
+                        inlineMember as {name as string}
+                    end interface
+
+                    sub takesInline(someIface as Iface}
+                        someIface.inlineMember = {name: "test"}
+                    end sub
+                `);
+                program.validate();
+                (0, testHelpers_spec_1.expectZeroDiagnostics)(program);
+            });
+            it('validates assigning an AA that does not meet the interface', () => {
+                program.setFile('source/main.bs', `
+                    interface Iface
+                        inlineMember as {name as string}
+                    end interface
+
+                    sub takesInline(someIface as Iface}
+                        someIface.inlineMember = {name: 123}
+                    end sub
+                `);
+                program.validate();
+                (0, testHelpers_spec_1.expectDiagnostics)(program, [
+                    DiagnosticMessages_1.DiagnosticMessages.assignmentTypeMismatch('roAssociativeArray', '{name as string}', {
+                        fieldMismatches: [{ name: 'name', expectedType: StringType_1.StringType.instance, actualType: IntegerType_1.IntegerType.instance }]
+                    }).message
+                ]);
+            });
+            it('allows assigning invalid to typed arrays', () => {
+                program.setFile('source/main.bs', `
+                sub test()
+                    intArray as integer[] = invalid
+                    strArray as string[] = invalid
+                end sub
+            `);
+                program.validate();
+                (0, testHelpers_spec_1.expectZeroDiagnostics)(program);
+            });
+        });
     });
     describe('operatorTypeMismatch', () => {
         it('finds when the type of the lhs is not compatible with the rhs type', () => {
@@ -3403,6 +3680,35 @@ describe('ScopeValidator', () => {
             program.validate();
             (0, testHelpers_spec_1.expectZeroDiagnostics)(program);
         });
+        it('allows unions of compatible types', () => {
+            program.setFile('source/main.bs', `
+                function test(s as string or roString, i as integer or longinteger)
+                    s1 = s + "test"
+                    s2 = "test" + s
+
+                    i1 = i + 5
+                    i2 = 5 + i
+                end function
+            `);
+            program.validate();
+            (0, testHelpers_spec_1.expectZeroDiagnostics)(program);
+        });
+        it('allows type statement type of compatible types', () => {
+            program.setFile('source/main.bs', `
+                type number = integer or float
+                type MyString = string or roString
+
+                function test(s as MyString, i as number)
+                    s1 = s + "test"
+                    s2 = "test" + s
+
+                    i1 = i + 5
+                    i2 = 5 + i
+                end function
+            `);
+            program.validate();
+            (0, testHelpers_spec_1.expectZeroDiagnostics)(program);
+        });
     });
     describe('memberAccessibilityMismatch', () => {
         it('should flag when accessing a private member', () => {
@@ -3682,6 +3988,25 @@ describe('ScopeValidator', () => {
             ]);
         });
     });
+    describe('circularReferenceDetected', () => {
+        it('finds circular references in consts', () => {
+            program.setFile('source/main.bs', `
+                const A = B ' this is circular-reference
+                const B = C ' this is circular-reference
+                const C = A ' this is circular-reference
+                sub main()
+                    print A ' this is circular-reference
+                end sub
+            `);
+            program.validate();
+            (0, testHelpers_spec_1.expectDiagnostics)(program, [
+                DiagnosticMessages_1.DiagnosticMessages.circularReferenceDetected(['B', 'C', 'B']).message,
+                DiagnosticMessages_1.DiagnosticMessages.circularReferenceDetected(['B', 'C', 'B']).message,
+                DiagnosticMessages_1.DiagnosticMessages.circularReferenceDetected(['B', 'C', 'B']).message,
+                DiagnosticMessages_1.DiagnosticMessages.circularReferenceDetected(['C', 'B', 'C']).message
+            ]);
+        });
+    });
     describe('revalidation', () => {
         it('revalidates when a enum defined in a different namespace changes', () => {
             program.setFile('source/file1.bs', `
@@ -4106,6 +4431,44 @@ describe('ScopeValidator', () => {
             // there should be no more errors
             (0, testHelpers_spec_1.expectZeroDiagnostics)(program);
         });
+        it('recognizes when the type of a for-each loop variable changes', () => {
+            program.setFile('source/file1.bs', `
+                interface FooFace
+                    prop as string
+                end interface
+            `);
+            program.setFile('source/file2.bs', `
+                function loopFooFace(input as FooFace[])
+                    out = ""
+                    for each ff in input
+                        out += ff.prop
+                    end for
+                    return out
+                end function
+            `);
+            program.validate();
+            //currently no error
+            (0, testHelpers_spec_1.expectZeroDiagnostics)(program);
+            // change FooFace.prop to not work in other file
+            program.setFile('source/file1.bs', `
+                interface FooFace
+                    prop as integer
+                end interface
+            `);
+            program.validate();
+            (0, testHelpers_spec_1.expectDiagnostics)(program, [
+                DiagnosticMessages_1.DiagnosticMessages.operatorTypeMismatch('+=', 'string', 'integer')
+            ]);
+            // change FooFace.prop to back to working
+            program.setFile('source/file1.bs', `
+                interface FooFace
+                    prop as string
+                end interface
+            `);
+            program.validate();
+            //currently no error
+            (0, testHelpers_spec_1.expectZeroDiagnostics)(program);
+        });
     });
     describe('preprocessor', () => {
         it('should process class inheritance correctly', () => {
@@ -4239,6 +4602,15 @@ describe('ScopeValidator', () => {
                 DiagnosticMessages_1.DiagnosticMessages.notCallable('"string"').message
             ]);
         });
+        it('allows calling an object type', () => {
+            program.setFile('source/calc.bs', `
+                function someFunc(otherFunc as object) as dynamic
+                    return otherFunc()
+                end function
+            `);
+            program.validate();
+            (0, testHelpers_spec_1.expectZeroDiagnostics)(program);
+        });
     });
     describe('callFunc', () => {
         it('allows access to member of return type when return type is custom node', () => {