brighterscript 1.0.0-alpha.41 → 1.0.0-alpha.42

package/dist/files/BrsFile.spec.js

@@ -16,6 +16,7 @@ const util_1 = require("../util");
 const testHelpers_spec_1 = require("../testHelpers.spec");
 const Parser_1 = require("../parser/Parser");
 const Statement_1 = require("../parser/Statement");
+const Statement_2 = require("../parser/Statement");
 const creators_1 = require("../astUtils/creators");
 const fsExtra = require("fs-extra");
 const undent_1 = require("undent");
@@ -23,6 +24,8 @@ const testHelpers_spec_2 = require("../testHelpers.spec");
 const types_1 = require("../types");
 const fileUrl = require("file-url");
 const reflection_1 = require("../astUtils/reflection");
+const Expression_1 = require("../parser/Expression");
+const logger_1 = require("@rokucommunity/logger");
 let sinon = sinonImport.createSandbox();
 describe('BrsFile', () => {
     let program;
@@ -156,6 +159,38 @@ describe('BrsFile', () => {
         program.validate();
         (0, testHelpers_spec_1.expectDiagnostics)(program, [DiagnosticMessages_1.DiagnosticMessages.itemCannotBeUsedAsVariable('enum').message]);
     });
+    it('does not crazy during validation with unique binary operator', () => {
+        //monitor the logging system, if we detect an error, this test fails
+        const spy = sinon.spy(logger_1.Logger.prototype, 'error');
+        const file = program.setFile('source/main.bs', `
+            namespace date
+                function timeElapsedInDay()
+                    time = 1
+                    if true then
+                        time = getInteger()
+                    end if
+                    clockSeconds = getInteger() + 1
+                    assumedMidnight = time - clockSeconds
+                    offset = assumedMidnight - 1
+                end function
+
+                function getInteger()
+                    return 1
+                end function
+            end namespace
+
+        `);
+        program.validate();
+        (0, testHelpers_spec_1.expectZeroDiagnostics)(program);
+        (0, chai_config_spec_1.expect)(spy.getCalls().map(x => { var _a, _b; return (_b = (_a = x.args) === null || _a === void 0 ? void 0 : _a[0]) === null || _b === void 0 ? void 0 : _b.toString(); }).filter(x => x === null || x === void 0 ? void 0 : x.includes('Error when calling plugin'))).to.eql([]);
+        // Check the result type too
+        const sourceScope = program.getScopeByName('source');
+        sourceScope.linkSymbolTable();
+        const timeElapsedFunc = file.ast.findChild(reflection_1.isFunctionExpression);
+        const symbolTable = timeElapsedFunc.body.getSymbolTable();
+        const offsetType = symbolTable.getSymbolType('offset', { flags: 1 /* SymbolTypeFlag.runtime */ });
+        (0, testHelpers_spec_1.expectTypeToBe)(offsetType, IntegerType_1.IntegerType);
+    });
     it('supports the third parameter in CreateObject', () => {
         program.setFile('source/main.brs', `
             sub main()
@@ -191,7 +226,7 @@ describe('BrsFile', () => {
     it('computes new import statements after clearing parser references', () => {
         const file = program.setFile('source/main.bs', ``);
         (0, chai_config_spec_1.expect)(file.ownScriptImports).to.be.empty;
-        file.parser.ast.statements.push(new Statement_1.ImportStatement({
+        file.parser.ast.statements.push(new Statement_2.ImportStatement({
             import: (0, creators_1.createToken)(TokenKind_1.TokenKind.Import),
             path: (0, creators_1.createToken)(TokenKind_1.TokenKind.StringLiteral, 'pkg:/source/lib.brs')
         }));
@@ -373,6 +408,17 @@ describe('BrsFile', () => {
                 program.validate();
                 (0, testHelpers_spec_1.expectDiagnostics)(program, [Object.assign(Object.assign({}, DiagnosticMessages_1.DiagnosticMessages.unknownDiagnosticCode(123456)), { location: util_1.default.createLocationFromFileRange(file, vscode_languageserver_1.Range.create(2, 53, 2, 59)) }), Object.assign(Object.assign({}, DiagnosticMessages_1.DiagnosticMessages.unknownDiagnosticCode(999999)), { location: util_1.default.createLocationFromFileRange(file, vscode_languageserver_1.Range.create(2, 60, 2, 66)) })]);
             });
+            it('recognizes diagnostic names', () => {
+                let file = program.setFile({ src: `${testHelpers_spec_2.rootDir}/source/main.brs`, dest: 'source/main.brs' }, `
+                    sub Main()
+                        'bs:disable-next-line: cannot-find-name
+                        name = unknown
+                    end sub
+                `);
+                (0, chai_config_spec_1.expect)(file.commentFlags[0]).to.exist;
+                program.validate();
+                (0, testHelpers_spec_1.expectZeroDiagnostics)(program);
+            });
         });
         describe('bs:disable-line', () => {
             it('works for all', () => {
@@ -646,7 +692,7 @@ describe('BrsFile', () => {
                 `);
                 program.validate();
                 (0, testHelpers_spec_1.expectDiagnostics)(program, [
-                    DiagnosticMessages_1.DiagnosticMessages.referencedConstDoesNotExist()
+                    DiagnosticMessages_1.DiagnosticMessages.hashConstDoesNotExist()
                 ]);
             });
             it('detects syntax error in #if not', () => {
@@ -659,7 +705,7 @@ describe('BrsFile', () => {
                 `);
                 program.validate();
                 (0, testHelpers_spec_1.expectDiagnostics)(program, [
-                    DiagnosticMessages_1.DiagnosticMessages.referencedConstDoesNotExist()
+                    DiagnosticMessages_1.DiagnosticMessages.hashConstDoesNotExist()
                 ]);
             });
             it('detects syntax error in #const', () => {
@@ -682,7 +728,7 @@ describe('BrsFile', () => {
                     end sub
                 `);
                 (0, testHelpers_spec_1.expectDiagnostics)(program, [
-                    DiagnosticMessages_1.DiagnosticMessages.constNameCannotBeReservedWord()
+                    DiagnosticMessages_1.DiagnosticMessages.cannotUseReservedWordAsIdentifier('function')
                 ]);
             });
             it('detects syntax error in #const', () => {
@@ -1063,7 +1109,7 @@ describe('BrsFile', () => {
             `);
             program.validate();
             (0, testHelpers_spec_1.expectDiagnostics)(program, [
-                DiagnosticMessages_1.DiagnosticMessages.statementMustBeDeclaredAtTopOfFile('import')
+                DiagnosticMessages_1.DiagnosticMessages.unexpectedStatementLocation('import', 'at the top of the file')
             ]);
         });
         it('supports library imports', () => {
@@ -1080,7 +1126,7 @@ describe('BrsFile', () => {
             `);
             program.validate();
             (0, testHelpers_spec_1.expectDiagnostics)(program, [
-                DiagnosticMessages_1.DiagnosticMessages.statementMustBeDeclaredAtTopOfFile('library')
+                DiagnosticMessages_1.DiagnosticMessages.unexpectedStatementLocation('library', 'at the top of the file')
             ]);
         });
         it('adds error for library statements inside of function body', () => {
@@ -1091,7 +1137,7 @@ describe('BrsFile', () => {
             `);
             program.validate();
             (0, testHelpers_spec_1.expectDiagnostics)(program, [
-                DiagnosticMessages_1.DiagnosticMessages.statementMustBeDeclaredAtTopOfFile('library')
+                DiagnosticMessages_1.DiagnosticMessages.unexpectedStatementLocation('library', 'at the top of the file')
             ]);
         });
         it('supports colons as separators in associative array properties', () => {
@@ -1191,10 +1237,10 @@ describe('BrsFile', () => {
                 end function
             `);
             (0, testHelpers_spec_1.expectDiagnostics)(file.parser.diagnostics, [
-                DiagnosticMessages_1.DiagnosticMessages.expectedRightParenAfterFunctionCallArguments(),
+                DiagnosticMessages_1.DiagnosticMessages.unmatchedLeftToken('(', 'function call arguments'),
                 DiagnosticMessages_1.DiagnosticMessages.expectedNewlineOrColon(),
                 DiagnosticMessages_1.DiagnosticMessages.unexpectedToken('end function'),
-                DiagnosticMessages_1.DiagnosticMessages.expectedRightParenAfterFunctionCallArguments(),
+                DiagnosticMessages_1.DiagnosticMessages.unmatchedLeftToken('(', 'function call arguments'),
                 DiagnosticMessages_1.DiagnosticMessages.expectedNewlineOrColon()
             ]);
         });
@@ -1668,8 +1714,8 @@ describe('BrsFile', () => {
                         print PKG_PATH
                         print LINE_NUM
                         print new Person()
-                        m@.someCallfunc()
-                        m@.someCallfunc(1, 2)
+                        m.node@.someCallfunc()
+                        m.node@.someCallfunc(1, 2)
                         print tag\`stuff\${LINE_NUM}\${LINE_NUM}\`
                         print 1 = 1 ? 1 : 2
                         print 1 = 1 ? m.one : m.two
@@ -1722,8 +1768,8 @@ describe('BrsFile', () => {
                         print "pkg:/source/main.brs"
                         print LINE_NUM
                         print Person()
-                        m.callfunc("someCallfunc")
-                        m.callfunc("someCallfunc", 1, 2)
+                        m.node.callfunc("someCallfunc")
+                        m.node.callfunc("someCallfunc", 1, 2)
                         print tag(["stuff", "", ""], [LINE_NUM, LINE_NUM])
                         print bslib_ternary(1 = 1, 1, 2)
                         print (function(__bsCondition, m)
@@ -1801,6 +1847,51 @@ describe('BrsFile', () => {
                 const result = file.transpile();
                 (0, chai_config_spec_1.expect)((0, testHelpers_spec_1.trimMap)((0, undent_1.default)(result.code))).to.eql((0, undent_1.default)(expected));
             }
+            it('transpiles call expression when paren tokens are missing', async () => {
+                const file = program.setFile('source/main.bs', `
+                    sub main()
+                    end sub
+                `);
+                const body = file.ast.findChild(reflection_1.isBlock);
+                body.statements.push(new Expression_1.CallExpression({
+                    callee: new Expression_1.LiteralExpression({ value: (0, creators_1.createIdentifier)('lcase') }),
+                    args: [(0, creators_1.createStringLiteral)('HELLO')]
+                }));
+                await testTranspile(file, `
+                    sub main()
+                        lcase("HELLO")
+                    end sub
+                `, undefined, undefined, false);
+            });
+            it('transpiles print expression when print token is missing', async () => {
+                const file = program.setFile('source/main.bs', `
+                    sub main()
+                    end sub
+                `);
+                const body = file.ast.findChild(reflection_1.isBlock);
+                body.statements.push(new Statement_2.PrintStatement({
+                    expressions: [(0, creators_1.createStringLiteral)('HELLO')]
+                }));
+                await testTranspile(file, `
+                    sub main()
+                        print "HELLO"
+                    end sub
+                `, undefined, undefined, false);
+            });
+            it('transpiles function expression when paren tokens are missing', async () => {
+                const file = program.setFile('source/main.bs', `
+                `);
+                file.ast.statements.push(new Statement_1.FunctionStatement({
+                    func: new Expression_1.FunctionExpression({
+                        body: new Statement_1.Block({ statements: [] })
+                    }),
+                    name: (0, creators_1.createIdentifier)('main')
+                }));
+                await testTranspile(file, `
+                    function main()
+                    end function
+                `, undefined, undefined, false);
+            });
         });
         it('transpilies libpkg:/ paths when encountered', async () => {
             program.setFile('source/lib.bs', `
@@ -3731,10 +3822,10 @@ describe('BrsFile', () => {
     });
     describe('callfunc operator', () => {
         describe('transpile', () => {
-            it('does not produce diagnostics', () => {
+            it('does not produce diagnostics on plain roSGNode', () => {
                 program.setFile('source/main.bs', `
                     sub test()
-                        someNode = createObject("roSGNode", "Rectangle")
+                        someNode = createObject("roSGNode", "Node")
                         someNode@.someFunction({test: "value"})
                     end sub
                 `);
@@ -3744,15 +3835,13 @@ describe('BrsFile', () => {
             it('sets invalid on empty callfunc with legacyCallfuncHandling=true', async () => {
                 program.options.legacyCallfuncHandling = true;
                 await testTranspile(`
-                    sub main()
-                        node = invalid
+                    sub main(node)
                         node@.doSomething()
                         m.top.node@.doSomething()
                         m.top.node@.doSomething(1)
                     end sub
                 `, `
-                    sub main()
-                        node = invalid
+                    sub main(node)
                         node.callfunc("doSomething", invalid)
                         m.top.node.callfunc("doSomething", invalid)
                         m.top.node.callfunc("doSomething", 1)
@@ -3761,15 +3850,13 @@ describe('BrsFile', () => {
             });
             it('empty callfunc allowed by default', async () => {
                 await testTranspile(`
-                    sub main()
-                        node = invalid
+                    sub main(node)
                         node@.doSomething()
                         m.top.node@.doSomething()
                         m.top.node@.doSomething(1)
                     end sub
                 `, `
-                    sub main()
-                        node = invalid
+                    sub main(node)
                         node.callfunc("doSomething")
                         m.top.node.callfunc("doSomething")
                         m.top.node.callfunc("doSomething", 1)
@@ -3778,13 +3865,11 @@ describe('BrsFile', () => {
             });
             it('includes original arguments', async () => {
                 await testTranspile(`
-                    sub main()
-                        node = invalid
+                    sub main(node)
                         node@.doSomething(1, true, m.top.someVal)
                     end sub
                 `, `
-                    sub main()
-                        node = invalid
+                    sub main(node)
                         node.callfunc("doSomething", 1, true, m.top.someVal)
                     end sub
                 `);
@@ -3933,9 +4018,11 @@ describe('BrsFile', () => {
         });
     });
     describe('getTypedef', () => {
-        function testTypedef(original, expected) {
-            let file = program.setFile('source/main.brs', original);
+        function testTypedef(original, expected, mode = Parser_1.ParseMode.BrighterScript) {
+            const ext = mode === Parser_1.ParseMode.BrighterScript ? 'bs' : 'brs';
+            let file = program.setFile(`source/main.${ext}`, original);
             program.validate();
+            (0, testHelpers_spec_1.expectZeroDiagnostics)(program);
             (0, chai_config_spec_1.expect)(file.getTypedef().trimEnd()).to.eql(expected);
         }
         it('includes namespace on extend class names', () => {
@@ -4008,6 +4095,7 @@ describe('BrsFile', () => {
             `);
         });
         it('includes import statements', () => {
+            program.setFile('source/lib.brs', ``);
             testTypedef(`
                import "pkg:/source/lib.brs"
             `, (0, testHelpers_spec_1.trim) `
@@ -4103,6 +4191,7 @@ describe('BrsFile', () => {
         it('includes class inheritance', () => {
             testTypedef(`
                 class Human
+                    name
                     sub new(name as string)
                         m.name = name
                     end sub
@@ -4114,6 +4203,7 @@ describe('BrsFile', () => {
                 end class
             `, (0, testHelpers_spec_1.trim) `
                 class Human
+                    public name as dynamic
                     sub new(name as string)
                     end sub
                 end class
@@ -4186,6 +4276,7 @@ describe('BrsFile', () => {
             testTypedef(`
                 namespace NameA
                     class Human
+                        name
                         sub new(name as string)
                             m.name = name
                         end sub
@@ -4201,6 +4292,7 @@ describe('BrsFile', () => {
             `, (0, testHelpers_spec_1.trim) `
                 namespace NameA
                     class Human
+                        public name as dynamic
                         sub new(name as string)
                         end sub
                     end class
@@ -4420,7 +4512,7 @@ describe('BrsFile', () => {
             end function
         `);
         program.validate();
-        (0, testHelpers_spec_1.expectDiagnostics)(program, [Object.assign(Object.assign({}, DiagnosticMessages_1.DiagnosticMessages.mismatchedEndCallableKeyword('function', 'sub')), { location: util_1.default.createLocationFromFileRange(file, util_1.default.createRange(2, 12, 2, 19)) }), Object.assign(Object.assign({}, DiagnosticMessages_1.DiagnosticMessages.mismatchedEndCallableKeyword('sub', 'function')), { location: util_1.default.createLocationFromFileRange(file, util_1.default.createRange(4, 12, 4, 24)) })]);
+        (0, testHelpers_spec_1.expectDiagnostics)(program, [Object.assign(Object.assign({}, DiagnosticMessages_1.DiagnosticMessages.closingKeywordMismatch('function', 'sub')), { location: util_1.default.createLocationFromFileRange(file, util_1.default.createRange(2, 12, 2, 19)) }), Object.assign(Object.assign({}, DiagnosticMessages_1.DiagnosticMessages.closingKeywordMismatch('sub', 'function')), { location: util_1.default.createLocationFromFileRange(file, util_1.default.createRange(4, 12, 4, 24)) })]);
     });
     describe('requiredSymbols', () => {
         it('should be empty for a simple file', () => {
@@ -4616,14 +4708,21 @@ describe('BrsFile', () => {
                 end class
             `);
             validateFile(mainFile);
-            (0, chai_config_spec_1.expect)(mainFile.requiredSymbols.length).to.eq(5);
+            // 'DataKind' is there twice:
+            // - when used as a type
+            // - when DataObject.kind is used
+            (0, chai_config_spec_1.expect)(mainFile.requiredSymbols.length).to.eq(6);
             const requiredTypeChains = mainFile.requiredSymbols.map(x => x.typeChain.map(tc => tc.name).join('.'));
-            (0, chai_config_spec_1.expect)(requiredTypeChains).to.have.same.members([
-                'DataKind', 'SubData', 'BaseData', 'DataProcessor', 'ProcessedData'
+            (0, chai_config_spec_1.expect)(Array.from(requiredTypeChains)).to.have.same.members([
+                'DataKind', 'DataKind', 'SubData', 'BaseData', 'DataProcessor', 'ProcessedData'
             ]);
             const requiredSymbolsFlags = mainFile.requiredSymbols.map(x => x.flags);
             (0, chai_config_spec_1.expect)(requiredSymbolsFlags).to.have.same.members([
-                2 /* SymbolTypeFlag.typetime */, 2 /* SymbolTypeFlag.typetime */, 2 /* SymbolTypeFlag.typetime */, 2 /* SymbolTypeFlag.typetime */, 2 /* SymbolTypeFlag.typetime */
+                2 /* SymbolTypeFlag.typetime */, 2 /* SymbolTypeFlag.typetime */, 2 /* SymbolTypeFlag.typetime */, 2 /* SymbolTypeFlag.typetime */, 2 /* SymbolTypeFlag.typetime */, 2 /* SymbolTypeFlag.typetime */
+            ]);
+            const requiredSymbolsEndFlags = mainFile.requiredSymbols.map(x => x.endChainFlags);
+            (0, chai_config_spec_1.expect)(requiredSymbolsEndFlags).to.have.same.members([
+                2 /* SymbolTypeFlag.typetime */, 1 /* SymbolTypeFlag.runtime */, 2 /* SymbolTypeFlag.typetime */, 2 /* SymbolTypeFlag.typetime */, 2 /* SymbolTypeFlag.typetime */, 2 /* SymbolTypeFlag.typetime */
             ]);
         });
         it('includes namespace details', () => {