brighterscript 1.0.0-alpha.28 → 1.0.0-alpha.29

package/dist/files/BrsFile.spec.js

@@ -24,6 +24,7 @@ const undent_1 = require("undent");
 const testHelpers_spec_2 = require("../testHelpers.spec");
 const types_1 = require("../types");
 const fileUrl = require("file-url");
+const reflection_1 = require("../astUtils/reflection");
 let sinon = sinonImport.createSandbox();
 describe('BrsFile', () => {
     let program;
@@ -32,6 +33,14 @@ describe('BrsFile', () => {
     let file;
     let testTranspile = (0, testHelpers_spec_1.getTestTranspile)(() => [program, testHelpers_spec_2.rootDir]);
     let testGetTypedef = (0, testHelpers_spec_1.getTestGetTypedef)(() => [program, testHelpers_spec_2.rootDir]);
+    function validateFile(...files) {
+        for (const file of files) {
+            program.plugins.emit('onFileValidate', { program: program, file: file });
+        }
+        for (const file of files) {
+            program.plugins.emit('afterFileValidate', { program: program, file: file });
+        }
+    }
     beforeEach(() => {
         fsExtra.emptyDirSync(testHelpers_spec_2.tempDir);
         program = new Program_1.Program({ rootDir: testHelpers_spec_2.rootDir, sourceMap: true });
@@ -1512,6 +1521,21 @@ describe('BrsFile', () => {
         //this test will throw an exception if something went wrong
     });
     describe('transpile', () => {
+        it('does not crash when AA is missing closing curly token', async () => {
+            const file = program.setFile('source/main.bs', `
+                sub main()
+                    aa = {}
+                end sub
+            `);
+            //delete the ending token `}`
+            const aa = file.ast.findChild(reflection_1.isAALiteralExpression);
+            delete aa.tokens.close;
+            await testTranspile(file, `
+                sub main()
+                    aa = {}
+                end sub
+            `, undefined, undefined, false);
+        });
         describe('null tokens', () => {
             it('succeeds when token locations are omitted', () => {
                 doTest(`
@@ -3384,11 +3408,7 @@ describe('BrsFile', () => {
                     return arg.getTwo()
                 end function
             `);
-            const validateFileEvent = {
-                program: program,
-                file: mainFile
-            };
-            program.plugins.emit('onFileValidate', validateFileEvent);
+            validateFile(mainFile);
             (0, chai_config_spec_1.expect)(mainFile.requiredSymbols.length).to.eq(2);
             (0, chai_config_spec_1.expect)(mainFile.requiredSymbols.map(x => x.typeChain[0].name)).to.have.same.members([
                 'TwoType', 'OneType'
@@ -3426,11 +3446,7 @@ describe('BrsFile', () => {
                     end function
                 end class
             `);
-            const validateFileEvent = {
-                program: program,
-                file: mainFile
-            };
-            program.plugins.emit('onFileValidate', validateFileEvent);
+            validateFile(mainFile);
             (0, chai_config_spec_1.expect)(mainFile.requiredSymbols.length).to.eq(2);
             (0, chai_config_spec_1.expect)(mainFile.requiredSymbols.map(x => x.typeChain[0].name)).to.have.same.members([
                 'TwoType', 'OneType'
@@ -3443,11 +3459,7 @@ describe('BrsFile', () => {
                     print x+1
                 end sub
             `);
-            const validateFileEvent = {
-                program: program,
-                file: mainFile
-            };
-            program.plugins.emit('onFileValidate', validateFileEvent);
+            validateFile(mainFile);
             (0, chai_config_spec_1.expect)(mainFile.requiredSymbols.length).to.eq(1);
             // x and arg are assigned.. they are not included in the required symbols
             (0, chai_config_spec_1.expect)(mainFile.requiredSymbols[0].typeChain[0].name).to.equal('SomeOtherType');
@@ -3466,11 +3478,7 @@ describe('BrsFile', () => {
                     return y-otherFileFunc4()
                 end function
             `);
-            const validateFileEvent = {
-                program: program,
-                file: mainFile
-            };
-            program.plugins.emit('onFileValidate', validateFileEvent);
+            validateFile(mainFile);
             (0, chai_config_spec_1.expect)(mainFile.requiredSymbols.length).to.eq(4);
             (0, chai_config_spec_1.expect)(mainFile.requiredSymbols.map(x => x.typeChain[0].name)).to.have.same.members([
                 'otherFileFunc1', 'otherFileFunc2', 'otherFileFunc3', 'otherFileFunc4'
@@ -3483,11 +3491,7 @@ describe('BrsFile', () => {
                     return other.getThing(x)
                 end function
             `);
-            const validateFileEvent = {
-                program: program,
-                file: mainFile
-            };
-            program.plugins.emit('onFileValidate', validateFileEvent);
+            validateFile(mainFile);
             (0, chai_config_spec_1.expect)(mainFile.requiredSymbols.length).to.eq(3);
             const requiredTypeChains = mainFile.requiredSymbols.map(x => x.typeChain.map(tc => tc.name).join('.'));
             (0, chai_config_spec_1.expect)(requiredTypeChains).to.have.same.members([
@@ -3510,11 +3514,7 @@ describe('BrsFile', () => {
                     end if
                 end sub
             `);
-            const validateFileEvent = {
-                program: program,
-                file: mainFile
-            };
-            program.plugins.emit('onFileValidate', validateFileEvent);
+            validateFile(mainFile);
             (0, chai_config_spec_1.expect)(mainFile.requiredSymbols.length).to.eq(4);
             const requiredTypeChains = mainFile.requiredSymbols.map(x => x.typeChain.map(tc => tc.name).join('.'));
             (0, chai_config_spec_1.expect)(requiredTypeChains).to.have.same.members([
@@ -3540,11 +3540,7 @@ describe('BrsFile', () => {
                     end function
                 end class
             `);
-            const validateFileEvent = {
-                program: program,
-                file: mainFile
-            };
-            program.plugins.emit('onFileValidate', validateFileEvent);
+            validateFile(mainFile);
             (0, chai_config_spec_1.expect)(mainFile.requiredSymbols.length).to.eq(5);
             const requiredTypeChains = mainFile.requiredSymbols.map(x => x.typeChain.map(tc => tc.name).join('.'));
             (0, chai_config_spec_1.expect)(requiredTypeChains).to.have.same.members([
@@ -3573,11 +3569,7 @@ describe('BrsFile', () => {
                     end namespace
                 end namespace
             `);
-            const validateFileEvent = {
-                program: program,
-                file: mainFile
-            };
-            program.plugins.emit('onFileValidate', validateFileEvent);
+            validateFile(mainFile);
             (0, chai_config_spec_1.expect)(mainFile.requiredSymbols.length).to.eq(2);
             const requiredTypeChains = mainFile.requiredSymbols.map(x => x.typeChain.map(tc => tc.name).join('.'));
             (0, chai_config_spec_1.expect)(requiredTypeChains).to.have.same.members([
@@ -3598,7 +3590,7 @@ describe('BrsFile', () => {
                     end namespace
                 end namespace
             `);
-            program.plugins.emit('onFileValidate', { program: program, file: mainFile });
+            validateFile(mainFile);
             (0, chai_config_spec_1.expect)(mainFile.requiredSymbols.length).to.eq(0);
         });
         it('should put types from typecasts as typetime required', () => {
@@ -3607,10 +3599,104 @@ describe('BrsFile', () => {
                     return (z as MyInterface).name
                 end function
             `);
-            program.plugins.emit('onFileValidate', { program: program, file: mainFile });
+            validateFile(mainFile);
             (0, chai_config_spec_1.expect)(mainFile.requiredSymbols.length).to.eq(1);
             (0, chai_config_spec_1.expect)(mainFile.requiredSymbols[0].flags).to.eq(2 /* SymbolTypeFlag.typetime */);
         });
+        it('should not include symbols in same namespace', () => {
+            const mainFile = program.setFile('source/main.bs', `
+                namespace alpha
+                    const PI = 3.14
+                    function area(r as float) as float
+                        return alpha.PI * r * r
+                    end function
+                end namespace
+            `);
+            validateFile(mainFile);
+            (0, chai_config_spec_1.expect)(mainFile.requiredSymbols.length).to.eq(0);
+        });
+        it('should not include symbols in same namespace, but different statements', () => {
+            const mainFile = program.setFile('source/main.bs', `
+                namespace alpha
+                    function area(r as float) as float
+                        return alpha.PI * r * r
+                    end function
+                end namespace
+
+                namespace alpha
+                    const PI = 3.14
+                end namespace
+            `);
+            validateFile(mainFile);
+            (0, chai_config_spec_1.expect)(mainFile.requiredSymbols.length).to.eq(0);
+        });
+        it('should not include symbols in imported file', () => {
+            const otherFile = program.setFile('source/other.bs', `
+                namespace alpha
+                    const PI = 3.14
+                end namespace
+            `);
+            const mainFile = program.setFile('source/main.bs', `
+                import "pkg:/source/other.bs"
+                namespace alpha
+                    function area(r as float) as float
+                        return alpha.PI * r * r
+                    end function
+                end namespace
+            `);
+            validateFile(otherFile, mainFile);
+            (0, chai_config_spec_1.expect)(mainFile.requiredSymbols.length).to.eq(0);
+        });
+        it('should not include symbols in imported file of imported file', () => {
+            const deepFile = program.setFile('source/deep.bs', `
+                namespace alpha
+                    const SOME_VALUE = 2
+                end namespace
+            `);
+            const otherFile = program.setFile('source/other.bs', `
+                import "pkg:/source/deep.bs"
+                namespace alpha
+                    const PI = 3.14
+                end namespace
+            `);
+            const mainFile = program.setFile('source/main.bs', `
+                import "pkg:/source/other.bs"
+                namespace alpha
+                    function area(r as float) as float
+                        return alpha.PI * r * r * alpha.SOME_VALUE
+                    end function
+                end namespace
+            `);
+            validateFile(otherFile, mainFile, deepFile);
+            (0, chai_config_spec_1.expect)(mainFile.requiredSymbols.length).to.eq(0);
+        });
+        it('should not have problems with circular references of imports', () => {
+            const deepFile = program.setFile('source/deep.bs', `
+                import "pkg:/source/main.bs"
+                namespace alpha
+                    function getMyValue()
+                        return alpha.MY_VALUE
+                    end function
+                end namespace
+            `);
+            const otherFile = program.setFile('source/other.bs', `
+                import "pkg:/source/deep.bs"
+                namespace alpha
+                    const PI = 3.14
+                end namespace
+            `);
+            const mainFile = program.setFile('source/main.bs', `
+                import "pkg:/source/other.bs"
+                namespace alpha
+                    function area(r as float) as float
+                        return alpha.PI * r * r * alpha.getMyValue()
+                    end function
+                    const MY_VALUE = 2
+                end namespace
+            `);
+            validateFile(otherFile, mainFile, deepFile);
+            (0, chai_config_spec_1.expect)(mainFile.requiredSymbols.length).to.eq(0);
+        });
     });
     describe('providedSymbols', () => {
         it('includes functions defined in the file', () => {
@@ -3623,11 +3709,7 @@ describe('BrsFile', () => {
                     return 2.3
                 end function
             `);
-            const validateFileEvent = {
-                program: program,
-                file: mainFile
-            };
-            program.plugins.emit('onFileValidate', validateFileEvent);
+            validateFile(mainFile);
             const runtimeSymbols = mainFile.providedSymbols.symbolMap.get(1 /* SymbolTypeFlag.runtime */);
             (0, chai_config_spec_1.expect)(runtimeSymbols.size).to.eq(2);
             const someFuncType = runtimeSymbols.get('somefunc').type;
@@ -3641,11 +3723,7 @@ describe('BrsFile', () => {
                     return new OtherFileType()
                 end function
             `);
-            const validateFileEvent = {
-                program: program,
-                file: mainFile
-            };
-            program.plugins.emit('onFileValidate', validateFileEvent);
+            validateFile(mainFile);
             const runtimeSymbols = mainFile.providedSymbols.symbolMap.get(1 /* SymbolTypeFlag.runtime */);
             (0, chai_config_spec_1.expect)(runtimeSymbols.size).to.eq(1);
             const someFuncType = runtimeSymbols.get('somefunc').type;
@@ -3673,11 +3751,7 @@ describe('BrsFile', () => {
                     propClass = new Klass2()
                 end class
             `);
-            const validateFileEvent = {
-                program: program,
-                file: mainFile
-            };
-            program.plugins.emit('onFileValidate', validateFileEvent);
+            validateFile(mainFile);
             const runtimeSymbols = mainFile.providedSymbols.symbolMap.get(1 /* SymbolTypeFlag.runtime */);
             (0, chai_config_spec_1.expect)(runtimeSymbols.size).to.eq(3);
             (0, testHelpers_spec_1.expectTypeToBe)(runtimeSymbols.get('klass').type, types_1.ClassType);
@@ -3704,11 +3778,7 @@ describe('BrsFile', () => {
                     const MyConst = 3.14
                 end namespace
             `);
-            const validateFileEvent = {
-                program: program,
-                file: mainFile
-            };
-            program.plugins.emit('onFileValidate', validateFileEvent);
+            validateFile(mainFile);
             const runtimeSymbols = mainFile.providedSymbols.symbolMap.get(1 /* SymbolTypeFlag.runtime */);
             (0, chai_config_spec_1.expect)(runtimeSymbols.size).to.eq(2);
             (0, testHelpers_spec_1.expectTypeToBe)(runtimeSymbols.get('myenum').type, types_1.EnumType);
@@ -3725,7 +3795,7 @@ describe('BrsFile', () => {
                         print 1
                     end sub
                 `);
-                program.plugins.emit('onFileValidate', { program: program, file: mainFile });
+                validateFile(mainFile);
                 let runtimeSymbols = mainFile.providedSymbols.symbolMap.get(1 /* SymbolTypeFlag.runtime */);
                 (0, chai_config_spec_1.expect)(runtimeSymbols.size).to.eq(1);
                 mainFile = program.setFile('source/main.bs', `
@@ -3737,7 +3807,7 @@ describe('BrsFile', () => {
                         print 2
                     end sub
                 `);
-                program.plugins.emit('onFileValidate', { program: program, file: mainFile });
+                validateFile(mainFile);
                 runtimeSymbols = mainFile.providedSymbols.symbolMap.get(1 /* SymbolTypeFlag.runtime */);
                 (0, chai_config_spec_1.expect)(runtimeSymbols.size).to.eq(2);
                 let runtimeChanges = mainFile.providedSymbols.changes.get(1 /* SymbolTypeFlag.runtime */);
@@ -3754,7 +3824,7 @@ describe('BrsFile', () => {
                         print 2
                     end sub
                 `);
-                program.plugins.emit('onFileValidate', { program: program, file: mainFile });
+                validateFile(mainFile);
                 let runtimeSymbols = mainFile.providedSymbols.symbolMap.get(1 /* SymbolTypeFlag.runtime */);
                 (0, chai_config_spec_1.expect)(runtimeSymbols.size).to.eq(2);
                 mainFile = program.setFile('source/main.bs', `
@@ -3762,7 +3832,7 @@ describe('BrsFile', () => {
                         print 1
                     end sub
                 `);
-                program.plugins.emit('onFileValidate', { program: program, file: mainFile });
+                validateFile(mainFile);
                 runtimeSymbols = mainFile.providedSymbols.symbolMap.get(1 /* SymbolTypeFlag.runtime */);
                 (0, chai_config_spec_1.expect)(runtimeSymbols.size).to.eq(1);
                 let runtimeChanges = mainFile.providedSymbols.changes.get(1 /* SymbolTypeFlag.runtime */);
@@ -3774,7 +3844,7 @@ describe('BrsFile', () => {
                     namespace Alpha
                     end namespace
                 `);
-                program.plugins.emit('onFileValidate', { program: program, file: mainFile });
+                validateFile(mainFile);
                 let runtimeSymbols = mainFile.providedSymbols.symbolMap.get(1 /* SymbolTypeFlag.runtime */);
                 (0, chai_config_spec_1.expect)(runtimeSymbols.size).to.eq(0);
                 mainFile = program.setFile('source/main.bs', `
@@ -3782,7 +3852,7 @@ describe('BrsFile', () => {
                         const ABC = "abc"
                     end namespace
                 `);
-                program.plugins.emit('onFileValidate', { program: program, file: mainFile });
+                validateFile(mainFile);
                 runtimeSymbols = mainFile.providedSymbols.symbolMap.get(1 /* SymbolTypeFlag.runtime */);
                 (0, chai_config_spec_1.expect)(runtimeSymbols.size).to.eq(1);
                 let runtimeChanges = mainFile.providedSymbols.changes.get(1 /* SymbolTypeFlag.runtime */);
@@ -3799,7 +3869,7 @@ describe('BrsFile', () => {
                         const PI = 3.14
                     end namespace
                 `);
-                program.plugins.emit('onFileValidate', { program: program, file: mainFile });
+                validateFile(mainFile);
                 let runtimeSymbols = mainFile.providedSymbols.symbolMap.get(1 /* SymbolTypeFlag.runtime */);
                 (0, chai_config_spec_1.expect)(runtimeSymbols.size).to.eq(2);
                 mainFile = program.setFile('source/main.bs', `
@@ -3811,7 +3881,7 @@ describe('BrsFile', () => {
                         const PI = 3.14159
                     end namespace
                 `);
-                program.plugins.emit('onFileValidate', { program: program, file: mainFile });
+                validateFile(mainFile);
                 runtimeSymbols = mainFile.providedSymbols.symbolMap.get(1 /* SymbolTypeFlag.runtime */);
                 (0, chai_config_spec_1.expect)(runtimeSymbols.size).to.eq(2);
                 let runtimeChanges = mainFile.providedSymbols.changes.get(1 /* SymbolTypeFlag.runtime */);
@@ -3823,7 +3893,7 @@ describe('BrsFile', () => {
                         return x
                     end function
                 `);
-                program.plugins.emit('onFileValidate', { program: program, file: mainFile });
+                validateFile(mainFile);
                 let runtimeSymbols = mainFile.providedSymbols.symbolMap.get(1 /* SymbolTypeFlag.runtime */);
                 (0, chai_config_spec_1.expect)(runtimeSymbols.size).to.eq(1);
                 mainFile = program.setFile('source/main.bs', `
@@ -3831,7 +3901,7 @@ describe('BrsFile', () => {
                         return x+y
                     end function
                 `);
-                program.plugins.emit('onFileValidate', { program: program, file: mainFile });
+                validateFile(mainFile);
                 runtimeSymbols = mainFile.providedSymbols.symbolMap.get(1 /* SymbolTypeFlag.runtime */);
                 (0, chai_config_spec_1.expect)(runtimeSymbols.size).to.eq(1);
                 let runtimeChanges = mainFile.providedSymbols.changes.get(1 /* SymbolTypeFlag.runtime */);
@@ -3847,7 +3917,7 @@ describe('BrsFile', () => {
                         end function
                     end class
                 `);
-                program.plugins.emit('onFileValidate', { program: program, file: mainFile });
+                validateFile(mainFile);
                 let runtimeSymbols = mainFile.providedSymbols.symbolMap.get(1 /* SymbolTypeFlag.runtime */);
                 (0, chai_config_spec_1.expect)(runtimeSymbols.size).to.eq(1);
                 mainFile = program.setFile('source/main.bs', `
@@ -3858,7 +3928,7 @@ describe('BrsFile', () => {
                         end function
                     end class
                 `);
-                program.plugins.emit('onFileValidate', { program: program, file: mainFile });
+                validateFile(mainFile);
                 runtimeSymbols = mainFile.providedSymbols.symbolMap.get(1 /* SymbolTypeFlag.runtime */);
                 (0, chai_config_spec_1.expect)(runtimeSymbols.size).to.eq(1);
                 let runtimeChanges = mainFile.providedSymbols.changes.get(1 /* SymbolTypeFlag.runtime */);
@@ -3875,7 +3945,7 @@ describe('BrsFile', () => {
                         function doStuff() as float
                     end interface
                 `);
-                program.plugins.emit('onFileValidate', { program: program, file: mainFile });
+                validateFile(mainFile);
                 let typetimeSymbols = mainFile.providedSymbols.symbolMap.get(2 /* SymbolTypeFlag.typetime */);
                 (0, chai_config_spec_1.expect)(typetimeSymbols.size).to.eq(1);
                 let runtimeSymbols = mainFile.providedSymbols.symbolMap.get(1 /* SymbolTypeFlag.runtime */);
@@ -3887,7 +3957,7 @@ describe('BrsFile', () => {
                         function doStuff() as float
                     end interface
                 `);
-                program.plugins.emit('onFileValidate', { program: program, file: mainFile });
+                validateFile(mainFile);
                 typetimeSymbols = mainFile.providedSymbols.symbolMap.get(2 /* SymbolTypeFlag.typetime */);
                 (0, chai_config_spec_1.expect)(typetimeSymbols.size).to.eq(1);
                 let typeTimeChanges = mainFile.providedSymbols.changes.get(2 /* SymbolTypeFlag.typetime */);
@@ -3905,7 +3975,7 @@ describe('BrsFile', () => {
                         west = 1
                     end enum
                 `);
-                program.plugins.emit('onFileValidate', { program: program, file: mainFile });
+                validateFile(mainFile);
                 let runtimeSymbols = mainFile.providedSymbols.symbolMap.get(1 /* SymbolTypeFlag.runtime */);
                 (0, chai_config_spec_1.expect)(runtimeSymbols.size).to.eq(1);
                 mainFile = program.setFile('source/main.bs', `
@@ -3916,7 +3986,7 @@ describe('BrsFile', () => {
                         west = 4
                     end enum
                 `);
-                program.plugins.emit('onFileValidate', { program: program, file: mainFile });
+                validateFile(mainFile);
                 runtimeSymbols = mainFile.providedSymbols.symbolMap.get(1 /* SymbolTypeFlag.runtime */);
                 (0, chai_config_spec_1.expect)(runtimeSymbols.size).to.eq(1);
                 let runtimeChanges = mainFile.providedSymbols.changes.get(1 /* SymbolTypeFlag.runtime */);
@@ -3947,7 +4017,7 @@ describe('BrsFile', () => {
                         purple
                     end enum
                 `);
-                program.plugins.emit('onFileValidate', { program: program, file: mainFile });
+                validateFile(mainFile);
                 let runtimeSymbols = mainFile.providedSymbols.symbolMap.get(1 /* SymbolTypeFlag.runtime */);
                 (0, chai_config_spec_1.expect)(runtimeSymbols.size).to.eq(3);
                 mainFile = program.setFile('source/main.bs', `
@@ -3970,7 +4040,7 @@ describe('BrsFile', () => {
                         green
                     end enum
                 `);
-                program.plugins.emit('onFileValidate', { program: program, file: mainFile });
+                validateFile(mainFile);
                 runtimeSymbols = mainFile.providedSymbols.symbolMap.get(1 /* SymbolTypeFlag.runtime */);
                 (0, chai_config_spec_1.expect)(runtimeSymbols.size).to.eq(3);
                 let runtimeChanges = mainFile.providedSymbols.changes.get(1 /* SymbolTypeFlag.runtime */);
@@ -3987,7 +4057,7 @@ describe('BrsFile', () => {
                         west = 4
                     end enum
                 `);
-                program.plugins.emit('onFileValidate', { program: program, file: mainFile });
+                validateFile(mainFile);
                 let runtimeSymbols = mainFile.providedSymbols.symbolMap.get(1 /* SymbolTypeFlag.runtime */);
                 (0, chai_config_spec_1.expect)(runtimeSymbols.size).to.eq(1);
                 mainFile = program.setFile('source/main.bs', `
@@ -4011,7 +4081,7 @@ describe('BrsFile', () => {
                         const PI = 3.14
                     end namespace
                 `);
-                program.plugins.emit('onFileValidate', { program: program, file: mainFile });
+                validateFile(mainFile);
                 let runtimeSymbols = mainFile.providedSymbols.symbolMap.get(1 /* SymbolTypeFlag.runtime */);
                 (0, chai_config_spec_1.expect)(runtimeSymbols.size).to.eq(1);
                 mainFile = program.setFile('source/main.bs', `
@@ -4019,7 +4089,7 @@ describe('BrsFile', () => {
                         const PI = "lemon chiffon"
                     end namespace
                 `);
-                program.plugins.emit('onFileValidate', { program: program, file: mainFile });
+                validateFile(mainFile);
                 runtimeSymbols = mainFile.providedSymbols.symbolMap.get(1 /* SymbolTypeFlag.runtime */);
                 (0, chai_config_spec_1.expect)(runtimeSymbols.size).to.eq(1);
                 let runtimeChanges = mainFile.providedSymbols.changes.get(1 /* SymbolTypeFlag.runtime */);
@@ -4039,7 +4109,7 @@ describe('BrsFile', () => {
                         print myLabel.getChildren(0, -1)
                     end sub
                 `);
-                program.plugins.emit('onFileValidate', { program: program, file: mainFile });
+                validateFile(mainFile);
                 let runtimeSymbols = mainFile.providedSymbols.symbolMap.get(1 /* SymbolTypeFlag.runtime */);
                 (0, chai_config_spec_1.expect)(runtimeSymbols.size).to.eq(2);
                 mainFile = program.setFile('source/main.bs', `
@@ -4054,7 +4124,7 @@ describe('BrsFile', () => {
                         print myLabel.getChildren(0, -1)
                     end sub
                 `);
-                program.plugins.emit('onFileValidate', { program: program, file: mainFile });
+                validateFile(mainFile);
                 runtimeSymbols = mainFile.providedSymbols.symbolMap.get(1 /* SymbolTypeFlag.runtime */);
                 (0, chai_config_spec_1.expect)(runtimeSymbols.size).to.eq(2);
                 let runtimeChanges = mainFile.providedSymbols.changes.get(1 /* SymbolTypeFlag.runtime */);
@@ -4069,10 +4139,10 @@ describe('BrsFile', () => {
                     end class
                 `;
                 let mainFile = program.setFile('source/class.bs', classFileContent);
-                program.plugins.emit('onFileValidate', { program: program, file: mainFile });
+                validateFile(mainFile);
                 // No changes!
                 mainFile = program.setFile('source/class.bs', classFileContent);
-                program.plugins.emit('onFileValidate', { program: program, file: mainFile });
+                validateFile(mainFile);
                 let runtimeChanges = mainFile.providedSymbols.changes.get(1 /* SymbolTypeFlag.runtime */);
                 (0, chai_config_spec_1.expect)(runtimeChanges.size).to.eq(0);
             });
@@ -4095,10 +4165,10 @@ describe('BrsFile', () => {
                     end namespace
                 `;
                 let mainFile = program.setFile('source/class.bs', fileContent);
-                program.plugins.emit('onFileValidate', { program: program, file: mainFile });
+                validateFile(mainFile);
                 // No changes!
                 mainFile = program.setFile('source/class.bs', fileContent);
-                program.plugins.emit('onFileValidate', { program: program, file: mainFile });
+                validateFile(mainFile);
                 let runtimeChanges = mainFile.providedSymbols.changes.get(1 /* SymbolTypeFlag.runtime */);
                 (0, chai_config_spec_1.expect)(runtimeChanges.size).to.eq(0);
             });
@@ -4119,10 +4189,29 @@ describe('BrsFile', () => {
                     end namespace
                 `;
                 let mainFile = program.setFile('source/class.bs', fileContent);
-                program.plugins.emit('onFileValidate', { program: program, file: mainFile });
+                validateFile(mainFile);
                 // No changes!
                 mainFile = program.setFile('source/class.bs', fileContent);
-                program.plugins.emit('onFileValidate', { program: program, file: mainFile });
+                validateFile(mainFile);
+                let runtimeChanges = mainFile.providedSymbols.changes.get(1 /* SymbolTypeFlag.runtime */);
+                (0, chai_config_spec_1.expect)(runtimeChanges.size).to.eq(0);
+            });
+            it('should not include namespaces in changes if no symbols in namespace changed', () => {
+                const fileContent = `
+                    namespace Alpha.Beta
+                        const PI = 3.14
+                    end namespace
+                `;
+                const fileContentWithComment = `
+                    namespace Alpha.Beta
+                        const PI = 3.14 ' comment
+                    end namespace
+                `;
+                let mainFile = program.setFile('source/namespace.bs', fileContent);
+                validateFile(mainFile);
+                // Just added a comment!
+                mainFile = program.setFile('source/namespace.bs', fileContentWithComment);
+                validateFile(mainFile);
                 let runtimeChanges = mainFile.providedSymbols.changes.get(1 /* SymbolTypeFlag.runtime */);
                 (0, chai_config_spec_1.expect)(runtimeChanges.size).to.eq(0);
             });
@@ -4221,6 +4310,42 @@ describe('BrsFile', () => {
                 end sub
             `);
         });
+        //fails at the specific length of statement including leading tabs and spaces
+        it('allows long statements', () => {
+            program.setFile('source/main.bs', `function request()\r\nhzzzzandleInterceptedScreenDataaaaaaaaaaainterceptedScreenData() 'bs:disable-line \r\nend function`);
+            program.validate();
+            (0, testHelpers_spec_1.expectZeroDiagnostics)(program);
+            program.setFile('source/main.bs', `function request()\r\n\t\t\t\t\t\t\t\t\t\t\t\t\t\t\t\t\t\t\t\t\t\t\t\t\t\t\t\t\t\t\t\t\t\t\t\t\t\t\t\t\t\t\t\t\t\thandleInterceptedScreenDataaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa(m._aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaainterceptedScreenData) 'bs:disable-line \r\nend function`);
+            program.validate();
+            (0, testHelpers_spec_1.expectZeroDiagnostics)(program);
+            program.setFile('source/main.bs', `function request()\r\n\t\t\t\thandleInterceptedScreenData(m._aaaaaaainterceptedScreenData) 'bs:disable-line 1001\r\nend function`);
+            program.validate();
+            (0, testHelpers_spec_1.expectZeroDiagnostics)(program);
+        });
+    });
+    it('allows up to 63 function params', () => {
+        program.setFile('source/main.bs', `
+            function test(p1 = 1, p2 = 2, p3 = 3, p4 = 4, p5 = 5, p6 = 6, p7 = 7, p8 = 8, p9 = 9, p10 = 10, p11 = 11, p12 = 12, p13 = 13, p14 = 14, p15 = 15, p16 = 16, p17 = 17, p18 = 18, p19 = 19, p20 = 20, p21 = 21, p22 = 22, p23 = 23, p24 = 24, p25 = 25, p26 = 26, p27 = 27, p28 = 28, p29 = 29, p30 = 30, p31 = 31, p32 = 32, p33 = 33, p34 = 34, p35 = 35, p36 = 36, p37 = 37, p38 = 38, p39 = 39, p40 = 40, p41 = 41, p42 = 42, p43 = 43, p44 = 44, p45 = 45, p46 = 46, p47 = 47, p48 = 48, p49 = 49, p50 = 50, p51 = 51, p52 = 52, p53 = 53, p54 = 54, p55 = 55, p56 = 56, p57 = 57, p58 = 58, p59 = 59, p60 = 60, p61 = 61, p62 = 62, p63 = 63)
+            end function
+        `);
+        program.validate();
+        (0, testHelpers_spec_1.expectZeroDiagnostics)(program);
+    });
+    it('flags functions having 64 parameters', () => {
+        program.setFile('source/main.bs', `
+            function test(p1 = 1, p2 = 2, p3 = 3, p4 = 4, p5 = 5, p6 = 6, p7 = 7, p8 = 8, p9 = 9, p10 = 10, p11 = 11, p12 = 12, p13 = 13, p14 = 14, p15 = 15, p16 = 16, p17 = 17, p18 = 18, p19 = 19, p20 = 20, p21 = 21, p22 = 22, p23 = 23, p24 = 24, p25 = 25, p26 = 26, p27 = 27, p28 = 28, p29 = 29, p30 = 30, p31 = 31, p32 = 32, p33 = 33, p34 = 34, p35 = 35, p36 = 36, p37 = 37, p38 = 38, p39 = 39, p40 = 40, p41 = 41, p42 = 42, p43 = 43, p44 = 44, p45 = 45, p46 = 46, p47 = 47, p48 = 48, p49 = 49, p50 = 50, p51 = 51, p52 = 52, p53 = 53, p54 = 54, p55 = 55, p56 = 56, p57 = 57, p58 = 58, p59 = 59, p60 = 60, p61 = 61, p62 = 62, p63 = 63, p64 = 64)
+            end function
+        `);
+        program.validate();
+        (0, testHelpers_spec_1.expectDiagnostics)(program, [Object.assign(Object.assign({}, DiagnosticMessages_1.DiagnosticMessages.tooManyCallableParameters(64, 63)), { range: util_1.default.createRange(1, 638, 1, 641) })]);
+    });
+    it('flags functions having 65 parameters', () => {
+        program.setFile('source/main.bs', `
+            function test(p1 = 1, p2 = 2, p3 = 3, p4 = 4, p5 = 5, p6 = 6, p7 = 7, p8 = 8, p9 = 9, p10 = 10, p11 = 11, p12 = 12, p13 = 13, p14 = 14, p15 = 15, p16 = 16, p17 = 17, p18 = 18, p19 = 19, p20 = 20, p21 = 21, p22 = 22, p23 = 23, p24 = 24, p25 = 25, p26 = 26, p27 = 27, p28 = 28, p29 = 29, p30 = 30, p31 = 31, p32 = 32, p33 = 33, p34 = 34, p35 = 35, p36 = 36, p37 = 37, p38 = 38, p39 = 39, p40 = 40, p41 = 41, p42 = 42, p43 = 43, p44 = 44, p45 = 45, p46 = 46, p47 = 47, p48 = 48, p49 = 49, p50 = 50, p51 = 51, p52 = 52, p53 = 53, p54 = 54, p55 = 55, p56 = 56, p57 = 57, p58 = 58, p59 = 59, p60 = 60, p61 = 61, p62 = 62, p63 = 63, p64 = 64, p65 = 65)
+            end function
+        `);
+        program.validate();
+        (0, testHelpers_spec_1.expectDiagnostics)(program, [Object.assign(Object.assign({}, DiagnosticMessages_1.DiagnosticMessages.tooManyCallableParameters(65, 63)), { range: util_1.default.createRange(1, 638, 1, 641) }), Object.assign(Object.assign({}, DiagnosticMessages_1.DiagnosticMessages.tooManyCallableParameters(65, 63)), { range: util_1.default.createRange(1, 648, 1, 651) })]);
     });
 });
 //# sourceMappingURL=BrsFile.spec.js.map