brighterscript 1.0.0-alpha.27 → 1.0.0-alpha.29

package/dist/files/BrsFile.spec.js

@@ -23,6 +23,8 @@ const vscode_uri_1 = require("vscode-uri");
 const undent_1 = require("undent");
 const testHelpers_spec_2 = require("../testHelpers.spec");
 const types_1 = require("../types");
+const fileUrl = require("file-url");
+const reflection_1 = require("../astUtils/reflection");
 let sinon = sinonImport.createSandbox();
 describe('BrsFile', () => {
     let program;
@@ -31,6 +33,14 @@ describe('BrsFile', () => {
     let file;
     let testTranspile = (0, testHelpers_spec_1.getTestTranspile)(() => [program, testHelpers_spec_2.rootDir]);
     let testGetTypedef = (0, testHelpers_spec_1.getTestGetTypedef)(() => [program, testHelpers_spec_2.rootDir]);
+    function validateFile(...files) {
+        for (const file of files) {
+            program.plugins.emit('onFileValidate', { program: program, file: file });
+        }
+        for (const file of files) {
+            program.plugins.emit('afterFileValidate', { program: program, file: file });
+        }
+    }
     beforeEach(() => {
         fsExtra.emptyDirSync(testHelpers_spec_2.tempDir);
         program = new Program_1.Program({ rootDir: testHelpers_spec_2.rootDir, sourceMap: true });
@@ -505,6 +515,27 @@ describe('BrsFile', () => {
             (0, testHelpers_spec_1.expectZeroDiagnostics)(file);
         });
         describe('conditional compile', () => {
+            it('supports whitespace-separated directives', async () => {
+                const file = program.setFile('source/main.bs', `
+                    sub main()
+                        #\t const thing=true
+                        #\t if thing
+                            print "if"
+                        #\t elseif false
+                            print "elseif"
+                            #\t error crash
+                        #\t else
+                            print "else"
+                        #\t endif
+                    end sub
+                `);
+                (0, testHelpers_spec_1.expectZeroDiagnostics)(program);
+                await testTranspile(file.fileContents, `
+                    sub main()
+                        print "if"
+                    end sub
+                `);
+            });
             it('supports case-insensitive bs_const variables', () => {
                 fsExtra.outputFileSync(`${testHelpers_spec_2.rootDir}/manifest`, (0, undent_1.default) `
                     bs_const=SomeKey=true
@@ -1490,6 +1521,245 @@ describe('BrsFile', () => {
         //this test will throw an exception if something went wrong
     });
     describe('transpile', () => {
+        it('does not crash when AA is missing closing curly token', async () => {
+            const file = program.setFile('source/main.bs', `
+                sub main()
+                    aa = {}
+                end sub
+            `);
+            //delete the ending token `}`
+            const aa = file.ast.findChild(reflection_1.isAALiteralExpression);
+            delete aa.tokens.close;
+            await testTranspile(file, `
+                sub main()
+                    aa = {}
+                end sub
+            `, undefined, undefined, false);
+        });
+        describe('null tokens', () => {
+            it('succeeds when token locations are omitted', () => {
+                doTest(`
+                    library "something" 'comment before func
+                    sub main(arg0, arg1 as string, arg2 = invalid)
+                        'comment
+                        aa = {
+                            'comment
+                            one: 1
+                            "two": 2
+                        }
+                        arr = [
+                            'comment
+                            1
+                            'comment
+                            2
+                        ]
+                        val = + m.val
+                        print "hello"
+                        'comment after print
+                        num = 1
+                        num++
+                        num += 2
+                        num = +num
+                        test(num)
+                        for i = 0 to 10 step 1
+                            exit for
+                        end for
+                        while true
+                            exit while
+                        end while
+                        if true then
+                            print 1
+                        else if true
+                            print 1
+                        else
+                            print 1
+                        end if
+                        dim thing[1, 2]
+                        label1:
+                        goto label1
+                        end
+                        stop
+                        stuff = [
+                            1
+                            2
+                            3
+                        ]
+                        for each item in stuff
+                            print item
+                        end for
+                        m.thing = 1
+                        m.thing += 1
+                        m[1] = 1
+                        m[1] += 1
+                        m[1, 2] = 2
+                        try
+                            print m.b.c
+                        catch e
+                            print e
+                        end try
+                        throw "crash"
+                        for i = 0 to 10
+                            continue
+                        end for
+                        print m@name
+                        print (1 + 2)
+                    end sub
+
+                    sub test(p1)
+                        return p1
+                    end sub
+                `);
+            });
+            it('works for bs content', () => {
+                program.setFile('source/lib.bs', ``);
+                doTest(`
+                    import "pkg:/source/lib.bs"
+                    @annotation()
+                    sub test()
+                        two = 2
+                        print \`1\${two}\${3}\n\`
+                        print (1 as integer)
+                        print SOURCE_LINE_NUM
+                        print FUNCTION_NAME
+                        print SOURCE_FUNCTION_NAME
+                        print PKG_LOCATION
+                        print PKG_PATH
+                        print LINE_NUM
+                        print new Person()
+                        m@.someCallfunc()
+                        m@.someCallfunc(1, 2)
+                        print tag\`stuff\${LINE_NUM}\${LINE_NUM}\`
+                        print 1 = 1 ? 1 : 2
+                        print 1 = 1 ? m.one : m.two
+                        print 1 ?? 2
+                        print m.one ?? m.two
+                        print /123/gi
+                    end sub
+                    function tag(param1, param2)
+                    end function
+                    const a = 1
+                    namespace alpha
+                        function beta()
+                            throw "An error has occurred"
+                        end function
+                        function charlie()
+                        end function
+                    end namespace
+                    sub test2()
+                        ' alpha.charlie()
+                    end sub
+
+                    enum Direction
+                        up = "up"
+                    end enum
+
+                    class Person
+                        name as string
+                        sub new()
+                            print m.name
+                        end sub
+
+                        sub test()
+                        end sub
+                    end class
+
+                    interface Beta
+                        name as string
+                    end interface
+                `, `
+                    'import "pkg:/source/lib.bs"
+
+                    sub test()
+                        two = 2
+                        print ("1" + bslib_toString(two) + bslib_toString(3) + chr(10))
+                        print 1
+                        print -1
+                        print "test"
+                        print "test"
+                        print "pkg:/source/main.brs:" + str(LINE_NUM)
+                        print "pkg:/source/main.brs"
+                        print LINE_NUM
+                        print Person()
+                        m.callfunc("someCallfunc")
+                        m.callfunc("someCallfunc", 1, 2)
+                        print tag(["stuff", "", ""], [LINE_NUM, LINE_NUM])
+                        print bslib_ternary(1 = 1, 1, 2)
+                        print (function(__bsCondition, m)
+                                if __bsCondition then
+                                    return m.one
+                                else
+                                    return m.two
+                                end if
+                            end function)(1 = 1, m)
+                        print bslib_coalesce(1, 2)
+                        print (function(m)
+                                __bsConsequent = m.one
+                                if __bsConsequent <> invalid then
+                                    return __bsConsequent
+                                else
+                                    return m.two
+                                end if
+                            end function)(m)
+                        print CreateObject("roRegex", "123", "gi")
+                    end sub
+
+                    function tag(param1, param2)
+                    end function
+
+                    function alpha_beta()
+                        throw "An error has occurred"
+                    end function
+
+                    function alpha_charlie()
+                    end function
+
+                    sub test2()
+                        ' alpha.charlie()
+                    end sub
+
+                    function __Person_builder()
+                        instance = {}
+                        instance.new = sub()
+                            m.name = invalid
+                            print m.name
+                        end sub
+                        instance.test = sub()
+                        end sub
+                        return instance
+                    end function
+                    function Person()
+                        instance = __Person_builder()
+                        instance.new()
+                        return instance
+                    end function
+                `);
+            });
+            it('handles source literals properly', () => {
+                const pathUrl = fileUrl(testHelpers_spec_2.rootDir);
+                let text = `"${pathUrl.substring(0, 4)}" + "${pathUrl.substring(4)}`;
+                doTest(`
+                    sub test()
+                        print SOURCE_FILE_PATH
+                        print SOURCE_LOCATION
+                    end sub
+                `, `
+                    sub test()
+                        print ${text}/source/main.bs"
+                        print ${text}/source/main.bs:-1"
+                    end sub
+                `);
+            });
+            function doTest(source, expected = source) {
+                const file = program.setFile('source/main.bs', '');
+                //override the parser with our locationless parser
+                file['_parser'] = Parser_1.Parser.parse(source, { mode: Parser_1.ParseMode.BrighterScript, trackLocations: false });
+                program.getScopesForFile(file).forEach(x => x['cache'].clear());
+                program.validate();
+                (0, testHelpers_spec_1.expectZeroDiagnostics)(program);
+                const result = file.transpile();
+                (0, chai_config_spec_1.expect)((0, testHelpers_spec_1.trimMap)((0, undent_1.default)(result.code))).to.eql((0, undent_1.default)(expected));
+            }
+        });
         it('transpilies libpkg:/ paths when encountered', async () => {
             program.setFile('source/lib.bs', `
                 import "libpkg:/source/numbers.bs"
@@ -1657,6 +1927,24 @@ describe('BrsFile', () => {
                     end sub
                 `);
             });
+            it('transpiles empty throw with "User-specified exception"', async () => {
+                await testTranspile(`
+                    sub main()
+                        try
+                            throw 'bs:disable-line
+                        catch e
+                        end try
+                    end sub
+                `, `
+                    sub main()
+                        try
+                            throw "User-specified exception"
+                        'bs:disable-line
+                        catch e
+                        end try
+                    end sub
+                `);
+            });
         });
         describe('try/catch', () => {
             it('transpiles properly', async () => {
@@ -1946,6 +2234,7 @@ describe('BrsFile', () => {
                 function DoSomething()
                     'lots of empty white space
                     'that will be removed during transpile
+                    'since there are newlines below this comment one newline will be preserved
 
 
 
@@ -1954,6 +2243,8 @@ describe('BrsFile', () => {
                 function DoSomething()
                     'lots of empty white space
                     'that will be removed during transpile
+                    'since there are newlines below this comment one newline will be preserved
+
                 end function
             `);
         });
@@ -1968,6 +2259,26 @@ describe('BrsFile', () => {
         it('does not add leading or trailing newlines', async () => {
             await testTranspile(`function abc()\nend function`, undefined, 'none');
         });
+        it('generates proper sourcemap comment', () => {
+            program.options.sourceMap = true;
+            const file = program.setFile('source/main.bs', `
+                sub main()
+                end sub
+            `);
+            (0, chai_config_spec_1.expect)(file.transpile().code).to.eql((0, undent_1.default) `
+                sub main()
+                end sub
+                '//# sourceMappingURL=./main.brs.map
+            `);
+        });
+        it('includes sourcemap.name property', () => {
+            program.options.sourceMap = true;
+            const file = program.setFile('source/main.bs', `
+                sub main()
+                end sub
+            `);
+            (0, chai_config_spec_1.expect)(file.transpile().map.toJSON().file).to.eql('main.brs');
+        });
         it('handles sourcemap edge case', async () => {
             let source = 'sub main()\n' +
                 '\n' +
@@ -2139,6 +2450,25 @@ describe('BrsFile', () => {
                 end sub
             `);
         });
+        it('keeps spaces in between comments when a statement ends in a comment ', async () => {
+            await testTranspile(`
+                sub foo()
+                end sub 'comment
+
+                'a function that does something
+                sub foo2()
+                end sub
+            `);
+        });
+        it('keeps comment in correct place in empty function', async () => {
+            await testTranspile(`
+                sub noop1()
+                end sub
+
+                sub noop2() 'comment in empty function
+                end sub
+            `);
+        });
         it('works for a complex function with comments all over the place', async () => {
             await testTranspile(`
                 'import some library
@@ -2330,7 +2660,7 @@ describe('BrsFile', () => {
                 program.setFile('source/main.bs', `
                     sub test()
                         someNode = createObject("roSGNode", "Rectangle")
-                        someNode@.someFunction(test.value)
+                        someNode@.someFunction({test: "value"})
                     end sub
                 `);
                 program.validate();
@@ -3078,16 +3408,36 @@ describe('BrsFile', () => {
                     return arg.getTwo()
                 end function
             `);
-            const validateFileEvent = {
-                program: program,
-                file: mainFile
-            };
-            program.plugins.emit('onFileValidate', validateFileEvent);
+            validateFile(mainFile);
             (0, chai_config_spec_1.expect)(mainFile.requiredSymbols.length).to.eq(2);
             (0, chai_config_spec_1.expect)(mainFile.requiredSymbols.map(x => x.typeChain[0].name)).to.have.same.members([
                 'TwoType', 'OneType'
             ]);
         });
+        it('allows built-in types for interface members', () => {
+            program.setFile('source/main.bs', `
+                interface MyBase
+                    regex as roRegex
+                    node as roSGNodeLabel
+                    sub outputMatches(textInput as string)
+                    function getLabelParent() as roSGNode
+                end interface
+                `);
+            program.validate();
+            (0, testHelpers_spec_1.expectZeroDiagnostics)(program);
+        });
+        it('allows extends on interfaces', async () => {
+            await testTranspile(`
+                interface MyBase
+                    url as string
+                end interface
+
+                interface MyExtends extends MyBase
+                    method as string
+                end interface
+            `, `
+            `);
+        });
         it('should include unknown param and return types on class methods', () => {
             const mainFile = program.setFile('source/main.bs', `
                 class Klass
@@ -3096,11 +3446,7 @@ describe('BrsFile', () => {
                     end function
                 end class
             `);
-            const validateFileEvent = {
-                program: program,
-                file: mainFile
-            };
-            program.plugins.emit('onFileValidate', validateFileEvent);
+            validateFile(mainFile);
             (0, chai_config_spec_1.expect)(mainFile.requiredSymbols.length).to.eq(2);
             (0, chai_config_spec_1.expect)(mainFile.requiredSymbols.map(x => x.typeChain[0].name)).to.have.same.members([
                 'TwoType', 'OneType'
@@ -3113,11 +3459,7 @@ describe('BrsFile', () => {
                     print x+1
                 end sub
             `);
-            const validateFileEvent = {
-                program: program,
-                file: mainFile
-            };
-            program.plugins.emit('onFileValidate', validateFileEvent);
+            validateFile(mainFile);
             (0, chai_config_spec_1.expect)(mainFile.requiredSymbols.length).to.eq(1);
             // x and arg are assigned.. they are not included in the required symbols
             (0, chai_config_spec_1.expect)(mainFile.requiredSymbols[0].typeChain[0].name).to.equal('SomeOtherType');
@@ -3136,11 +3478,7 @@ describe('BrsFile', () => {
                     return y-otherFileFunc4()
                 end function
             `);
-            const validateFileEvent = {
-                program: program,
-                file: mainFile
-            };
-            program.plugins.emit('onFileValidate', validateFileEvent);
+            validateFile(mainFile);
             (0, chai_config_spec_1.expect)(mainFile.requiredSymbols.length).to.eq(4);
             (0, chai_config_spec_1.expect)(mainFile.requiredSymbols.map(x => x.typeChain[0].name)).to.have.same.members([
                 'otherFileFunc1', 'otherFileFunc2', 'otherFileFunc3', 'otherFileFunc4'
@@ -3153,11 +3491,7 @@ describe('BrsFile', () => {
                     return other.getThing(x)
                 end function
             `);
-            const validateFileEvent = {
-                program: program,
-                file: mainFile
-            };
-            program.plugins.emit('onFileValidate', validateFileEvent);
+            validateFile(mainFile);
             (0, chai_config_spec_1.expect)(mainFile.requiredSymbols.length).to.eq(3);
             const requiredTypeChains = mainFile.requiredSymbols.map(x => x.typeChain.map(tc => tc.name).join('.'));
             (0, chai_config_spec_1.expect)(requiredTypeChains).to.have.same.members([
@@ -3180,11 +3514,7 @@ describe('BrsFile', () => {
                     end if
                 end sub
             `);
-            const validateFileEvent = {
-                program: program,
-                file: mainFile
-            };
-            program.plugins.emit('onFileValidate', validateFileEvent);
+            validateFile(mainFile);
             (0, chai_config_spec_1.expect)(mainFile.requiredSymbols.length).to.eq(4);
             const requiredTypeChains = mainFile.requiredSymbols.map(x => x.typeChain.map(tc => tc.name).join('.'));
             (0, chai_config_spec_1.expect)(requiredTypeChains).to.have.same.members([
@@ -3210,11 +3540,7 @@ describe('BrsFile', () => {
                     end function
                 end class
             `);
-            const validateFileEvent = {
-                program: program,
-                file: mainFile
-            };
-            program.plugins.emit('onFileValidate', validateFileEvent);
+            validateFile(mainFile);
             (0, chai_config_spec_1.expect)(mainFile.requiredSymbols.length).to.eq(5);
             const requiredTypeChains = mainFile.requiredSymbols.map(x => x.typeChain.map(tc => tc.name).join('.'));
             (0, chai_config_spec_1.expect)(requiredTypeChains).to.have.same.members([
@@ -3243,11 +3569,7 @@ describe('BrsFile', () => {
                     end namespace
                 end namespace
             `);
-            const validateFileEvent = {
-                program: program,
-                file: mainFile
-            };
-            program.plugins.emit('onFileValidate', validateFileEvent);
+            validateFile(mainFile);
             (0, chai_config_spec_1.expect)(mainFile.requiredSymbols.length).to.eq(2);
             const requiredTypeChains = mainFile.requiredSymbols.map(x => x.typeChain.map(tc => tc.name).join('.'));
             (0, chai_config_spec_1.expect)(requiredTypeChains).to.have.same.members([
@@ -3268,7 +3590,7 @@ describe('BrsFile', () => {
                     end namespace
                 end namespace
             `);
-            program.plugins.emit('onFileValidate', { program: program, file: mainFile });
+            validateFile(mainFile);
             (0, chai_config_spec_1.expect)(mainFile.requiredSymbols.length).to.eq(0);
         });
         it('should put types from typecasts as typetime required', () => {
@@ -3277,10 +3599,104 @@ describe('BrsFile', () => {
                     return (z as MyInterface).name
                 end function
             `);
-            program.plugins.emit('onFileValidate', { program: program, file: mainFile });
+            validateFile(mainFile);
             (0, chai_config_spec_1.expect)(mainFile.requiredSymbols.length).to.eq(1);
             (0, chai_config_spec_1.expect)(mainFile.requiredSymbols[0].flags).to.eq(2 /* SymbolTypeFlag.typetime */);
         });
+        it('should not include symbols in same namespace', () => {
+            const mainFile = program.setFile('source/main.bs', `
+                namespace alpha
+                    const PI = 3.14
+                    function area(r as float) as float
+                        return alpha.PI * r * r
+                    end function
+                end namespace
+            `);
+            validateFile(mainFile);
+            (0, chai_config_spec_1.expect)(mainFile.requiredSymbols.length).to.eq(0);
+        });
+        it('should not include symbols in same namespace, but different statements', () => {
+            const mainFile = program.setFile('source/main.bs', `
+                namespace alpha
+                    function area(r as float) as float
+                        return alpha.PI * r * r
+                    end function
+                end namespace
+
+                namespace alpha
+                    const PI = 3.14
+                end namespace
+            `);
+            validateFile(mainFile);
+            (0, chai_config_spec_1.expect)(mainFile.requiredSymbols.length).to.eq(0);
+        });
+        it('should not include symbols in imported file', () => {
+            const otherFile = program.setFile('source/other.bs', `
+                namespace alpha
+                    const PI = 3.14
+                end namespace
+            `);
+            const mainFile = program.setFile('source/main.bs', `
+                import "pkg:/source/other.bs"
+                namespace alpha
+                    function area(r as float) as float
+                        return alpha.PI * r * r
+                    end function
+                end namespace
+            `);
+            validateFile(otherFile, mainFile);
+            (0, chai_config_spec_1.expect)(mainFile.requiredSymbols.length).to.eq(0);
+        });
+        it('should not include symbols in imported file of imported file', () => {
+            const deepFile = program.setFile('source/deep.bs', `
+                namespace alpha
+                    const SOME_VALUE = 2
+                end namespace
+            `);
+            const otherFile = program.setFile('source/other.bs', `
+                import "pkg:/source/deep.bs"
+                namespace alpha
+                    const PI = 3.14
+                end namespace
+            `);
+            const mainFile = program.setFile('source/main.bs', `
+                import "pkg:/source/other.bs"
+                namespace alpha
+                    function area(r as float) as float
+                        return alpha.PI * r * r * alpha.SOME_VALUE
+                    end function
+                end namespace
+            `);
+            validateFile(otherFile, mainFile, deepFile);
+            (0, chai_config_spec_1.expect)(mainFile.requiredSymbols.length).to.eq(0);
+        });
+        it('should not have problems with circular references of imports', () => {
+            const deepFile = program.setFile('source/deep.bs', `
+                import "pkg:/source/main.bs"
+                namespace alpha
+                    function getMyValue()
+                        return alpha.MY_VALUE
+                    end function
+                end namespace
+            `);
+            const otherFile = program.setFile('source/other.bs', `
+                import "pkg:/source/deep.bs"
+                namespace alpha
+                    const PI = 3.14
+                end namespace
+            `);
+            const mainFile = program.setFile('source/main.bs', `
+                import "pkg:/source/other.bs"
+                namespace alpha
+                    function area(r as float) as float
+                        return alpha.PI * r * r * alpha.getMyValue()
+                    end function
+                    const MY_VALUE = 2
+                end namespace
+            `);
+            validateFile(otherFile, mainFile, deepFile);
+            (0, chai_config_spec_1.expect)(mainFile.requiredSymbols.length).to.eq(0);
+        });
     });
     describe('providedSymbols', () => {
         it('includes functions defined in the file', () => {
@@ -3293,11 +3709,7 @@ describe('BrsFile', () => {
                     return 2.3
                 end function
             `);
-            const validateFileEvent = {
-                program: program,
-                file: mainFile
-            };
-            program.plugins.emit('onFileValidate', validateFileEvent);
+            validateFile(mainFile);
             const runtimeSymbols = mainFile.providedSymbols.symbolMap.get(1 /* SymbolTypeFlag.runtime */);
             (0, chai_config_spec_1.expect)(runtimeSymbols.size).to.eq(2);
             const someFuncType = runtimeSymbols.get('somefunc').type;
@@ -3311,11 +3723,7 @@ describe('BrsFile', () => {
                     return new OtherFileType()
                 end function
             `);
-            const validateFileEvent = {
-                program: program,
-                file: mainFile
-            };
-            program.plugins.emit('onFileValidate', validateFileEvent);
+            validateFile(mainFile);
             const runtimeSymbols = mainFile.providedSymbols.symbolMap.get(1 /* SymbolTypeFlag.runtime */);
             (0, chai_config_spec_1.expect)(runtimeSymbols.size).to.eq(1);
             const someFuncType = runtimeSymbols.get('somefunc').type;
@@ -3343,11 +3751,7 @@ describe('BrsFile', () => {
                     propClass = new Klass2()
                 end class
             `);
-            const validateFileEvent = {
-                program: program,
-                file: mainFile
-            };
-            program.plugins.emit('onFileValidate', validateFileEvent);
+            validateFile(mainFile);
             const runtimeSymbols = mainFile.providedSymbols.symbolMap.get(1 /* SymbolTypeFlag.runtime */);
             (0, chai_config_spec_1.expect)(runtimeSymbols.size).to.eq(3);
             (0, testHelpers_spec_1.expectTypeToBe)(runtimeSymbols.get('klass').type, types_1.ClassType);
@@ -3374,11 +3778,7 @@ describe('BrsFile', () => {
                     const MyConst = 3.14
                 end namespace
             `);
-            const validateFileEvent = {
-                program: program,
-                file: mainFile
-            };
-            program.plugins.emit('onFileValidate', validateFileEvent);
+            validateFile(mainFile);
             const runtimeSymbols = mainFile.providedSymbols.symbolMap.get(1 /* SymbolTypeFlag.runtime */);
             (0, chai_config_spec_1.expect)(runtimeSymbols.size).to.eq(2);
             (0, testHelpers_spec_1.expectTypeToBe)(runtimeSymbols.get('myenum').type, types_1.EnumType);
@@ -3395,7 +3795,7 @@ describe('BrsFile', () => {
                         print 1
                     end sub
                 `);
-                program.plugins.emit('onFileValidate', { program: program, file: mainFile });
+                validateFile(mainFile);
                 let runtimeSymbols = mainFile.providedSymbols.symbolMap.get(1 /* SymbolTypeFlag.runtime */);
                 (0, chai_config_spec_1.expect)(runtimeSymbols.size).to.eq(1);
                 mainFile = program.setFile('source/main.bs', `
@@ -3407,7 +3807,7 @@ describe('BrsFile', () => {
                         print 2
                     end sub
                 `);
-                program.plugins.emit('onFileValidate', { program: program, file: mainFile });
+                validateFile(mainFile);
                 runtimeSymbols = mainFile.providedSymbols.symbolMap.get(1 /* SymbolTypeFlag.runtime */);
                 (0, chai_config_spec_1.expect)(runtimeSymbols.size).to.eq(2);
                 let runtimeChanges = mainFile.providedSymbols.changes.get(1 /* SymbolTypeFlag.runtime */);
@@ -3424,7 +3824,7 @@ describe('BrsFile', () => {
                         print 2
                     end sub
                 `);
-                program.plugins.emit('onFileValidate', { program: program, file: mainFile });
+                validateFile(mainFile);
                 let runtimeSymbols = mainFile.providedSymbols.symbolMap.get(1 /* SymbolTypeFlag.runtime */);
                 (0, chai_config_spec_1.expect)(runtimeSymbols.size).to.eq(2);
                 mainFile = program.setFile('source/main.bs', `
@@ -3432,7 +3832,7 @@ describe('BrsFile', () => {
                         print 1
                     end sub
                 `);
-                program.plugins.emit('onFileValidate', { program: program, file: mainFile });
+                validateFile(mainFile);
                 runtimeSymbols = mainFile.providedSymbols.symbolMap.get(1 /* SymbolTypeFlag.runtime */);
                 (0, chai_config_spec_1.expect)(runtimeSymbols.size).to.eq(1);
                 let runtimeChanges = mainFile.providedSymbols.changes.get(1 /* SymbolTypeFlag.runtime */);
@@ -3444,7 +3844,7 @@ describe('BrsFile', () => {
                     namespace Alpha
                     end namespace
                 `);
-                program.plugins.emit('onFileValidate', { program: program, file: mainFile });
+                validateFile(mainFile);
                 let runtimeSymbols = mainFile.providedSymbols.symbolMap.get(1 /* SymbolTypeFlag.runtime */);
                 (0, chai_config_spec_1.expect)(runtimeSymbols.size).to.eq(0);
                 mainFile = program.setFile('source/main.bs', `
@@ -3452,7 +3852,7 @@ describe('BrsFile', () => {
                         const ABC = "abc"
                     end namespace
                 `);
-                program.plugins.emit('onFileValidate', { program: program, file: mainFile });
+                validateFile(mainFile);
                 runtimeSymbols = mainFile.providedSymbols.symbolMap.get(1 /* SymbolTypeFlag.runtime */);
                 (0, chai_config_spec_1.expect)(runtimeSymbols.size).to.eq(1);
                 let runtimeChanges = mainFile.providedSymbols.changes.get(1 /* SymbolTypeFlag.runtime */);
@@ -3469,7 +3869,7 @@ describe('BrsFile', () => {
                         const PI = 3.14
                     end namespace
                 `);
-                program.plugins.emit('onFileValidate', { program: program, file: mainFile });
+                validateFile(mainFile);
                 let runtimeSymbols = mainFile.providedSymbols.symbolMap.get(1 /* SymbolTypeFlag.runtime */);
                 (0, chai_config_spec_1.expect)(runtimeSymbols.size).to.eq(2);
                 mainFile = program.setFile('source/main.bs', `
@@ -3481,7 +3881,7 @@ describe('BrsFile', () => {
                         const PI = 3.14159
                     end namespace
                 `);
-                program.plugins.emit('onFileValidate', { program: program, file: mainFile });
+                validateFile(mainFile);
                 runtimeSymbols = mainFile.providedSymbols.symbolMap.get(1 /* SymbolTypeFlag.runtime */);
                 (0, chai_config_spec_1.expect)(runtimeSymbols.size).to.eq(2);
                 let runtimeChanges = mainFile.providedSymbols.changes.get(1 /* SymbolTypeFlag.runtime */);
@@ -3493,7 +3893,7 @@ describe('BrsFile', () => {
                         return x
                     end function
                 `);
-                program.plugins.emit('onFileValidate', { program: program, file: mainFile });
+                validateFile(mainFile);
                 let runtimeSymbols = mainFile.providedSymbols.symbolMap.get(1 /* SymbolTypeFlag.runtime */);
                 (0, chai_config_spec_1.expect)(runtimeSymbols.size).to.eq(1);
                 mainFile = program.setFile('source/main.bs', `
@@ -3501,7 +3901,7 @@ describe('BrsFile', () => {
                         return x+y
                     end function
                 `);
-                program.plugins.emit('onFileValidate', { program: program, file: mainFile });
+                validateFile(mainFile);
                 runtimeSymbols = mainFile.providedSymbols.symbolMap.get(1 /* SymbolTypeFlag.runtime */);
                 (0, chai_config_spec_1.expect)(runtimeSymbols.size).to.eq(1);
                 let runtimeChanges = mainFile.providedSymbols.changes.get(1 /* SymbolTypeFlag.runtime */);
@@ -3517,7 +3917,7 @@ describe('BrsFile', () => {
                         end function
                     end class
                 `);
-                program.plugins.emit('onFileValidate', { program: program, file: mainFile });
+                validateFile(mainFile);
                 let runtimeSymbols = mainFile.providedSymbols.symbolMap.get(1 /* SymbolTypeFlag.runtime */);
                 (0, chai_config_spec_1.expect)(runtimeSymbols.size).to.eq(1);
                 mainFile = program.setFile('source/main.bs', `
@@ -3528,7 +3928,7 @@ describe('BrsFile', () => {
                         end function
                     end class
                 `);
-                program.plugins.emit('onFileValidate', { program: program, file: mainFile });
+                validateFile(mainFile);
                 runtimeSymbols = mainFile.providedSymbols.symbolMap.get(1 /* SymbolTypeFlag.runtime */);
                 (0, chai_config_spec_1.expect)(runtimeSymbols.size).to.eq(1);
                 let runtimeChanges = mainFile.providedSymbols.changes.get(1 /* SymbolTypeFlag.runtime */);
@@ -3545,7 +3945,7 @@ describe('BrsFile', () => {
                         function doStuff() as float
                     end interface
                 `);
-                program.plugins.emit('onFileValidate', { program: program, file: mainFile });
+                validateFile(mainFile);
                 let typetimeSymbols = mainFile.providedSymbols.symbolMap.get(2 /* SymbolTypeFlag.typetime */);
                 (0, chai_config_spec_1.expect)(typetimeSymbols.size).to.eq(1);
                 let runtimeSymbols = mainFile.providedSymbols.symbolMap.get(1 /* SymbolTypeFlag.runtime */);
@@ -3557,7 +3957,7 @@ describe('BrsFile', () => {
                         function doStuff() as float
                     end interface
                 `);
-                program.plugins.emit('onFileValidate', { program: program, file: mainFile });
+                validateFile(mainFile);
                 typetimeSymbols = mainFile.providedSymbols.symbolMap.get(2 /* SymbolTypeFlag.typetime */);
                 (0, chai_config_spec_1.expect)(typetimeSymbols.size).to.eq(1);
                 let typeTimeChanges = mainFile.providedSymbols.changes.get(2 /* SymbolTypeFlag.typetime */);
@@ -3575,7 +3975,7 @@ describe('BrsFile', () => {
                         west = 1
                     end enum
                 `);
-                program.plugins.emit('onFileValidate', { program: program, file: mainFile });
+                validateFile(mainFile);
                 let runtimeSymbols = mainFile.providedSymbols.symbolMap.get(1 /* SymbolTypeFlag.runtime */);
                 (0, chai_config_spec_1.expect)(runtimeSymbols.size).to.eq(1);
                 mainFile = program.setFile('source/main.bs', `
@@ -3586,7 +3986,7 @@ describe('BrsFile', () => {
                         west = 4
                     end enum
                 `);
-                program.plugins.emit('onFileValidate', { program: program, file: mainFile });
+                validateFile(mainFile);
                 runtimeSymbols = mainFile.providedSymbols.symbolMap.get(1 /* SymbolTypeFlag.runtime */);
                 (0, chai_config_spec_1.expect)(runtimeSymbols.size).to.eq(1);
                 let runtimeChanges = mainFile.providedSymbols.changes.get(1 /* SymbolTypeFlag.runtime */);
@@ -3617,7 +4017,7 @@ describe('BrsFile', () => {
                         purple
                     end enum
                 `);
-                program.plugins.emit('onFileValidate', { program: program, file: mainFile });
+                validateFile(mainFile);
                 let runtimeSymbols = mainFile.providedSymbols.symbolMap.get(1 /* SymbolTypeFlag.runtime */);
                 (0, chai_config_spec_1.expect)(runtimeSymbols.size).to.eq(3);
                 mainFile = program.setFile('source/main.bs', `
@@ -3640,7 +4040,7 @@ describe('BrsFile', () => {
                         green
                     end enum
                 `);
-                program.plugins.emit('onFileValidate', { program: program, file: mainFile });
+                validateFile(mainFile);
                 runtimeSymbols = mainFile.providedSymbols.symbolMap.get(1 /* SymbolTypeFlag.runtime */);
                 (0, chai_config_spec_1.expect)(runtimeSymbols.size).to.eq(3);
                 let runtimeChanges = mainFile.providedSymbols.changes.get(1 /* SymbolTypeFlag.runtime */);
@@ -3657,7 +4057,7 @@ describe('BrsFile', () => {
                         west = 4
                     end enum
                 `);
-                program.plugins.emit('onFileValidate', { program: program, file: mainFile });
+                validateFile(mainFile);
                 let runtimeSymbols = mainFile.providedSymbols.symbolMap.get(1 /* SymbolTypeFlag.runtime */);
                 (0, chai_config_spec_1.expect)(runtimeSymbols.size).to.eq(1);
                 mainFile = program.setFile('source/main.bs', `
@@ -3681,7 +4081,7 @@ describe('BrsFile', () => {
                         const PI = 3.14
                     end namespace
                 `);
-                program.plugins.emit('onFileValidate', { program: program, file: mainFile });
+                validateFile(mainFile);
                 let runtimeSymbols = mainFile.providedSymbols.symbolMap.get(1 /* SymbolTypeFlag.runtime */);
                 (0, chai_config_spec_1.expect)(runtimeSymbols.size).to.eq(1);
                 mainFile = program.setFile('source/main.bs', `
@@ -3689,7 +4089,7 @@ describe('BrsFile', () => {
                         const PI = "lemon chiffon"
                     end namespace
                 `);
-                program.plugins.emit('onFileValidate', { program: program, file: mainFile });
+                validateFile(mainFile);
                 runtimeSymbols = mainFile.providedSymbols.symbolMap.get(1 /* SymbolTypeFlag.runtime */);
                 (0, chai_config_spec_1.expect)(runtimeSymbols.size).to.eq(1);
                 let runtimeChanges = mainFile.providedSymbols.changes.get(1 /* SymbolTypeFlag.runtime */);
@@ -3709,12 +4109,12 @@ describe('BrsFile', () => {
                         print myLabel.getChildren(0, -1)
                     end sub
                 `);
-                program.plugins.emit('onFileValidate', { program: program, file: mainFile });
+                validateFile(mainFile);
                 let runtimeSymbols = mainFile.providedSymbols.symbolMap.get(1 /* SymbolTypeFlag.runtime */);
                 (0, chai_config_spec_1.expect)(runtimeSymbols.size).to.eq(2);
                 mainFile = program.setFile('source/main.bs', `
                     function func1(p as string) as integer
-                        return len(p)+1
+                        return len(p) + 1
                     end function
 
                     sub displayModelTypeInLabel(myLabel as roSgNodeLabel)
@@ -3724,7 +4124,7 @@ describe('BrsFile', () => {
                         print myLabel.getChildren(0, -1)
                     end sub
                 `);
-                program.plugins.emit('onFileValidate', { program: program, file: mainFile });
+                validateFile(mainFile);
                 runtimeSymbols = mainFile.providedSymbols.symbolMap.get(1 /* SymbolTypeFlag.runtime */);
                 (0, chai_config_spec_1.expect)(runtimeSymbols.size).to.eq(2);
                 let runtimeChanges = mainFile.providedSymbols.changes.get(1 /* SymbolTypeFlag.runtime */);
@@ -3739,10 +4139,10 @@ describe('BrsFile', () => {
                     end class
                 `;
                 let mainFile = program.setFile('source/class.bs', classFileContent);
-                program.plugins.emit('onFileValidate', { program: program, file: mainFile });
+                validateFile(mainFile);
                 // No changes!
                 mainFile = program.setFile('source/class.bs', classFileContent);
-                program.plugins.emit('onFileValidate', { program: program, file: mainFile });
+                validateFile(mainFile);
                 let runtimeChanges = mainFile.providedSymbols.changes.get(1 /* SymbolTypeFlag.runtime */);
                 (0, chai_config_spec_1.expect)(runtimeChanges.size).to.eq(0);
             });
@@ -3765,21 +4165,20 @@ describe('BrsFile', () => {
                     end namespace
                 `;
                 let mainFile = program.setFile('source/class.bs', fileContent);
-                program.plugins.emit('onFileValidate', { program: program, file: mainFile });
+                validateFile(mainFile);
                 // No changes!
                 mainFile = program.setFile('source/class.bs', fileContent);
-                program.plugins.emit('onFileValidate', { program: program, file: mainFile });
+                validateFile(mainFile);
                 let runtimeChanges = mainFile.providedSymbols.changes.get(1 /* SymbolTypeFlag.runtime */);
                 (0, chai_config_spec_1.expect)(runtimeChanges.size).to.eq(0);
             });
             it('functions in a namespace that have class params show change properly', () => {
                 const fileContent = `
                     namespace Alpha.Beta
-
                         class SomeKlass
                             name as string
                             function combineName(klass as SomeKlass)
-                                m.name = m.name+klass.name
+                                m.name = m.name + klass.name
                             end function
                         end class
 
@@ -3790,10 +4189,29 @@ describe('BrsFile', () => {
                     end namespace
                 `;
                 let mainFile = program.setFile('source/class.bs', fileContent);
-                program.plugins.emit('onFileValidate', { program: program, file: mainFile });
+                validateFile(mainFile);
                 // No changes!
                 mainFile = program.setFile('source/class.bs', fileContent);
-                program.plugins.emit('onFileValidate', { program: program, file: mainFile });
+                validateFile(mainFile);
+                let runtimeChanges = mainFile.providedSymbols.changes.get(1 /* SymbolTypeFlag.runtime */);
+                (0, chai_config_spec_1.expect)(runtimeChanges.size).to.eq(0);
+            });
+            it('should not include namespaces in changes if no symbols in namespace changed', () => {
+                const fileContent = `
+                    namespace Alpha.Beta
+                        const PI = 3.14
+                    end namespace
+                `;
+                const fileContentWithComment = `
+                    namespace Alpha.Beta
+                        const PI = 3.14 ' comment
+                    end namespace
+                `;
+                let mainFile = program.setFile('source/namespace.bs', fileContent);
+                validateFile(mainFile);
+                // Just added a comment!
+                mainFile = program.setFile('source/namespace.bs', fileContentWithComment);
+                validateFile(mainFile);
                 let runtimeChanges = mainFile.providedSymbols.changes.get(1 /* SymbolTypeFlag.runtime */);
                 (0, chai_config_spec_1.expect)(runtimeChanges.size).to.eq(0);
             });
@@ -3806,7 +4224,7 @@ describe('BrsFile', () => {
                     aa1 = {
                         "sprop1": 0,
                         prop1: 1
-                        prop2: {
+                                prop2: {
                             prop3: 2
                         }
                     }
@@ -3840,7 +4258,7 @@ describe('BrsFile', () => {
                     aa1 = {
                         "constructor": 0,
                         constructor: 1
-                        valueOf: {
+                                valueOf: {
                             toString: 2
                         }
                     }
@@ -3854,6 +4272,80 @@ describe('BrsFile', () => {
             const { propertyHints } = file['_cachedLookups'];
             (0, chai_config_spec_1.expect)(Object.keys(propertyHints).sort()).to.deep.equal(expected, 'Initial hints');
         });
+        it('allows built-in types for class members', () => {
+            program.setFile('source/main.bs', `
+                class MyBase
+                    regex as roRegex
+                    node as roSGNodeLabel
+
+                    sub outputMatches(textInput as string)
+                        matches = m.regex.match(textInput)
+                        if matches.count() > 1
+                            m.node.text = matches[1]
+                        else
+                            m.node.text = "no match"
+                        end if
+                    end sub
+
+                    function getLabelParent() as roSGNode
+                        return m.node.getParent()
+                    end function
+                end class
+            `);
+            program.validate();
+            (0, testHelpers_spec_1.expectZeroDiagnostics)(program);
+        });
+        it('allows types on lhs of assignments', async () => {
+            await testTranspile(`
+                sub foo(node as roSGNode)
+                    nodeParent as roSGNode = node.getParent()
+                    text as string = nodeParent.id
+                    print text
+                end sub
+            `, `
+                sub foo(node as dynamic)
+                    nodeParent = node.getParent()
+                    text = nodeParent.id
+                    print text
+                end sub
+            `);
+        });
+        //fails at the specific length of statement including leading tabs and spaces
+        it('allows long statements', () => {
+            program.setFile('source/main.bs', `function request()\r\nhzzzzandleInterceptedScreenDataaaaaaaaaaainterceptedScreenData() 'bs:disable-line \r\nend function`);
+            program.validate();
+            (0, testHelpers_spec_1.expectZeroDiagnostics)(program);
+            program.setFile('source/main.bs', `function request()\r\n\t\t\t\t\t\t\t\t\t\t\t\t\t\t\t\t\t\t\t\t\t\t\t\t\t\t\t\t\t\t\t\t\t\t\t\t\t\t\t\t\t\t\t\t\t\thandleInterceptedScreenDataaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa(m._aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaainterceptedScreenData) 'bs:disable-line \r\nend function`);
+            program.validate();
+            (0, testHelpers_spec_1.expectZeroDiagnostics)(program);
+            program.setFile('source/main.bs', `function request()\r\n\t\t\t\thandleInterceptedScreenData(m._aaaaaaainterceptedScreenData) 'bs:disable-line 1001\r\nend function`);
+            program.validate();
+            (0, testHelpers_spec_1.expectZeroDiagnostics)(program);
+        });
+    });
+    it('allows up to 63 function params', () => {
+        program.setFile('source/main.bs', `
+            function test(p1 = 1, p2 = 2, p3 = 3, p4 = 4, p5 = 5, p6 = 6, p7 = 7, p8 = 8, p9 = 9, p10 = 10, p11 = 11, p12 = 12, p13 = 13, p14 = 14, p15 = 15, p16 = 16, p17 = 17, p18 = 18, p19 = 19, p20 = 20, p21 = 21, p22 = 22, p23 = 23, p24 = 24, p25 = 25, p26 = 26, p27 = 27, p28 = 28, p29 = 29, p30 = 30, p31 = 31, p32 = 32, p33 = 33, p34 = 34, p35 = 35, p36 = 36, p37 = 37, p38 = 38, p39 = 39, p40 = 40, p41 = 41, p42 = 42, p43 = 43, p44 = 44, p45 = 45, p46 = 46, p47 = 47, p48 = 48, p49 = 49, p50 = 50, p51 = 51, p52 = 52, p53 = 53, p54 = 54, p55 = 55, p56 = 56, p57 = 57, p58 = 58, p59 = 59, p60 = 60, p61 = 61, p62 = 62, p63 = 63)
+            end function
+        `);
+        program.validate();
+        (0, testHelpers_spec_1.expectZeroDiagnostics)(program);
+    });
+    it('flags functions having 64 parameters', () => {
+        program.setFile('source/main.bs', `
+            function test(p1 = 1, p2 = 2, p3 = 3, p4 = 4, p5 = 5, p6 = 6, p7 = 7, p8 = 8, p9 = 9, p10 = 10, p11 = 11, p12 = 12, p13 = 13, p14 = 14, p15 = 15, p16 = 16, p17 = 17, p18 = 18, p19 = 19, p20 = 20, p21 = 21, p22 = 22, p23 = 23, p24 = 24, p25 = 25, p26 = 26, p27 = 27, p28 = 28, p29 = 29, p30 = 30, p31 = 31, p32 = 32, p33 = 33, p34 = 34, p35 = 35, p36 = 36, p37 = 37, p38 = 38, p39 = 39, p40 = 40, p41 = 41, p42 = 42, p43 = 43, p44 = 44, p45 = 45, p46 = 46, p47 = 47, p48 = 48, p49 = 49, p50 = 50, p51 = 51, p52 = 52, p53 = 53, p54 = 54, p55 = 55, p56 = 56, p57 = 57, p58 = 58, p59 = 59, p60 = 60, p61 = 61, p62 = 62, p63 = 63, p64 = 64)
+            end function
+        `);
+        program.validate();
+        (0, testHelpers_spec_1.expectDiagnostics)(program, [Object.assign(Object.assign({}, DiagnosticMessages_1.DiagnosticMessages.tooManyCallableParameters(64, 63)), { range: util_1.default.createRange(1, 638, 1, 641) })]);
+    });
+    it('flags functions having 65 parameters', () => {
+        program.setFile('source/main.bs', `
+            function test(p1 = 1, p2 = 2, p3 = 3, p4 = 4, p5 = 5, p6 = 6, p7 = 7, p8 = 8, p9 = 9, p10 = 10, p11 = 11, p12 = 12, p13 = 13, p14 = 14, p15 = 15, p16 = 16, p17 = 17, p18 = 18, p19 = 19, p20 = 20, p21 = 21, p22 = 22, p23 = 23, p24 = 24, p25 = 25, p26 = 26, p27 = 27, p28 = 28, p29 = 29, p30 = 30, p31 = 31, p32 = 32, p33 = 33, p34 = 34, p35 = 35, p36 = 36, p37 = 37, p38 = 38, p39 = 39, p40 = 40, p41 = 41, p42 = 42, p43 = 43, p44 = 44, p45 = 45, p46 = 46, p47 = 47, p48 = 48, p49 = 49, p50 = 50, p51 = 51, p52 = 52, p53 = 53, p54 = 54, p55 = 55, p56 = 56, p57 = 57, p58 = 58, p59 = 59, p60 = 60, p61 = 61, p62 = 62, p63 = 63, p64 = 64, p65 = 65)
+            end function
+        `);
+        program.validate();
+        (0, testHelpers_spec_1.expectDiagnostics)(program, [Object.assign(Object.assign({}, DiagnosticMessages_1.DiagnosticMessages.tooManyCallableParameters(65, 63)), { range: util_1.default.createRange(1, 638, 1, 641) }), Object.assign(Object.assign({}, DiagnosticMessages_1.DiagnosticMessages.tooManyCallableParameters(65, 63)), { range: util_1.default.createRange(1, 648, 1, 651) })]);
     });
 });
 //# sourceMappingURL=BrsFile.spec.js.map