breakaway 1.5.0-main.30 → 1.5.0-main.32

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "breakaway",
-  "version": "1.5.0-main.30",
+  "version": "1.5.0-main.32",
   "description": "The task board for you and your coding agents: a Cloudflare Worker, its web app, Taskwarrior sync, and the CLI (npx breakaway).",
   "license": "FSL-1.1-Apache-2.0",
   "type": "module",

package/scripts/tasks/structure.js

@@ -98,6 +98,7 @@ export const PING_TEMPLATE = {
       done_when: 'The new done when.',
     },
     { type: 'done', task: 'CLD-113', note: 'Does not reproduce any more; it behaves as expected.' },
+    { type: 'delete', task: 'CLD-114', note: 'CLD-112 covers it now.' },
     { type: 'release', task: 'CLD-111' },
   ],
 };
@@ -138,6 +139,7 @@ function proposalLine(c) {
   if (c.type === 'modify')
     return `change ${c.task}: ${['horizon', 'addTags', 'removeTags', 'brief', 'done_when'].filter((k) => k in c).join(', ')}`;
   if (c.type === 'done') return `finish ${c.task}${c.note ? ` (${c.note})` : ''}`;
+  if (c.type === 'delete') return `delete ${c.task}${c.note ? ` (${c.note})` : ''}`;
   return `release ${c.task}`;
 }
 

package/src/ping.js

@@ -30,11 +30,28 @@ export function looksLikeSecret(text) {
   if (/-----BEGIN [A-Z ]*PRIVATE KEY-----/u.test(value)) return true;
   for (const [word] of value.matchAll(/[A-Za-z0-9+/_=-]{32,}/gu)) {
     if (/^[0-9a-f]{40}$/u.test(word)) continue;
+    if (looksLikePath(word)) continue;
     if (/\d/u.test(word) && /[A-Za-z]/u.test(word) && !/^[a-z]+(?:-[a-z0-9]+)+$/u.test(word)) return true;
   }
   return false;
 }
 
+/**
+ * Whether a long word is a file path or a link's path (`docs/specs/IDEA-36-peloton-planning`), not a token with
+ * slashes in it: it has a slash, no `+` or `=`, and every name in it splits on `.`, `_`, and `-` into short pieces,
+ * a commit SHA, or pieces that don't look random (a long run of letters and digits, or of mixed case and digits).
+ */
+function looksLikePath(word) {
+  if (!word.includes('/') || /[+=]/u.test(word)) return false;
+  for (const piece of word.split(/[/._-]+/u)) {
+    if (!piece || /^[0-9a-f]{40}$/u.test(piece)) continue;
+    const digits = /\d/u.test(piece);
+    if (digits && /[A-Za-z]/u.test(piece) && piece.length >= 16) return false;
+    if (digits && /[a-z]/u.test(piece) && /[A-Z]/u.test(piece) && piece.length >= 8) return false;
+  }
+  return true;
+}
+
 /** A ping's kind and message, cleaned, or an InputError that says what to fix. */
 export function checkPing({ kind, message }) {
   if (!PING_KINDS.includes(kind)) throw new InputError(`kind is one of ${PING_KINDS.join(', ')}`);
@@ -174,6 +191,7 @@ export function validateProposal(raw, ctx) {
 
   const changes = [];
   const finished = new Set();
+  const deleted = new Set();
   for (const [i, change] of list.entries()) {
     const where = `change ${i + 1} (${change?.type ?? '?'})`;
     if (!isObject(change)) throw new InputError(`${where}: each change is an object`);
@@ -274,10 +292,30 @@ export function validateProposal(raw, ctx) {
       const uuid = existing(change.task, where, { open: true });
       if (ctx.inReview(uuid))
         throw new InputError(`${where}: ${name(uuid)} has an open pull request that finishes it when it merges`);
-      if (finished.has(uuid)) throw new InputError(`${where}: ${name(uuid)} is finished twice`);
+      if (finished.has(uuid))
+        throw new InputError(
+          `${where}: ${name(uuid)} is ${deleted.has(uuid) ? 'deleted and finished' : 'finished twice'} in this proposal`,
+        );
       finished.add(uuid);
       const note = text(change.note, 'note', MAX_NOTE, where);
       changes.push({ type: 'done', task: ctx.tasks.get(uuid).wid ?? uuid, ...(note ? { note } : {}) });
+    } else if (change.type === 'delete') {
+      // For a task the agent may not delete itself (IDEA-36 section 6): the owner deletes it in one press.
+      only(change, ['type', 'task', 'note'], where);
+      const uuid = existing(change.task, where, { open: true });
+      const holder = ctx.tasks.get(uuid).claim;
+      if (holder === ctx.by) throw new InputError(`${where}: you hold ${name(uuid)}; release it instead`);
+      if (holder) throw new InputError(`${where}: ${holder} has ${name(uuid)}; ask them on the peloton`);
+      if (ctx.inReview(uuid))
+        throw new InputError(`${where}: ${name(uuid)} has an open pull request that finishes it when it merges`);
+      if (finished.has(uuid))
+        throw new InputError(
+          `${where}: ${name(uuid)} is ${deleted.has(uuid) ? 'deleted twice' : 'finished and deleted'} in this proposal`,
+        );
+      finished.add(uuid);
+      deleted.add(uuid);
+      const note = text(change.note, 'note', MAX_NOTE, where);
+      changes.push({ type: 'delete', task: ctx.tasks.get(uuid).wid ?? uuid, ...(note ? { note } : {}) });
     } else if (change.type === 'release') {
       only(change, ['type', 'task'], where);
       const uuid = existing(change.task, where, { open: true });
@@ -285,7 +323,7 @@ export function validateProposal(raw, ctx) {
       if (!ctx.tasks.get(uuid).claim) throw new InputError(`${where}: ${name(uuid)} holds no claim`);
       changes.push({ type: 'release', task: ctx.tasks.get(uuid).wid ?? uuid });
     } else {
-      throw new InputError(`${where}: type is one of add, depend, modify, done, release`);
+      throw new InputError(`${where}: type is one of add, depend, modify, done, delete, release`);
     }
   }
 
@@ -298,7 +336,8 @@ export function validateProposal(raw, ctx) {
     const waiting = [...graph]
       .filter(([node, set]) => set.has(uuid) && !finished.has(node))
       .map(([node]) => name(node));
-    if (waiting.length) warnings.push(`finishing ${name(uuid)} releases ${waiting.join(', ')}`);
+    if (waiting.length)
+      warnings.push(`${deleted.has(uuid) ? 'deleting' : 'finishing'} ${name(uuid)} releases ${waiting.join(', ')}`);
   }
   return { changes, warnings };
 }
@@ -311,6 +350,7 @@ export function summarizeProposal(changes) {
   if (count('depend')) parts.push(`change ${count('depend')} dependenc${count('depend') === 1 ? 'y' : 'ies'}`);
   if (count('modify')) parts.push(`edit ${count('modify')} task${count('modify') === 1 ? '' : 's'}`);
   if (count('done')) parts.push(`finish ${count('done')} task${count('done') === 1 ? '' : 's'}`);
+  if (count('delete')) parts.push(`delete ${count('delete')} task${count('delete') === 1 ? '' : 's'}`);
   if (count('release')) parts.push('release a claim');
   return parts.join(', ');
 }

package/src/specs.js

@@ -89,6 +89,71 @@ export function specMeta(name, text) {
   return { wid, title, status };
 }
 
+/** The step a status takes when the owner marks a spec (BRK-215): draft to approved, approved to built. */
+export const NEXT_STATUS = Object.freeze({ draft: 'approved', approved: 'built' });
+
+/** The status after `status`, or null when it has none (built, or a word the board doesn't know). */
+export const nextStatus = (status) => (Object.hasOwn(NEXT_STATUS, status) ? NEXT_STATUS[status] : null);
+
+/** `Status:`, its word, and what its brackets say, as the template writes it: `Status: approved (1 Oct 2026)`. */
+const STATUS = /(\bStatus:\s*\**\s*)([A-Za-z][\w-]*)(?:\s*\(([^)\n]*)\))?/u;
+
+/** The index of the line under a spec's title (its first `# ` heading), or -1. */
+function statusLineAt(lines) {
+  const at = lines.findIndex((l) => /^#\s+\S/u.test(l));
+  if (at < 0) return -1;
+  return lines.findIndex((l, i) => i > at && l.trim() !== '');
+}
+
+/**
+ * The status on the line under a spec's title, lowercased, and what its brackets say (null without them), or
+ * null when that line has no `Status:`, as specMeta reads it.
+ * @param {string} text
+ * @returns {{ status: string, detail: string | null } | null}
+ */
+export function readStatus(text) {
+  const lines = String(text).split('\n');
+  const at = statusLineAt(lines);
+  const m = at < 0 ? null : STATUS.exec(lines[at]);
+  return m ? { status: m[2].toLowerCase(), detail: m[3]?.trim() || null } : null;
+}
+
+/**
+ * `text` with the status on the line under its title set to `status (detail)`, and nothing else changed: the rest
+ * of that line, a later `Status:` in the body, and the line endings stay. Null when that line has no `Status:`.
+ * @param {string} text
+ * @param {string} status
+ * @param {string} detail
+ */
+export function withStatus(text, status, detail) {
+  const lines = String(text).split('\n');
+  const at = statusLineAt(lines);
+  if (at < 0 || !STATUS.test(lines[at])) return null;
+  lines[at] = lines[at].replace(STATUS, (_, lead) => `${lead}${status} (${detail})`);
+  return lines.join('\n');
+}
+
+const MONTHS = ['Jan', 'Feb', 'Mar', 'Apr', 'May', 'Jun', 'Jul', 'Aug', 'Sep', 'Oct', 'Nov', 'Dec'];
+
+/** A day as the specs and the decision log write it, in UTC: `29 Sep 2026`. */
+export function specDate(ms) {
+  const d = new Date(ms);
+  return `${d.getUTCDate()} ${MONTHS[d.getUTCMonth()]} ${d.getUTCFullYear()}`;
+}
+
+/**
+ * What a built spec's brackets say: the merged pull requests of the tasks that link it (`#41, #42`), else the day,
+ * and then when it was approved, from the brackets it had (`approved 1 Oct 2026, by the owner`).
+ * @param {number[]} pulls
+ * @param {string | null} approved
+ * @param {number} now
+ */
+export function builtDetail(pulls, approved, now) {
+  const numbers = [...new Set(pulls.map(Number).filter((n) => Number.isInteger(n) && n > 0))].sort((a, b) => a - b);
+  const built = numbers.length ? numbers.map((n) => `#${n}`).join(', ') : `as of ${specDate(now)}`;
+  return approved ? `${built}; approved ${approved}` : built;
+}
+
 /** Newest first by the work ID's number, then by path; specs without a work ID last. */
 export function bySpecOrder(a, b) {
   const n = (s) => (s.wid ? Number(s.wid.split('-')[1]) : -1);