breakaway 1.2.1-main.10 → 1.2.1-main.12

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "breakaway",
-  "version": "1.2.1-main.10",
+  "version": "1.2.1-main.12",
   "description": "The task board for you and your coding agents: a Cloudflare Worker, its web app, Taskwarrior sync, and the CLI (npx breakaway).",
   "license": "FSL-1.1-Apache-2.0",
   "type": "module",

package/scripts/tasks/cli.js

@@ -79,7 +79,7 @@ export const FIX_PROBLEMS = ['conflicts', 'failing', 'review'];
 
 /**
  * The request behind `npx breakaway github fix <n>` and `github review <n>` (BRK-81): the pull request page's "Fix with an
- * agent" and "Safe to merge?" buttons (`POST github/pulls/<n>/fix` and `/review`). It names the checkout's repository
+ * agent" and "Safe to merge?" or "Review with an agent" buttons (`POST github/pulls/<n>/fix` and `/review`). It names the checkout's repository
  * like `github` does. Returns an error message instead when the number or `problem` can't be right.
  * @param {'fix' | 'review'} action
  * @param {string | number | undefined} number
@@ -96,11 +96,40 @@ export function pullAgentRequest(action, number, { repo = null, problem, note, f
     ...(repo ? { repo } : {}),
     ...(problem ? { problem } : {}),
     ...(typeof note === 'string' && note.trim() ? { note } : {}),
-    ...forceFields(force, by),
+    // Review with an agent is the owner's, so a review always says who asks (BRK-111); a fix only when forcing.
+    ...(action === 'review' ? { ...(force ? { force: true } : {}), ...(by ? { by } : {}) } : forceFields(force, by)),
   };
   return { request: ['POST', `github/pulls/${n}/${action}`, body] };
 }
 
+export const REVIEW_VERDICTS = ['ready', 'follow-up', 'changes'];
+
+/**
+ * `npx breakaway review <ID> --verdict ready|follow-up|changes "<note>"` (BRK-111): an agent's answer on the pull
+ * request that closes its task. The board adds it to the task as a comment and keeps it for the pull request page.
+ * `pr` picks the pull request when the task has several open.
+ * @param {string | undefined} ref
+ * @param {string | undefined} verdict
+ * @param {string | undefined} note
+ * @param {{ by?: string, pr?: string | number }} [options]
+ */
+export function reviewRequest(ref, verdict, note, { by, pr } = {}) {
+  if (!ref) return { error: 'say which task: npx breakaway review <task> --verdict ready "<note>"' };
+  if (!REVIEW_VERDICTS.includes(String(verdict)))
+    return { error: `say the verdict: --verdict ${REVIEW_VERDICTS.join('|')}` };
+  const text = String(note ?? '').trim();
+  if (!text) return { error: 'say what you found: the note is the review (Markdown)' };
+  const n = pr === undefined ? null : String(pr).replace(/^#/u, '');
+  if (n !== null && !/^[1-9]\d{0,8}$/u.test(n)) return { error: '--pr is a pull request number' };
+  return {
+    request: [
+      'POST',
+      `tasks/${encodeURIComponent(ref)}/review`,
+      { verdict, note: text, ...(by ? { by } : {}), ...(n ? { pr: Number(n) } : {}) },
+    ],
+  };
+}
+
 /**
  * Force start on a request that starts an agent (BRK-107): `force`, and who is asking, so the board can refuse an
  * agent's name (only the owner forces a start). Nothing when it isn't forced.
@@ -145,12 +174,13 @@ export function generalAgentSummary({ task, run, waiting, forceable }) {
  * What the CLI says about an answer to those requests: which task and agent took the pull request, or who already has it.
  * @param {'fix' | 'review'} action
  * @param {string | number} number
- * @param {{ task: { wid?: string, short?: string }, run?: { url?: string, agent?: string } | null, already?: string | null }} answer
+ * @param {{ task: { wid?: string, short?: string }, run?: { url?: string, agent?: string, kind?: string } | null, already?: string | null }} answer
  */
 export function pullAgentSummary(action, number, { task, run, already }) {
   const id = task.wid ?? task.short;
   if (!run) return `${id} already has it: ${already}.`;
-  const what = action === 'fix' ? `fixing #${number}` : `testing #${number}`;
+  const what =
+    action === 'fix' ? `fixing #${number}` : run.kind === 'pr-review' ? `reviewing #${number}` : `testing #${number}`;
   return `Started ${run.agent ? `${run.agent}, ` : 'an agent '}${what} on ${id}${run.url ? `: ${run.url}` : ''}`;
 }
 

package/scripts/tasks.mjs

@@ -51,6 +51,7 @@ import {
   ideaTask,
   pullAgentRequest,
   pullAgentSummary,
+  reviewRequest,
   staleCliWarning,
   unknownSubcommand,
 } from './tasks/cli.js';
@@ -145,7 +146,9 @@ Reading                (list, next, claim, and add work in this checkout's repos
   routines run <slug>    run one now: makes a RUN task and starts an agent on it  [--note <text>] [--force]
   horizon close          close now: finished tasks go to the archive, next becomes now, later becomes next  [--dry-run]
   github fix <n>         start an agent on a pull request's conflicts, failing checks, or review comments (owner)  [--problem conflicts|failing|review] [--note <text>] [--repo <slug>] [--force]
-  github review <n>      start an agent that tests a Dependabot pull request, as Safe to merge? does (owner)  [--note <text>] [--repo <slug>] [--force]
+  github review <n>      start an agent that reviews a pull request that can merge as it stands, on the task it closes, as
+                         Review with an agent does; on a Dependabot one it tests the update, as Safe to merge? does
+                         (owner)  [--note <text>] [--repo <slug>] [--force]
   github                 the checkout's repository on GitHub: open pull requests, checks, reviews, CI, deploys, alerts  [--sync] [--repo <slug>]
   hook session|wait      the Claude Code session hooks a repository's .claude/settings.json runs (npx breakaway hook session)
   health                 the server's state
@@ -157,6 +160,8 @@ Working
                          refuses another repository's task unless --repo names it
   release <ref>          give it back  [--force]
   comment <ref> <text>   add a comment (signed with your agent name); note is the same command
+  review <ref> --verdict ready|follow-up|changes <note>   your review of the pull request that closes the task you
+                         hold: a comment on it, and the review on the pull request's page (the note is Markdown)  [--pr <n>]
   done <ref>             finish it  [--note <text>] [--pr <url>]
   add <description>      new task; gets the next work ID for its project
     --project <p> --tag <t>… --priority H|M|L --horizon now|next|later
@@ -1076,6 +1081,12 @@ const commands = {
     unmarkSession(task);
     print(task, (t) => `Released ${ref(t)}.`);
   },
+  async review() {
+    const built = reviewRequest(args[0], opts.verdict, args.slice(1).join(' '), { by: agent(), pr: opts.pr });
+    if (built.error || !built.request) fail(built.error ?? 'bad request');
+    const { review, task } = await call(...built.request);
+    print({ review, task }, (r) => `Left your review of #${r.review.pr} on ${ref(r.task)}: ${r.review.label}.`);
+  },
   // The board's `annotate` route is the comments route's alias; using it keeps this working on a board that hasn't deployed /comments yet.
   async comment() {
     const text = args.slice(1).join(' ');

package/src/cli-version.js

@@ -4,5 +4,5 @@
  * and how to update it. scripts/tasks/version.test.js fails when the copied files change and this doesn't:
  * so it lives in the board's package (CLD-135) and the CLI imports it from here.
  */
-export const CLI_VERSION = 52;
-export const CLI_FINGERPRINT = 'b1542857a107623b';
+export const CLI_VERSION = 53;
+export const CLI_FINGERPRINT = '2254d8fb27cd3d52';