brave-real-puppeteer-core 24.25.0 → 24.26.1

package/src/api/Page.ts

@@ -507,7 +507,7 @@ export const enum PageEvent {
   Metrics = 'metrics',
   /**
    * Emitted when an uncaught exception happens within the page. Contains an
-   * `Error`.
+   * `Error` or data of type unknown.
    */
   PageError = 'pageerror',
   /**
@@ -602,7 +602,7 @@ export interface PageEvents extends Record<EventType, unknown> {
   [PageEvent.FrameNavigated]: Frame;
   [PageEvent.Load]: undefined;
   [PageEvent.Metrics]: {title: string; metrics: Metrics};
-  [PageEvent.PageError]: Error;
+  [PageEvent.PageError]: Error | unknown;
   [PageEvent.Popup]: Page | null;
   [PageEvent.Request]: HTTPRequest;
   [PageEvent.Response]: HTTPResponse;

package/src/bidi/Browser.ts

@@ -89,6 +89,8 @@ export class BidiBrowser extends Browser {
         // yet because WebDriver BiDi behavior is not specified. See
         // https://github.com/w3c/webdriver-bidi/issues/321.
         'goog:prerenderingDisabled': true,
+        // TODO: remove after Puppeteer rolled Chrome to 142 after Oct 28, 2025.
+        'goog:disableNetworkDurableMessages': true,
       },
     });
 
@@ -109,20 +111,28 @@ export class BidiBrowser extends Browser {
       }) as [string, ...string[]],
     );
 
-    try {
-      await session.send('network.addDataCollector', {
-        dataTypes: [Bidi.Network.DataType.Response],
-        // Buffer size of 20 MB is equivalent to the CDP:
-        maxEncodedDataSize: 20 * 1000 * 1000, // 20 MB
-      });
-    } catch (err) {
-      if (err instanceof ProtocolError) {
-        // Ignore protocol errors, as the data collectors can be not implemented.
-        debugError(err);
-      } else {
-        throw err;
-      }
-    }
+    await Promise.all(
+      [Bidi.Network.DataType.Request, Bidi.Network.DataType.Response].map(
+        // Data collectors might be not implemented for specific data type, so create them
+        // separately and ignore protocol errors.
+        async dataType => {
+          try {
+            await session.send('network.addDataCollector', {
+              dataTypes: [dataType],
+              // Buffer size of 20 MB is equivalent to the CDP:
+              maxEncodedDataSize: 20_000_000,
+            });
+          } catch (err) {
+            if (err instanceof ProtocolError) {
+              debugError(err);
+            } else {
+              throw err;
+            }
+          }
+        },
+      ),
+    );
+
     const browser = new BidiBrowser(session.browser, opts);
     browser.#initialize();
     return browser;

package/src/bidi/Connection.ts

@@ -88,10 +88,26 @@ export class BidiConnection
     this.#emitters.push(emitter);
   }
 
+  #toWebDriverOnlyEvent(event: Record<string, any>) {
+    for (const key in event) {
+      if (key.startsWith('goog:')) {
+        delete event[key];
+      } else {
+        if (typeof event[key] === 'object' && event[key] !== null) {
+          this.#toWebDriverOnlyEvent(event[key]);
+        }
+      }
+    }
+  }
+
   override emit<Key extends keyof EventsWithWildcard<BidiEvents>>(
     type: Key,
     event: EventsWithWildcard<BidiEvents>[Key],
   ): boolean {
+    if (process.env['PUPPETEER_WEBDRIVER_BIDI_ONLY'] === 'true') {
+      // Required for WebDriver-only testing.
+      this.#toWebDriverOnlyEvent(event);
+    }
     for (const emitter of this.#emitters) {
       emitter.emit(type, event);
     }

package/src/bidi/HTTPRequest.ts

@@ -158,14 +158,11 @@ export class BidiHTTPRequest extends HTTPRequest {
   }
 
   override hasPostData(): boolean {
-    if (!this.#frame.page().browser().cdpSupported) {
-      throw new UnsupportedOperation();
-    }
     return this.#request.hasPostData;
   }
 
   override async fetchPostData(): Promise<string | undefined> {
-    throw new UnsupportedOperation();
+    return await this.#request.fetchPostData();
   }
 
   get #hasInternalHeaderOverwrite(): boolean {
@@ -184,6 +181,7 @@ export class BidiHTTPRequest extends HTTPRequest {
   }
 
   override headers(): Record<string, string> {
+    // Callers should not be allowed to mutate internal structure.
     const headers: Record<string, string> = {};
     for (const header of this.#request.headers) {
       headers[header.name.toLowerCase()] = header.value.value;

package/src/bidi/core/Request.ts

@@ -6,7 +6,7 @@
 
 import * as Bidi from 'webdriver-bidi-protocol';
 
-import {ProtocolError} from '../../common/Errors.js';
+import {ProtocolError, UnsupportedOperation} from '../../common/Errors.js';
 import {EventEmitter} from '../../common/EventEmitter.js';
 import {inertIfDisposed} from '../../util/decorators.js';
 import {DisposableStack, disposeSymbol} from '../../util/disposable.js';
@@ -37,6 +37,7 @@ export class Request extends EventEmitter<{
   }
 
   #responseContentPromise: Promise<Uint8Array<ArrayBufferLike>> | null = null;
+  #requestBodyPromise: Promise<string> | null = null;
   #error?: string;
   #redirect?: Request;
   #response?: Bidi.Network.ResponseData;
@@ -153,7 +154,14 @@ export class Request extends EventEmitter<{
     return this.#event.request.request;
   }
   get initiator(): Bidi.Network.Initiator | undefined {
-    return this.#event.initiator;
+    return {
+      ...this.#event.initiator,
+      // Initiator URL is not specified in BiDi.
+      // @ts-expect-error non-standard property.
+      url: this.#event.request['goog:resourceInitiator']?.url,
+      // @ts-expect-error non-standard property.
+      stack: this.#event.request['goog:resourceInitiator']?.stack,
+    };
   }
   get method(): string {
     return this.#event.request.method;
@@ -195,8 +203,7 @@ export class Request extends EventEmitter<{
   }
 
   get hasPostData(): boolean {
-    // @ts-expect-error non-standard attribute.
-    return this.#event.request['goog:hasPostData'] ?? false;
+    return (this.#event.request.bodySize ?? 0) > 0;
   }
 
   async continueRequest({
@@ -237,6 +244,29 @@ export class Request extends EventEmitter<{
     });
   }
 
+  async fetchPostData(): Promise<string | undefined> {
+    if (!this.hasPostData) {
+      return undefined;
+    }
+    if (!this.#requestBodyPromise) {
+      this.#requestBodyPromise = (async () => {
+        const data = await this.#session.send('network.getData', {
+          dataType: Bidi.Network.DataType.Request,
+          request: this.id,
+        });
+        if (data.result.bytes.type === 'string') {
+          return data.result.bytes.value;
+        }
+
+        // TODO: support base64 response.
+        throw new UnsupportedOperation(
+          `Collected request body data of type ${data.result.bytes.type} is not supported`,
+        );
+      })();
+    }
+    return await this.#requestBodyPromise;
+  }
+
   async getResponseContent(): Promise<Uint8Array> {
     if (!this.#responseContentPromise) {
       this.#responseContentPromise = (async () => {
@@ -258,7 +288,7 @@ export class Request extends EventEmitter<{
             )
           ) {
             throw new ProtocolError(
-              'Could not load body for this request. This might happen if the request is a preflight request.',
+              'Could not load response body for this request. This might happen if the request is a preflight request.',
             );
           }
 

package/src/cdp/Accessibility.ts

@@ -76,6 +76,11 @@ export interface SerializedAXNode {
    */
   invalid?: string;
   orientation?: string;
+
+  /**
+   * Url for link elements.
+   */
+  url?: string;
   /**
    * Children of this node, if there are any.
    */
@@ -460,12 +465,32 @@ class AXNode {
     }
   }
 
+  public isLandmark(): boolean {
+    switch (this.#role) {
+      case 'banner':
+      case 'complementary':
+      case 'contentinfo':
+      case 'form':
+      case 'main':
+      case 'navigation':
+      case 'region':
+      case 'search':
+        return true;
+      default:
+        return false;
+    }
+  }
+
   public isInteresting(insideControl: boolean): boolean {
     const role = this.#role;
     if (role === 'Ignored' || this.#hidden || this.#ignored) {
       return false;
     }
 
+    if (this.isLandmark()) {
+      return true;
+    }
+
     if (this.#focusable || this.#richlyEditable) {
       return true;
     }
@@ -522,7 +547,8 @@ class AXNode {
       | 'description'
       | 'keyshortcuts'
       | 'roledescription'
-      | 'valuetext';
+      | 'valuetext'
+      | 'url';
 
     const userStringProperties: UserStringProperty[] = [
       'name',
@@ -531,6 +557,7 @@ class AXNode {
       'keyshortcuts',
       'roledescription',
       'valuetext',
+      'url',
     ];
     const getUserStringPropertyValue = (key: UserStringProperty): string => {
       return properties.get(key) as string;

package/src/cdp/ExecutionContext.ts

@@ -597,7 +597,9 @@ export class ExecutionContext
       }
 
       if (returnByValue) {
-        return valueFromRemoteObject(remoteObject);
+        return valueFromRemoteObject(remoteObject) as HandleFor<
+          Awaited<ReturnType<Func>>
+        >;
       }
 
       return this.#world.createCdpHandle(remoteObject) as HandleFor<
@@ -649,7 +651,9 @@ export class ExecutionContext
     }
 
     if (returnByValue) {
-      return valueFromRemoteObject(remoteObject);
+      return valueFromRemoteObject(remoteObject) as unknown as HandleFor<
+        Awaited<ReturnType<Func>>
+      >;
     }
 
     return this.#world.createCdpHandle(remoteObject) as HandleFor<

package/src/cdp/HTTPRequest.ts

@@ -138,7 +138,8 @@ export class CdpHTTPRequest extends HTTPRequest {
   }
 
   override headers(): Record<string, string> {
-    return this.#headers;
+    // Callers should not be allowed to mutate internal structure.
+    return structuredClone(this.#headers);
   }
 
   override response(): CdpHTTPResponse | null {

package/src/cdp/HTTPResponse.ts

@@ -139,7 +139,7 @@ export class CdpHTTPResponse extends HTTPResponse {
                 'No resource with given identifier found'
             ) {
               throw new ProtocolError(
-                'Could not load body for this request. This might happen if the request is a preflight request.',
+                'Could not load response body for this request. This might happen if the request is a preflight request.',
               );
             }
 

package/src/cdp/JSHandle.ts

@@ -45,7 +45,7 @@ export class CdpJSHandle<T = unknown> extends JSHandle<T> {
 
   override async jsonValue(): Promise<T> {
     if (!this.#remoteObject.objectId) {
-      return valueFromRemoteObject(this.#remoteObject);
+      return valueFromRemoteObject(this.#remoteObject) as T;
     }
     const value = await this.evaluate(object => {
       return object;

package/src/cdp/Page.ts

@@ -859,7 +859,7 @@ export class CdpPage extends Page {
     }
     const textTokens = [];
     // eslint-disable-next-line max-len -- The comment is long.
-    // eslint-disable-next-line rulesdir/use-using -- These are not owned by this function.
+    // eslint-disable-next-line @puppeteer/use-using -- These are not owned by this function.
     for (const arg of args) {
       const remoteObject = arg.remoteObject();
       if (remoteObject.objectId) {

package/src/cdp/utils.ts

@@ -94,7 +94,7 @@ const getErrorDetails = (details: Protocol.Runtime.ExceptionDetails) => {
  */
 export function createClientError(
   details: Protocol.Runtime.ExceptionDetails,
-): Error {
+): Error | unknown {
   let name: string;
   let message: string;
   if (!details.exception) {
@@ -141,7 +141,7 @@ export function createClientError(
  */
 export function valueFromRemoteObject(
   remoteObject: Protocol.Runtime.RemoteObject,
-): any {
+): unknown {
   assert(!remoteObject.objectId, 'Cannot extract value when objectId is given');
   if (remoteObject.unserializableValue) {
     if (remoteObject.type === 'bigint') {

package/src/revisions.ts

@@ -8,7 +8,7 @@
  * @internal
  */
 export const PUPPETEER_REVISIONS = Object.freeze({
-  chrome: '141.0.7390.78',
-  'chrome-headless-shell': '141.0.7390.78',
+  chrome: '141.0.7390.122',
+  'chrome-headless-shell': '141.0.7390.122',
   firefox: 'stable_144.0',
 });

package/src/util/version.ts

@@ -6,5 +6,5 @@
 
 // If moved update release-please config
 // x-release-please-start-version
-export const packageVersion = '24.25.0';
+export const packageVersion = '24.26.1';
 // x-release-please-end