brave-real-playwright-core 1.56.1-patch.1 → 1.57.0-patch.1

package/lib/server/bidi/bidiBrowser.js

@@ -62,12 +62,16 @@ class BidiBrowser extends import_browser.Browser {
     browser._bidiSessionInfo = await browser._browserSession.send("session.new", {
       capabilities: {
         alwaysMatch: {
-          acceptInsecureCerts: options.persistent?.internalIgnoreHTTPSErrors || options.persistent?.ignoreHTTPSErrors,
-          proxy: getProxyConfiguration(options.originalLaunchOptions.proxyOverride ?? options.proxy),
-          unhandledPromptBehavior: {
+          "acceptInsecureCerts": options.persistent?.internalIgnoreHTTPSErrors || options.persistent?.ignoreHTTPSErrors,
+          "proxy": getProxyConfiguration(options.originalLaunchOptions.proxyOverride ?? options.proxy),
+          "unhandledPromptBehavior": {
             default: bidi.Session.UserPromptHandlerType.Ignore
           },
-          webSocketUrl: true
+          "webSocketUrl": true,
+          // Chrome with WebDriver BiDi does not support prerendering
+          // yet because WebDriver BiDi behavior is not specified. See
+          // https://github.com/w3c/webdriver-bidi/issues/321.
+          "goog:prerenderingDisabled": true
         }
       }
     });
@@ -76,7 +80,8 @@ class BidiBrowser extends import_browser.Browser {
         "browsingContext",
         "network",
         "log",
-        "script"
+        "script",
+        "input"
       ]
     });
     await browser._browserSession.send("network.addDataCollector", {
@@ -122,16 +127,13 @@ class BidiBrowser extends import_browser.Browser {
   _onBrowsingContextCreated(event) {
     if (event.parent) {
       const parentFrameId = event.parent;
-      for (const page2 of this._bidiPages.values()) {
-        const parentFrame = page2._page.frameManager.frame(parentFrameId);
-        if (!parentFrame)
-          continue;
+      const page2 = this._findPageForFrame(parentFrameId);
+      if (page2) {
         page2._session.addFrameBrowsingContext(event.context);
         page2._page.frameManager.frameAttached(event.context, parentFrameId);
         const frame = page2._page.frameManager.frame(event.context);
         if (frame)
           frame._url = event.url;
-        return;
       }
       return;
     }
@@ -141,7 +143,7 @@ class BidiBrowser extends import_browser.Browser {
     if (!context)
       return;
     const session = this._connection.createMainFrameBrowsingContextSession(event.context);
-    const opener = event.originalOpener && this._bidiPages.get(event.originalOpener);
+    const opener = event.originalOpener && this._findPageForFrame(event.originalOpener);
     const page = new import_bidiPage.BidiPage(context, session, opener || null);
     page._page.mainFrame()._url = event.url;
     this._bidiPages.set(event.context, page);
@@ -171,6 +173,12 @@ class BidiBrowser extends import_browser.Browser {
         return;
     }
   }
+  _findPageForFrame(frameId) {
+    for (const page of this._bidiPages.values()) {
+      if (page._page.frameManager.frame(frameId))
+        return page;
+    }
+  }
 }
 class BidiBrowserContext extends import_browserContext.BrowserContext {
   constructor(browser, browserContextId, options) {
@@ -207,6 +215,8 @@ class BidiBrowserContext extends import_browserContext.BrowserContext {
         userContexts: [this._userContextId()]
       }));
     }
+    if (this._options.extraHTTPHeaders)
+      promises.push(this.doUpdateExtraHTTPHeaders());
     await Promise.all(promises);
   }
   possiblyUninitializedPages() {
@@ -300,6 +310,11 @@ class BidiBrowserContext extends import_browserContext.BrowserContext {
     });
   }
   async doUpdateExtraHTTPHeaders() {
+    const allHeaders = this._options.extraHTTPHeaders || [];
+    await this._browser._browserSession.send("network.setExtraHeaders", {
+      headers: allHeaders.map(({ name, value }) => ({ name, value: { type: "string", value } })),
+      userContexts: [this._userContextId()]
+    });
   }
   async setUserAgent(userAgent) {
     this._options.userAgent = userAgent;

package/lib/server/bidi/bidiChromium.js

@@ -40,7 +40,7 @@ var import_chromiumSwitches = require("../chromium/chromiumSwitches");
 var import_chromium = require("../chromium/chromium");
 class BidiChromium extends import_browserType.BrowserType {
   constructor(parent) {
-    super(parent, "_bidiChromium");
+    super(parent, "chromium");
   }
   async connectToTransport(transport, options, browserLogsCollector) {
     const bidiTransport = await require("./bidiOverCdp").connectBidiOverCdp(transport);

package/lib/server/bidi/bidiFirefox.js

@@ -41,7 +41,7 @@ var import_firefoxPrefs = require("./third_party/firefoxPrefs");
 var import_manualPromise = require("../../utils/isomorphic/manualPromise");
 class BidiFirefox extends import_browserType.BrowserType {
   constructor(parent) {
-    super(parent, "_bidiFirefox");
+    super(parent, "firefox");
   }
   executablePath() {
     return "";

package/lib/server/bidi/bidiPage.js

@@ -42,6 +42,7 @@ var import_bidiInput = require("./bidiInput");
 var import_bidiNetworkManager = require("./bidiNetworkManager");
 var import_bidiPdf = require("./bidiPdf");
 var bidi = __toESM(require("./third_party/bidiProtocol"));
+var network = __toESM(require("../network"));
 const UTILITY_WORLD_NAME = "__playwright_utility_world__";
 const kPlaywrightBindingChannel = "playwrightChannel";
 class BidiPage {
@@ -75,7 +76,8 @@ class BidiPage {
       import_eventsHelper.eventsHelper.addEventListener(bidiSession, "browsingContext.downloadWillBegin", this._onDownloadWillBegin.bind(this)),
       import_eventsHelper.eventsHelper.addEventListener(bidiSession, "browsingContext.downloadEnd", this._onDownloadEnded.bind(this)),
       import_eventsHelper.eventsHelper.addEventListener(bidiSession, "browsingContext.userPromptOpened", this._onUserPromptOpened.bind(this)),
-      import_eventsHelper.eventsHelper.addEventListener(bidiSession, "log.entryAdded", this._onLogEntryAdded.bind(this))
+      import_eventsHelper.eventsHelper.addEventListener(bidiSession, "log.entryAdded", this._onLogEntryAdded.bind(this)),
+      import_eventsHelper.eventsHelper.addEventListener(bidiSession, "input.fileDialogOpened", this._onFileDialogOpened.bind(this))
     ];
     this._initialize().then(
       () => this._page.reportAsNew(this._opener?._page),
@@ -113,6 +115,7 @@ class BidiPage {
       const delegate2 = new import_bidiExecutionContext.BidiExecutionContext(this._session, realmInfo);
       const worker = new import_page.Worker(this._page, realmInfo.origin);
       this._realmToWorkerContext.set(realmInfo.realm, worker.createExecutionContext(delegate2));
+      worker.workerScriptLoaded();
       this._page.addWorker(realmInfo.realm, worker);
       return;
     }
@@ -260,7 +263,17 @@ ${params.stackTrace?.callFrames.map((f) => {
       return;
     const callFrame = params.stackTrace?.callFrames[0];
     const location = callFrame ?? { url: "", lineNumber: 1, columnNumber: 1 };
-    this._page.addConsoleMessage(entry.method, entry.args.map((arg) => (0, import_bidiExecutionContext.createHandle)(context, arg)), location, params.text || void 0);
+    this._page.addConsoleMessage(null, entry.method, entry.args.map((arg) => (0, import_bidiExecutionContext.createHandle)(context, arg)), location, params.text || void 0);
+  }
+  async _onFileDialogOpened(params) {
+    if (!params.element)
+      return;
+    const frame = this._page.frameManager.frame(params.context);
+    if (!frame)
+      return;
+    const executionContext = await frame._mainContext();
+    const handle = await toBidiExecutionContext(executionContext).remoteObjectForNodeId(executionContext, { sharedId: params.element.sharedId });
+    await this._page._onFileChooserOpened(handle);
   }
   async navigateFrame(frame, url, referrer) {
     const { navigation } = await this._session.send("browsingContext.navigate", {
@@ -270,6 +283,14 @@ ${params.stackTrace?.callFrames.map((f) => {
     return { newDocumentId: navigation || void 0 };
   }
   async updateExtraHTTPHeaders() {
+    const allHeaders = network.mergeHeaders([
+      this._browserContext._options.extraHTTPHeaders,
+      this._page.extraHTTPHeaders()
+    ]);
+    await this._session.send("network.setExtraHeaders", {
+      headers: allHeaders.map(({ name, value }) => ({ name, value: { type: "string", value } })),
+      contexts: [this._session.sessionId]
+    });
   }
   async updateEmulateMedia() {
   }
@@ -379,6 +400,8 @@ ${params.stackTrace?.callFrames.map((f) => {
     }
   }
   async setBackgroundColor(color) {
+    if (color)
+      throw new Error("Not implemented");
   }
   async takeScreenshot(progress, format, documentRect, viewportRect, quality, fitsViewport, scale) {
     const rect = documentRect || viewportRect;
@@ -503,9 +526,6 @@ ${params.stackTrace?.callFrames.map((f) => {
     const executionContext = toBidiExecutionContext(to);
     return await executionContext.remoteObjectForNodeId(to, nodeId);
   }
-  async getAccessibilityTree(needle) {
-    throw new Error("Method not implemented.");
-  }
   async inputActionEpilogue() {
   }
   async resetForReuse(progress) {

package/lib/server/browserContext.js

@@ -69,7 +69,6 @@ class BrowserContext extends import_instrumentation.SdkObject {
     this._creatingStorageStatePage = false;
     this.initScripts = [];
     this._routesInFlight = /* @__PURE__ */ new Set();
-    this._playwrightBindingExposed = false;
     this.attribution.context = this;
     this._browser = browser;
     this._options = options;
@@ -231,17 +230,17 @@ if (navigator.serviceWorker) navigator.serviceWorker.register = async () => { co
     return this._pageBindings.get(name)?.forClient;
   }
   async exposePlaywrightBindingIfNeeded() {
-    if (this._playwrightBindingExposed)
-      return;
-    this._playwrightBindingExposed = true;
-    await this.doExposePlaywrightBinding();
-    this.bindingsInitScript = import_page2.PageBinding.createInitScript();
-    this.initScripts.push(this.bindingsInitScript);
-    await this.doAddInitScript(this.bindingsInitScript);
-    await this.safeNonStallingEvaluateInAllFrames(this.bindingsInitScript.source, "main");
+    this._playwrightBindingExposed ??= (async () => {
+      await this.doExposePlaywrightBinding();
+      this.bindingsInitScript = import_page2.PageBinding.createInitScript();
+      this.initScripts.push(this.bindingsInitScript);
+      await this.doAddInitScript(this.bindingsInitScript);
+      await this.safeNonStallingEvaluateInAllFrames(this.bindingsInitScript.source, "main");
+    })();
+    return await this._playwrightBindingExposed;
   }
   needsPlaywrightBinding() {
-    return this._playwrightBindingExposed;
+    return this._playwrightBindingExposed !== void 0;
   }
   async exposeBinding(progress, name, needsHandle, playwrightBinding, forClient) {
     if (this._pageBindings.has(name))

package/lib/server/chromium/chromium.js

@@ -55,11 +55,22 @@ var import_fileUtils = require("../utils/fileUtils");
 var import_processLauncher = require("../utils/processLauncher");
 const ARTIFACTS_FOLDER = import_path.default.join(import_os.default.tmpdir(), "playwright-artifacts-");
 class Chromium extends import_browserType.BrowserType {
-  constructor(parent) {
+  constructor(parent, bidiChromium) {
     super(parent, "chromium");
+    this._bidiChromium = bidiChromium;
     if ((0, import_utils.debugMode)() === "inspector")
       this._devtools = this._createDevTools();
   }
+  launch(progress, options, protocolLogger) {
+    if (options.channel?.startsWith("bidi-"))
+      return this._bidiChromium.launch(progress, options, protocolLogger);
+    return super.launch(progress, options, protocolLogger);
+  }
+  async launchPersistentContext(progress, userDataDir, options) {
+    if (options.channel?.startsWith("bidi-"))
+      return this._bidiChromium.launchPersistentContext(progress, userDataDir, options);
+    return super.launchPersistentContext(progress, userDataDir, options);
+  }
   async connectOverCDP(progress, endpointURL, options) {
     return await this._connectOverCDPInternal(progress, endpointURL, options);
   }

package/lib/server/chromium/chromiumSwitches.js

@@ -46,9 +46,11 @@ const disabledFeatures = (assistantMode) => [
   "AutoDeElevate",
   // See https://github.com/microsoft/playwright/issues/37714
   "RenderDocument",
+  // Prevents downloading optimization hints on startup.
+  "OptimizationHints",
   assistantMode ? "AutomationControlled" : ""
 ].filter(Boolean);
-const chromiumSwitches = (assistantMode, channel) => [
+const chromiumSwitches = (assistantMode, channel, android) => [
   "--disable-field-trial-config",
   // https://source.chromium.org/chromium/chromium/src/+/main:testing/variations/README.md
   "--disable-background-networking",
@@ -87,7 +89,14 @@ const chromiumSwitches = (assistantMode, channel) => [
   "--unsafely-disable-devtools-self-xss-warnings",
   // Edge can potentially restart on Windows (msRelaunchNoCompatLayer) which looses its file descriptors (stdout/stderr) and CDP (3/4). Disable until fixed upstream.
   "--edge-skip-compat-layer-relaunch",
-  assistantMode ? "" : "--enable-automation"
+  assistantMode ? "" : "--enable-automation",
+  // This disables Chrome for Testing infobar that is visible in the persistent context.
+  // The switch is ignored everywhere else, including Chromium/Chrome/Edge.
+  "--disable-infobars",
+  // Less annoying popups.
+  "--disable-search-engine-choice-screen",
+  // Prevents the "three dots" menu crash in IdentityManager::HasPrimaryAccount for ephemeral contexts.
+  android ? "" : "--disable-sync"
 ].filter(Boolean);
 // Annotate the CommonJS export names for ESM import in node:
 0 && (module.exports = {

package/lib/server/chromium/crBrowser.js

@@ -53,6 +53,7 @@ class CRBrowser extends import_browser.Browser {
     this._crPages = /* @__PURE__ */ new Map();
     this._serviceWorkers = /* @__PURE__ */ new Map();
     this._version = "";
+    this._majorVersion = 0;
     this._tracingRecording = false;
     this._userAgent = "";
     this._connection = connection;
@@ -75,6 +76,10 @@ class CRBrowser extends import_browser.Browser {
       await options.__testHookOnConnectToBrowser();
     const version = await session.send("Browser.getVersion");
     browser._version = version.product.substring(version.product.indexOf("/") + 1);
+    try {
+      browser._majorVersion = +browser._version.split(".")[0];
+    } catch {
+    }
     browser._userAgent = version.userAgent;
     browser.options.headful = !version.userAgent.includes("Headless");
     if (!options.persistent) {
@@ -116,6 +121,9 @@ class CRBrowser extends import_browser.Browser {
   version() {
     return this._version;
   }
+  majorVersion() {
+    return this._majorVersion;
+  }
   userAgent() {
     return this._userAgent;
   }

package/lib/server/chromium/crPage.js

@@ -43,7 +43,6 @@ var import_helper = require("../helper");
 var network = __toESM(require("../network"));
 var import_page = require("../page");
 var import_registry = require("../registry");
-var import_crAccessibility = require("./crAccessibility");
 var import_crCoverage = require("./crCoverage");
 var import_crDragDrop = require("./crDragDrop");
 var import_crExecutionContext = require("./crExecutionContext");
@@ -268,9 +267,6 @@ class CRPage {
   async adoptElementHandle(handle, to) {
     return this._sessionForHandle(handle)._adoptElementHandle(handle, to);
   }
-  async getAccessibilityTree(needle) {
-    return (0, import_crAccessibility.getAccessibilityTree)(this._mainFrameSession._client, needle);
-  }
   async inputActionEpilogue() {
     await this._mainFrameSession._client.send("Page.enable").catch((e) => {
     });
@@ -620,6 +616,10 @@ class FrameSession {
     session.once("Runtime.executionContextCreated", async (event2) => {
       worker.createExecutionContext(new import_crExecutionContext.CRExecutionContext(session, event2.context));
     });
+    if (this._crPage._browserContext._browser.majorVersion() >= 143)
+      session.on("Inspector.workerScriptLoaded", () => worker.workerScriptLoaded());
+    else
+      worker.workerScriptLoaded();
     session._sendMayFail("Runtime.enable");
     this._crPage._networkManager.addSession(session, this._page.frameManager.frame(this._targetId) ?? void 0).catch(() => {
     });
@@ -629,7 +629,7 @@ class FrameSession {
     session.on("Target.detachedFromTarget", (event2) => this._onDetachedFromTarget(event2));
     session.on("Runtime.consoleAPICalled", (event2) => {
       const args = event2.args.map((o) => (0, import_crExecutionContext.createHandle)(worker.existingExecutionContext, o));
-      this._page.addConsoleMessage(event2.type, args, (0, import_crProtocolHelper.toConsoleMessageLocation)(event2.stackTrace));
+      this._page.addConsoleMessage(worker, event2.type, args, (0, import_crProtocolHelper.toConsoleMessageLocation)(event2.stackTrace));
     });
     session.on("Runtime.exceptionThrown", (exception) => this._page.addPageError((0, import_crProtocolHelper.exceptionToError)(exception.exceptionDetails)));
   }
@@ -664,7 +664,7 @@ class FrameSession {
     if (!context)
       return;
     const values = event.args.map((arg) => (0, import_crExecutionContext.createHandle)(context, arg));
-    this._page.addConsoleMessage(event.type, values, (0, import_crProtocolHelper.toConsoleMessageLocation)(event.stackTrace));
+    this._page.addConsoleMessage(null, event.type, values, (0, import_crProtocolHelper.toConsoleMessageLocation)(event.stackTrace));
   }
   async _onBindingCalled(event) {
     const pageOrError = await this._crPage._page.waitForInitializedOrError();
@@ -706,7 +706,7 @@ class FrameSession {
         lineNumber: lineNumber || 0,
         columnNumber: 0
       };
-      this._page.addConsoleMessage(level, [], location, text);
+      this._page.addConsoleMessage(null, level, [], location, text);
     }
   }
   async _onFileChooserOpened(event) {

package/lib/server/chromium/crServiceWorker.js

@@ -36,16 +36,22 @@ var import_crExecutionContext = require("./crExecutionContext");
 var import_crNetworkManager = require("./crNetworkManager");
 var import_browserContext = require("../browserContext");
 var network = __toESM(require("../network"));
+var import_console = require("../console");
+var import_crProtocolHelper = require("./crProtocolHelper");
 class CRServiceWorker extends import_page.Worker {
   constructor(browserContext, session, url) {
     super(browserContext, url);
     this._session = session;
     this.browserContext = browserContext;
-    if (!!process.env.PW_EXPERIMENTAL_SERVICE_WORKER_NETWORK_EVENTS)
+    if (!process.env.PLAYWRIGHT_DISABLE_SERVICE_WORKER_NETWORK)
       this._networkManager = new import_crNetworkManager.CRNetworkManager(null, this);
     session.once("Runtime.executionContextCreated", (event) => {
       this.createExecutionContext(new import_crExecutionContext.CRExecutionContext(session, event.context));
     });
+    if (this.browserContext._browser.majorVersion() >= 143)
+      session.on("Inspector.workerScriptLoaded", () => this.workerScriptLoaded());
+    else
+      this.workerScriptLoaded();
     if (this._networkManager && this._isNetworkInspectionEnabled()) {
       this.updateRequestInterception();
       this.updateExtraHTTPHeaders();
@@ -59,10 +65,15 @@ class CRServiceWorker extends import_page.Worker {
       ).catch(() => {
       });
     }
-    if (process.env["REBROWSER_PATCHES_RUNTIME_FIX_MODE"] === "0") {
-      session.send("Runtime.enable", {}).catch((e) => {
-      });
-    }
+    session.on("Runtime.consoleAPICalled", (event) => {
+      if (!this.existingExecutionContext || process.env.PLAYWRIGHT_DISABLE_SERVICE_WORKER_CONSOLE)
+        return;
+      const args = event.args.map((o) => (0, import_crExecutionContext.createHandle)(this.existingExecutionContext, o));
+      const message = new import_console.ConsoleMessage(null, this, event.type, void 0, args, (0, import_crProtocolHelper.toConsoleMessageLocation)(event.stackTrace));
+      this.browserContext.emit(import_browserContext.BrowserContext.Events.Console, message);
+    });
+    session.send("Runtime.enable", {}).catch((e) => {
+    });
     session.send("Runtime.runIfWaitingForDebugger").catch((e) => {
     });
     session.on("Inspector.targetReloadedAfterCrash", () => {

package/lib/server/chromium/videoRecorder.js

@@ -30,9 +30,9 @@ class VideoRecorder {
     this._process = null;
     this._gracefullyClose = null;
     this._lastWritePromise = Promise.resolve();
-    this._lastFrameTimestamp = 0;
-    this._lastFrameBuffer = null;
-    this._lastWriteTimestamp = 0;
+    this._firstFrameTimestamp = 0;
+    this._lastFrame = null;
+    this._lastWriteNodeTime = 0;
     this._frameQueue = [];
     this._isStopped = false;
     this._ffmpegPath = ffmpegPath;
@@ -77,16 +77,17 @@ class VideoRecorder {
     (0, import_utils.assert)(this._process);
     if (this._isStopped)
       return;
-    if (this._lastFrameBuffer) {
-      const durationSec = timestamp - this._lastFrameTimestamp;
-      const repeatCount = Math.max(1, Math.round(fps * durationSec));
+    if (!this._firstFrameTimestamp)
+      this._firstFrameTimestamp = timestamp;
+    const frameNumber = Math.floor((timestamp - this._firstFrameTimestamp) * fps);
+    if (this._lastFrame) {
+      const repeatCount = frameNumber - this._lastFrame.frameNumber;
       for (let i = 0; i < repeatCount; ++i)
-        this._frameQueue.push(this._lastFrameBuffer);
+        this._frameQueue.push(this._lastFrame.buffer);
       this._lastWritePromise = this._lastWritePromise.then(() => this._sendFrames());
     }
-    this._lastFrameBuffer = frame;
-    this._lastFrameTimestamp = timestamp;
-    this._lastWriteTimestamp = (0, import_utils.monotonicTime)();
+    this._lastFrame = { buffer: frame, timestamp, frameNumber };
+    this._lastWriteNodeTime = (0, import_utils.monotonicTime)();
   }
   async _sendFrames() {
     while (this._frameQueue.length)
@@ -99,9 +100,10 @@ class VideoRecorder {
     });
   }
   async stop() {
-    if (this._isStopped)
+    if (this._isStopped || !this._lastFrame)
       return;
-    this.writeFrame(Buffer.from([]), this._lastFrameTimestamp + ((0, import_utils.monotonicTime)() - this._lastWriteTimestamp) / 1e3);
+    const addTime = Math.max(((0, import_utils.monotonicTime)() - this._lastWriteNodeTime) / 1e3, 1);
+    this.writeFrame(Buffer.from([]), this._lastFrame.timestamp + addTime);
     this._isStopped = true;
     await this._lastWritePromise;
     await this._gracefullyClose();

package/lib/server/console.js

@@ -22,8 +22,9 @@ __export(console_exports, {
 });
 module.exports = __toCommonJS(console_exports);
 class ConsoleMessage {
-  constructor(page, type, text, args, location) {
+  constructor(page, worker, type, text, args, location) {
     this._page = page;
+    this._worker = worker;
     this._type = type;
     this._text = text;
     this._args = args;
@@ -32,6 +33,9 @@ class ConsoleMessage {
   page() {
     return this._page;
   }
+  worker() {
+    return this._worker;
+  }
   type() {
     return this._type;
   }