brave-real-playwright-core 1.55.1 → 1.56.1

package/lib/server/bidi/bidiBrowser.js

@@ -30,7 +30,8 @@ var bidiBrowser_exports = {};
 __export(bidiBrowser_exports, {
   BidiBrowser: () => BidiBrowser,
   BidiBrowserContext: () => BidiBrowserContext,
-  Network: () => Network
+  Network: () => Network,
+  getScreenOrientation: () => getScreenOrientation
 });
 module.exports = __toCommonJS(bidiBrowser_exports);
 var import_eventsHelper = require("../utils/eventsHelper");
@@ -78,6 +79,11 @@ class BidiBrowser extends import_browser.Browser {
         "script"
       ]
     });
+    await browser._browserSession.send("network.addDataCollector", {
+      dataTypes: [bidi.Network.DataType.Response],
+      maxEncodedDataSize: 2e7
+      // same default as in CDP: https://source.chromium.org/chromium/chromium/src/+/main:third_party/blink/renderer/core/inspector/inspector_network_agent.cc;l=134;drc=4128411589187a396829a827f59a655bed876aa7
+    });
     if (options.persistent) {
       const context = new BidiBrowserContext(browser, void 0, options.persistent);
       browser._defaultContext = context;
@@ -189,6 +195,18 @@ class BidiBrowserContext extends import_browserContext.BrowserContext {
         userContexts: [this._userContextId()]
       }));
     }
+    if (this._options.timezoneId) {
+      promises.push(this._browser._browserSession.send("emulation.setTimezoneOverride", {
+        timezone: this._options.timezoneId,
+        userContexts: [this._userContextId()]
+      }));
+    }
+    if (this._options.userAgent) {
+      promises.push(this._browser._browserSession.send("emulation.setUserAgentOverride", {
+        userAgent: this._options.userAgent,
+        userContexts: [this._userContextId()]
+      }));
+    }
     await Promise.all(promises);
   }
   possiblyUninitializedPages() {
@@ -284,6 +302,11 @@ class BidiBrowserContext extends import_browserContext.BrowserContext {
   async doUpdateExtraHTTPHeaders() {
   }
   async setUserAgent(userAgent) {
+    this._options.userAgent = userAgent;
+    await this._browser._browserSession.send("emulation.setUserAgentOverride", {
+      userAgent: userAgent ?? null,
+      userContexts: [this._userContextId()]
+    });
   }
   async doUpdateOffline() {
   }
@@ -315,14 +338,20 @@ class BidiBrowserContext extends import_browserContext.BrowserContext {
   async doUpdateDefaultViewport() {
     if (!this._options.viewport)
       return;
-    await this._browser._browserSession.send("browsingContext.setViewport", {
-      viewport: {
-        width: this._options.viewport.width,
-        height: this._options.viewport.height
-      },
-      devicePixelRatio: this._options.deviceScaleFactor || 1,
-      userContexts: [this._userContextId()]
-    });
+    await Promise.all([
+      this._browser._browserSession.send("browsingContext.setViewport", {
+        viewport: {
+          width: this._options.viewport.width,
+          height: this._options.viewport.height
+        },
+        devicePixelRatio: this._options.deviceScaleFactor || 1,
+        userContexts: [this._userContextId()]
+      }),
+      this._browser._browserSession.send("emulation.setScreenOrientationOverride", {
+        screenOrientation: getScreenOrientation(!!this._options.isMobile, this._options.viewport),
+        userContexts: [this._userContextId()]
+      })
+    ]);
   }
   async doUpdateDefaultEmulatedMedia() {
   }
@@ -385,6 +414,8 @@ function fromBidiSameSite(sameSite) {
       return "Lax";
     case "none":
       return "None";
+    case "default":
+      return "Lax";
   }
   return "None";
 }
@@ -429,6 +460,18 @@ function getProxyConfiguration(proxySettings) {
     proxy.noProxy = bypass.split(",");
   return proxy;
 }
+function getScreenOrientation(isMobile, viewportSize) {
+  const screenOrientation = {
+    type: "landscape-primary",
+    natural: bidi.Emulation.ScreenOrientationNatural.Landscape
+  };
+  if (isMobile) {
+    screenOrientation.natural = bidi.Emulation.ScreenOrientationNatural.Portrait;
+    if (viewportSize.width <= viewportSize.height)
+      screenOrientation.type = "portrait-primary";
+  }
+  return screenOrientation;
+}
 var Network;
 ((Network2) => {
   let SameSite;
@@ -442,5 +485,6 @@ var Network;
 0 && (module.exports = {
   BidiBrowser,
   BidiBrowserContext,
-  Network
+  Network,
+  getScreenOrientation
 });

package/lib/server/bidi/bidiChromium.js

@@ -86,7 +86,7 @@ class BidiChromium extends import_browserType.BrowserType {
   supportsPipeTransport() {
     return false;
   }
-  defaultArgs(options, isPersistent, userDataDir) {
+  async defaultArgs(options, isPersistent, userDataDir) {
     const chromeArguments = this._innerDefaultArgs(options);
     chromeArguments.push(`--user-data-dir=${userDataDir}`);
     chromeArguments.push("--remote-debugging-port=0");

package/lib/server/bidi/bidiConnection.js

@@ -20,19 +20,24 @@ var bidiConnection_exports = {};
 __export(bidiConnection_exports, {
   BidiConnection: () => BidiConnection,
   BidiSession: () => BidiSession,
-  kBrowserCloseMessageId: () => kBrowserCloseMessageId
+  kBrowserCloseMessageId: () => kBrowserCloseMessageId,
+  kShutdownSessionNewMessageId: () => kShutdownSessionNewMessageId
 });
 module.exports = __toCommonJS(bidiConnection_exports);
 var import_events = require("events");
 var import_debugLogger = require("../utils/debugLogger");
 var import_helper = require("../helper");
 var import_protocolError = require("../protocolError");
-const kBrowserCloseMessageId = 0;
+const kBrowserCloseMessageId = Number.MAX_SAFE_INTEGER - 1;
+const kShutdownSessionNewMessageId = kBrowserCloseMessageId - 1;
 class BidiConnection {
   constructor(transport, onDisconnect, protocolLogger, browserLogsCollector) {
     this._lastId = 0;
     this._closed = false;
     this._browsingContextToSession = /* @__PURE__ */ new Map();
+    this._realmToBrowsingContext = /* @__PURE__ */ new Map();
+    // TODO: shared/service workers might have multiple owner realms.
+    this._realmToOwnerRealm = /* @__PURE__ */ new Map();
     this._transport = transport;
     this._onDisconnect = onDisconnect;
     this._protocolLogger = protocolLogger;
@@ -54,11 +59,30 @@ class BidiConnection {
     this._protocolLogger("receive", message);
     const object = message;
     if (object.type === "event") {
+      if (object.method === "script.realmCreated") {
+        if ("context" in object.params)
+          this._realmToBrowsingContext.set(object.params.realm, object.params.context);
+        if (object.params.type === "dedicated-worker")
+          this._realmToOwnerRealm.set(object.params.realm, object.params.owners[0]);
+      } else if (object.method === "script.realmDestroyed") {
+        this._realmToBrowsingContext.delete(object.params.realm);
+        this._realmToOwnerRealm.delete(object.params.realm);
+      }
       let context;
-      if ("context" in object.params)
+      let realm;
+      if ("context" in object.params) {
         context = object.params.context;
-      else if (object.method === "log.entryAdded" || object.method === "script.message")
+      } else if (object.method === "log.entryAdded" || object.method === "script.message") {
         context = object.params.source?.context;
+        realm = object.params.source?.realm;
+      } else if (object.method === "script.realmCreated" && object.params.type === "dedicated-worker") {
+        realm = object.params.owners[0];
+      }
+      if (!context && realm) {
+        while (this._realmToOwnerRealm.get(realm))
+          realm = this._realmToOwnerRealm.get(realm);
+        context = this._realmToBrowsingContext.get(realm);
+      }
       if (context) {
         const session = this._browsingContextToSession.get(context);
         if (session) {
@@ -159,7 +183,7 @@ class BidiSession extends import_events.EventEmitter {
   }
   dispatchMessage(message) {
     const object = message;
-    if (object.id === kBrowserCloseMessageId)
+    if (object.id === kBrowserCloseMessageId || object.id === kShutdownSessionNewMessageId)
       return;
     if (object.id && this._callbacks.has(object.id)) {
       const callback = this._callbacks.get(object.id);
@@ -183,5 +207,6 @@ class BidiSession extends import_events.EventEmitter {
 0 && (module.exports = {
   BidiConnection,
   BidiSession,
-  kBrowserCloseMessageId
+  kBrowserCloseMessageId,
+  kShutdownSessionNewMessageId
 });

package/lib/server/bidi/bidiExecutionContext.js

@@ -67,7 +67,7 @@ class BidiExecutionContext {
     if (response.type === "success")
       return import_bidiDeserializer.BidiDeserializer.deserialize(response.result);
     if (response.type === "exception")
-      throw new js.JavaScriptErrorInEvaluate(response.exceptionDetails.text + "\nFull val: " + JSON.stringify(response.exceptionDetails));
+      throw new js.JavaScriptErrorInEvaluate(response.exceptionDetails.text);
     throw new js.JavaScriptErrorInEvaluate("Unexpected response type: " + JSON.stringify(response));
   }
   async rawEvaluateHandle(context, expression) {
@@ -86,7 +86,7 @@ class BidiExecutionContext {
       throw new js.JavaScriptErrorInEvaluate("Cannot get handle: " + JSON.stringify(response.result));
     }
     if (response.type === "exception")
-      throw new js.JavaScriptErrorInEvaluate(response.exceptionDetails.text + "\nFull val: " + JSON.stringify(response.exceptionDetails));
+      throw new js.JavaScriptErrorInEvaluate(response.exceptionDetails.text);
     throw new js.JavaScriptErrorInEvaluate("Unexpected response type: " + JSON.stringify(response));
   }
   async evaluateWithArguments(functionDeclaration, returnByValue, utilityScript, values, handles) {
@@ -105,7 +105,7 @@ class BidiExecutionContext {
       userActivation: true
     });
     if (response.type === "exception")
-      throw new js.JavaScriptErrorInEvaluate(response.exceptionDetails.text + "\nFull val: " + JSON.stringify(response.exceptionDetails));
+      throw new js.JavaScriptErrorInEvaluate(response.exceptionDetails.text);
     if (response.type === "success") {
       if (returnByValue)
         return (0, import_utilityScriptSerializers.parseEvaluationResultValue)(import_bidiDeserializer.BidiDeserializer.deserialize(response.result));
@@ -180,7 +180,7 @@ class BidiExecutionContext {
       userActivation: true
     });
     if (response.type === "exception")
-      throw new js.JavaScriptErrorInEvaluate(response.exceptionDetails.text + "\nFull val: " + JSON.stringify(response.exceptionDetails));
+      throw new js.JavaScriptErrorInEvaluate(response.exceptionDetails.text);
     if (response.type === "success")
       return response.result;
     throw new js.JavaScriptErrorInEvaluate("Unexpected response type: " + JSON.stringify(response));

package/lib/server/bidi/bidiFirefox.js

@@ -74,6 +74,19 @@ Workaround: Set the HOME=/root environment variable${process.env.GITHUB_ACTION ?
     return env;
   }
   attemptToGracefullyCloseBrowser(transport) {
+    this._attemptToGracefullyCloseBrowser(transport).catch(() => {
+    });
+  }
+  async _attemptToGracefullyCloseBrowser(transport) {
+    if (!transport.onmessage) {
+      transport.send({ method: "session.new", params: { capabilities: {} }, id: import_bidiConnection.kShutdownSessionNewMessageId });
+      await new Promise((resolve) => {
+        transport.onmessage = (message) => {
+          if (message.id === import_bidiConnection.kShutdownSessionNewMessageId)
+            resolve(true);
+        };
+      });
+    }
     transport.send({ method: "browser.close", params: {}, id: import_bidiConnection.kBrowserCloseMessageId });
   }
   supportsPipeTransport() {
@@ -85,11 +98,13 @@ Workaround: Set the HOME=/root environment variable${process.env.GITHUB_ACTION ?
       preferences: options.firefoxUserPrefs || {}
     });
   }
-  defaultArgs(options, isPersistent, userDataDir) {
+  async defaultArgs(options, isPersistent, userDataDir) {
     const { args = [], headless } = options;
     const userDataDirArg = args.find((arg) => arg.startsWith("-profile") || arg.startsWith("--profile"));
     if (userDataDirArg)
       throw this._createUserDataDirArgMisuseError("--profile");
+    if (args.find((arg) => !arg.startsWith("-")))
+      throw new Error("Arguments can not specify page to be opened");
     const firefoxArguments = ["--remote-debugging-port=0"];
     if (headless)
       firefoxArguments.push("--headless");

package/lib/server/bidi/bidiNetworkManager.js

@@ -40,6 +40,7 @@ class BidiNetworkManager {
   constructor(bidiSession, page) {
     this._userRequestInterceptionEnabled = false;
     this._protocolRequestInterceptionEnabled = false;
+    this._attemptedAuthentications = /* @__PURE__ */ new Set();
     this._session = bidiSession;
     this._requests = /* @__PURE__ */ new Map();
     this._page = page;
@@ -62,7 +63,7 @@ class BidiNetworkManager {
     if (!frame)
       return;
     if (redirectedFrom)
-      this._requests.delete(redirectedFrom._id);
+      this._deleteRequest(redirectedFrom._id);
     let route;
     if (param.intercepts) {
       if (redirectedFrom) {
@@ -86,7 +87,9 @@ class BidiNetworkManager {
     if (!request)
       return;
     const getResponseBody = async () => {
-      throw new Error(`Response body is not available for requests in Bidi`);
+      const { bytes } = await this._session.send("network.getData", { request: params.request.request, dataType: bidi.Network.DataType.Response });
+      const encoding = bytes.type === "base64" ? "base64" : "utf8";
+      return Buffer.from(bytes.value, encoding);
     };
     const timings = params.request.timings;
     const startTime = timings.requestTime;
@@ -124,7 +127,7 @@ class BidiNetworkManager {
     if (isRedirected) {
       response._requestFinished(responseEndTime);
     } else {
-      this._requests.delete(request._id);
+      this._deleteRequest(request._id);
       response._requestFinished(responseEndTime);
     }
     response._setHttpVersion(params.response.protocol);
@@ -134,7 +137,7 @@ class BidiNetworkManager {
     const request = this._requests.get(params.request.request);
     if (!request)
       return;
-    this._requests.delete(request._id);
+    this._deleteRequest(request._id);
     const response = request.request._existingResponse();
     if (response) {
       response.setTransferSize(null);
@@ -147,23 +150,35 @@ class BidiNetworkManager {
   _onAuthRequired(params) {
     const isBasic = params.response.authChallenges?.some((challenge) => challenge.scheme.startsWith("Basic"));
     const credentials = this._page.browserContext._options.httpCredentials;
-    if (isBasic && credentials) {
-      this._session.sendMayFail("network.continueWithAuth", {
-        request: params.request.request,
-        action: "provideCredentials",
-        credentials: {
-          type: "password",
-          username: credentials.username,
-          password: credentials.password
-        }
-      });
+    if (isBasic && credentials && (!credentials.origin || new URL(params.request.url).origin.toLowerCase() === credentials.origin.toLowerCase())) {
+      if (this._attemptedAuthentications.has(params.request.request)) {
+        this._session.sendMayFail("network.continueWithAuth", {
+          request: params.request.request,
+          action: "cancel"
+        });
+      } else {
+        this._attemptedAuthentications.add(params.request.request);
+        this._session.sendMayFail("network.continueWithAuth", {
+          request: params.request.request,
+          action: "provideCredentials",
+          credentials: {
+            type: "password",
+            username: credentials.username,
+            password: credentials.password
+          }
+        });
+      }
     } else {
       this._session.sendMayFail("network.continueWithAuth", {
         request: params.request.request,
-        action: "default"
+        action: "cancel"
       });
     }
   }
+  _deleteRequest(requestId) {
+    this._requests.delete(requestId);
+    this._attemptedAuthentications.delete(requestId);
+  }
   async setRequestInterception(value) {
     this._userRequestInterceptionEnabled = value;
     await this._updateProtocolRequestInterception();
@@ -209,7 +224,7 @@ class BidiRequest {
       redirectedFrom ? redirectedFrom.request : null,
       payload.navigation ?? void 0,
       payload.request.url,
-      "other",
+      resourceTypeFromBidi(payload.request.destination, payload.request.initiatorType, payload.initiator?.type),
       payload.request.method,
       postDataBuffer,
       fromBidiHeaders(payload.request.headers)
@@ -310,6 +325,57 @@ function toBidiSameSite(sameSite) {
     return bidi.Network.SameSite.Lax;
   return bidi.Network.SameSite.None;
 }
+function resourceTypeFromBidi(requestDestination, requestInitiatorType, eventInitiatorType) {
+  switch (requestDestination) {
+    case "audio":
+      return "media";
+    case "audioworklet":
+      return "script";
+    case "document":
+      return "document";
+    case "font":
+      return "font";
+    case "frame":
+      return "document";
+    case "iframe":
+      return "document";
+    case "image":
+      return "image";
+    case "object":
+      return "object";
+    case "paintworklet":
+      return "script";
+    case "script":
+      return "script";
+    case "serviceworker":
+      return "script";
+    case "sharedworker":
+      return "script";
+    case "style":
+      return "stylesheet";
+    case "track":
+      return "texttrack";
+    case "video":
+      return "media";
+    case "worker":
+      return "script";
+    case "":
+      switch (requestInitiatorType) {
+        case "fetch":
+          return "fetch";
+        case "font":
+          return "font";
+        case "xmlhttprequest":
+          return "xhr";
+        case null:
+          return eventInitiatorType === "script" ? "xhr" : "document";
+        default:
+          return "other";
+      }
+    default:
+      return "other";
+  }
+}
 // Annotate the CommonJS export names for ESM import in node:
 0 && (module.exports = {
   BidiNetworkManager,

package/lib/server/bidi/bidiPage.js

@@ -35,6 +35,7 @@ module.exports = __toCommonJS(bidiPage_exports);
 var import_eventsHelper = require("../utils/eventsHelper");
 var dialog = __toESM(require("../dialog"));
 var dom = __toESM(require("../dom"));
+var import_bidiBrowser = require("./bidiBrowser");
 var import_page = require("../page");
 var import_bidiExecutionContext = require("./bidiExecutionContext");
 var import_bidiInput = require("./bidiInput");
@@ -45,6 +46,7 @@ const UTILITY_WORLD_NAME = "__playwright_utility_world__";
 const kPlaywrightBindingChannel = "playwrightChannel";
 class BidiPage {
   constructor(browserContext, bidiSession, opener) {
+    this._realmToWorkerContext = /* @__PURE__ */ new Map();
     this._sessionListeners = [];
     this._initScriptIds = /* @__PURE__ */ new Map();
     this._session = bidiSession;
@@ -70,6 +72,8 @@ class BidiPage {
       import_eventsHelper.eventsHelper.addEventListener(bidiSession, "browsingContext.historyUpdated", this._onHistoryUpdated.bind(this)),
       import_eventsHelper.eventsHelper.addEventListener(bidiSession, "browsingContext.domContentLoaded", this._onDomContentLoaded.bind(this)),
       import_eventsHelper.eventsHelper.addEventListener(bidiSession, "browsingContext.load", this._onLoad.bind(this)),
+      import_eventsHelper.eventsHelper.addEventListener(bidiSession, "browsingContext.downloadWillBegin", this._onDownloadWillBegin.bind(this)),
+      import_eventsHelper.eventsHelper.addEventListener(bidiSession, "browsingContext.downloadEnd", this._onDownloadEnded.bind(this)),
       import_eventsHelper.eventsHelper.addEventListener(bidiSession, "browsingContext.userPromptOpened", this._onUserPromptOpened.bind(this)),
       import_eventsHelper.eventsHelper.addEventListener(bidiSession, "log.entryAdded", this._onLogEntryAdded.bind(this))
     ];
@@ -105,6 +109,13 @@ class BidiPage {
     }
   }
   _onRealmCreated(realmInfo) {
+    if (realmInfo.type === "dedicated-worker") {
+      const delegate2 = new import_bidiExecutionContext.BidiExecutionContext(this._session, realmInfo);
+      const worker = new import_page.Worker(this._page, realmInfo.origin);
+      this._realmToWorkerContext.set(realmInfo.realm, worker.createExecutionContext(delegate2));
+      this._page.addWorker(realmInfo.realm, worker);
+      return;
+    }
     if (this._realmToContext.has(realmInfo.realm))
       return;
     if (realmInfo.type !== "window")
@@ -143,11 +154,17 @@ class BidiPage {
   }
   _onRealmDestroyed(params) {
     const context = this._realmToContext.get(params.realm);
-    if (!context)
-      return false;
-    this._realmToContext.delete(params.realm);
-    context.frame._contextDestroyed(context);
-    return true;
+    if (context) {
+      this._realmToContext.delete(params.realm);
+      context.frame._contextDestroyed(context);
+      return true;
+    }
+    const existed = this._realmToWorkerContext.delete(params.realm);
+    if (existed) {
+      this._page.removeWorker(params.realm);
+      return true;
+    }
+    return false;
   }
   // TODO: route the message directly to the browser
   _onBrowsingContextDestroyed(params) {
@@ -198,11 +215,47 @@ class BidiPage {
       event.defaultValue
     ));
   }
+  _onDownloadWillBegin(event) {
+    if (!event.navigation)
+      return;
+    this._page.frameManager.frameAbortedNavigation(event.context, "Download is starting");
+    let originPage = this._page.initializedOrUndefined();
+    if (!originPage && this._opener)
+      originPage = this._opener._page.initializedOrUndefined();
+    if (!originPage)
+      return;
+    this._browserContext._browser._downloadCreated(originPage, event.navigation, event.url, event.suggestedFilename);
+  }
+  _onDownloadEnded(event) {
+    if (!event.navigation)
+      return;
+    this._browserContext._browser._downloadFinished(event.navigation, event.status === "canceled" ? "canceled" : void 0);
+  }
   _onLogEntryAdded(params) {
+    if (params.type === "javascript" && params.level === "error") {
+      let errorName = "";
+      let errorMessage;
+      if (params.text?.includes(": ")) {
+        const index = params.text.indexOf(": ");
+        errorName = params.text.substring(0, index);
+        errorMessage = params.text.substring(index + 2);
+      } else {
+        errorMessage = params.text ?? void 0;
+      }
+      const error = new Error(errorMessage);
+      error.name = errorName;
+      error.stack = `${params.text}
+${params.stackTrace?.callFrames.map((f) => {
+        const location2 = `${f.url}:${f.lineNumber + 1}:${f.columnNumber + 1}`;
+        return f.functionName ? `    at ${f.functionName} (${location2})` : `    at ${location2}`;
+      }).join("\n")}`;
+      this._page.addPageError(error);
+      return;
+    }
     if (params.type !== "console")
       return;
     const entry = params;
-    const context = this._realmToContext.get(params.source.realm);
+    const context = this._realmToContext.get(params.source.realm) ?? this._realmToWorkerContext.get(params.source.realm);
     if (!context)
       return;
     const callFrame = params.stackTrace?.callFrames[0];
@@ -233,14 +286,20 @@ class BidiPage {
     if (!emulatedSize)
       return;
     const viewportSize = emulatedSize.viewport;
-    await this._session.send("browsingContext.setViewport", {
-      context: this._session.sessionId,
-      viewport: {
-        width: viewportSize.width,
-        height: viewportSize.height
-      },
-      devicePixelRatio: options.deviceScaleFactor || 1
-    });
+    await Promise.all([
+      this._session.send("browsingContext.setViewport", {
+        context: this._session.sessionId,
+        viewport: {
+          width: viewportSize.width,
+          height: viewportSize.height
+        },
+        devicePixelRatio: options.deviceScaleFactor || 1
+      }),
+      this._session.send("emulation.setScreenOrientationOverride", {
+        contexts: [this._session.sessionId],
+        screenOrientation: (0, import_bidiBrowser.getScreenOrientation)(!!options.isMobile, viewportSize)
+      })
+    ]);
   }
   async updateRequestInterception() {
     await this._networkManager.setRequestInterception(this._page.needsRequestInterception());
@@ -307,10 +366,17 @@ class BidiPage {
     await Promise.all(ids.map((script) => this._session.send("script.removePreloadScript", { script })));
   }
   async closePage(runBeforeUnload) {
-    await this._session.send("browsingContext.close", {
-      context: this._session.sessionId,
-      promptUnload: runBeforeUnload
-    });
+    if (runBeforeUnload) {
+      this._session.sendMayFail("browsingContext.close", {
+        context: this._session.sessionId,
+        promptUnload: runBeforeUnload
+      });
+    } else {
+      await this._session.send("browsingContext.close", {
+        context: this._session.sessionId,
+        promptUnload: runBeforeUnload
+      });
+    }
   }
   async setBackgroundColor(color) {
   }

package/lib/server/browserType.js

@@ -169,9 +169,9 @@ class BrowserType extends import_instrumentation.SdkObject {
     if (ignoreAllDefaultArgs)
       browserArguments.push(...args);
     else if (ignoreDefaultArgs)
-      browserArguments.push(...this.defaultArgs(options, isPersistent, userDataDir).filter((arg) => ignoreDefaultArgs.indexOf(arg) === -1));
+      browserArguments.push(...(await this.defaultArgs(options, isPersistent, userDataDir)).filter((arg) => ignoreDefaultArgs.indexOf(arg) === -1));
     else
-      browserArguments.push(...this.defaultArgs(options, isPersistent, userDataDir));
+      browserArguments.push(...await this.defaultArgs(options, isPersistent, userDataDir));
     let executable;
     if (executablePath) {
       if (!await (0, import_fileUtils.existsAsync)(executablePath))
@@ -200,7 +200,7 @@ class BrowserType extends import_instrumentation.SdkObject {
     const { launchedProcess, gracefullyClose, kill } = await (0, import_processLauncher.launchProcess)({
       command: prepared.executable,
       args: prepared.browserArguments,
-      env: this.amendEnvironment(env, prepared.userDataDir, isPersistent),
+      env: this.amendEnvironment(env, prepared.userDataDir, isPersistent, options),
       handleSIGINT,
       handleSIGTERM,
       handleSIGHUP,

package/lib/server/chromium/chromium.js

@@ -250,7 +250,7 @@ class Chromium extends import_browserType.BrowserType {
       throw e;
     }
   }
-  defaultArgs(options, isPersistent, userDataDir) {
+  async defaultArgs(options, isPersistent, userDataDir) {
     const chromeArguments = this._innerDefaultArgs(options);
     chromeArguments.push(`--user-data-dir=${userDataDir}`);
     if (options.cdpPort !== void 0)

package/lib/server/chromium/chromiumSwitches.js

@@ -44,6 +44,8 @@ const disabledFeatures = (assistantMode) => [
   "Translate",
   // See https://issues.chromium.org/u/1/issues/435410220
   "AutoDeElevate",
+  // See https://github.com/microsoft/playwright/issues/37714
+  "RenderDocument",
   assistantMode ? "AutomationControlled" : ""
 ].filter(Boolean);
 const chromiumSwitches = (assistantMode, channel) => [
@@ -64,7 +66,7 @@ const chromiumSwitches = (assistantMode, channel) => [
   "--disable-dev-shm-usage",
   "--disable-extensions",
   "--disable-features=" + disabledFeatures(assistantMode).join(","),
-  channel === "chromium-tip-of-tree" ? "--enable-features=CDPScreenshotNewSurface" : "",
+  process.env.PLAYWRIGHT_LEGACY_SCREENSHOT ? "" : "--enable-features=CDPScreenshotNewSurface",
   "--allow-pre-commit-input",
   "--disable-hang-monitor",
   "--disable-ipc-flooding-protection",