brass-runtime 1.19.1 → 1.19.2

package/CHANGELOG.md

@@ -1,5 +1,39 @@
 # Changelog
 
+## 1.18.3 - HTTP Pool/Timeout Fast Path
+
+### Performance
+
+- Connected the non-streaming HTTP wire client to the existing `runPoolTransport`
+  fast path whenever a request uses `pool`, `adaptiveLimiter`, or `timeoutMs`.
+  The uncontended pool path now uses synchronous `tryAcquireSync` before falling
+  back to queued async acquire, avoiding the generic `fromPromiseAbortable`
+  wrapper and extra promise/microtask boundaries on hot BFF/proxy paths.
+- Improved local HTTP overhead benchmark results for the proxy effect transport
+  path with 30k calls, 5k warmup, concurrency 32:
+  - `default-proxy-effect-timeout`: p99 `1.915ms` -> `1.559ms`,
+    throughput `70.9k/s` -> `101.5k/s`.
+  - `default-proxy-effect-pool`: p99 `1.564ms` -> `1.276ms`,
+    throughput `79.2k/s` -> `115.7k/s`.
+  - `default-proxy-effect-timeout-pool`: p99 `2.014ms` -> `1.209ms`,
+    throughput `70.2k/s` -> `103.1k/s`.
+
+### Fixed
+
+- Preserved real host-request cancellation on the pool/timeout fast path by
+  passing transports a request-scoped `AbortController` signal. Promise
+  transports such as Axios can now observe aborts on cancellation and timeout
+  while still benefiting from the pool fast path.
+- Added regression coverage ensuring uncontended pool transports run during
+  effect registration and that cancellation aborts the signal passed to the
+  transport.
+
+### Validation
+
+- `npm run test:types`
+- `npm test -- src/http/__tests__`
+- `BRASS_HTTP_OVERHEAD_CALLS=30000 BRASS_HTTP_OVERHEAD_WARMUP_CALLS=5000 BRASS_HTTP_OVERHEAD_CONCURRENCY=32 BRASS_HTTP_OVERHEAD_VARIANTS=default-proxy-effect-transport,default-proxy-effect-timeout,default-proxy-effect-pool,default-proxy-effect-timeout-pool npm run benchmark:http:overhead`
+
 ## 1.18.2 - Release Metadata Alignment
 
 ### Fixed

package/dist/{chunk-ID2WOCBA.mjs → chunk-5X3MPWTR.mjs}

@@ -12,6 +12,8 @@ import {
 } from "./chunk-XRRC5BBM.mjs";
 import {
   fromPromiseAbortable,
+  recordAbortablePromiseFinish,
+  recordAbortablePromiseStart,
   resolveWasmModule,
   toPromise
 } from "./chunk-BFNBU47C.mjs";
@@ -3182,6 +3184,275 @@ var noopSignal = (() => {
   globalThis.__brassNoopSignal = s;
   return s;
 })();
+var PoolRequestState = class {
+  constructor(req, url, transport, metrics, pool, adaptiveLimiter, timerWheel, timeoutMs, env, cb, previousSignal, controller, signal, label, startedAt) {
+    this.req = req;
+    this.url = url;
+    this.transport = transport;
+    this.metrics = metrics;
+    this.pool = pool;
+    this.adaptiveLimiter = adaptiveLimiter;
+    this.timerWheel = timerWheel;
+    this.timeoutMs = timeoutMs;
+    this.env = env;
+    this.cb = cb;
+    this.previousSignal = previousSignal;
+    this.controller = controller;
+    this.signal = signal;
+    this.label = label;
+    this.startedAt = startedAt;
+  }
+  req;
+  url;
+  transport;
+  metrics;
+  pool;
+  adaptiveLimiter;
+  timerWheel;
+  timeoutMs;
+  env;
+  cb;
+  previousSignal;
+  controller;
+  signal;
+  label;
+  startedAt;
+  done = false;
+  cancelInner = void 0;
+  timerHandle = void 0;
+  timeoutHandle = void 0;
+  lease = void 0;
+  finish(outcome, exit, error) {
+    if (this.done) return;
+    this.done = true;
+    if (this.timerHandle) {
+      this.timerHandle.cancel();
+      this.timerHandle = void 0;
+    }
+    if (this.timeoutHandle !== void 0) {
+      clearTimeout(this.timeoutHandle);
+      this.timeoutHandle = void 0;
+    }
+    if (this.previousSignal) this.previousSignal.removeEventListener("abort", this.boundAbortFromPrevious);
+    this.cancelInner = void 0;
+    recordAbortablePromiseFinish(this.label, outcome);
+    this.metrics.onFinish({
+      label: this.label,
+      outcome,
+      durationMs: Math.round(performance.now() - this.startedAt),
+      error
+    });
+    this.cb(exit);
+  }
+  finishFailure(error, outcome = "failure") {
+    this.finish(outcome, { _tag: "Failure", cause: Cause.fail(error) }, error);
+  }
+  abortCurrent(reason) {
+    if (!this.controller) return;
+    try {
+      this.controller.abort(reason);
+    } catch {
+      this.controller.abort();
+    }
+  }
+  /**
+   * Bound reference for addEventListener/removeEventListener.
+   * Only allocated when previousSignal is present (not on the hot path).
+   */
+  boundAbortFromPrevious = void 0;
+  abortFromPrevious() {
+    const error = this.previousSignal ? abortErrorForSignal(this.previousSignal) : { _tag: "Abort" };
+    this.abortCurrent(this.previousSignal?.reason);
+    const cancel = this.cancelInner;
+    this.cancelInner = void 0;
+    if (this.lease) {
+      releaseFailure(this.lease, this.adaptiveLimiter);
+      this.lease = void 0;
+    }
+    queueMicrotask(() => {
+      this.finishFailure(error);
+      cancel?.();
+    });
+  }
+  runTransportInner() {
+    const { transport, req, url, signal, env } = this;
+    try {
+      const effect = transport({ request: req, url, signal });
+      if (effect._tag === "Succeed") {
+        if (this.lease) releaseSuccess(this.lease, this.adaptiveLimiter, effect.value);
+        this.finish("success", { _tag: "Success", value: effect.value });
+      } else if (effect._tag === "Fail") {
+        if (this.lease) releaseFailure(this.lease, this.adaptiveLimiter);
+        this.finishFailure(effect.error);
+      } else if (effect._tag === "Async") {
+        try {
+          const cancel = effect.register(env, (exit) => {
+            if (this.done) return;
+            this.cancelInner = void 0;
+            if (exit._tag === "Success") {
+              if (this.lease) releaseSuccess(this.lease, this.adaptiveLimiter, exit.value);
+              this.finish("success", exit);
+            } else {
+              if (this.lease) releaseFailure(this.lease, this.adaptiveLimiter);
+              this.finish("failure", exit, exitError(exit));
+            }
+          });
+          if (!this.done) this.cancelInner = typeof cancel === "function" ? cancel : void 0;
+        } catch (error) {
+          if (this.lease) releaseFailure(this.lease, this.adaptiveLimiter);
+          this.finishFailure(normalizeHttpError(error));
+        }
+      } else {
+        const innerCancel = registerHttpEffect(
+          effect,
+          env,
+          (exit) => {
+            if (this.done) return;
+            this.cancelInner = void 0;
+            if (exit._tag === "Success") {
+              if (this.lease) releaseSuccess(this.lease, this.adaptiveLimiter, exit.value);
+              this.finish("success", exit);
+            } else {
+              if (this.lease) releaseFailure(this.lease, this.adaptiveLimiter);
+              this.finish("failure", exit, exitError(exit));
+            }
+          }
+        );
+        if (!this.done) this.cancelInner = innerCancel;
+      }
+    } catch (error) {
+      if (this.lease) releaseFailure(this.lease, this.adaptiveLimiter);
+      this.finishFailure(normalizeHttpError(error));
+    }
+  }
+};
+var runPoolTransport = (req, url, transport, metrics, pool, adaptiveLimiter, timerWheel, timeoutMs) => ({
+  _tag: "Async",
+  register: (env, cb) => {
+    const previousSignal = req.init?.signal;
+    const controller = new AbortController();
+    const signal = controller.signal;
+    const label = fetchLabel(req, url);
+    const startedAt = performance.now();
+    const state = new PoolRequestState(
+      req,
+      url,
+      transport,
+      metrics,
+      pool,
+      adaptiveLimiter,
+      timerWheel,
+      timeoutMs,
+      env,
+      cb,
+      previousSignal,
+      controller,
+      signal,
+      label,
+      startedAt
+    );
+    recordAbortablePromiseStart(label);
+    metrics.onStart();
+    if (previousSignal) {
+      state.boundAbortFromPrevious = () => state.abortFromPrevious();
+      if (previousSignal.aborted) {
+        state.abortFromPrevious();
+        return () => void 0;
+      }
+      previousSignal.addEventListener("abort", state.boundAbortFromPrevious, ONCE_OPTIONS);
+    }
+    if (timeoutMs !== void 0 && timeoutMs > 0) {
+      const onTimeout = () => {
+        const reason = timeoutReason(req, url, timeoutMs);
+        if (state.lease) {
+          releaseFailure(state.lease, adaptiveLimiter);
+          state.lease = void 0;
+        }
+        const cancel = state.cancelInner;
+        state.cancelInner = void 0;
+        state.finishFailure(reason, "timeout");
+        state.abortCurrent(reason);
+        cancel?.();
+      };
+      if (timerWheel) {
+        state.timerHandle = timerWheel.schedule(timeoutMs, onTimeout, startedAt);
+      } else {
+        state.timeoutHandle = setTimeout(onTimeout, timeoutMs);
+      }
+    }
+    if (adaptiveLimiter) {
+      const key = resolveHttpPoolKey(adaptiveLimiter.keyResolver, req, url);
+      const syncLease = adaptiveLimiter.tryAcquireSync(key, signal);
+      if (syncLease) {
+        state.lease = syncLease;
+      } else {
+        adaptiveLimiter.acquire(key, signal, { priority: requestPriority(req) }).then(
+          (asyncLease) => {
+            if (state.done) {
+              asyncLease.release(0);
+              return;
+            }
+            state.lease = asyncLease;
+            state.runTransportInner();
+          },
+          (err) => {
+            if (state.done) return;
+            state.finishFailure(normalizeHttpError(err));
+          }
+        );
+        return () => {
+          if (state.done) return;
+          const cancel = state.cancelInner;
+          state.cancelInner = void 0;
+          state.abortCurrent();
+          if (state.lease) releaseFailure(state.lease, adaptiveLimiter);
+          state.finish("interrupt", { _tag: "Failure", cause: Cause.interrupt() });
+          cancel?.();
+        };
+      }
+    } else if (pool) {
+      const key = resolveHttpPoolKey(pool.keyResolver, req, url);
+      const syncLease = pool.tryAcquireSync(key, signal);
+      if (syncLease) {
+        state.lease = syncLease;
+      } else {
+        pool.acquire(key, signal).then(
+          (asyncLease) => {
+            if (state.done) {
+              asyncLease.release();
+              return;
+            }
+            state.lease = asyncLease;
+            state.runTransportInner();
+          },
+          (err) => {
+            if (state.done) return;
+            state.finishFailure(normalizeHttpError(err));
+          }
+        );
+        return () => {
+          if (state.done) return;
+          const cancel = state.cancelInner;
+          state.cancelInner = void 0;
+          state.abortCurrent();
+          if (state.lease) releaseFailure(state.lease, void 0);
+          state.finish("interrupt", { _tag: "Failure", cause: Cause.interrupt() });
+          cancel?.();
+        };
+      }
+    }
+    state.runTransportInner();
+    return () => {
+      if (state.done) return;
+      const cancel = state.cancelInner;
+      state.cancelInner = void 0;
+      state.abortCurrent();
+      if (state.lease) releaseFailure(state.lease, adaptiveLimiter);
+      state.finish("interrupt", { _tag: "Failure", cause: Cause.interrupt() });
+      cancel?.();
+    };
+  }
+});
 function makeHttp(cfg = {}) {
   validateMakeHttpConfig(cfg);
   const baseUrl = cfg.baseUrl ?? "";
@@ -3200,42 +3471,7 @@ function makeHttp(cfg = {}) {
     if (!adaptiveLimiter && !pool && timeoutMs === void 0) {
       return runDirectTransport(req, url, transport, metrics);
     }
-    return fromPromiseAbortable(
-      async (signal, env) => {
-        let lease;
-        const linkedSignal = linkAbortSignals(signal, req.init?.signal);
-        try {
-          if (linkedSignal.signal.aborted) throw abortErrorForSignal(linkedSignal.signal);
-          if (adaptiveLimiter) {
-            const key = resolveHttpPoolKey(adaptiveLimiter.keyResolver, req, url);
-            lease = await adaptiveLimiter.acquire(key, linkedSignal.signal, { priority: requestPriority(req) });
-          } else if (pool) {
-            const key = resolveHttpPoolKey(pool.keyResolver, req, url);
-            lease = await pool.acquire(key, linkedSignal.signal);
-          }
-          const response = await runTransportEffect(
-            transport({ request: req, url, signal: linkedSignal.signal }),
-            env,
-            linkedSignal.signal
-          );
-          lease = releaseSuccess(lease, adaptiveLimiter, response);
-          return response;
-        } finally {
-          linkedSignal.cleanup();
-          if (lease) {
-            releaseFailure(lease, adaptiveLimiter);
-          }
-        }
-      },
-      normalizeHttpError,
-      {
-        label: fetchLabel(req, url),
-        timeoutMs,
-        timeoutReason: timeoutMs ? () => timeoutReason(req, url, timeoutMs) : void 0,
-        onStart: metrics.onStart,
-        onFinish: metrics.onFinish
-      }
-    );
+    return runPoolTransport(req, url, transport, metrics, pool, adaptiveLimiter, void 0, timeoutMs);
   };
   const metadata = {};
   if (adaptiveLimiter) metadata.adaptiveLimiter = adaptiveLimiter;

package/dist/{chunk-U42YF6B2.js → chunk-6AGAZD32.js}

@@ -4,7 +4,7 @@ import {
 } from "./chunk-RZQK32C6.js";
 import {
   withHttpObservability
-} from "./chunk-XJSWDU2S.js";
+} from "./chunk-BHX4MD35.js";
 import {
   makeObservability
 } from "./chunk-TAPB4NN5.js";
@@ -14,7 +14,7 @@ import {
 import {
   makeDefaultHttpClient,
   makeHttp
-} from "./chunk-IHXF6NQG.js";
+} from "./chunk-HKLZJ5UK.js";
 import {
   Runtime,
   Scheduler

package/dist/{chunk-XJSWDU2S.js → chunk-BHX4MD35.js}

@@ -20,7 +20,7 @@ import {
   httpErrorStatus,
   isRetryableHttpError,
   makeDefaultHttpClient
-} from "./chunk-IHXF6NQG.js";
+} from "./chunk-HKLZJ5UK.js";
 import {
   registerHttpEffect
 } from "./chunk-TRM4JUZQ.js";