brain-dev 2.5.0 → 2.5.2

package/bin/lib/commands/complete.cjs

@@ -2,7 +2,7 @@
 
 const fs = require('node:fs');
 const path = require('node:path');
-const { readState, writeState } = require('../state.cjs');
+const { readState, writeState, syncPhaseStatus } = require('../state.cjs');
 const { parseRoadmap, writeRoadmap } = require('../roadmap.cjs');
 const { gitTag } = require('../git.cjs');
 const { output, error, success } = require('../core.cjs');
@@ -163,7 +163,7 @@ function handlePhaseComplete(args, phaseIdx, brainDir, state) {
     return { error: 'not-verified', nextAction: '/brain:verify' };
   }
 
-  // Mark phase as complete in state (handle both string and object formats)
+  // Mark current phase as complete in per-phase array
   if (Array.isArray(state.phase.phases)) {
     const idx = state.phase.phases.findIndex(p =>
       typeof p === 'object' ? p.number === phaseNumber : false
@@ -179,9 +179,9 @@ function handlePhaseComplete(args, phaseIdx, brainDir, state) {
   const hasNextPhase = totalPhases > 0 && nextPhase <= totalPhases;
   if (hasNextPhase) {
     state.phase.current = nextPhase;
-    state.phase.status = 'pending';
+    syncPhaseStatus(state, 'pending');
   } else {
-    state.phase.status = 'complete';
+    syncPhaseStatus(state, 'complete');
   }
   writeState(brainDir, state);
 

package/bin/lib/commands/discuss.cjs

@@ -2,7 +2,7 @@
 
 const fs = require('node:fs');
 const path = require('node:path');
-const { readState, writeState, atomicWriteSync } = require('../state.cjs');
+const { readState, writeState, atomicWriteSync, syncPhaseStatus } = require('../state.cjs');
 const { parseRoadmap } = require('../roadmap.cjs');
 const { loadTemplate, interpolate } = require('../templates.cjs');
 const { output, error, success, prefix, pipelineGate } = require('../core.cjs');
@@ -132,7 +132,7 @@ function handleAnalyze(args, brainDir, state) {
   });
 
   // Update status to discussing
-  state.phase.status = 'discussing';
+  syncPhaseStatus(state, 'discussing');
   writeState(brainDir, state);
 
   const result = {
@@ -220,7 +220,7 @@ function handleSave(args, brainDir, state) {
   atomicWriteSync(contextPath, lines.join('\n'));
 
   // Update state: set phase status to "discussed"
-  state.phase.status = 'discussed';
+  syncPhaseStatus(state, 'discussed');
   writeState(brainDir, state);
 
   const result = {

package/bin/lib/commands/execute.cjs

@@ -2,7 +2,7 @@
 
 const fs = require('node:fs');
 const path = require('node:path');
-const { readState, writeState } = require('../state.cjs');
+const { readState, writeState, syncPhaseStatus } = require('../state.cjs');
 const { loadTemplate, interpolate, loadTemplateWithOverlay } = require('../templates.cjs');
 const { getAgent, resolveModel } = require('../agents.cjs');
 const { logEvent } = require('../logger.cjs');
@@ -304,7 +304,7 @@ async function run(args = [], opts = {}) {
 
   // All plans executed
   if (!targetPlan) {
-    state.phase.status = 'executed';
+    syncPhaseStatus(state, 'executed');
     writeState(brainDir, state);
     const msg = "All plans executed. Run /brain:review before verify.";
     output({ action: 'all-executed', message: msg, nextAction: '/brain:review' }, `[brain] ${msg}\n${pipelineGate('npx brain-dev review --phase ' + phaseNumber)}`);
@@ -385,7 +385,7 @@ async function run(args = [], opts = {}) {
   } catch { /* cost tracking failure is non-fatal */ }
 
   // Update state to executing
-  state.phase.status = 'executing';
+  syncPhaseStatus(state, 'executing');
   if (!state.phase.execution_started_at) {
     state.phase.execution_started_at = new Date().toISOString();
   }

package/bin/lib/commands/plan.cjs

@@ -2,7 +2,7 @@
 
 const fs = require('node:fs');
 const path = require('node:path');
-const { readState, writeState } = require('../state.cjs');
+const { readState, writeState, syncPhaseStatus } = require('../state.cjs');
 const { parseRoadmap } = require('../roadmap.cjs');
 const { loadTemplate, interpolate, loadTemplateWithOverlay } = require('../templates.cjs');
 const { getAgent, resolveModel } = require('../agents.cjs');
@@ -291,7 +291,7 @@ function handleSingle(args, brainDir, state) {
   const fullPrompt = prompt + checkerInstruction;
 
   // Update state: phase status = "planning"
-  state.phase.status = 'planning';
+  syncPhaseStatus(state, 'planning');
   writeState(brainDir, state);
 
   const result = {
@@ -531,7 +531,7 @@ function handleAll(brainDir, state) {
   });
 
   // Update status to planning
-  state.phase.status = 'planning';
+  syncPhaseStatus(state, 'planning');
   writeState(brainDir, state);
 
   const result = {

package/bin/lib/commands/review.cjs

@@ -2,7 +2,7 @@
 
 const fs = require('node:fs');
 const path = require('node:path');
-const { readState, writeState } = require('../state.cjs');
+const { readState, writeState, syncPhaseStatus } = require('../state.cjs');
 const { loadTemplateWithOverlay, interpolate } = require('../templates.cjs');
 const { getAgent, resolveModel } = require('../agents.cjs');
 const { logEvent } = require('../logger.cjs');
@@ -93,7 +93,7 @@ async function run(args = [], opts = {}) {
   });
 
   // Update state
-  state.phase.status = 'reviewing';
+  syncPhaseStatus(state, 'reviewing');
   writeState(brainDir, state);
 
   const result = {
@@ -145,14 +145,14 @@ function handleResult(brainDir, state, args) {
   const reviewStatus = statusMatch ? statusMatch[1] : 'passed';
 
   if (reviewStatus === 'critical') {
-    state.phase.status = 'review-failed';
+    syncPhaseStatus(state, 'review-failed');
     writeState(brainDir, state);
     error('Review found critical issues. Fix them and re-run /brain:review.');
     output({ action: 'review-failed', phase: phaseNumber, status: reviewStatus }, '');
     return { action: 'review-failed', phase: phaseNumber };
   }
 
-  state.phase.status = 'reviewed';
+  syncPhaseStatus(state, 'reviewed');
   writeState(brainDir, state);
 
   const result = {

package/bin/lib/commands/story.cjs

@@ -3,7 +3,7 @@
 const fs = require('node:fs');
 const path = require('node:path');
 const { parseArgs } = require('node:util');
-const { readState, writeState } = require('../state.cjs');
+const { readState, writeState, syncPhaseStatus } = require('../state.cjs');
 const { output, error, prefix } = require('../core.cjs');
 const { logEvent } = require('../logger.cjs');
 const { loadTemplate, interpolate, loadTemplateWithOverlay } = require('../templates.cjs');
@@ -913,7 +913,6 @@ function stepActivate(brainDir, state, storyDir, storyMeta) {
   // Update state phases
   state.phase = state.phase || { current: 0, status: 'initialized', total: 0, phases: [] };
   state.phase.current = 1;
-  state.phase.status = 'ready';
   state.phase.total = roadmapData.phases.length;
   state.phase.phases = roadmapData.phases.map(p => ({
     number: p.number,
@@ -921,7 +920,8 @@ function stepActivate(brainDir, state, storyDir, storyMeta) {
     status: p.status === 'Pending' ? 'pending' : p.status.toLowerCase(),
     goal: p.goal
   }));
-  state.phase.execution_started_at = null;
+  // Sync AFTER phases array is rebuilt so per-phase status is correctly updated
+  syncPhaseStatus(state, 'ready');
   state.phase.stuck_count = 0;
   state.phase.last_stuck_at = null;
 

package/bin/lib/commands/verify.cjs

@@ -2,7 +2,7 @@
 
 const fs = require('node:fs');
 const path = require('node:path');
-const { readState, writeState, atomicWriteSync } = require('../state.cjs');
+const { readState, writeState, atomicWriteSync, syncPhaseStatus } = require('../state.cjs');
 const { loadTemplate, interpolate, loadTemplateWithOverlay } = require('../templates.cjs');
 const { getAgent, resolveModel } = require('../agents.cjs');
 const { logEvent } = require('../logger.cjs');
@@ -320,7 +320,7 @@ async function run(args = [], opts = {}) {
   const fullPrompt = prompt + depthInstruction + summarySection;
 
   // Update state to verifying
-  state.phase.status = 'verifying';
+  syncPhaseStatus(state, 'verifying');
   writeState(brainDir, state);
 
   const result = {
@@ -421,9 +421,7 @@ function handleSaveResults(args, saveIdx, brainDir, state) {
   }
 
   // Update state
-  state.phase.status = results.passed ? 'verified' : 'verification-failed';
-  // Clear execution timer after verification completes
-  state.phase.execution_started_at = null;
+  syncPhaseStatus(state, results.passed ? 'verified' : 'verification-failed');
   writeState(brainDir, state);
 
   const msg = results.passed

package/bin/lib/recovery.cjs

@@ -4,7 +4,7 @@ const fs = require('node:fs');
 const path = require('node:path');
 const { readLock, isLockStale, clearStaleLock } = require('./lock.cjs');
 const { readLog } = require('./logger.cjs');
-const { readState, writeState, VALID_PHASE_STATUSES } = require('./state.cjs');
+const { readState, writeState, VALID_PHASE_STATUSES, syncPhaseStatus } = require('./state.cjs');
 
 /**
  * Analyze the JSONL execution log for a crashed phase.
@@ -293,11 +293,11 @@ function autoResume(brainDir, logAnalysis, state) {
   if (state.phase) {
     if (state.phase.status === 'executing' && logAnalysis.inProgressTask) {
       // There was work in progress - set to planned so execution can retry
-      state.phase.status = 'planned';
+      syncPhaseStatus(state, 'planned');
       changes.push(`Reset phase status from "executing" to "planned"`);
     } else if (state.phase.status === 'executing' && !logAnalysis.inProgressTask) {
       // All tasks were completed or none in progress
-      state.phase.status = 'planned';
+      syncPhaseStatus(state, 'planned');
       changes.push(`Reset phase status to "planned" for re-verification`);
     }
 
@@ -337,8 +337,7 @@ function rollback(brainDir, staleLock, state) {
   // Reset phase status
   if (state.phase) {
     const previousStatus = state.phase.status;
-    state.phase.status = 'planned';
-    state.phase.execution_started_at = null;
+    syncPhaseStatus(state, 'planned');
     changes.push(`Reset phase status from "${previousStatus}" to "planned"`);
   }
 

package/bin/lib/state.cjs

@@ -517,6 +517,27 @@ const VALID_PHASE_STATUSES = [
   'partial', 'failed', 'paused', 'complete'
 ];
 
+/**
+ * Atomically sync phase status across both top-level and per-phase array.
+ * Also clears execution_started_at when regressing to pre-execute states.
+ * @param {object} state - brain.json state object
+ * @param {string} newStatus - New status value
+ */
+function syncPhaseStatus(state, newStatus) {
+  const preExecuteStatuses = ['pending', 'ready', 'discussing', 'discussed', 'planning', 'planned'];
+  if (preExecuteStatuses.includes(newStatus)) {
+    state.phase.execution_started_at = null;
+  }
+
+  state.phase.status = newStatus;
+  if (Array.isArray(state.phase.phases) && state.phase.current > 0) {
+    const idx = state.phase.phases.findIndex(p => p.number === state.phase.current);
+    if (idx >= 0) {
+      state.phase.phases[idx].status = newStatus;
+    }
+  }
+}
+
 module.exports = {
   atomicWriteSync,
   readState,
@@ -524,5 +545,6 @@ module.exports = {
   generateStateMd,
   createDefaultState,
   migrateState,
+  syncPhaseStatus,
   VALID_PHASE_STATUSES
 };

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "brain-dev",
-  "version": "2.5.0",
+  "version": "2.5.2",
   "description": "AI-powered development workflow orchestrator",
   "author": "halilcosdu",
   "license": "MIT",