braid-http 0.3.17 → 0.3.19

package/braid-http-client.js

@@ -229,8 +229,8 @@ async function braid_fetch (url, params = {}) {
 
     // Now we define the subscription function we just used:
     function start_subscription (cb, error) {
-        if (!res.ok)
-            throw new Error('Request returned not ok', res)
+        if (!res.ok) {
+            throw new Error('Request returned not ok status:', res.status)
 
         if (res.bodyUsed)
             // TODO: check if this needs a return
@@ -362,7 +362,7 @@ var subscription_parser = (cb) => ({
     read (input) {
 
         // Store the new input!
-        this.state.input.push(...input)
+        for (let x of input) this.state.input.push(x)
 
         // Now loop through the input and parse until we hit a dead end
         while (this.state.input.length) {

package/braid-http-server.js

@@ -123,7 +123,7 @@ function parse_update (req, cb) {
         req.on('data', function parse (chunk) {
 
             // Merge the latest chunk into our buffer
-            buffer.push(...chunk)
+            for (let x of chunk) buffer.push(x)
 
             while (patches.length < num_patches) {
                 let h = extractHeader(buffer)
@@ -236,10 +236,22 @@ function braidify (req, res, next) {
             res.statusCode = 209
             res.setHeader("subscribe", req.headers.subscribe)
             res.setHeader('cache-control', 'no-cache, no-transform')
-            if (req.httpVersionMajor == 1) {
-                // Explicitly disable transfer-encoding chunked for http 1
-                res.setHeader('transfer-encoding', '')
-            }
+
+
+            // Note: I used to explicitly disable transfer-encoding chunked
+            // here by setting the header to empty string.  This is the only
+            // way I know to disable it in nodejs.  We don't need chunked
+            // encoding in subscriptions, because chunked encoding is used to
+            // signal the end of a response, and subscriptions don't end.  I
+            // disabled them to make responses cleaner.  However, it turns out
+            // the Caddy proxy throws an error if it receives a response with
+            // transfer-encoding: set to the empty string.  So I'm disabling
+            // it now.
+
+            // if (req.httpVersionMajor == 1) {
+            //     // Explicitly disable transfer-encoding chunked for http 1
+            //     res.setHeader('transfer-encoding', '')
+            // }
 
             // Tell nginx not to buffer the subscription
             res.setHeader('X-Accel-Buffering', 'no')

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "braid-http",
-  "version": "0.3.17",
+  "version": "0.3.19",
   "description": "An implementation of Braid-HTTP for Node.js and Browsers",
   "scripts": {
     "test": "node test/server.js"