braid-http 0.3.0 → 0.3.2

package/braid-http-client.js

@@ -155,7 +155,7 @@ async function braid_fetch (url, params = {}) {
     // We provide some shortcuts for Braid params
     if (params.version)
         params.headers.set('version', params.version.map(JSON.stringify).join(', '))
-    if (params.parents)
+    if (params.parents?.length)
         params.headers.set('parents', params.parents.map(JSON.stringify).join(', '))
     if (params.subscribe)
         params.headers.set('subscribe', 'true')
@@ -488,8 +488,7 @@ function parse_headers (input) {
     // Success!  Let's parse special headers
     if ('version' in headers)
         headers.version = JSON.parse('['+headers.version+']')
-    if ('parents' in headers)
-        headers.parents = JSON.parse('['+headers.parents+']')
+    headers.parents = JSON.parse('['+(headers.parents ?? '')+']')
     if ('patches' in headers)
         headers.patches = JSON.parse(headers.patches)
 

package/braid-http-server.js

@@ -195,8 +195,8 @@ function braidify (req, res, next) {
     res.setHeader('Range-Request-Allow-Units', 'json')
 
     // Extract braid info from headers
-    var version = req.headers.version && JSON.parse(req.headers.version),
-        parents = req.headers.parents && JSON.parse('['+req.headers.parents+']'),
+    var version = JSON.parse('['+(req.headers.version ?? '')+']'),
+        parents = JSON.parse('['+(req.headers.parents ?? '')+']'),
         peer = req.headers['peer'],
         url = req.url.substr(1)
 
@@ -338,6 +338,7 @@ function send_version(res, data, url, peer) {
             value = value.map(JSON.stringify).join(", ")
         } else if (header === 'parents') {
             header = 'Parents'               // Capitalize for prettiness
+            if (value.length == 0) continue  // we express no parents as not having the field at all
             value = value.map(JSON.stringify).join(", ")
         }
 

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "braid-http",
-  "version": "0.3.0",
+  "version": "0.3.2",
   "description": "An implementation of Braid-HTTP for Node.js and Browsers",
   "scripts": {
     "test": "node test/server.js"

package/readme.md

@@ -51,7 +51,7 @@ fetch('https://braid.org/chat', {subscribe: true}).then(
         (new_version) => {
             console.log('We got a new version!', new_version)
             // {
-            //   version: "me",
+            //   version: ["me"],
             //   parents: ["mom", "dad"],
             //   patches: [{unit: "json", range: ".foo", content: "3"}]
             //   body:    "3"
@@ -153,7 +153,7 @@ require('http').createServer(
 
         // Send the current version
         res.sendUpdate({
-            version: 'greg',
+            version: ['greg'],
             body: JSON.stringify({greg: 'greg'})
         })
     }
@@ -184,14 +184,14 @@ app.get('/', (req, res) => {
 
     // Send the current version
     res.sendUpdate({
-        version: 'greg',
+        version: ['greg'],
         parents: ['gr','eg'],
         body: JSON.stringify({greg: 'greg'})
     })
 
     // Or you can send patches like this:
     // res.sendUpdate({
-    //     version: 'greg',
+    //     version: ['greg'],
     //     parents: ['gr','eg'],
     //     patches: [{range: '.greg', unit: 'json', content: '"greg"'}]
     // })
@@ -234,7 +234,7 @@ function connect () {
         (res) => {
             res.on('version', (version) => {
                 // {
-                //   version: "me",
+                //   version: ["me"],
                 //   parents: ["mom", "dad"],
                 //   patches: [{unit: "json", range: ".foo", content: "3"}]
                 //   body:    "3"
@@ -272,5 +272,3 @@ automatically reconnect.  (See
 [issue #980](https://github.com/node-fetch/node-fetch/issues/980) and
 [#753](https://github.com/node-fetch/node-fetch/issues/753).)  We recommend
 using the `http` library (below) for requests on nodejs instead.
-
-