bpmnlint 9.2.0 → 10.1.0

package/config/all.js

@@ -9,8 +9,8 @@ const allRules = [
   'no-disconnected',
   'no-duplicate-sequence-flows',
   'no-gateway-join-fork',
-  'no-implicit-split',
   'no-implicit-end',
+  'no-implicit-split',
   'no-implicit-start',
   'no-inclusive-gateway',
   'no-overlapping-elements',
@@ -18,7 +18,8 @@ const allRules = [
   'single-event-definition',
   'start-event-required',
   'sub-process-blank-start-event',
-  'superfluous-gateway'
+  'superfluous-gateway',
+  'superfluous-termination'
 ];
 
 

package/config/recommended.js

@@ -19,6 +19,7 @@ module.exports = {
     'single-event-definition': 'error',
     'start-event-required': 'error',
     'sub-process-blank-start-event': 'error',
-    'superfluous-gateway': 'warn'
+    'superfluous-gateway': 'warn',
+    'superfluous-termination': 'warn'
   }
 };

package/package.json

@@ -1,7 +1,7 @@
 {
   "name": "bpmnlint",
   "description": "Validate your BPMN diagrams based on configurable lint rules",
-  "version": "9.2.0",
+  "version": "10.1.0",
   "main": "lib/index.js",
   "keywords": [
     "bpmnlint",
@@ -23,14 +23,14 @@
     }
   ],
   "engines": {
-    "node": ">= 12"
+    "node": ">= 16"
   },
   "license": "MIT",
   "scripts": {
     "all": "run-s lint test-coverage",
     "lint": "eslint .",
     "dev": "npm test -- --watch",
-    "test": "mocha -r esm --exclude 'test/integration/*/**' 'test/**/*.js'",
+    "test": "mocha --exclude 'test/integration/*/**' 'test/**/*.*js'",
     "test-coverage": "nyc --reporter=lcov --reporter=html npm test",
     "generate-docs-images": "npx @bpmn-io/bpmnlint-generate-docs-images ."
   },
@@ -38,7 +38,7 @@
     "bpmnlint": "./bin/bpmnlint.js"
   },
   "dependencies": {
-    "@bpmn-io/moddle-utils": "^0.2.0",
+    "@bpmn-io/moddle-utils": "^0.2.1",
     "ansi-colors": "^4.1.3",
     "bpmn-moddle": "^8.0.1",
     "bpmnlint-utils": "^1.1.1",
@@ -51,13 +51,13 @@
   },
   "devDependencies": {
     "@bpmn-io/bpmnlint-generate-docs-images": "^0.4.0",
-    "chai": "^4.3.7",
-    "eslint": "^8.44.0",
+    "bpmnlint": ".",
+    "chai": "^4.3.8",
+    "eslint": "^8.49.0",
     "eslint-plugin-bpmn-io": "^1.0.0",
-    "esm": "^3.2.25",
-    "execa": "^5.1.1",
+    "execa": "^8.0.1",
     "install-local": "^3.0.1",
-    "mocha": "^8.4.0",
+    "mocha": "^10.2.0",
     "npm-run-all": "^4.1.5",
     "nyc": "^15.1.0",
     "strip-indent": "^3.0.0"

package/rules/fake-join.js

@@ -14,7 +14,7 @@ module.exports = function() {
   function check(node, reporter) {
 
     if (!isAny(node, [
-      'bpmn:Task',
+      'bpmn:Activity',
       'bpmn:Event'
     ])) {
       return;

package/rules/no-implicit-split.js

@@ -15,7 +15,7 @@ module.exports = function() {
   function check(node, reporter) {
 
     if (!isAny(node, [
-      'bpmn:Task',
+      'bpmn:Activity',
       'bpmn:Event'
     ])) {
       return;

package/rules/superfluous-termination.js

@@ -0,0 +1,63 @@
+const {
+  is, isAny
+} = require('bpmnlint-utils');
+
+/**
+ * A rule that checks, whether a gateway has only one source and target.
+ *
+ * Those gateways are superfluous since they don't do anything.
+ */
+module.exports = function() {
+
+  function check(node, reporter) {
+
+    if (!isAny(node, [ 'bpmn:Process', 'bpmn:SubProcess' ])) {
+      return;
+    }
+
+    const flowElements = node.flowElements || [];
+
+    const ends = flowElements.filter(
+      element => is(element, 'bpmn:FlowNode') && (element.outgoing || []).length === 0
+    );
+
+    const terminateEnds = ends.filter(isTerminateEnd);
+
+    if (terminateEnds.length !== 1) {
+
+      // TODO(nikku): only detect basic cases, do not
+      // do any kinds of elaborate flow analysis
+      return;
+    }
+
+    const superfluous = ends.every(
+      (end) => isInterruptingEventSub(end) || isTerminateEnd(end)
+    );
+
+    if (superfluous) {
+
+      for (const node of terminateEnds) {
+        reporter.report(node.id, 'Termination is superfluous.');
+      }
+    }
+  }
+
+  return {
+    check
+  };
+
+};
+
+function isTerminateEnd(element) {
+  return is(element, 'bpmn:EndEvent') && (element.eventDefinitions || []).some(
+    eventDefinition => is(eventDefinition, 'bpmn:TerminateEventDefinition')
+  );
+}
+
+function isInterruptingEventSub(element) {
+  const isEventSub = is(element, 'bpmn:SubProcess') && element.triggeredByEvent;
+
+  return isEventSub && (element.flowElements || []).some(
+    element => is(element, 'bpmn:StartEvent') && element.isInterrupting
+  );
+}