bpmnlint 12.0.0 → 12.1.0

package/package.json

@@ -1,7 +1,7 @@
 {
   "name": "bpmnlint",
   "description": "Validate your BPMN diagrams based on configurable lint rules",
-  "version": "12.0.0",
+  "version": "12.1.0",
   "main": "lib/index.js",
   "exports": {
     ".": "./lib/index.js",

package/rules/fake-join.js

@@ -1,4 +1,9 @@
 const {
+  groupBy
+} = require('min-dash');
+
+const {
+  is,
   isAny
 } = require('bpmnlint-utils');
 
@@ -9,7 +14,9 @@ const {
 
 /**
  * A rule that checks that no fake join is modeled by attempting
- * to give a task or event join semantics.
+ * to give an element join semantics, i.e. a task or event with
+ * multiple incoming flows, or a link catch event targeted by
+ * multiple link throw events.
  *
  * Users should model a parallel joining gateway
  * to achieve the desired behavior.
@@ -20,6 +27,10 @@ module.exports = function() {
 
   function check(node, reporter) {
 
+    if (is(node, 'bpmn:FlowElementsContainer')) {
+      checkLinks(node, reporter);
+    }
+
     if (!isAny(node, [
       'bpmn:Activity',
       'bpmn:Event'
@@ -34,8 +45,46 @@ module.exports = function() {
     }
   }
 
+  function checkLinks(container, reporter) {
+
+    const links = (container.flowElements || []).filter(isLinkEvent);
+
+    // links are resolved by name, per scope
+    const names = groupBy(links.filter(getLinkName), getLinkName);
+
+    for (const [ name, events ] of Object.entries(names)) {
+      const throwEvents = events.filter(event => is(event, 'bpmn:ThrowEvent'));
+      const catchEvents = events.filter(event => is(event, 'bpmn:CatchEvent'));
+
+      // ignore ambiguous catch
+      if (throwEvents.length > 1 && catchEvents.length === 1) {
+        reporter.report(
+          catchEvents[0].id,
+          `Link throw events with link name <${ name }> do not join`
+        );
+      }
+    }
+  }
+
   return annotateRule('fake-join', {
     check
   });
 
-};
+};
+
+
+// helpers /////////////////
+
+function isLinkEvent(node) {
+  return is(node, 'bpmn:Event') && !!getLinkDefinition(node);
+}
+
+function getLinkDefinition(linkEvent) {
+  return (linkEvent.eventDefinitions || []).find(
+    definition => is(definition, 'bpmn:LinkEventDefinition')
+  );
+}
+
+function getLinkName(linkEvent) {
+  return getLinkDefinition(linkEvent).name;
+}